From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752762AbdF2MfC (ORCPT ); Thu, 29 Jun 2017 08:35:02 -0400 Received: from mail-yb0-f176.google.com ([209.85.213.176]:34567 "EHLO mail-yb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751893AbdF2Mez (ORCPT ); Thu, 29 Jun 2017 08:34:55 -0400 MIME-Version: 1.0 In-Reply-To: <20170628180843.Horde.KKnryIaN7wki5B896j1w8Sa@gator4166.hostgator.com> References: <20170628092229.Horde.Hsk18WJyYojTJE5OKzhVd3d@gator4166.hostgator.com> <20170628180843.Horde.KKnryIaN7wki5B896j1w8Sa@gator4166.hostgator.com> From: Alex Deucher Date: Thu, 29 Jun 2017 08:34:53 -0400 Message-ID: Subject: Re: [gpu-drm-radeon] question about potential dead code in vce_v2_0_enable_mgcg() To: "Gustavo A. R. Silva" Cc: "Deucher, Alexander" , David Airlie , Maling list - DRI developers , "Koenig, Christian" , amd-gfx list , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 28, 2017 at 7:08 PM, Gustavo A. R. Silva wrote: > Hi Alex, > > Quoting "Deucher, Alexander" : > >>> -----Original Message----- >>> From: Gustavo A. R. Silva [mailto:garsilva@embeddedor.com] >>> Sent: Wednesday, June 28, 2017 10:22 AM >>> To: Deucher, Alexander; Koenig, Christian; David Airlie >>> Cc: amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; >>> linux- >>> kernel@vger.kernel.org >>> Subject: [gpu-drm-radeon] question about potential dead code in >>> vce_v2_0_enable_mgcg() >>> >>> >>> Hello everybody, >>> >>> While looking into Coverity ID 1198635 I ran into the following piece >>> of code at drivers/gpu/drm/radeon/vce_v2_0.c:107: >>> >>> 107void vce_v2_0_enable_mgcg(struct radeon_device *rdev, bool enable) >>> 108{ >>> 109 bool sw_cg = false; >>> 110 >>> 111 if (enable && (rdev->cg_flags & >>> RADEON_CG_SUPPORT_VCE_MGCG)) { >>> 112 if (sw_cg) >>> 113 vce_v2_0_set_sw_cg(rdev, true); >>> 114 else >>> 115 vce_v2_0_set_dyn_cg(rdev, true); >>> 116 } else { >>> 117 vce_v2_0_disable_cg(rdev); >>> 118 >>> 119 if (sw_cg) >>> 120 vce_v2_0_set_sw_cg(rdev, false); >>> 121 else >>> 122 vce_v2_0_set_dyn_cg(rdev, false); >>> 123 } >>> 124} >>> >>> The issue here is that local variable sw_cg is never updated again >>> after its initialization; which cause some code to be logically dead. >>> >>> My question here is if such variable is there for testing purposes or >>> if it is a sort of an old code leftover that should be removed? >>> >>> In any case I can send a patch to add a comment or remove the dead code. >>> >>> I'd really appreciate any comments on this. >> >> >> I wanted to leave the code in for debugging if we ran into problems with >> dynamic clockgating. >> > > Do you mind if I send a patch to add such comment and make it clear the > purpose of that variable? Sure. Thanks. Alex > > --- a/drivers/gpu/drm/radeon/vce_v2_0.c > +++ b/drivers/gpu/drm/radeon/vce_v2_0.c > @@ -104,6 +104,10 @@ static void vce_v2_0_disable_cg(struct radeon_device > *rdev) > WREG32(VCE_CGTT_CLK_OVERRIDE, 7); > } > > +/* > + * Local variable sw_cg is used for debugging purposes, in case we > + * ran into problems with dynamic clock gating. Don't remove it. > + */ > void vce_v2_0_enable_mgcg(struct radeon_device *rdev, bool enable) > { > bool sw_cg = false; > > > Thanks for clarifying! > -- > Gustavo A. R. Silva > > > > > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [gpu-drm-radeon] question about potential dead code in vce_v2_0_enable_mgcg() Date: Thu, 29 Jun 2017 08:34:53 -0400 Message-ID: References: <20170628092229.Horde.Hsk18WJyYojTJE5OKzhVd3d@gator4166.hostgator.com> <20170628180843.Horde.KKnryIaN7wki5B896j1w8Sa@gator4166.hostgator.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170628180843.Horde.KKnryIaN7wki5B896j1w8Sa@gator4166.hostgator.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Gustavo A. R. Silva" Cc: LKML , amd-gfx list , Maling list - DRI developers , "Deucher, Alexander" , "Koenig, Christian" List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKdW4gMjgsIDIwMTcgYXQgNzowOCBQTSwgR3VzdGF2byBBLiBSLiBTaWx2YQo8Z2Fy c2lsdmFAZW1iZWRkZWRvci5jb20+IHdyb3RlOgo+IEhpIEFsZXgsCj4KPiBRdW90aW5nICJEZXVj aGVyLCBBbGV4YW5kZXIiIDxBbGV4YW5kZXIuRGV1Y2hlckBhbWQuY29tPjoKPgo+Pj4gLS0tLS1P cmlnaW5hbCBNZXNzYWdlLS0tLS0KPj4+IEZyb206IEd1c3Rhdm8gQS4gUi4gU2lsdmEgW21haWx0 bzpnYXJzaWx2YUBlbWJlZGRlZG9yLmNvbV0KPj4+IFNlbnQ6IFdlZG5lc2RheSwgSnVuZSAyOCwg MjAxNyAxMDoyMiBBTQo+Pj4gVG86IERldWNoZXIsIEFsZXhhbmRlcjsgS29lbmlnLCBDaHJpc3Rp YW47IERhdmlkIEFpcmxpZQo+Pj4gQ2M6IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnOyBk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnOwo+Pj4gbGludXgtCj4+PiBrZXJuZWxAdmdl ci5rZXJuZWwub3JnCj4+PiBTdWJqZWN0OiBbZ3B1LWRybS1yYWRlb25dIHF1ZXN0aW9uIGFib3V0 IHBvdGVudGlhbCBkZWFkIGNvZGUgaW4KPj4+IHZjZV92Ml8wX2VuYWJsZV9tZ2NnKCkKPj4+Cj4+ Pgo+Pj4gSGVsbG8gZXZlcnlib2R5LAo+Pj4KPj4+IFdoaWxlIGxvb2tpbmcgaW50byBDb3Zlcml0 eSBJRCAxMTk4NjM1IEkgcmFuIGludG8gdGhlIGZvbGxvd2luZyBwaWVjZQo+Pj4gb2YgY29kZSBh dCBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3ZjZV92Ml8wLmM6MTA3Ogo+Pj4KPj4+IDEwN3ZvaWQg dmNlX3YyXzBfZW5hYmxlX21nY2coc3RydWN0IHJhZGVvbl9kZXZpY2UgKnJkZXYsIGJvb2wgZW5h YmxlKQo+Pj4gMTA4ewo+Pj4gMTA5ICAgICAgICBib29sIHN3X2NnID0gZmFsc2U7Cj4+PiAxMTAK Pj4+IDExMSAgICAgICAgaWYgKGVuYWJsZSAmJiAocmRldi0+Y2dfZmxhZ3MgJgo+Pj4gUkFERU9O X0NHX1NVUFBPUlRfVkNFX01HQ0cpKSB7Cj4+PiAxMTIgICAgICAgICAgICAgICAgaWYgKHN3X2Nn KQo+Pj4gMTEzICAgICAgICAgICAgICAgICAgICAgICAgdmNlX3YyXzBfc2V0X3N3X2NnKHJkZXYs IHRydWUpOwo+Pj4gMTE0ICAgICAgICAgICAgICAgIGVsc2UKPj4+IDExNSAgICAgICAgICAgICAg ICAgICAgICAgIHZjZV92Ml8wX3NldF9keW5fY2cocmRldiwgdHJ1ZSk7Cj4+PiAxMTYgICAgICAg IH0gZWxzZSB7Cj4+PiAxMTcgICAgICAgICAgICAgICAgdmNlX3YyXzBfZGlzYWJsZV9jZyhyZGV2 KTsKPj4+IDExOAo+Pj4gMTE5ICAgICAgICAgICAgICAgIGlmIChzd19jZykKPj4+IDEyMCAgICAg ICAgICAgICAgICAgICAgICAgIHZjZV92Ml8wX3NldF9zd19jZyhyZGV2LCBmYWxzZSk7Cj4+PiAx MjEgICAgICAgICAgICAgICAgZWxzZQo+Pj4gMTIyICAgICAgICAgICAgICAgICAgICAgICAgdmNl X3YyXzBfc2V0X2R5bl9jZyhyZGV2LCBmYWxzZSk7Cj4+PiAxMjMgICAgICAgIH0KPj4+IDEyNH0K Pj4+Cj4+PiBUaGUgaXNzdWUgaGVyZSBpcyB0aGF0IGxvY2FsIHZhcmlhYmxlIHN3X2NnIGlzIG5l dmVyIHVwZGF0ZWQgYWdhaW4KPj4+IGFmdGVyIGl0cyBpbml0aWFsaXphdGlvbjsgd2hpY2ggY2F1 c2Ugc29tZSBjb2RlIHRvIGJlIGxvZ2ljYWxseSBkZWFkLgo+Pj4KPj4+IE15IHF1ZXN0aW9uIGhl cmUgaXMgaWYgc3VjaCB2YXJpYWJsZSBpcyB0aGVyZSBmb3IgdGVzdGluZyBwdXJwb3NlcyBvcgo+ Pj4gaWYgaXQgaXMgYSBzb3J0IG9mIGFuIG9sZCBjb2RlIGxlZnRvdmVyIHRoYXQgc2hvdWxkIGJl IHJlbW92ZWQ/Cj4+Pgo+Pj4gSW4gYW55IGNhc2UgSSBjYW4gc2VuZCBhIHBhdGNoIHRvIGFkZCBh IGNvbW1lbnQgb3IgcmVtb3ZlIHRoZSBkZWFkIGNvZGUuCj4+Pgo+Pj4gSSdkIHJlYWxseSBhcHBy ZWNpYXRlIGFueSBjb21tZW50cyBvbiB0aGlzLgo+Pgo+Pgo+PiBJIHdhbnRlZCB0byBsZWF2ZSB0 aGUgY29kZSBpbiBmb3IgZGVidWdnaW5nIGlmIHdlIHJhbiBpbnRvIHByb2JsZW1zIHdpdGgKPj4g ZHluYW1pYyBjbG9ja2dhdGluZy4KPj4KPgo+IERvIHlvdSBtaW5kIGlmIEkgc2VuZCBhIHBhdGNo IHRvIGFkZCBzdWNoIGNvbW1lbnQgYW5kIG1ha2UgaXQgY2xlYXIgdGhlCj4gcHVycG9zZSBvZiB0 aGF0IHZhcmlhYmxlPwoKU3VyZS4gIFRoYW5rcy4KCkFsZXgKCj4KPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vcmFkZW9uL3ZjZV92Ml8wLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3Zj ZV92Ml8wLmMKPiBAQCAtMTA0LDYgKzEwNCwxMCBAQCBzdGF0aWMgdm9pZCB2Y2VfdjJfMF9kaXNh YmxlX2NnKHN0cnVjdCByYWRlb25fZGV2aWNlCj4gKnJkZXYpCj4gICAgICAgICBXUkVHMzIoVkNF X0NHVFRfQ0xLX09WRVJSSURFLCA3KTsKPiAgfQo+Cj4gKy8qCj4gKyAqIExvY2FsIHZhcmlhYmxl IHN3X2NnIGlzIHVzZWQgZm9yIGRlYnVnZ2luZyBwdXJwb3NlcywgaW4gY2FzZSB3ZQo+ICsgKiBy YW4gaW50byBwcm9ibGVtcyB3aXRoIGR5bmFtaWMgY2xvY2sgZ2F0aW5nLiBEb24ndCByZW1vdmUg aXQuCj4gKyAqLwo+ICB2b2lkIHZjZV92Ml8wX2VuYWJsZV9tZ2NnKHN0cnVjdCByYWRlb25fZGV2 aWNlICpyZGV2LCBib29sIGVuYWJsZSkKPiAgewo+ICAgICAgICAgYm9vbCBzd19jZyA9IGZhbHNl Owo+Cj4KPiBUaGFua3MgZm9yIGNsYXJpZnlpbmchCj4gLS0KPiBHdXN0YXZvIEEuIFIuIFNpbHZh Cj4KPgo+Cj4KPgo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiBhbWQtZ2Z4IG1haWxpbmcgbGlzdAo+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQt Z2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=