From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DA87C04A68 for ; Wed, 27 Jul 2022 15:23:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234013AbiG0PXP (ORCPT ); Wed, 27 Jul 2022 11:23:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233239AbiG0PXN (ORCPT ); Wed, 27 Jul 2022 11:23:13 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2DBD3205F for ; Wed, 27 Jul 2022 08:23:12 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id sz17so32093122ejc.9 for ; Wed, 27 Jul 2022 08:23:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3QoQIcw2k7KJYASXT3ZADS6J+gQkSi9pbz+G9ycdbwU=; b=HCbs8iPs9gJhX59IpgPJsCa2fuxs/UEAYiUEkx6VbdfgffAl0JiY0Kl0ovVFN7tKuH TBARPeHOi9Fkh83OJhx+l0/TUqfogT7lZ11O4JqeHqfZ5IoFAcw/yLWuF6Ke235el7oO Zr8ZOPAxr2g6sjyooHYIN8X8ZwZpJtRbfsTwOjiPJVt89aT5Hq2Ig8kVGTuhn3pijiwJ nMs9N0HehNF8gC+hhbxqFCl4uw+yje7AK2GbrG8SNULDXr/MrsOmw+l7xg3dABd1Fh7k yazGhqOdZz57nHnLxuiVfsnRmJaWH/D+70indNftdRsODejYRRxqf2MpT95NI+y66PkG 8+uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3QoQIcw2k7KJYASXT3ZADS6J+gQkSi9pbz+G9ycdbwU=; b=WvYyJkZFbXV2ZT4YCZlBlkNKjI2Jk0G4omcM99d/RaLDpNz6ghrzMTEOQD8YQQmAzO IbcypfyPAa9jVBsBuoq6nKg+/wTogA0BZDQCjxwXlNKIpUpRxYy3V7aSWUvdohZd2oII KSlhSklq3XtFc+L4oic/0LpOOhIhDmx+gXD6RMpqdSA3Rms9hqgyVcsC67mncnJem7v0 WM/Itou+TXEUtpvw0LDQSrzGpL7RjkxZC6RA79I2+0QlswajWH4IxuZpSBHvFhmVXOUI O0pdk7awnX35ccM5/gWF8H3m6KhKWSbd9TlfTJhlqgsZDmjCO+9Qx+A6rm3/YSey8xku c0fw== X-Gm-Message-State: AJIora/WIYqjJjuawCRJypfKs6UK0XChEEZZcwl9tTsNAo7FQMj+l8Am 7NIycJw03yI6LYJ429P0gPnP57nb0OlRuoBUDjg= X-Google-Smtp-Source: AGRyM1tsUeLUmrPGthGwyhSNHhxQUgBP/qJfxueLK6ioM0y8Wb7Fq8JANC1a+3Fzq9kK8Imtgrks58J9/2IY7PbLYcA= X-Received: by 2002:a17:907:2723:b0:72b:5af3:5a11 with SMTP id d3-20020a170907272300b0072b5af35a11mr17884124ejl.584.1658935391241; Wed, 27 Jul 2022 08:23:11 -0700 (PDT) MIME-Version: 1.0 References: <20220727144249.415228-1-Vijendar.Mukunda@amd.com> <1031eddb-4cfa-e94a-e77e-03aa3cb8b680@amd.com> In-Reply-To: <1031eddb-4cfa-e94a-e77e-03aa3cb8b680@amd.com> From: Alex Deucher Date: Wed, 27 Jul 2022 11:22:59 -0400 Message-ID: Subject: Re: [PATCH] drm/amdgpu: fix i2s_pdata out of bound array access To: "Mukunda,Vijendar" Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Sunil-kumar.Dommati@amd.com, David Airlie , "Pan, Xinhui" , open list , Daniel Vetter , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , dan.carpenter@oracle.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 27, 2022 at 11:16 AM Mukunda,Vijendar wrote: > > On 7/27/22 8:25 PM, Alex Deucher wrote: > > On Wed, Jul 27, 2022 at 10:42 AM Vijendar Mukunda > > wrote: > >> > >> Fixed following Smatch static checker warning: > >> > >> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:393 acp_hw_init() > >> error: buffer overflow 'i2s_pdata' 3 <= 3 > >> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:396 acp_hw_init() > >> error: buffer overflow 'i2s_pdata' 3 <= 3 > >> > >> Reported-by: Dan Carpenter > >> Signed-off-by: Vijendar Mukunda > >> --- > >> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 8 -------- > >> 1 file changed, 8 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c > >> index bcc7ee02e0fc..6d72355ac492 100644 > >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c > >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c > >> @@ -390,14 +390,6 @@ static int acp_hw_init(void *handle) > >> i2s_pdata[2].i2s_reg_comp1 = ACP_BT_COMP1_REG_OFFSET; > >> i2s_pdata[2].i2s_reg_comp2 = ACP_BT_COMP2_REG_OFFSET; > >> > >> - i2s_pdata[3].quirks = DW_I2S_QUIRK_COMP_REG_OFFSET; > >> - switch (adev->asic_type) { > >> - case CHIP_STONEY: > >> - i2s_pdata[3].quirks |= DW_I2S_QUIRK_16BIT_IDX_OVERRIDE; > >> - break; > >> - default: > >> - break; > >> - } > > > > Is this actually not used or should we just increase the allocation size? > > > > Alex > it's my bad. i2s_pdata array size is 3. when we recently included code > changes for JD platform , this piece of code was added mistakenly for > Stoney platform switch case. Thanks. Patch is: Acked-by: Alex Deucher > > -- > Vijendar > > > > >> adev->acp.acp_res[0].name = "acp2x_dma"; > >> adev->acp.acp_res[0].flags = IORESOURCE_MEM; > >> adev->acp.acp_res[0].start = acp_base; > >> -- > >> 2.25.1 > >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F00D5C19F2B for ; Wed, 27 Jul 2022 15:23:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DE80F96C56; Wed, 27 Jul 2022 15:23:13 +0000 (UTC) Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0507896C47; Wed, 27 Jul 2022 15:23:13 +0000 (UTC) Received: by mail-ej1-x636.google.com with SMTP id b11so31998092eju.10; Wed, 27 Jul 2022 08:23:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3QoQIcw2k7KJYASXT3ZADS6J+gQkSi9pbz+G9ycdbwU=; b=HCbs8iPs9gJhX59IpgPJsCa2fuxs/UEAYiUEkx6VbdfgffAl0JiY0Kl0ovVFN7tKuH TBARPeHOi9Fkh83OJhx+l0/TUqfogT7lZ11O4JqeHqfZ5IoFAcw/yLWuF6Ke235el7oO Zr8ZOPAxr2g6sjyooHYIN8X8ZwZpJtRbfsTwOjiPJVt89aT5Hq2Ig8kVGTuhn3pijiwJ nMs9N0HehNF8gC+hhbxqFCl4uw+yje7AK2GbrG8SNULDXr/MrsOmw+l7xg3dABd1Fh7k yazGhqOdZz57nHnLxuiVfsnRmJaWH/D+70indNftdRsODejYRRxqf2MpT95NI+y66PkG 8+uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3QoQIcw2k7KJYASXT3ZADS6J+gQkSi9pbz+G9ycdbwU=; b=FrHEZfbHjpfMv2SCftBy8f5eSu+NEaogboShzRj2y2dqYg/S1UTLTsWdmY/d/y1/t/ 2LegT4TDyhfC9lRNHhnqgdSkeqpkD+ufmC8WqTc91jdtngWxwUaphjYFWe5IIeRkhIJ8 f23jOeX8FDnUmLfE54OjgOq/VfgYLGBtcmjYOpAX8P84YMWZgepp5pXqH6BJ+D3E0Nbb fNGY7syk88eazwHOwNLFgzwYiXaEhwH96nN2oXtgLWT+yqFGaTNOs39ZFK/7yqkCRFTL U3qgizdXM2babWSTiB7wwWqexOSdxb2bhvhmieKt2gqPN4+QbCegnnN1RHwcS4Nb46ag OSBg== X-Gm-Message-State: AJIora+stJRCPgMcAhWkdwZxxMOUGPwHu2B9pOUvD/Uapw6rRyQKgIfQ EcfhX1W3k1pPYMdfVTVjDNRqcGAuezl+Z7L8SWs= X-Google-Smtp-Source: AGRyM1tsUeLUmrPGthGwyhSNHhxQUgBP/qJfxueLK6ioM0y8Wb7Fq8JANC1a+3Fzq9kK8Imtgrks58J9/2IY7PbLYcA= X-Received: by 2002:a17:907:2723:b0:72b:5af3:5a11 with SMTP id d3-20020a170907272300b0072b5af35a11mr17884124ejl.584.1658935391241; Wed, 27 Jul 2022 08:23:11 -0700 (PDT) MIME-Version: 1.0 References: <20220727144249.415228-1-Vijendar.Mukunda@amd.com> <1031eddb-4cfa-e94a-e77e-03aa3cb8b680@amd.com> In-Reply-To: <1031eddb-4cfa-e94a-e77e-03aa3cb8b680@amd.com> From: Alex Deucher Date: Wed, 27 Jul 2022 11:22:59 -0400 Message-ID: Subject: Re: [PATCH] drm/amdgpu: fix i2s_pdata out of bound array access To: "Mukunda,Vijendar" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sunil-kumar.Dommati@amd.com, David Airlie , "Pan, Xinhui" , open list , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , dan.carpenter@oracle.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Jul 27, 2022 at 11:16 AM Mukunda,Vijendar wrote: > > On 7/27/22 8:25 PM, Alex Deucher wrote: > > On Wed, Jul 27, 2022 at 10:42 AM Vijendar Mukunda > > wrote: > >> > >> Fixed following Smatch static checker warning: > >> > >> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:393 acp_hw_init() > >> error: buffer overflow 'i2s_pdata' 3 <= 3 > >> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:396 acp_hw_init() > >> error: buffer overflow 'i2s_pdata' 3 <= 3 > >> > >> Reported-by: Dan Carpenter > >> Signed-off-by: Vijendar Mukunda > >> --- > >> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 8 -------- > >> 1 file changed, 8 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c > >> index bcc7ee02e0fc..6d72355ac492 100644 > >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c > >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c > >> @@ -390,14 +390,6 @@ static int acp_hw_init(void *handle) > >> i2s_pdata[2].i2s_reg_comp1 = ACP_BT_COMP1_REG_OFFSET; > >> i2s_pdata[2].i2s_reg_comp2 = ACP_BT_COMP2_REG_OFFSET; > >> > >> - i2s_pdata[3].quirks = DW_I2S_QUIRK_COMP_REG_OFFSET; > >> - switch (adev->asic_type) { > >> - case CHIP_STONEY: > >> - i2s_pdata[3].quirks |= DW_I2S_QUIRK_16BIT_IDX_OVERRIDE; > >> - break; > >> - default: > >> - break; > >> - } > > > > Is this actually not used or should we just increase the allocation size? > > > > Alex > it's my bad. i2s_pdata array size is 3. when we recently included code > changes for JD platform , this piece of code was added mistakenly for > Stoney platform switch case. Thanks. Patch is: Acked-by: Alex Deucher > > -- > Vijendar > > > > >> adev->acp.acp_res[0].name = "acp2x_dma"; > >> adev->acp.acp_res[0].flags = IORESOURCE_MEM; > >> adev->acp.acp_res[0].start = acp_base; > >> -- > >> 2.25.1 > >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82F68C04A68 for ; Wed, 27 Jul 2022 15:23:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DB7B196C52; Wed, 27 Jul 2022 15:23:13 +0000 (UTC) Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0507896C47; Wed, 27 Jul 2022 15:23:13 +0000 (UTC) Received: by mail-ej1-x636.google.com with SMTP id b11so31998092eju.10; Wed, 27 Jul 2022 08:23:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3QoQIcw2k7KJYASXT3ZADS6J+gQkSi9pbz+G9ycdbwU=; b=HCbs8iPs9gJhX59IpgPJsCa2fuxs/UEAYiUEkx6VbdfgffAl0JiY0Kl0ovVFN7tKuH TBARPeHOi9Fkh83OJhx+l0/TUqfogT7lZ11O4JqeHqfZ5IoFAcw/yLWuF6Ke235el7oO Zr8ZOPAxr2g6sjyooHYIN8X8ZwZpJtRbfsTwOjiPJVt89aT5Hq2Ig8kVGTuhn3pijiwJ nMs9N0HehNF8gC+hhbxqFCl4uw+yje7AK2GbrG8SNULDXr/MrsOmw+l7xg3dABd1Fh7k yazGhqOdZz57nHnLxuiVfsnRmJaWH/D+70indNftdRsODejYRRxqf2MpT95NI+y66PkG 8+uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3QoQIcw2k7KJYASXT3ZADS6J+gQkSi9pbz+G9ycdbwU=; b=FrHEZfbHjpfMv2SCftBy8f5eSu+NEaogboShzRj2y2dqYg/S1UTLTsWdmY/d/y1/t/ 2LegT4TDyhfC9lRNHhnqgdSkeqpkD+ufmC8WqTc91jdtngWxwUaphjYFWe5IIeRkhIJ8 f23jOeX8FDnUmLfE54OjgOq/VfgYLGBtcmjYOpAX8P84YMWZgepp5pXqH6BJ+D3E0Nbb fNGY7syk88eazwHOwNLFgzwYiXaEhwH96nN2oXtgLWT+yqFGaTNOs39ZFK/7yqkCRFTL U3qgizdXM2babWSTiB7wwWqexOSdxb2bhvhmieKt2gqPN4+QbCegnnN1RHwcS4Nb46ag OSBg== X-Gm-Message-State: AJIora+stJRCPgMcAhWkdwZxxMOUGPwHu2B9pOUvD/Uapw6rRyQKgIfQ EcfhX1W3k1pPYMdfVTVjDNRqcGAuezl+Z7L8SWs= X-Google-Smtp-Source: AGRyM1tsUeLUmrPGthGwyhSNHhxQUgBP/qJfxueLK6ioM0y8Wb7Fq8JANC1a+3Fzq9kK8Imtgrks58J9/2IY7PbLYcA= X-Received: by 2002:a17:907:2723:b0:72b:5af3:5a11 with SMTP id d3-20020a170907272300b0072b5af35a11mr17884124ejl.584.1658935391241; Wed, 27 Jul 2022 08:23:11 -0700 (PDT) MIME-Version: 1.0 References: <20220727144249.415228-1-Vijendar.Mukunda@amd.com> <1031eddb-4cfa-e94a-e77e-03aa3cb8b680@amd.com> In-Reply-To: <1031eddb-4cfa-e94a-e77e-03aa3cb8b680@amd.com> From: Alex Deucher Date: Wed, 27 Jul 2022 11:22:59 -0400 Message-ID: Subject: Re: [PATCH] drm/amdgpu: fix i2s_pdata out of bound array access To: "Mukunda,Vijendar" Content-Type: text/plain; charset="UTF-8" X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sunil-kumar.Dommati@amd.com, David Airlie , "Pan, Xinhui" , open list , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , dan.carpenter@oracle.com Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Wed, Jul 27, 2022 at 11:16 AM Mukunda,Vijendar wrote: > > On 7/27/22 8:25 PM, Alex Deucher wrote: > > On Wed, Jul 27, 2022 at 10:42 AM Vijendar Mukunda > > wrote: > >> > >> Fixed following Smatch static checker warning: > >> > >> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:393 acp_hw_init() > >> error: buffer overflow 'i2s_pdata' 3 <= 3 > >> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:396 acp_hw_init() > >> error: buffer overflow 'i2s_pdata' 3 <= 3 > >> > >> Reported-by: Dan Carpenter > >> Signed-off-by: Vijendar Mukunda > >> --- > >> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 8 -------- > >> 1 file changed, 8 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c > >> index bcc7ee02e0fc..6d72355ac492 100644 > >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c > >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c > >> @@ -390,14 +390,6 @@ static int acp_hw_init(void *handle) > >> i2s_pdata[2].i2s_reg_comp1 = ACP_BT_COMP1_REG_OFFSET; > >> i2s_pdata[2].i2s_reg_comp2 = ACP_BT_COMP2_REG_OFFSET; > >> > >> - i2s_pdata[3].quirks = DW_I2S_QUIRK_COMP_REG_OFFSET; > >> - switch (adev->asic_type) { > >> - case CHIP_STONEY: > >> - i2s_pdata[3].quirks |= DW_I2S_QUIRK_16BIT_IDX_OVERRIDE; > >> - break; > >> - default: > >> - break; > >> - } > > > > Is this actually not used or should we just increase the allocation size? > > > > Alex > it's my bad. i2s_pdata array size is 3. when we recently included code > changes for JD platform , this piece of code was added mistakenly for > Stoney platform switch case. Thanks. Patch is: Acked-by: Alex Deucher > > -- > Vijendar > > > > >> adev->acp.acp_res[0].name = "acp2x_dma"; > >> adev->acp.acp_res[0].flags = IORESOURCE_MEM; > >> adev->acp.acp_res[0].start = acp_base; > >> -- > >> 2.25.1 > >> >