From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753186AbdF2TZV (ORCPT ); Thu, 29 Jun 2017 15:25:21 -0400 Received: from mail-yw0-f196.google.com ([209.85.161.196]:33575 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753109AbdF2TZU (ORCPT ); Thu, 29 Jun 2017 15:25:20 -0400 MIME-Version: 1.0 In-Reply-To: <20170629173837.GA3397@embeddedgus> References: <20170629173837.GA3397@embeddedgus> From: Alex Deucher Date: Thu, 29 Jun 2017 15:25:19 -0400 Message-ID: Subject: Re: [PATCH] drm/radeon: add header comment for clarification to vce_v2_0_enable_mgcg() To: "Gustavo A. R. Silva" Cc: Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , David Airlie , amd-gfx list , Maling list - DRI developers , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 29, 2017 at 1:38 PM, Gustavo A. R. Silva wrote: > Add function header comment to make it clear that local variable sw_cg > is used for debugging and it should not be removed. > > Addresses-Coverity-ID: 1198635 > Cc: Alex Deucher > Signed-off-by: Gustavo A. R. Silva Applied. thanks! Alex > --- > drivers/gpu/drm/radeon/vce_v2_0.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/radeon/vce_v2_0.c b/drivers/gpu/drm/radeon/vce_v2_0.c > index fce2144..b0a43b6 100644 > --- a/drivers/gpu/drm/radeon/vce_v2_0.c > +++ b/drivers/gpu/drm/radeon/vce_v2_0.c > @@ -104,6 +104,10 @@ static void vce_v2_0_disable_cg(struct radeon_device *rdev) > WREG32(VCE_CGTT_CLK_OVERRIDE, 7); > } > > +/* > + * Local variable sw_cg is used for debugging purposes, in case we > + * ran into problems with dynamic clock gating. Don't remove it. > + */ > void vce_v2_0_enable_mgcg(struct radeon_device *rdev, bool enable) > { > bool sw_cg = false; > -- > 2.5.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH] drm/radeon: add header comment for clarification to vce_v2_0_enable_mgcg() Date: Thu, 29 Jun 2017 15:25:19 -0400 Message-ID: References: <20170629173837.GA3397@embeddedgus> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170629173837.GA3397@embeddedgus> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Gustavo A. R. Silva" Cc: LKML , Maling list - DRI developers , amd-gfx list , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdW4gMjksIDIwMTcgYXQgMTozOCBQTSwgR3VzdGF2byBBLiBSLiBTaWx2YQo8Z2Fy c2lsdmFAZW1iZWRkZWRvci5jb20+IHdyb3RlOgo+IEFkZCBmdW5jdGlvbiBoZWFkZXIgY29tbWVu dCB0byBtYWtlIGl0IGNsZWFyIHRoYXQgbG9jYWwgdmFyaWFibGUgc3dfY2cKPiBpcyB1c2VkIGZv ciBkZWJ1Z2dpbmcgYW5kIGl0IHNob3VsZCBub3QgYmUgcmVtb3ZlZC4KPgo+IEFkZHJlc3Nlcy1D b3Zlcml0eS1JRDogMTE5ODYzNQo+IENjOiBBbGV4IERldWNoZXIgPGFsZXhkZXVjaGVyQGdtYWls LmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBHdXN0YXZvIEEuIFIuIFNpbHZhIDxnYXJzaWx2YUBlbWJl ZGRlZG9yLmNvbT4KCkFwcGxpZWQuICB0aGFua3MhCgpBbGV4Cgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vcmFkZW9uL3ZjZV92Ml8wLmMgfCA0ICsrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5z ZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vdmNlX3Yy XzAuYyBiL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vdmNlX3YyXzAuYwo+IGluZGV4IGZjZTIxNDQu LmIwYTQzYjYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi92Y2VfdjJfMC5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi92Y2VfdjJfMC5jCj4gQEAgLTEwNCw2ICsx MDQsMTAgQEAgc3RhdGljIHZvaWQgdmNlX3YyXzBfZGlzYWJsZV9jZyhzdHJ1Y3QgcmFkZW9uX2Rl dmljZSAqcmRldikKPiAgICAgICAgIFdSRUczMihWQ0VfQ0dUVF9DTEtfT1ZFUlJJREUsIDcpOwo+ ICB9Cj4KPiArLyoKPiArICogTG9jYWwgdmFyaWFibGUgc3dfY2cgaXMgdXNlZCBmb3IgZGVidWdn aW5nIHB1cnBvc2VzLCBpbiBjYXNlIHdlCj4gKyAqIHJhbiBpbnRvIHByb2JsZW1zIHdpdGggZHlu YW1pYyBjbG9jayBnYXRpbmcuIERvbid0IHJlbW92ZSBpdC4KPiArICovCj4gIHZvaWQgdmNlX3Yy XzBfZW5hYmxlX21nY2coc3RydWN0IHJhZGVvbl9kZXZpY2UgKnJkZXYsIGJvb2wgZW5hYmxlKQo+ ICB7Cj4gICAgICAgICBib29sIHN3X2NnID0gZmFsc2U7Cj4gLS0KPiAyLjUuMAo+Cl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=