Re: [PATCH 2/2] drm: make DRI1 drivers depend on BROKEN

From: Alex Deucher <alexdeucher@gmail.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	ML dri-devel <dri-devel@lists.freedesktop.org>,
	ConnorBehan <connor.behan@gmail.com>
Subject: Re: [PATCH 2/2] drm: make DRI1 drivers depend on BROKEN
Date: Thu, 25 Aug 2016 11:13:24 -0400	[thread overview]
Message-ID: <CADnq5_Np+q5wGndc-G2fEMBk=PwNWnERbdyCeNEVgTS9O66GbQ@mail.gmail.com> (raw)
In-Reply-To: <CACvgo52cP4L81r6A_YEWrjNcw9h6Vh2Zgz35d35VBZzo5EKY2w@mail.gmail.com>

On Thu, Aug 25, 2016 at 11:04 AM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> On 25 August 2016 at 12:14, Daniel Vetter <daniel@ffwll.ch> wrote:
>> On Thu, Aug 04, 2016 at 09:15:07AM +0100, Chris Wilson wrote:
>>> On Thu, Aug 04, 2016 at 10:06:57AM +0200, David Herrmann wrote:
>>> > The legacy DRI1 drivers expose highly broken interfaces to user-space. No
>>> > modern system should enable them, or you will effectively allow user-space
>>> > to circumvent most of your kernel security measures. The DRI1 kernel APIs
>>> > are simply broken.
>>> >
>>> > User-space can always use vesafb/efifb/simplefb and friends to get working
>>> > graphics.
>>> >
>>> > Lets hide the old drivers behind CONFIG_BROKEN. In case they turn out to
>>> > be still used (really?), we can easily revert this and figure out a way to
>>> > move them out of sight (e.g., moving all DRI1 drivers to
>>> > drivers/gpu/dri1/).
>>> >
>>> > Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
>>>
>>> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
>>>
>>> I'd rather have a couple of distro devs check if they are still using
>>> any of these, and would value their a-b/r-b.
>>
>> Mesa stopped shipping dri1 drivers years ago, and neither Fedora and
>> Debian here have that old version packaged (it should keep working since
>> the dri loader is an ABI). I don't think anyone needs this, and if I'm
>> wrong we'll hear about it ;-)
>>
> Archlinux (which seems to be picking more users) is still shipping
> dri1 drivers - both mesa and X. No idea for many actually use those
> and/or for how much longer the packages will be around.
>
> IIRC the maintainer, Connor, used to hack on the xf86-video-r128 with
> plans(?) on getting things KMS aware. Not sure if that was by
> extending the existing radeon kernel, ddx, mesa driver(s) or
> otherwise.
> Connor, can you shed some light ?
>

r128 is 90% the same as early radeons so it would make sense to add
support to radeon.

Alex
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel