From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754410AbdGNOGv (ORCPT ); Fri, 14 Jul 2017 10:06:51 -0400 Received: from mail-yw0-f194.google.com ([209.85.161.194]:34864 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754028AbdGNOGt (ORCPT ); Fri, 14 Jul 2017 10:06:49 -0400 MIME-Version: 1.0 In-Reply-To: <20170713162538.22788-13-peda@axentia.se> References: <20170713162538.22788-1-peda@axentia.se> <20170713162538.22788-13-peda@axentia.se> From: Alex Deucher Date: Fri, 14 Jul 2017 10:06:47 -0400 Message-ID: Subject: Re: [PATCH v5 12/14] drm: radeon: remove dead code and pointless local lut storage To: Peter Rosin Cc: LKML , Jani Nikula , Boris Brezillon , Lionel Landwerlin , David Airlie , Maling list - DRI developers , =?UTF-8?Q?Christian_K=C3=B6nig?= , Sean Paul , amd-gfx list , Alex Deucher , Daniel Vetter Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 13, 2017 at 12:25 PM, Peter Rosin wrote: > The redundant fb helpers .load_lut, .gamma_set and .gamma_get are > no longer used. Remove the dead code and hook up the crtc .gamma_set > to use the crtc gamma_store directly instead of duplicating that > info locally. > > Acked-by: Daniel Vetter > Signed-off-by: Peter Rosin Acked-by: Alex Deucher > --- > drivers/gpu/drm/radeon/atombios_crtc.c | 1 - > drivers/gpu/drm/radeon/radeon_connectors.c | 7 ++- > drivers/gpu/drm/radeon/radeon_display.c | 71 ++++++++++++----------------- > drivers/gpu/drm/radeon/radeon_fb.c | 2 - > drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 1 - > drivers/gpu/drm/radeon/radeon_mode.h | 4 -- > 6 files changed, 33 insertions(+), 53 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c > index 3c492a0aa6bd..02baaaf20e9d 100644 > --- a/drivers/gpu/drm/radeon/atombios_crtc.c > +++ b/drivers/gpu/drm/radeon/atombios_crtc.c > @@ -2217,7 +2217,6 @@ static const struct drm_crtc_helper_funcs atombios_helper_funcs = { > .mode_set_base_atomic = atombios_crtc_set_base_atomic, > .prepare = atombios_crtc_prepare, > .commit = atombios_crtc_commit, > - .load_lut = radeon_crtc_load_lut, > .disable = atombios_crtc_disable, > }; > > diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c > index 27affbde058c..2f642cbefd8e 100644 > --- a/drivers/gpu/drm/radeon/radeon_connectors.c > +++ b/drivers/gpu/drm/radeon/radeon_connectors.c > @@ -773,12 +773,15 @@ static int radeon_connector_set_property(struct drm_connector *connector, struct > > if (connector->encoder->crtc) { > struct drm_crtc *crtc = connector->encoder->crtc; > - const struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private; > struct radeon_crtc *radeon_crtc = to_radeon_crtc(crtc); > > radeon_crtc->output_csc = radeon_encoder->output_csc; > > - (*crtc_funcs->load_lut)(crtc); > + /* > + * Our .gamma_set assumes the .gamma_store has been > + * prefilled and don't care about its arguments. > + */ > + crtc->funcs->gamma_set(crtc, NULL, NULL, NULL, 0, NULL); > } > } > > diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c > index 17d3dafc8319..8b7d7a0d3ca8 100644 > --- a/drivers/gpu/drm/radeon/radeon_display.c > +++ b/drivers/gpu/drm/radeon/radeon_display.c > @@ -42,6 +42,7 @@ static void avivo_crtc_load_lut(struct drm_crtc *crtc) > struct radeon_crtc *radeon_crtc = to_radeon_crtc(crtc); > struct drm_device *dev = crtc->dev; > struct radeon_device *rdev = dev->dev_private; > + u16 *r, *g, *b; > int i; > > DRM_DEBUG_KMS("%d\n", radeon_crtc->crtc_id); > @@ -60,11 +61,14 @@ static void avivo_crtc_load_lut(struct drm_crtc *crtc) > WREG32(AVIVO_DC_LUT_WRITE_EN_MASK, 0x0000003f); > > WREG8(AVIVO_DC_LUT_RW_INDEX, 0); > + r = crtc->gamma_store; > + g = r + crtc->gamma_size; > + b = g + crtc->gamma_size; > for (i = 0; i < 256; i++) { > WREG32(AVIVO_DC_LUT_30_COLOR, > - (radeon_crtc->lut_r[i] << 20) | > - (radeon_crtc->lut_g[i] << 10) | > - (radeon_crtc->lut_b[i] << 0)); > + ((*r++ & 0xffc0) << 14) | > + ((*g++ & 0xffc0) << 4) | > + (*b++ >> 6)); > } > > /* Only change bit 0 of LUT_SEL, other bits are set elsewhere */ > @@ -76,6 +80,7 @@ static void dce4_crtc_load_lut(struct drm_crtc *crtc) > struct radeon_crtc *radeon_crtc = to_radeon_crtc(crtc); > struct drm_device *dev = crtc->dev; > struct radeon_device *rdev = dev->dev_private; > + u16 *r, *g, *b; > int i; > > DRM_DEBUG_KMS("%d\n", radeon_crtc->crtc_id); > @@ -93,11 +98,14 @@ static void dce4_crtc_load_lut(struct drm_crtc *crtc) > WREG32(EVERGREEN_DC_LUT_WRITE_EN_MASK + radeon_crtc->crtc_offset, 0x00000007); > > WREG32(EVERGREEN_DC_LUT_RW_INDEX + radeon_crtc->crtc_offset, 0); > + r = crtc->gamma_store; > + g = r + crtc->gamma_size; > + b = g + crtc->gamma_size; > for (i = 0; i < 256; i++) { > WREG32(EVERGREEN_DC_LUT_30_COLOR + radeon_crtc->crtc_offset, > - (radeon_crtc->lut_r[i] << 20) | > - (radeon_crtc->lut_g[i] << 10) | > - (radeon_crtc->lut_b[i] << 0)); > + ((*r++ & 0xffc0) << 14) | > + ((*g++ & 0xffc0) << 4) | > + (*b++ >> 6)); > } > } > > @@ -106,6 +114,7 @@ static void dce5_crtc_load_lut(struct drm_crtc *crtc) > struct radeon_crtc *radeon_crtc = to_radeon_crtc(crtc); > struct drm_device *dev = crtc->dev; > struct radeon_device *rdev = dev->dev_private; > + u16 *r, *g, *b; > int i; > > DRM_DEBUG_KMS("%d\n", radeon_crtc->crtc_id); > @@ -135,11 +144,14 @@ static void dce5_crtc_load_lut(struct drm_crtc *crtc) > WREG32(EVERGREEN_DC_LUT_WRITE_EN_MASK + radeon_crtc->crtc_offset, 0x00000007); > > WREG32(EVERGREEN_DC_LUT_RW_INDEX + radeon_crtc->crtc_offset, 0); > + r = crtc->gamma_store; > + g = r + crtc->gamma_size; > + b = g + crtc->gamma_size; > for (i = 0; i < 256; i++) { > WREG32(EVERGREEN_DC_LUT_30_COLOR + radeon_crtc->crtc_offset, > - (radeon_crtc->lut_r[i] << 20) | > - (radeon_crtc->lut_g[i] << 10) | > - (radeon_crtc->lut_b[i] << 0)); > + ((*r++ & 0xffc0) << 14) | > + ((*g++ & 0xffc0) << 4) | > + (*b++ >> 6)); > } > > WREG32(NI_DEGAMMA_CONTROL + radeon_crtc->crtc_offset, > @@ -172,6 +184,7 @@ static void legacy_crtc_load_lut(struct drm_crtc *crtc) > struct radeon_crtc *radeon_crtc = to_radeon_crtc(crtc); > struct drm_device *dev = crtc->dev; > struct radeon_device *rdev = dev->dev_private; > + u16 *r, *g, *b; > int i; > uint32_t dac2_cntl; > > @@ -183,11 +196,14 @@ static void legacy_crtc_load_lut(struct drm_crtc *crtc) > WREG32(RADEON_DAC_CNTL2, dac2_cntl); > > WREG8(RADEON_PALETTE_INDEX, 0); > + r = crtc->gamma_store; > + g = r + crtc->gamma_size; > + b = g + crtc->gamma_size; > for (i = 0; i < 256; i++) { > WREG32(RADEON_PALETTE_30_DATA, > - (radeon_crtc->lut_r[i] << 20) | > - (radeon_crtc->lut_g[i] << 10) | > - (radeon_crtc->lut_b[i] << 0)); > + ((*r++ & 0xffc0) << 14) | > + ((*g++ & 0xffc0) << 4) | > + (*b++ >> 6)); > } > } > > @@ -209,41 +225,10 @@ void radeon_crtc_load_lut(struct drm_crtc *crtc) > legacy_crtc_load_lut(crtc); > } > > -/** Sets the color ramps on behalf of fbcon */ > -void radeon_crtc_fb_gamma_set(struct drm_crtc *crtc, u16 red, u16 green, > - u16 blue, int regno) > -{ > - struct radeon_crtc *radeon_crtc = to_radeon_crtc(crtc); > - > - radeon_crtc->lut_r[regno] = red >> 6; > - radeon_crtc->lut_g[regno] = green >> 6; > - radeon_crtc->lut_b[regno] = blue >> 6; > -} > - > -/** Gets the color ramps on behalf of fbcon */ > -void radeon_crtc_fb_gamma_get(struct drm_crtc *crtc, u16 *red, u16 *green, > - u16 *blue, int regno) > -{ > - struct radeon_crtc *radeon_crtc = to_radeon_crtc(crtc); > - > - *red = radeon_crtc->lut_r[regno] << 6; > - *green = radeon_crtc->lut_g[regno] << 6; > - *blue = radeon_crtc->lut_b[regno] << 6; > -} > - > static int radeon_crtc_gamma_set(struct drm_crtc *crtc, u16 *red, u16 *green, > u16 *blue, uint32_t size, > struct drm_modeset_acquire_ctx *ctx) > { > - struct radeon_crtc *radeon_crtc = to_radeon_crtc(crtc); > - int i; > - > - /* userspace palettes are always correct as is */ > - for (i = 0; i < size; i++) { > - radeon_crtc->lut_r[i] = red[i] >> 6; > - radeon_crtc->lut_g[i] = green[i] >> 6; > - radeon_crtc->lut_b[i] = blue[i] >> 6; > - } > radeon_crtc_load_lut(crtc); > > return 0; > diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c > index 356ad90a5238..638bcb5593c8 100644 > --- a/drivers/gpu/drm/radeon/radeon_fb.c > +++ b/drivers/gpu/drm/radeon/radeon_fb.c > @@ -332,8 +332,6 @@ static int radeon_fbdev_destroy(struct drm_device *dev, struct radeon_fbdev *rfb > } > > static const struct drm_fb_helper_funcs radeon_fb_helper_funcs = { > - .gamma_set = radeon_crtc_fb_gamma_set, > - .gamma_get = radeon_crtc_fb_gamma_get, > .fb_probe = radeonfb_create, > }; > > diff --git a/drivers/gpu/drm/radeon/radeon_legacy_crtc.c b/drivers/gpu/drm/radeon/radeon_legacy_crtc.c > index ce6cb6666212..1f1856e0b1e0 100644 > --- a/drivers/gpu/drm/radeon/radeon_legacy_crtc.c > +++ b/drivers/gpu/drm/radeon/radeon_legacy_crtc.c > @@ -1116,7 +1116,6 @@ static const struct drm_crtc_helper_funcs legacy_helper_funcs = { > .mode_set_base_atomic = radeon_crtc_set_base_atomic, > .prepare = radeon_crtc_prepare, > .commit = radeon_crtc_commit, > - .load_lut = radeon_crtc_load_lut, > .disable = radeon_crtc_disable > }; > > diff --git a/drivers/gpu/drm/radeon/radeon_mode.h b/drivers/gpu/drm/radeon/radeon_mode.h > index 00f5ec5c12c7..da44ac234f64 100644 > --- a/drivers/gpu/drm/radeon/radeon_mode.h > +++ b/drivers/gpu/drm/radeon/radeon_mode.h > @@ -935,10 +935,6 @@ extern void > radeon_combios_encoder_crtc_scratch_regs(struct drm_encoder *encoder, int crtc); > extern void > radeon_combios_encoder_dpms_scratch_regs(struct drm_encoder *encoder, bool on); > -extern void radeon_crtc_fb_gamma_set(struct drm_crtc *crtc, u16 red, u16 green, > - u16 blue, int regno); > -extern void radeon_crtc_fb_gamma_get(struct drm_crtc *crtc, u16 *red, u16 *green, > - u16 *blue, int regno); > int radeon_framebuffer_init(struct drm_device *dev, > struct radeon_framebuffer *rfb, > const struct drm_mode_fb_cmd2 *mode_cmd, > -- > 2.11.0 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH v5 12/14] drm: radeon: remove dead code and pointless local lut storage Date: Fri, 14 Jul 2017 10:06:47 -0400 Message-ID: References: <20170713162538.22788-1-peda@axentia.se> <20170713162538.22788-13-peda@axentia.se> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170713162538.22788-13-peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Peter Rosin Cc: Jani Nikula , Boris Brezillon , amd-gfx list , David Airlie , LKML , Lionel Landwerlin , Sean Paul , Maling list - DRI developers , Alex Deucher , Daniel Vetter , =?UTF-8?Q?Christian_K=C3=B6nig?= List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdWwgMTMsIDIwMTcgYXQgMTI6MjUgUE0sIFBldGVyIFJvc2luIDxwZWRhQGF4ZW50 aWEuc2U+IHdyb3RlOgo+IFRoZSByZWR1bmRhbnQgZmIgaGVscGVycyAubG9hZF9sdXQsIC5nYW1t YV9zZXQgYW5kIC5nYW1tYV9nZXQgYXJlCj4gbm8gbG9uZ2VyIHVzZWQuIFJlbW92ZSB0aGUgZGVh ZCBjb2RlIGFuZCBob29rIHVwIHRoZSBjcnRjIC5nYW1tYV9zZXQKPiB0byB1c2UgdGhlIGNydGMg Z2FtbWFfc3RvcmUgZGlyZWN0bHkgaW5zdGVhZCBvZiBkdXBsaWNhdGluZyB0aGF0Cj4gaW5mbyBs b2NhbGx5Lgo+Cj4gQWNrZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwu Y2g+Cj4gU2lnbmVkLW9mZi1ieTogUGV0ZXIgUm9zaW4gPHBlZGFAYXhlbnRpYS5zZT4KCkFja2Vk LWJ5OiBBbGV4IERldWNoZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+Cgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vcmFkZW9uL2F0b21iaW9zX2NydGMuYyAgICAgIHwgIDEgLQo+ICBkcml2 ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9jb25uZWN0b3JzLmMgIHwgIDcgKystCj4gIGRyaXZl cnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2Rpc3BsYXkuYyAgICAgfCA3MSArKysrKysrKysrKyst LS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9mYi5jICAg ICAgICAgIHwgIDIgLQo+ICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9sZWdhY3lfY3J0 Yy5jIHwgIDEgLQo+ICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9tb2RlLmggICAgICAg IHwgIDQgLS0KPiAgNiBmaWxlcyBjaGFuZ2VkLCAzMyBpbnNlcnRpb25zKCspLCA1MyBkZWxldGlv bnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL2F0b21iaW9zX2Ny dGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vYXRvbWJpb3NfY3J0Yy5jCj4gaW5kZXggM2M0 OTJhMGFhNmJkLi4wMmJhYWFmMjBlOWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3Jh ZGVvbi9hdG9tYmlvc19jcnRjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL2F0b21i aW9zX2NydGMuYwo+IEBAIC0yMjE3LDcgKzIyMTcsNiBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRy bV9jcnRjX2hlbHBlcl9mdW5jcyBhdG9tYmlvc19oZWxwZXJfZnVuY3MgPSB7Cj4gICAgICAgICAu bW9kZV9zZXRfYmFzZV9hdG9taWMgPSBhdG9tYmlvc19jcnRjX3NldF9iYXNlX2F0b21pYywKPiAg ICAgICAgIC5wcmVwYXJlID0gYXRvbWJpb3NfY3J0Y19wcmVwYXJlLAo+ICAgICAgICAgLmNvbW1p dCA9IGF0b21iaW9zX2NydGNfY29tbWl0LAo+IC0gICAgICAgLmxvYWRfbHV0ID0gcmFkZW9uX2Ny dGNfbG9hZF9sdXQsCj4gICAgICAgICAuZGlzYWJsZSA9IGF0b21iaW9zX2NydGNfZGlzYWJsZSwK PiAgfTsKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9jb25u ZWN0b3JzLmMgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9jb25uZWN0b3JzLmMKPiBp bmRleCAyN2FmZmJkZTA1OGMuLjJmNjQyY2JlZmQ4ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vcmFkZW9uL3JhZGVvbl9jb25uZWN0b3JzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v cmFkZW9uL3JhZGVvbl9jb25uZWN0b3JzLmMKPiBAQCAtNzczLDEyICs3NzMsMTUgQEAgc3RhdGlj IGludCByYWRlb25fY29ubmVjdG9yX3NldF9wcm9wZXJ0eShzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAq Y29ubmVjdG9yLCBzdHJ1Y3QKPgo+ICAgICAgICAgICAgICAgICBpZiAoY29ubmVjdG9yLT5lbmNv ZGVyLT5jcnRjKSB7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGRybV9jcnRjICpj cnRjICA9IGNvbm5lY3Rvci0+ZW5jb2Rlci0+Y3J0YzsKPiAtICAgICAgICAgICAgICAgICAgICAg ICBjb25zdCBzdHJ1Y3QgZHJtX2NydGNfaGVscGVyX2Z1bmNzICpjcnRjX2Z1bmNzID0gY3J0Yy0+ aGVscGVyX3ByaXZhdGU7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHJhZGVvbl9j cnRjICpyYWRlb25fY3J0YyA9IHRvX3JhZGVvbl9jcnRjKGNydGMpOwo+Cj4gICAgICAgICAgICAg ICAgICAgICAgICAgcmFkZW9uX2NydGMtPm91dHB1dF9jc2MgPSByYWRlb25fZW5jb2Rlci0+b3V0 cHV0X2NzYzsKPgo+IC0gICAgICAgICAgICAgICAgICAgICAgICgqY3J0Y19mdW5jcy0+bG9hZF9s dXQpKGNydGMpOwo+ICsgICAgICAgICAgICAgICAgICAgICAgIC8qCj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICogT3VyIC5nYW1tYV9zZXQgYXNzdW1lcyB0aGUgLmdhbW1hX3N0b3JlIGhhcyBi ZWVuCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICogcHJlZmlsbGVkIGFuZCBkb24ndCBjYXJl IGFib3V0IGl0cyBhcmd1bWVudHMuCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICovCj4gKyAg ICAgICAgICAgICAgICAgICAgICAgY3J0Yy0+ZnVuY3MtPmdhbW1hX3NldChjcnRjLCBOVUxMLCBO VUxMLCBOVUxMLCAwLCBOVUxMKTsKPiAgICAgICAgICAgICAgICAgfQo+ICAgICAgICAgfQo+Cj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2Rpc3BsYXkuYyBiL2Ry aXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2Rpc3BsYXkuYwo+IGluZGV4IDE3ZDNkYWZjODMx OS4uOGI3ZDdhMGQzY2E4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFk ZW9uX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2Rpc3Bs YXkuYwo+IEBAIC00Miw2ICs0Miw3IEBAIHN0YXRpYyB2b2lkIGF2aXZvX2NydGNfbG9hZF9sdXQo c3RydWN0IGRybV9jcnRjICpjcnRjKQo+ICAgICAgICAgc3RydWN0IHJhZGVvbl9jcnRjICpyYWRl b25fY3J0YyA9IHRvX3JhZGVvbl9jcnRjKGNydGMpOwo+ICAgICAgICAgc3RydWN0IGRybV9kZXZp Y2UgKmRldiA9IGNydGMtPmRldjsKPiAgICAgICAgIHN0cnVjdCByYWRlb25fZGV2aWNlICpyZGV2 ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiArICAgICAgIHUxNiAqciwgKmcsICpiOwo+ICAgICAgICAg aW50IGk7Cj4KPiAgICAgICAgIERSTV9ERUJVR19LTVMoIiVkXG4iLCByYWRlb25fY3J0Yy0+Y3J0 Y19pZCk7Cj4gQEAgLTYwLDExICs2MSwxNCBAQCBzdGF0aWMgdm9pZCBhdml2b19jcnRjX2xvYWRf bHV0KHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiAgICAgICAgIFdSRUczMihBVklWT19EQ19MVVRf V1JJVEVfRU5fTUFTSywgMHgwMDAwMDAzZik7Cj4KPiAgICAgICAgIFdSRUc4KEFWSVZPX0RDX0xV VF9SV19JTkRFWCwgMCk7Cj4gKyAgICAgICByID0gY3J0Yy0+Z2FtbWFfc3RvcmU7Cj4gKyAgICAg ICBnID0gciArIGNydGMtPmdhbW1hX3NpemU7Cj4gKyAgICAgICBiID0gZyArIGNydGMtPmdhbW1h X3NpemU7Cj4gICAgICAgICBmb3IgKGkgPSAwOyBpIDwgMjU2OyBpKyspIHsKPiAgICAgICAgICAg ICAgICAgV1JFRzMyKEFWSVZPX0RDX0xVVF8zMF9DT0xPUiwKPiAtICAgICAgICAgICAgICAgICAg ICAgICAgICAgIChyYWRlb25fY3J0Yy0+bHV0X3JbaV0gPDwgMjApIHwKPiAtICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChyYWRlb25fY3J0Yy0+bHV0X2dbaV0gPDwgMTApIHwKPiAtICAgICAg ICAgICAgICAgICAgICAgICAgICAgIChyYWRlb25fY3J0Yy0+bHV0X2JbaV0gPDwgMCkpOwo+ICsg ICAgICAgICAgICAgICAgICAgICAgKCgqcisrICYgMHhmZmMwKSA8PCAxNCkgfAo+ICsgICAgICAg ICAgICAgICAgICAgICAgKCgqZysrICYgMHhmZmMwKSA8PCA0KSB8Cj4gKyAgICAgICAgICAgICAg ICAgICAgICAoKmIrKyA+PiA2KSk7Cj4gICAgICAgICB9Cj4KPiAgICAgICAgIC8qIE9ubHkgY2hh bmdlIGJpdCAwIG9mIExVVF9TRUwsIG90aGVyIGJpdHMgYXJlIHNldCBlbHNld2hlcmUgKi8KPiBA QCAtNzYsNiArODAsNyBAQCBzdGF0aWMgdm9pZCBkY2U0X2NydGNfbG9hZF9sdXQoc3RydWN0IGRy bV9jcnRjICpjcnRjKQo+ICAgICAgICAgc3RydWN0IHJhZGVvbl9jcnRjICpyYWRlb25fY3J0YyA9 IHRvX3JhZGVvbl9jcnRjKGNydGMpOwo+ICAgICAgICAgc3RydWN0IGRybV9kZXZpY2UgKmRldiA9 IGNydGMtPmRldjsKPiAgICAgICAgIHN0cnVjdCByYWRlb25fZGV2aWNlICpyZGV2ID0gZGV2LT5k ZXZfcHJpdmF0ZTsKPiArICAgICAgIHUxNiAqciwgKmcsICpiOwo+ICAgICAgICAgaW50IGk7Cj4K PiAgICAgICAgIERSTV9ERUJVR19LTVMoIiVkXG4iLCByYWRlb25fY3J0Yy0+Y3J0Y19pZCk7Cj4g QEAgLTkzLDExICs5OCwxNCBAQCBzdGF0aWMgdm9pZCBkY2U0X2NydGNfbG9hZF9sdXQoc3RydWN0 IGRybV9jcnRjICpjcnRjKQo+ICAgICAgICAgV1JFRzMyKEVWRVJHUkVFTl9EQ19MVVRfV1JJVEVf RU5fTUFTSyArIHJhZGVvbl9jcnRjLT5jcnRjX29mZnNldCwgMHgwMDAwMDAwNyk7Cj4KPiAgICAg ICAgIFdSRUczMihFVkVSR1JFRU5fRENfTFVUX1JXX0lOREVYICsgcmFkZW9uX2NydGMtPmNydGNf b2Zmc2V0LCAwKTsKPiArICAgICAgIHIgPSBjcnRjLT5nYW1tYV9zdG9yZTsKPiArICAgICAgIGcg PSByICsgY3J0Yy0+Z2FtbWFfc2l6ZTsKPiArICAgICAgIGIgPSBnICsgY3J0Yy0+Z2FtbWFfc2l6 ZTsKPiAgICAgICAgIGZvciAoaSA9IDA7IGkgPCAyNTY7IGkrKykgewo+ICAgICAgICAgICAgICAg ICBXUkVHMzIoRVZFUkdSRUVOX0RDX0xVVF8zMF9DT0xPUiArIHJhZGVvbl9jcnRjLT5jcnRjX29m ZnNldCwKPiAtICAgICAgICAgICAgICAgICAgICAgIChyYWRlb25fY3J0Yy0+bHV0X3JbaV0gPDwg MjApIHwKPiAtICAgICAgICAgICAgICAgICAgICAgIChyYWRlb25fY3J0Yy0+bHV0X2dbaV0gPDwg MTApIHwKPiAtICAgICAgICAgICAgICAgICAgICAgIChyYWRlb25fY3J0Yy0+bHV0X2JbaV0gPDwg MCkpOwo+ICsgICAgICAgICAgICAgICAgICAgICAgKCgqcisrICYgMHhmZmMwKSA8PCAxNCkgfAo+ ICsgICAgICAgICAgICAgICAgICAgICAgKCgqZysrICYgMHhmZmMwKSA8PCA0KSB8Cj4gKyAgICAg ICAgICAgICAgICAgICAgICAoKmIrKyA+PiA2KSk7Cj4gICAgICAgICB9Cj4gIH0KPgo+IEBAIC0x MDYsNiArMTE0LDcgQEAgc3RhdGljIHZvaWQgZGNlNV9jcnRjX2xvYWRfbHV0KHN0cnVjdCBkcm1f Y3J0YyAqY3J0YykKPiAgICAgICAgIHN0cnVjdCByYWRlb25fY3J0YyAqcmFkZW9uX2NydGMgPSB0 b19yYWRlb25fY3J0YyhjcnRjKTsKPiAgICAgICAgIHN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBj cnRjLT5kZXY7Cj4gICAgICAgICBzdHJ1Y3QgcmFkZW9uX2RldmljZSAqcmRldiA9IGRldi0+ZGV2 X3ByaXZhdGU7Cj4gKyAgICAgICB1MTYgKnIsICpnLCAqYjsKPiAgICAgICAgIGludCBpOwo+Cj4g ICAgICAgICBEUk1fREVCVUdfS01TKCIlZFxuIiwgcmFkZW9uX2NydGMtPmNydGNfaWQpOwo+IEBA IC0xMzUsMTEgKzE0NCwxNCBAQCBzdGF0aWMgdm9pZCBkY2U1X2NydGNfbG9hZF9sdXQoc3RydWN0 IGRybV9jcnRjICpjcnRjKQo+ICAgICAgICAgV1JFRzMyKEVWRVJHUkVFTl9EQ19MVVRfV1JJVEVf RU5fTUFTSyArIHJhZGVvbl9jcnRjLT5jcnRjX29mZnNldCwgMHgwMDAwMDAwNyk7Cj4KPiAgICAg ICAgIFdSRUczMihFVkVSR1JFRU5fRENfTFVUX1JXX0lOREVYICsgcmFkZW9uX2NydGMtPmNydGNf b2Zmc2V0LCAwKTsKPiArICAgICAgIHIgPSBjcnRjLT5nYW1tYV9zdG9yZTsKPiArICAgICAgIGcg PSByICsgY3J0Yy0+Z2FtbWFfc2l6ZTsKPiArICAgICAgIGIgPSBnICsgY3J0Yy0+Z2FtbWFfc2l6 ZTsKPiAgICAgICAgIGZvciAoaSA9IDA7IGkgPCAyNTY7IGkrKykgewo+ICAgICAgICAgICAgICAg ICBXUkVHMzIoRVZFUkdSRUVOX0RDX0xVVF8zMF9DT0xPUiArIHJhZGVvbl9jcnRjLT5jcnRjX29m ZnNldCwKPiAtICAgICAgICAgICAgICAgICAgICAgIChyYWRlb25fY3J0Yy0+bHV0X3JbaV0gPDwg MjApIHwKPiAtICAgICAgICAgICAgICAgICAgICAgIChyYWRlb25fY3J0Yy0+bHV0X2dbaV0gPDwg MTApIHwKPiAtICAgICAgICAgICAgICAgICAgICAgIChyYWRlb25fY3J0Yy0+bHV0X2JbaV0gPDwg MCkpOwo+ICsgICAgICAgICAgICAgICAgICAgICAgKCgqcisrICYgMHhmZmMwKSA8PCAxNCkgfAo+ ICsgICAgICAgICAgICAgICAgICAgICAgKCgqZysrICYgMHhmZmMwKSA8PCA0KSB8Cj4gKyAgICAg ICAgICAgICAgICAgICAgICAoKmIrKyA+PiA2KSk7Cj4gICAgICAgICB9Cj4KPiAgICAgICAgIFdS RUczMihOSV9ERUdBTU1BX0NPTlRST0wgKyByYWRlb25fY3J0Yy0+Y3J0Y19vZmZzZXQsCj4gQEAg LTE3Miw2ICsxODQsNyBAQCBzdGF0aWMgdm9pZCBsZWdhY3lfY3J0Y19sb2FkX2x1dChzdHJ1Y3Qg ZHJtX2NydGMgKmNydGMpCj4gICAgICAgICBzdHJ1Y3QgcmFkZW9uX2NydGMgKnJhZGVvbl9jcnRj ID0gdG9fcmFkZW9uX2NydGMoY3J0Yyk7Cj4gICAgICAgICBzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 ID0gY3J0Yy0+ZGV2Owo+ICAgICAgICAgc3RydWN0IHJhZGVvbl9kZXZpY2UgKnJkZXYgPSBkZXYt PmRldl9wcml2YXRlOwo+ICsgICAgICAgdTE2ICpyLCAqZywgKmI7Cj4gICAgICAgICBpbnQgaTsK PiAgICAgICAgIHVpbnQzMl90IGRhYzJfY250bDsKPgo+IEBAIC0xODMsMTEgKzE5NiwxNCBAQCBz dGF0aWMgdm9pZCBsZWdhY3lfY3J0Y19sb2FkX2x1dChzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4g ICAgICAgICBXUkVHMzIoUkFERU9OX0RBQ19DTlRMMiwgZGFjMl9jbnRsKTsKPgo+ICAgICAgICAg V1JFRzgoUkFERU9OX1BBTEVUVEVfSU5ERVgsIDApOwo+ICsgICAgICAgciA9IGNydGMtPmdhbW1h X3N0b3JlOwo+ICsgICAgICAgZyA9IHIgKyBjcnRjLT5nYW1tYV9zaXplOwo+ICsgICAgICAgYiA9 IGcgKyBjcnRjLT5nYW1tYV9zaXplOwo+ICAgICAgICAgZm9yIChpID0gMDsgaSA8IDI1NjsgaSsr KSB7Cj4gICAgICAgICAgICAgICAgIFdSRUczMihSQURFT05fUEFMRVRURV8zMF9EQVRBLAo+IC0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgKHJhZGVvbl9jcnRjLT5sdXRfcltpXSA8PCAyMCkg fAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgKHJhZGVvbl9jcnRjLT5sdXRfZ1tpXSA8 PCAxMCkgfAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgKHJhZGVvbl9jcnRjLT5sdXRf YltpXSA8PCAwKSk7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAoKCpyKysgJiAweGZmYzApIDw8 IDE0KSB8Cj4gKyAgICAgICAgICAgICAgICAgICAgICAoKCpnKysgJiAweGZmYzApIDw8IDQpIHwK PiArICAgICAgICAgICAgICAgICAgICAgICgqYisrID4+IDYpKTsKPiAgICAgICAgIH0KPiAgfQo+ Cj4gQEAgLTIwOSw0MSArMjI1LDEwIEBAIHZvaWQgcmFkZW9uX2NydGNfbG9hZF9sdXQoc3RydWN0 IGRybV9jcnRjICpjcnRjKQo+ICAgICAgICAgICAgICAgICBsZWdhY3lfY3J0Y19sb2FkX2x1dChj cnRjKTsKPiAgfQo+Cj4gLS8qKiBTZXRzIHRoZSBjb2xvciByYW1wcyBvbiBiZWhhbGYgb2YgZmJj b24gKi8KPiAtdm9pZCByYWRlb25fY3J0Y19mYl9nYW1tYV9zZXQoc3RydWN0IGRybV9jcnRjICpj cnRjLCB1MTYgcmVkLCB1MTYgZ3JlZW4sCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg dTE2IGJsdWUsIGludCByZWdubykKPiAtewo+IC0gICAgICAgc3RydWN0IHJhZGVvbl9jcnRjICpy YWRlb25fY3J0YyA9IHRvX3JhZGVvbl9jcnRjKGNydGMpOwo+IC0KPiAtICAgICAgIHJhZGVvbl9j cnRjLT5sdXRfcltyZWdub10gPSByZWQgPj4gNjsKPiAtICAgICAgIHJhZGVvbl9jcnRjLT5sdXRf Z1tyZWdub10gPSBncmVlbiA+PiA2Owo+IC0gICAgICAgcmFkZW9uX2NydGMtPmx1dF9iW3JlZ25v XSA9IGJsdWUgPj4gNjsKPiAtfQo+IC0KPiAtLyoqIEdldHMgdGhlIGNvbG9yIHJhbXBzIG9uIGJl aGFsZiBvZiBmYmNvbiAqLwo+IC12b2lkIHJhZGVvbl9jcnRjX2ZiX2dhbW1hX2dldChzdHJ1Y3Qg ZHJtX2NydGMgKmNydGMsIHUxNiAqcmVkLCB1MTYgKmdyZWVuLAo+IC0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHUxNiAqYmx1ZSwgaW50IHJlZ25vKQo+IC17Cj4gLSAgICAgICBzdHJ1Y3Qg cmFkZW9uX2NydGMgKnJhZGVvbl9jcnRjID0gdG9fcmFkZW9uX2NydGMoY3J0Yyk7Cj4gLQo+IC0g ICAgICAgKnJlZCA9IHJhZGVvbl9jcnRjLT5sdXRfcltyZWdub10gPDwgNjsKPiAtICAgICAgICpn cmVlbiA9IHJhZGVvbl9jcnRjLT5sdXRfZ1tyZWdub10gPDwgNjsKPiAtICAgICAgICpibHVlID0g cmFkZW9uX2NydGMtPmx1dF9iW3JlZ25vXSA8PCA2Owo+IC19Cj4gLQo+ICBzdGF0aWMgaW50IHJh ZGVvbl9jcnRjX2dhbW1hX3NldChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsIHUxNiAqcmVkLCB1MTYg KmdyZWVuLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHUxNiAqYmx1ZSwgdWlu dDMyX3Qgc2l6ZSwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgZHJt X21vZGVzZXRfYWNxdWlyZV9jdHggKmN0eCkKPiAgewo+IC0gICAgICAgc3RydWN0IHJhZGVvbl9j cnRjICpyYWRlb25fY3J0YyA9IHRvX3JhZGVvbl9jcnRjKGNydGMpOwo+IC0gICAgICAgaW50IGk7 Cj4gLQo+IC0gICAgICAgLyogdXNlcnNwYWNlIHBhbGV0dGVzIGFyZSBhbHdheXMgY29ycmVjdCBh cyBpcyAqLwo+IC0gICAgICAgZm9yIChpID0gMDsgaSA8IHNpemU7IGkrKykgewo+IC0gICAgICAg ICAgICAgICByYWRlb25fY3J0Yy0+bHV0X3JbaV0gPSByZWRbaV0gPj4gNjsKPiAtICAgICAgICAg ICAgICAgcmFkZW9uX2NydGMtPmx1dF9nW2ldID0gZ3JlZW5baV0gPj4gNjsKPiAtICAgICAgICAg ICAgICAgcmFkZW9uX2NydGMtPmx1dF9iW2ldID0gYmx1ZVtpXSA+PiA2Owo+IC0gICAgICAgfQo+ ICAgICAgICAgcmFkZW9uX2NydGNfbG9hZF9sdXQoY3J0Yyk7Cj4KPiAgICAgICAgIHJldHVybiAw Owo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9mYi5jIGIvZHJp dmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fZmIuYwo+IGluZGV4IDM1NmFkOTBhNTIzOC4uNjM4 YmNiNTU5M2M4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2Zi LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9mYi5jCj4gQEAgLTMzMiw4 ICszMzIsNiBAQCBzdGF0aWMgaW50IHJhZGVvbl9mYmRldl9kZXN0cm95KHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYsIHN0cnVjdCByYWRlb25fZmJkZXYgKnJmYgo+ICB9Cj4KPiAgc3RhdGljIGNvbnN0 IHN0cnVjdCBkcm1fZmJfaGVscGVyX2Z1bmNzIHJhZGVvbl9mYl9oZWxwZXJfZnVuY3MgPSB7Cj4g LSAgICAgICAuZ2FtbWFfc2V0ID0gcmFkZW9uX2NydGNfZmJfZ2FtbWFfc2V0LAo+IC0gICAgICAg LmdhbW1hX2dldCA9IHJhZGVvbl9jcnRjX2ZiX2dhbW1hX2dldCwKPiAgICAgICAgIC5mYl9wcm9i ZSA9IHJhZGVvbmZiX2NyZWF0ZSwKPiAgfTsKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vcmFkZW9uL3JhZGVvbl9sZWdhY3lfY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9y YWRlb25fbGVnYWN5X2NydGMuYwo+IGluZGV4IGNlNmNiNjY2NjIxMi4uMWYxODU2ZTBiMWUwIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2xlZ2FjeV9jcnRjLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9sZWdhY3lfY3J0Yy5jCj4gQEAg LTExMTYsNyArMTExNiw2IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2NydGNfaGVscGVyX2Z1 bmNzIGxlZ2FjeV9oZWxwZXJfZnVuY3MgPSB7Cj4gICAgICAgICAubW9kZV9zZXRfYmFzZV9hdG9t aWMgPSByYWRlb25fY3J0Y19zZXRfYmFzZV9hdG9taWMsCj4gICAgICAgICAucHJlcGFyZSA9IHJh ZGVvbl9jcnRjX3ByZXBhcmUsCj4gICAgICAgICAuY29tbWl0ID0gcmFkZW9uX2NydGNfY29tbWl0 LAo+IC0gICAgICAgLmxvYWRfbHV0ID0gcmFkZW9uX2NydGNfbG9hZF9sdXQsCj4gICAgICAgICAu ZGlzYWJsZSA9IHJhZGVvbl9jcnRjX2Rpc2FibGUKPiAgfTsKPgo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9tb2RlLmggYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9u L3JhZGVvbl9tb2RlLmgKPiBpbmRleCAwMGY1ZWM1YzEyYzcuLmRhNDRhYzIzNGY2NCAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9tb2RlLmgKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9tb2RlLmgKPiBAQCAtOTM1LDEwICs5MzUsNiBAQCBl eHRlcm4gdm9pZAo+ICByYWRlb25fY29tYmlvc19lbmNvZGVyX2NydGNfc2NyYXRjaF9yZWdzKHN0 cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlciwgaW50IGNydGMpOwo+ICBleHRlcm4gdm9pZAo+ICBy YWRlb25fY29tYmlvc19lbmNvZGVyX2RwbXNfc2NyYXRjaF9yZWdzKHN0cnVjdCBkcm1fZW5jb2Rl ciAqZW5jb2RlciwgYm9vbCBvbik7Cj4gLWV4dGVybiB2b2lkIHJhZGVvbl9jcnRjX2ZiX2dhbW1h X3NldChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsIHUxNiByZWQsIHUxNiBncmVlbiwKPiAtICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdTE2IGJsdWUsIGludCByZWdubyk7Cj4gLWV4 dGVybiB2b2lkIHJhZGVvbl9jcnRjX2ZiX2dhbW1hX2dldChzdHJ1Y3QgZHJtX2NydGMgKmNydGMs IHUxNiAqcmVkLCB1MTYgKmdyZWVuLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB1MTYgKmJsdWUsIGludCByZWdubyk7Cj4gIGludCByYWRlb25fZnJhbWVidWZmZXJfaW5p dChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg c3RydWN0IHJhZGVvbl9mcmFtZWJ1ZmZlciAqcmZiLAo+ICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgY29uc3Qgc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIgKm1vZGVfY21kLAo+IC0tCj4gMi4x MS4wCj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ IGFtZC1nZnggbWFpbGluZyBsaXN0Cj4gYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWls aW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==