From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7F60C55ABD for ; Tue, 10 Nov 2020 22:05:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9947F20BED for ; Tue, 10 Nov 2020 22:05:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XjyOicW3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732020AbgKJWFX (ORCPT ); Tue, 10 Nov 2020 17:05:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726467AbgKJWFW (ORCPT ); Tue, 10 Nov 2020 17:05:22 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A0CEC0613D1 for ; Tue, 10 Nov 2020 14:05:21 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id a65so4694751wme.1 for ; Tue, 10 Nov 2020 14:05:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=qZToJzWvZIM70EuRiQ7NoVEKN6DZ5AQGlu/l0sYJbdo=; b=XjyOicW3O9YNxvhwetYYen8NIUXx6DtxhfHeM3eeS7dRqHQTVCI2YXrvlAXna8ubw4 91hNbvU5rvEipK0xYxRb+aAFeCVhGN3sXSmKvT9uMnvyRjKZK0MVQZsLsUW0y1NuThB+ qpIQUWf4Q0V6cxCuoEiAk5gvoYEqve6tboDkF4bzKsMEEGMaDqknFVAuHon1tPSxft88 V067xL1LNtenmB1IGjhefnjnAd+OSJwQqSxSxYntaqlXt+tfZN5Xbu9/CPyqNV+M53Nd jgI1xhFvjcpsQuqb3xpH/SxHFKAFKgfzkzozf2vYODBsdHbjTBxXZ59zgeTdlvW9/9y6 K9+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qZToJzWvZIM70EuRiQ7NoVEKN6DZ5AQGlu/l0sYJbdo=; b=R8EcXZZ+VcWfGzSu8TVMNm2DO/q8VOPLDOdIaMX7ZXj43T13iItQXniQVN9tWZc9ah FIDv4xLf1t0NOHNt9HFYOKjQqXScLA2BK+yBEUjPV5sRGKOyukxdw45n2U3DE+ChdswQ AgBeSsHyDRyEuDxXAb4iHAL7UuIuWz8iR2SWCAi8FFZfbVYS7NE96YR509DUCW+LuQyL J3vFxzL5M72IXg0kPyub7uTlRQJn0XYFtDClUap80JHnVHdXOsa17jtqKXmBJcvXjRqG nq++Pe9K2X6b8MOvFId3ZiEZ5qCXhr5HlszOv0gAVCZNhCInQTEQj2BNoyzCkPclrzPb E76g== X-Gm-Message-State: AOAM532F/0PS656odAkgVxJ0Uiy3LHqam8eGQ0B5pfd2lls98P8sIMzK eCcD3cLYkRa0unjqi+Gy8nQcChrVAwr/3mWwc2Y= X-Google-Smtp-Source: ABdhPJwWqoDTPUmRVpXmlstCWEAP5RO5KfmAgKzuWQagXCBAiZ6FokJKfpjc7Kx5J2AQT9MwV7S2Guk+ZWnb/gt8JoM= X-Received: by 2002:a7b:c157:: with SMTP id z23mr246689wmi.70.1605045920104; Tue, 10 Nov 2020 14:05:20 -0800 (PST) MIME-Version: 1.0 References: <20201109211855.3340030-1-lee.jones@linaro.org> <20201109211855.3340030-2-lee.jones@linaro.org> In-Reply-To: <20201109211855.3340030-2-lee.jones@linaro.org> From: Alex Deucher Date: Tue, 10 Nov 2020 17:05:07 -0500 Message-ID: Subject: Re: [PATCH 01/20] drm/radeon/radeon_ttm: Place declaration of 'rdev' in same clause as its use To: Lee Jones Cc: David Airlie , LKML , amd-gfx list , Jerome Glisse , Maling list - DRI developers , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 9, 2020 at 4:19 PM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_ttm.c: In function =E2=80=98radeon_ttm_tt_= create=E2=80=99: > drivers/gpu/drm/radeon/radeon_ttm.c:611:24: warning: variable =E2=80=98r= dev=E2=80=99 set but not used [-Wunused-but-set-variable] > > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Jerome Glisse > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/radeon_ttm.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon= /radeon_ttm.c > index 95038ac3382e2..a8c915920070f 100644 > --- a/drivers/gpu/drm/radeon/radeon_ttm.c > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c > @@ -608,21 +608,21 @@ static void radeon_ttm_backend_destroy(struct ttm_b= o_device *bdev, struct ttm_tt > static struct ttm_tt *radeon_ttm_tt_create(struct ttm_buffer_object *bo, > uint32_t page_flags) > { > - struct radeon_device *rdev; > struct radeon_ttm_tt *gtt; > enum ttm_caching caching; > struct radeon_bo *rbo; > - > - rbo =3D container_of(bo, struct radeon_bo, tbo); > +#if IS_ENABLED(CONFIG_AGP) > + struct radeon_device *rdev; > > rdev =3D radeon_get_rdev(bo->bdev); > -#if IS_ENABLED(CONFIG_AGP) > if (rdev->flags & RADEON_IS_AGP) { > return ttm_agp_tt_create(bo, rdev->ddev->agp->bridge, > page_flags); > } > #endif > > + rbo =3D container_of(bo, struct radeon_bo, tbo); > + > gtt =3D kzalloc(sizeof(struct radeon_ttm_tt), GFP_KERNEL); > if (gtt =3D=3D NULL) { > return NULL; > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7298C388F7 for ; Tue, 10 Nov 2020 22:05:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4340420809 for ; Tue, 10 Nov 2020 22:05:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XjyOicW3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4340420809 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F5CD89CBE; Tue, 10 Nov 2020 22:05:22 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 761BD89CBE; Tue, 10 Nov 2020 22:05:21 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id h2so4733042wmm.0; Tue, 10 Nov 2020 14:05:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=qZToJzWvZIM70EuRiQ7NoVEKN6DZ5AQGlu/l0sYJbdo=; b=XjyOicW3O9YNxvhwetYYen8NIUXx6DtxhfHeM3eeS7dRqHQTVCI2YXrvlAXna8ubw4 91hNbvU5rvEipK0xYxRb+aAFeCVhGN3sXSmKvT9uMnvyRjKZK0MVQZsLsUW0y1NuThB+ qpIQUWf4Q0V6cxCuoEiAk5gvoYEqve6tboDkF4bzKsMEEGMaDqknFVAuHon1tPSxft88 V067xL1LNtenmB1IGjhefnjnAd+OSJwQqSxSxYntaqlXt+tfZN5Xbu9/CPyqNV+M53Nd jgI1xhFvjcpsQuqb3xpH/SxHFKAFKgfzkzozf2vYODBsdHbjTBxXZ59zgeTdlvW9/9y6 K9+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qZToJzWvZIM70EuRiQ7NoVEKN6DZ5AQGlu/l0sYJbdo=; b=bASratxfo+poyQnCjc7JAZFNye4YDLYwUtEDblfaQlMhIIl3iuWpqQajk219qJE+Gj cdbBnsU+A4ruRScrBRYhR6EZry8kPqBKoWemrjXwDnATTzQ8HSSX/HculjxFSsbah3HD 8pJ/c81l4jcPko8SznBmy9dPZ3N3sDjcdFwevM3QBDTaZtGLVq0mg6ijtyCbxDGI8pHB ftIok2JqVPXU6bS8VwZJwdTxPTVHzlIDqYX1X2jIvVFbdckzUzs3DNZffR0e74Jbpo20 K9jVYZzHCerCw9pK7N8DeY3Lkwkjl+mvtcw5Yp2oSd19ws4CPwTMYLnxDZlvQDyrVXoK dVEA== X-Gm-Message-State: AOAM530gE+h1RTjrD/Z6d/8JlVCQWSNMx99rxTjqsZCYIfNstnVK6gf0 gBoR0iAijcdvkpCmqpJY4xXT4PqvEDh3b5iNoBs= X-Google-Smtp-Source: ABdhPJwWqoDTPUmRVpXmlstCWEAP5RO5KfmAgKzuWQagXCBAiZ6FokJKfpjc7Kx5J2AQT9MwV7S2Guk+ZWnb/gt8JoM= X-Received: by 2002:a7b:c157:: with SMTP id z23mr246689wmi.70.1605045920104; Tue, 10 Nov 2020 14:05:20 -0800 (PST) MIME-Version: 1.0 References: <20201109211855.3340030-1-lee.jones@linaro.org> <20201109211855.3340030-2-lee.jones@linaro.org> In-Reply-To: <20201109211855.3340030-2-lee.jones@linaro.org> From: Alex Deucher Date: Tue, 10 Nov 2020 17:05:07 -0500 Message-ID: Subject: Re: [PATCH 01/20] drm/radeon/radeon_ttm: Place declaration of 'rdev' in same clause as its use To: Lee Jones X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , Jerome Glisse , amd-gfx list , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gTW9uLCBOb3YgOSwgMjAyMCBhdCA0OjE5IFBNIExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFy by5vcmc+IHdyb3RlOgo+Cj4gRml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2VybmVsIGJ1aWxkIHdh cm5pbmcocyk6Cj4KPiAgZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fdHRtLmM6IEluIGZ1 bmN0aW9uIOKAmHJhZGVvbl90dG1fdHRfY3JlYXRl4oCZOgo+ICBkcml2ZXJzL2dwdS9kcm0vcmFk ZW9uL3JhZGVvbl90dG0uYzo2MTE6MjQ6IHdhcm5pbmc6IHZhcmlhYmxlIOKAmHJkZXbigJkgc2V0 IGJ1dCBub3QgdXNlZCBbLVd1bnVzZWQtYnV0LXNldC12YXJpYWJsZV0KPgo+IENjOiBBbGV4IERl dWNoZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+Cj4gQ2M6ICJDaHJpc3RpYW4gS8O2bmln IiA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgo+IENjOiBEYXZpZCBBaXJsaWUgPGFpcmxpZWRA bGludXguaWU+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4KPiBDYzogSmVy b21lIEdsaXNzZSA8Z2xpc3NlQGZyZWVkZXNrdG9wLm9yZz4KPiBDYzogYW1kLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IFNp Z25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+CgpBcHBsaWVkLiAg VGhhbmtzIQoKQWxleAoKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX3R0 bS5jIHwgOCArKysrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRl bGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9u X3R0bS5jIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fdHRtLmMKPiBpbmRleCA5NTAz OGFjMzM4MmUyLi5hOGM5MTU5MjAwNzBmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9y YWRlb24vcmFkZW9uX3R0bS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25f dHRtLmMKPiBAQCAtNjA4LDIxICs2MDgsMjEgQEAgc3RhdGljIHZvaWQgcmFkZW9uX3R0bV9iYWNr ZW5kX2Rlc3Ryb3koc3RydWN0IHR0bV9ib19kZXZpY2UgKmJkZXYsIHN0cnVjdCB0dG1fdHQKPiAg c3RhdGljIHN0cnVjdCB0dG1fdHQgKnJhZGVvbl90dG1fdHRfY3JlYXRlKHN0cnVjdCB0dG1fYnVm ZmVyX29iamVjdCAqYm8sCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHVpbnQzMl90IHBhZ2VfZmxhZ3MpCj4gIHsKPiAtICAgICAgIHN0cnVjdCByYWRlb25fZGV2 aWNlICpyZGV2Owo+ICAgICAgICAgc3RydWN0IHJhZGVvbl90dG1fdHQgKmd0dDsKPiAgICAgICAg IGVudW0gdHRtX2NhY2hpbmcgY2FjaGluZzsKPiAgICAgICAgIHN0cnVjdCByYWRlb25fYm8gKnJi bzsKPiAtCj4gLSAgICAgICByYm8gPSBjb250YWluZXJfb2YoYm8sIHN0cnVjdCByYWRlb25fYm8s IHRibyk7Cj4gKyNpZiBJU19FTkFCTEVEKENPTkZJR19BR1ApCj4gKyAgICAgICBzdHJ1Y3QgcmFk ZW9uX2RldmljZSAqcmRldjsKPgo+ICAgICAgICAgcmRldiA9IHJhZGVvbl9nZXRfcmRldihiby0+ YmRldik7Cj4gLSNpZiBJU19FTkFCTEVEKENPTkZJR19BR1ApCj4gICAgICAgICBpZiAocmRldi0+ ZmxhZ3MgJiBSQURFT05fSVNfQUdQKSB7Cj4gICAgICAgICAgICAgICAgIHJldHVybiB0dG1fYWdw X3R0X2NyZWF0ZShibywgcmRldi0+ZGRldi0+YWdwLT5icmlkZ2UsCj4gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBwYWdlX2ZsYWdzKTsKPiAgICAgICAgIH0KPiAgI2Vu ZGlmCj4KPiArICAgICAgIHJibyA9IGNvbnRhaW5lcl9vZihibywgc3RydWN0IHJhZGVvbl9ibywg dGJvKTsKPiArCj4gICAgICAgICBndHQgPSBremFsbG9jKHNpemVvZihzdHJ1Y3QgcmFkZW9uX3R0 bV90dCksIEdGUF9LRVJORUwpOwo+ICAgICAgICAgaWYgKGd0dCA9PSBOVUxMKSB7Cj4gICAgICAg ICAgICAgICAgIHJldHVybiBOVUxMOwo+IC0tCj4gMi4yNS4xCj4KPiBfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK PiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8190C388F7 for ; Tue, 10 Nov 2020 22:05:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E3E920809 for ; Tue, 10 Nov 2020 22:05:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XjyOicW3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E3E920809 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CC5A489CD5; Tue, 10 Nov 2020 22:05:22 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 761BD89CBE; Tue, 10 Nov 2020 22:05:21 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id h2so4733042wmm.0; Tue, 10 Nov 2020 14:05:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=qZToJzWvZIM70EuRiQ7NoVEKN6DZ5AQGlu/l0sYJbdo=; b=XjyOicW3O9YNxvhwetYYen8NIUXx6DtxhfHeM3eeS7dRqHQTVCI2YXrvlAXna8ubw4 91hNbvU5rvEipK0xYxRb+aAFeCVhGN3sXSmKvT9uMnvyRjKZK0MVQZsLsUW0y1NuThB+ qpIQUWf4Q0V6cxCuoEiAk5gvoYEqve6tboDkF4bzKsMEEGMaDqknFVAuHon1tPSxft88 V067xL1LNtenmB1IGjhefnjnAd+OSJwQqSxSxYntaqlXt+tfZN5Xbu9/CPyqNV+M53Nd jgI1xhFvjcpsQuqb3xpH/SxHFKAFKgfzkzozf2vYODBsdHbjTBxXZ59zgeTdlvW9/9y6 K9+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qZToJzWvZIM70EuRiQ7NoVEKN6DZ5AQGlu/l0sYJbdo=; b=bASratxfo+poyQnCjc7JAZFNye4YDLYwUtEDblfaQlMhIIl3iuWpqQajk219qJE+Gj cdbBnsU+A4ruRScrBRYhR6EZry8kPqBKoWemrjXwDnATTzQ8HSSX/HculjxFSsbah3HD 8pJ/c81l4jcPko8SznBmy9dPZ3N3sDjcdFwevM3QBDTaZtGLVq0mg6ijtyCbxDGI8pHB ftIok2JqVPXU6bS8VwZJwdTxPTVHzlIDqYX1X2jIvVFbdckzUzs3DNZffR0e74Jbpo20 K9jVYZzHCerCw9pK7N8DeY3Lkwkjl+mvtcw5Yp2oSd19ws4CPwTMYLnxDZlvQDyrVXoK dVEA== X-Gm-Message-State: AOAM530gE+h1RTjrD/Z6d/8JlVCQWSNMx99rxTjqsZCYIfNstnVK6gf0 gBoR0iAijcdvkpCmqpJY4xXT4PqvEDh3b5iNoBs= X-Google-Smtp-Source: ABdhPJwWqoDTPUmRVpXmlstCWEAP5RO5KfmAgKzuWQagXCBAiZ6FokJKfpjc7Kx5J2AQT9MwV7S2Guk+ZWnb/gt8JoM= X-Received: by 2002:a7b:c157:: with SMTP id z23mr246689wmi.70.1605045920104; Tue, 10 Nov 2020 14:05:20 -0800 (PST) MIME-Version: 1.0 References: <20201109211855.3340030-1-lee.jones@linaro.org> <20201109211855.3340030-2-lee.jones@linaro.org> In-Reply-To: <20201109211855.3340030-2-lee.jones@linaro.org> From: Alex Deucher Date: Tue, 10 Nov 2020 17:05:07 -0500 Message-ID: Subject: Re: [PATCH 01/20] drm/radeon/radeon_ttm: Place declaration of 'rdev' in same clause as its use To: Lee Jones X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , Jerome Glisse , amd-gfx list , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" T24gTW9uLCBOb3YgOSwgMjAyMCBhdCA0OjE5IFBNIExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFy by5vcmc+IHdyb3RlOgo+Cj4gRml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2VybmVsIGJ1aWxkIHdh cm5pbmcocyk6Cj4KPiAgZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fdHRtLmM6IEluIGZ1 bmN0aW9uIOKAmHJhZGVvbl90dG1fdHRfY3JlYXRl4oCZOgo+ICBkcml2ZXJzL2dwdS9kcm0vcmFk ZW9uL3JhZGVvbl90dG0uYzo2MTE6MjQ6IHdhcm5pbmc6IHZhcmlhYmxlIOKAmHJkZXbigJkgc2V0 IGJ1dCBub3QgdXNlZCBbLVd1bnVzZWQtYnV0LXNldC12YXJpYWJsZV0KPgo+IENjOiBBbGV4IERl dWNoZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+Cj4gQ2M6ICJDaHJpc3RpYW4gS8O2bmln IiA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgo+IENjOiBEYXZpZCBBaXJsaWUgPGFpcmxpZWRA bGludXguaWU+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4KPiBDYzogSmVy b21lIEdsaXNzZSA8Z2xpc3NlQGZyZWVkZXNrdG9wLm9yZz4KPiBDYzogYW1kLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IFNp Z25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+CgpBcHBsaWVkLiAg VGhhbmtzIQoKQWxleAoKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX3R0 bS5jIHwgOCArKysrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRl bGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9u X3R0bS5jIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fdHRtLmMKPiBpbmRleCA5NTAz OGFjMzM4MmUyLi5hOGM5MTU5MjAwNzBmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9y YWRlb24vcmFkZW9uX3R0bS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25f dHRtLmMKPiBAQCAtNjA4LDIxICs2MDgsMjEgQEAgc3RhdGljIHZvaWQgcmFkZW9uX3R0bV9iYWNr ZW5kX2Rlc3Ryb3koc3RydWN0IHR0bV9ib19kZXZpY2UgKmJkZXYsIHN0cnVjdCB0dG1fdHQKPiAg c3RhdGljIHN0cnVjdCB0dG1fdHQgKnJhZGVvbl90dG1fdHRfY3JlYXRlKHN0cnVjdCB0dG1fYnVm ZmVyX29iamVjdCAqYm8sCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHVpbnQzMl90IHBhZ2VfZmxhZ3MpCj4gIHsKPiAtICAgICAgIHN0cnVjdCByYWRlb25fZGV2 aWNlICpyZGV2Owo+ICAgICAgICAgc3RydWN0IHJhZGVvbl90dG1fdHQgKmd0dDsKPiAgICAgICAg IGVudW0gdHRtX2NhY2hpbmcgY2FjaGluZzsKPiAgICAgICAgIHN0cnVjdCByYWRlb25fYm8gKnJi bzsKPiAtCj4gLSAgICAgICByYm8gPSBjb250YWluZXJfb2YoYm8sIHN0cnVjdCByYWRlb25fYm8s IHRibyk7Cj4gKyNpZiBJU19FTkFCTEVEKENPTkZJR19BR1ApCj4gKyAgICAgICBzdHJ1Y3QgcmFk ZW9uX2RldmljZSAqcmRldjsKPgo+ICAgICAgICAgcmRldiA9IHJhZGVvbl9nZXRfcmRldihiby0+ YmRldik7Cj4gLSNpZiBJU19FTkFCTEVEKENPTkZJR19BR1ApCj4gICAgICAgICBpZiAocmRldi0+ ZmxhZ3MgJiBSQURFT05fSVNfQUdQKSB7Cj4gICAgICAgICAgICAgICAgIHJldHVybiB0dG1fYWdw X3R0X2NyZWF0ZShibywgcmRldi0+ZGRldi0+YWdwLT5icmlkZ2UsCj4gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBwYWdlX2ZsYWdzKTsKPiAgICAgICAgIH0KPiAgI2Vu ZGlmCj4KPiArICAgICAgIHJibyA9IGNvbnRhaW5lcl9vZihibywgc3RydWN0IHJhZGVvbl9ibywg dGJvKTsKPiArCj4gICAgICAgICBndHQgPSBremFsbG9jKHNpemVvZihzdHJ1Y3QgcmFkZW9uX3R0 bV90dCksIEdGUF9LRVJORUwpOwo+ICAgICAgICAgaWYgKGd0dCA9PSBOVUxMKSB7Cj4gICAgICAg ICAgICAgICAgIHJldHVybiBOVUxMOwo+IC0tCj4gMi4yNS4xCj4KPiBfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK PiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9hbWQtZ2Z4Cg==