From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D67DCC433DB for ; Tue, 23 Feb 2021 17:49:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A165964E83 for ; Tue, 23 Feb 2021 17:49:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233786AbhBWRtC (ORCPT ); Tue, 23 Feb 2021 12:49:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232340AbhBWRsz (ORCPT ); Tue, 23 Feb 2021 12:48:55 -0500 Received: from mail-oo1-xc30.google.com (mail-oo1-xc30.google.com [IPv6:2607:f8b0:4864:20::c30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5343FC061574 for ; Tue, 23 Feb 2021 09:48:15 -0800 (PST) Received: by mail-oo1-xc30.google.com with SMTP id x23so4063487oop.1 for ; Tue, 23 Feb 2021 09:48:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ffSuOizC5vkUXK1gRj/KWG3leLFcWqMQLhXqk6jtjF8=; b=vbgy9CARhYqdjN8Ho0PbyEzF2w+6y+n6HQqUZYHQI722nTtteSgOdfhyF4xLx6RjQf ZHF4NoXNSe/9YN19Tv1e5e3DFmQ9WRH8KfVHVdesDO6q1vl/dd7TDMGfp6+n2AR74lOL 5Y0rSya1bpC7gEAMn42hTASouVT2h2Vx+nOdfRKSV7BBhkwCU+apO1umKsk1HTqQScTQ 0NgeXSzLPhe7htdcc+NOI1ffXxgekrCB5+jpr691zE916wqJfptwgHrgViVOy26aUw/B urPcPfsnnoWL/eydzwiUAG+iubpxx/UquDpjx+pzRzRCXbk4lEVZMQ+4sDgiw6Nz66qR FsFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ffSuOizC5vkUXK1gRj/KWG3leLFcWqMQLhXqk6jtjF8=; b=rJHuQdQf4b6ClW2uO1RI5xvvwMn+b5e309pO0xouOEOAITUqnKTvFEW3oF9lPxbk8g cFq0WZSiYMPQCeKwAlCYCADQ+qkF/e6VgMEuq99PuxcmgqgKbCoIL2SJjFIy05pkdAK+ HwL+hVYDGtuNgSrd1wlFMi+5v7c+wwtA1ZZlWZm0a1efzS/lyxcJkFvQ7jfO7XP+2VBC QXz26AT/qCVyWQBxuq+KUDSzn1JFKx6sguGTnq81CsrrXBIHv0kLpN3TBQDWECLAp/HC SPFm74fkbUFYc3YLnRuzw7frxKqBZR97xg6JMxusF9WrJngb4rGUhaehMnyu/4rD4QdY TlCw== X-Gm-Message-State: AOAM531CJdlu7ZVf9d9tzMhLnqmwVZl+0uhY3AqyQCqaZIlBkexNf/uX 9iIasbGEmMUEDvRpMRDFAuT1MCCy+K4IYnTloxA= X-Google-Smtp-Source: ABdhPJzxvdElhLv4Olbxje+vfunp4TxzAJH8llMrhEMdjEvnxVubx328z9Es28kfa/xGAYsyYOsVKAW93HWSYchf8zc= X-Received: by 2002:a4a:4581:: with SMTP id y123mr20841890ooa.61.1614102494816; Tue, 23 Feb 2021 09:48:14 -0800 (PST) MIME-Version: 1.0 References: <1614051813-51451-1-git-send-email-jiapeng.chong@linux.alibaba.com> In-Reply-To: <1614051813-51451-1-git-send-email-jiapeng.chong@linux.alibaba.com> From: Alex Deucher Date: Tue, 23 Feb 2021 12:48:03 -0500 Message-ID: Subject: Re: [PATCH] drm/amdgpu: Remove unnecessary conversion to bool To: Jiapeng Chong Cc: "Deucher, Alexander" , Dave Airlie , LKML , Maling list - DRI developers , amd-gfx list , Christian Koenig Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 22, 2021 at 10:44 PM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/amdgpu/athub_v2_1.c:79:40-45: WARNING: conversion > to bool not needed here. > > ./drivers/gpu/drm/amd/amdgpu/athub_v2_1.c:81:40-45: WARNING: conversion > to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/athub_v2_1.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c b/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c > index 7b1b183..2ac4988 100644 > --- a/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c > +++ b/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c > @@ -74,10 +74,8 @@ int athub_v2_1_set_clockgating(struct amdgpu_device *adev, > case CHIP_SIENNA_CICHLID: > case CHIP_NAVY_FLOUNDER: > case CHIP_DIMGREY_CAVEFISH: > - athub_v2_1_update_medium_grain_clock_gating(adev, > - state == AMD_CG_STATE_GATE ? true : false); > - athub_v2_1_update_medium_grain_light_sleep(adev, > - state == AMD_CG_STATE_GATE ? true : false); > + athub_v2_1_update_medium_grain_clock_gating(adev, state == AMD_CG_STATE_GATE); > + athub_v2_1_update_medium_grain_light_sleep(adev, state == AMD_CG_STATE_GATE); > break; > default: > break; > -- > 1.8.3.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D837C433E6 for ; Tue, 23 Feb 2021 17:48:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF25A6146D for ; Tue, 23 Feb 2021 17:48:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF25A6146D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 53C0D6E84E; Tue, 23 Feb 2021 17:48:16 +0000 (UTC) Received: from mail-oo1-xc2e.google.com (mail-oo1-xc2e.google.com [IPv6:2607:f8b0:4864:20::c2e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7625D6E84B; Tue, 23 Feb 2021 17:48:15 +0000 (UTC) Received: by mail-oo1-xc2e.google.com with SMTP id g46so4055360ooi.9; Tue, 23 Feb 2021 09:48:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ffSuOizC5vkUXK1gRj/KWG3leLFcWqMQLhXqk6jtjF8=; b=vbgy9CARhYqdjN8Ho0PbyEzF2w+6y+n6HQqUZYHQI722nTtteSgOdfhyF4xLx6RjQf ZHF4NoXNSe/9YN19Tv1e5e3DFmQ9WRH8KfVHVdesDO6q1vl/dd7TDMGfp6+n2AR74lOL 5Y0rSya1bpC7gEAMn42hTASouVT2h2Vx+nOdfRKSV7BBhkwCU+apO1umKsk1HTqQScTQ 0NgeXSzLPhe7htdcc+NOI1ffXxgekrCB5+jpr691zE916wqJfptwgHrgViVOy26aUw/B urPcPfsnnoWL/eydzwiUAG+iubpxx/UquDpjx+pzRzRCXbk4lEVZMQ+4sDgiw6Nz66qR FsFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ffSuOizC5vkUXK1gRj/KWG3leLFcWqMQLhXqk6jtjF8=; b=IP3FPKF4IMWknvSzcCbAtK/QB3tm66Uv/u4jSN3mWo7havcNPX/jWDyKVksHpSlTY/ To+cHhiU68c9KinMev+C/nzqwPF+3EGNkfljjlyngy0z23p9zo+l/UtPg9N+QBuhsDG+ v5bapF+xKLlHwrbNo7ar9GRdYWH9KPDNDENv99ZFlyVUwbLrs3ia8SlOMEbQu/+P9rOj jNtWtQ6tGRDvAYYXAKmRsi5pRcefRux7GjaEyUIAQGx1XHvgIBOnOlF7EDhC8CqxPkOv Df8xw127Rt8da58K1WLA0vp3fTWyQaTUg5FP3GHqA2cMMKYLolIjXqGda51r58r43olQ hi6A== X-Gm-Message-State: AOAM532mKWs+gqNrdyOHoXkWA2/kAI6w/QLg93qfbzSe7H8aS+CPZ1VR +wrl/HQGYQMSVfkJ8Afx6EtJxk+vK2OBQ0j/ADA= X-Google-Smtp-Source: ABdhPJzxvdElhLv4Olbxje+vfunp4TxzAJH8llMrhEMdjEvnxVubx328z9Es28kfa/xGAYsyYOsVKAW93HWSYchf8zc= X-Received: by 2002:a4a:4581:: with SMTP id y123mr20841890ooa.61.1614102494816; Tue, 23 Feb 2021 09:48:14 -0800 (PST) MIME-Version: 1.0 References: <1614051813-51451-1-git-send-email-jiapeng.chong@linux.alibaba.com> In-Reply-To: <1614051813-51451-1-git-send-email-jiapeng.chong@linux.alibaba.com> From: Alex Deucher Date: Tue, 23 Feb 2021 12:48:03 -0500 Message-ID: Subject: Re: [PATCH] drm/amdgpu: Remove unnecessary conversion to bool To: Jiapeng Chong X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Airlie , LKML , amd-gfx list , Maling list - DRI developers , "Deucher, Alexander" , Christian Koenig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Feb 22, 2021 at 10:44 PM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/amdgpu/athub_v2_1.c:79:40-45: WARNING: conversion > to bool not needed here. > > ./drivers/gpu/drm/amd/amdgpu/athub_v2_1.c:81:40-45: WARNING: conversion > to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/athub_v2_1.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c b/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c > index 7b1b183..2ac4988 100644 > --- a/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c > +++ b/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c > @@ -74,10 +74,8 @@ int athub_v2_1_set_clockgating(struct amdgpu_device *adev, > case CHIP_SIENNA_CICHLID: > case CHIP_NAVY_FLOUNDER: > case CHIP_DIMGREY_CAVEFISH: > - athub_v2_1_update_medium_grain_clock_gating(adev, > - state == AMD_CG_STATE_GATE ? true : false); > - athub_v2_1_update_medium_grain_light_sleep(adev, > - state == AMD_CG_STATE_GATE ? true : false); > + athub_v2_1_update_medium_grain_clock_gating(adev, state == AMD_CG_STATE_GATE); > + athub_v2_1_update_medium_grain_light_sleep(adev, state == AMD_CG_STATE_GATE); > break; > default: > break; > -- > 1.8.3.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66D23C433E0 for ; Tue, 23 Feb 2021 17:48:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24D6F64E83 for ; Tue, 23 Feb 2021 17:48:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24D6F64E83 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BE0DD6E84B; Tue, 23 Feb 2021 17:48:15 +0000 (UTC) Received: from mail-oo1-xc2e.google.com (mail-oo1-xc2e.google.com [IPv6:2607:f8b0:4864:20::c2e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7625D6E84B; Tue, 23 Feb 2021 17:48:15 +0000 (UTC) Received: by mail-oo1-xc2e.google.com with SMTP id g46so4055360ooi.9; Tue, 23 Feb 2021 09:48:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ffSuOizC5vkUXK1gRj/KWG3leLFcWqMQLhXqk6jtjF8=; b=vbgy9CARhYqdjN8Ho0PbyEzF2w+6y+n6HQqUZYHQI722nTtteSgOdfhyF4xLx6RjQf ZHF4NoXNSe/9YN19Tv1e5e3DFmQ9WRH8KfVHVdesDO6q1vl/dd7TDMGfp6+n2AR74lOL 5Y0rSya1bpC7gEAMn42hTASouVT2h2Vx+nOdfRKSV7BBhkwCU+apO1umKsk1HTqQScTQ 0NgeXSzLPhe7htdcc+NOI1ffXxgekrCB5+jpr691zE916wqJfptwgHrgViVOy26aUw/B urPcPfsnnoWL/eydzwiUAG+iubpxx/UquDpjx+pzRzRCXbk4lEVZMQ+4sDgiw6Nz66qR FsFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ffSuOizC5vkUXK1gRj/KWG3leLFcWqMQLhXqk6jtjF8=; b=IP3FPKF4IMWknvSzcCbAtK/QB3tm66Uv/u4jSN3mWo7havcNPX/jWDyKVksHpSlTY/ To+cHhiU68c9KinMev+C/nzqwPF+3EGNkfljjlyngy0z23p9zo+l/UtPg9N+QBuhsDG+ v5bapF+xKLlHwrbNo7ar9GRdYWH9KPDNDENv99ZFlyVUwbLrs3ia8SlOMEbQu/+P9rOj jNtWtQ6tGRDvAYYXAKmRsi5pRcefRux7GjaEyUIAQGx1XHvgIBOnOlF7EDhC8CqxPkOv Df8xw127Rt8da58K1WLA0vp3fTWyQaTUg5FP3GHqA2cMMKYLolIjXqGda51r58r43olQ hi6A== X-Gm-Message-State: AOAM532mKWs+gqNrdyOHoXkWA2/kAI6w/QLg93qfbzSe7H8aS+CPZ1VR +wrl/HQGYQMSVfkJ8Afx6EtJxk+vK2OBQ0j/ADA= X-Google-Smtp-Source: ABdhPJzxvdElhLv4Olbxje+vfunp4TxzAJH8llMrhEMdjEvnxVubx328z9Es28kfa/xGAYsyYOsVKAW93HWSYchf8zc= X-Received: by 2002:a4a:4581:: with SMTP id y123mr20841890ooa.61.1614102494816; Tue, 23 Feb 2021 09:48:14 -0800 (PST) MIME-Version: 1.0 References: <1614051813-51451-1-git-send-email-jiapeng.chong@linux.alibaba.com> In-Reply-To: <1614051813-51451-1-git-send-email-jiapeng.chong@linux.alibaba.com> From: Alex Deucher Date: Tue, 23 Feb 2021 12:48:03 -0500 Message-ID: Subject: Re: [PATCH] drm/amdgpu: Remove unnecessary conversion to bool To: Jiapeng Chong X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Airlie , LKML , amd-gfx list , Maling list - DRI developers , "Deucher, Alexander" , Christian Koenig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Mon, Feb 22, 2021 at 10:44 PM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/amdgpu/athub_v2_1.c:79:40-45: WARNING: conversion > to bool not needed here. > > ./drivers/gpu/drm/amd/amdgpu/athub_v2_1.c:81:40-45: WARNING: conversion > to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/athub_v2_1.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c b/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c > index 7b1b183..2ac4988 100644 > --- a/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c > +++ b/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c > @@ -74,10 +74,8 @@ int athub_v2_1_set_clockgating(struct amdgpu_device *adev, > case CHIP_SIENNA_CICHLID: > case CHIP_NAVY_FLOUNDER: > case CHIP_DIMGREY_CAVEFISH: > - athub_v2_1_update_medium_grain_clock_gating(adev, > - state == AMD_CG_STATE_GATE ? true : false); > - athub_v2_1_update_medium_grain_light_sleep(adev, > - state == AMD_CG_STATE_GATE ? true : false); > + athub_v2_1_update_medium_grain_clock_gating(adev, state == AMD_CG_STATE_GATE); > + athub_v2_1_update_medium_grain_light_sleep(adev, state == AMD_CG_STATE_GATE); > break; > default: > break; > -- > 1.8.3.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx