From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH] drm/radeon: Fix num_banks calculation for SI Date: Tue, 22 Apr 2014 08:51:06 -0400 Message-ID: References: <1398153232-29410-1-git-send-email-michel@daenzer.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qg0-f53.google.com (mail-qg0-f53.google.com [209.85.192.53]) by gabe.freedesktop.org (Postfix) with ESMTP id 5EB856E523 for ; Tue, 22 Apr 2014 05:51:08 -0700 (PDT) Received: by mail-qg0-f53.google.com with SMTP id f51so5213177qge.40 for ; Tue, 22 Apr 2014 05:51:06 -0700 (PDT) In-Reply-To: <1398153232-29410-1-git-send-email-michel@daenzer.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?Q?Michel_D=C3=A4nzer?= Cc: Maling list - DRI developers List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBBcHIgMjIsIDIwMTQgYXQgMzo1MyBBTSwgTWljaGVsIETDpG56ZXIgPG1pY2hlbEBk YWVuemVyLm5ldD4gd3JvdGU6Cj4gRnJvbTogTWljaGVsIETDpG56ZXIgPG1pY2hlbC5kYWVuemVy QGFtZC5jb20+Cj4KPiBUaGUgd2F5IHRoZSB0aWxlIG1vZGUgYXJyYXkgaW5kZXggd2FzIGNhbGN1 bGF0ZWQgb25seSBtYWtlcyBzZW5zZSBmb3IKPiB0aGUgQ0lLIHNwZWNpZmljIG1hY3JvdGlsZSBt b2RlIGFycmF5LiBGb3IgU0ksIHdlIG5lZWQgdG8gdXNlIG9uZSBvZiB0aGUKPiB0aWxlIG1vZGUg YXJyYXkgaW5kaWNlcyByZXNlcnZlZCBmb3IgZGlzcGxheWFibGUgc3VyZmFjZXMuCj4KPiBUaGlz IGhhcHBlbmVkIHRvIHJlc3VsdCBpbiBjb3JyZWN0IGRpc3BsYXkgbW9zdCBpZiBub3QgYWxsIG9m IHRoZSB0aW1lCj4gYmVjYXVzZSBtb3N0IG9mIHRoZSBTSSB0aWxpbmcgbW9kZXMgdXNlIHRoZSBz YW1lIG51bWJlciBvZiBiYW5rcy4KPgo+IFNpZ25lZC1vZmYtYnk6IE1pY2hlbCBEw6RuemVyIDxt aWNoZWwuZGFlbnplckBhbWQuY29tPgoKVGhhbmtzIGZvciBkb2luZyB0aGlzLgoKUmV2aWV3ZWQt Ynk6ICBBbGV4IERldWNoZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+CgpDaHJpc3RpYW4s IGNhbiB5b3UgY2Mgc3RhYmxlIHdoZW4geW91IHBpY2sgdGhpcyB1cD8KCkFsZXgKCj4gLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vYXRvbWJpb3NfY3J0Yy5jIHwgNDYgKysrKysrKysrKysr KysrKysrKysrKystLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMzEgaW5zZXJ0aW9ucygr KSwgMTUgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JhZGVv bi9hdG9tYmlvc19jcnRjLmMgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL2F0b21iaW9zX2NydGMu Ywo+IGluZGV4IGZiMTg3YzcuLjJiODAzOWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L3JhZGVvbi9hdG9tYmlvc19jcnRjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL2F0 b21iaW9zX2NydGMuYwo+IEBAIC0xMTc3LDI3ICsxMTc3LDQzIEBAIHN0YXRpYyBpbnQgZGNlNF9j cnRjX2RvX3NldF9iYXNlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPgo+ICAgICAgICAgICAgICAg ICAvKiBTZXQgTlVNX0JBTktTLiAqLwo+ICAgICAgICAgICAgICAgICBpZiAocmRldi0+ZmFtaWx5 ID49IENISVBfVEFISVRJKSB7Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgdGls ZWIsIGluZGV4LCBudW1fYmFua3MsIHRpbGVfc3BsaXRfYnl0ZXM7Cj4gKyAgICAgICAgICAgICAg ICAgICAgICAgdW5zaWduZWQgaW5kZXgsIG51bV9iYW5rczsKPgo+IC0gICAgICAgICAgICAgICAg ICAgICAgIC8qIENhbGN1bGF0ZSB0aGUgbWFjcm90aWxlIG1vZGUgaW5kZXguICovCj4gLSAgICAg ICAgICAgICAgICAgICAgICAgdGlsZV9zcGxpdF9ieXRlcyA9IDY0IDw8IHRpbGVfc3BsaXQ7Cj4g LSAgICAgICAgICAgICAgICAgICAgICAgdGlsZWIgPSA4ICogOCAqIHRhcmdldF9mYi0+Yml0c19w ZXJfcGl4ZWwgLyA4Owo+IC0gICAgICAgICAgICAgICAgICAgICAgIHRpbGViID0gbWluKHRpbGVf c3BsaXRfYnl0ZXMsIHRpbGViKTsKPiArICAgICAgICAgICAgICAgICAgICAgICBpZiAocmRldi0+ ZmFtaWx5ID49IENISVBfQk9OQUlSRSkgewo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgdW5zaWduZWQgdGlsZWIsIHRpbGVfc3BsaXRfYnl0ZXM7Cj4KPiAtICAgICAgICAgICAgICAg ICAgICAgICBmb3IgKGluZGV4ID0gMDsgdGlsZWIgPiA2NDsgaW5kZXgrKykgewo+IC0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgdGlsZWIgPj49IDE7Cj4gLSAgICAgICAgICAgICAgICAg ICAgICAgfQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLyogQ2FsY3VsYXRlIHRo ZSBtYWNyb3RpbGUgbW9kZSBpbmRleC4gKi8KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHRpbGVfc3BsaXRfYnl0ZXMgPSA2NCA8PCB0aWxlX3NwbGl0Owo+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgdGlsZWIgPSA4ICogOCAqIHRhcmdldF9mYi0+Yml0c19wZXJfcGl4 ZWwgLyA4Owo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdGlsZWIgPSBtaW4odGls ZV9zcGxpdF9ieXRlcywgdGlsZWIpOwo+Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgaWYgKGlu ZGV4ID49IDE2KSB7Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBEUk1fRVJST1Io Ildyb25nIHNjcmVlbiBicHAgKCV1KSBvciB0aWxlIHNwbGl0ICgldSlcbiIsCj4gLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdGFyZ2V0X2ZiLT5iaXRzX3Blcl9waXhl bCwgdGlsZV9zcGxpdCk7Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4g LUVJTlZBTDsKPiAtICAgICAgICAgICAgICAgICAgICAgICB9Cj4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBmb3IgKGluZGV4ID0gMDsgdGlsZWIgPiA2NDsgaW5kZXgrKykKPiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdGlsZWIgPj49IDE7Cj4gKwo+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGluZGV4ID49IDE2KSB7Cj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIERSTV9FUlJPUigiV3Jvbmcgc2NyZWVu IGJwcCAoJXUpIG9yIHRpbGUgc3BsaXQgKCV1KVxuIiwKPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRhcmdldF9mYi0+Yml0c19wZXJfcGl4ZWwsIHRp bGVfc3BsaXQpOwo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1 cm4gLUVJTlZBTDsKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH0KPgo+IC0gICAg ICAgICAgICAgICAgICAgICAgIGlmIChyZGV2LT5mYW1pbHkgPj0gQ0hJUF9CT05BSVJFKQo+ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbnVtX2JhbmtzID0gKHJkZXYtPmNvbmZpZy5j aWsubWFjcm90aWxlX21vZGVfYXJyYXlbaW5kZXhdID4+IDYpICYgMHgzOwo+IC0gICAgICAgICAg ICAgICAgICAgICAgIGVsc2UKPiArICAgICAgICAgICAgICAgICAgICAgICB9IGVsc2Ugewo+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3dpdGNoICh0YXJnZXRfZmItPmJpdHNfcGVy X3BpeGVsKSB7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjYXNlIDg6Cj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluZGV4ID0gMTA7Cj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwo+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgY2FzZSAxNjoKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgaW5kZXggPSBTSV9USUxFX01PREVfQ09MT1JfMkRfU0NBTk9VVF8xNkJQUDsK PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBkZWZhdWx0Ogo+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgY2FzZSAzMjoKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgaW5kZXggPSBTSV9USUxFX01PREVfQ09MT1JfMkRfU0NBTk9VVF8zMkJQUDsKPiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB9Cj4gKwo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgbnVtX2JhbmtzID0gKHJkZXYtPmNvbmZpZy5zaS50aWxlX21vZGVfYXJyYXlbaW5kZXhdID4+ IDIwKSAmIDB4MzsKPiArICAgICAgICAgICAgICAgICAgICAgICB9Cj4gKwo+ICAgICAgICAgICAg ICAgICAgICAgICAgIGZiX2Zvcm1hdCB8PSBFVkVSR1JFRU5fR1JQSF9OVU1fQkFOS1MobnVtX2Jh bmtzKTsKPiAgICAgICAgICAgICAgICAgfSBlbHNlIHsKPiAgICAgICAgICAgICAgICAgICAgICAg ICAvKiBOSSBhbmQgb2xkZXIuICovCj4gLS0KPiAxLjkuMgo+Cj4gX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4g ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK