From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C217CC433F5 for ; Mon, 25 Apr 2022 21:55:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D7BA210E117; Mon, 25 Apr 2022 21:55:49 +0000 (UTC) Received: from mail-oo1-xc2e.google.com (mail-oo1-xc2e.google.com [IPv6:2607:f8b0:4864:20::c2e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3145010E117; Mon, 25 Apr 2022 21:55:49 +0000 (UTC) Received: by mail-oo1-xc2e.google.com with SMTP id m22-20020a056820051600b0033a41079257so3049063ooj.4; Mon, 25 Apr 2022 14:55:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=VRxcdf2w/jvgBn/u4RdkEXeiNvH19TSLvJDSRvR1heQ=; b=JmheJvyryMJtpqVWc5yk3qs+kDpkw5/AYBwMAAJ9S/yHT7qWf0WgTM5yH157BCuqqz ABnLL4htcJOjrRMHGRMc0eEg5K2G2FmWdA78ERk4N6OdcIVCDKjVMmbdbSviBlS856Wh 5BrKL7kdyoG2wunDb0si928fF0y/g784bnByLh1ogTWakYahSOIqlRa2nzX62hShABDS WMIasoWg1V+K+1wex8bvsNtfzwf0McLxCG8HFL6Zv8fgstAKPaJzHBGvZmqJrtcxi1Tx nX5msTlvEb6cEkHd+meuTJrm69i2LeU5v9S0wjVeJMlDfVsyKoSwzXy0yyI3onsZj/b3 T1Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=VRxcdf2w/jvgBn/u4RdkEXeiNvH19TSLvJDSRvR1heQ=; b=zaiozFPCv/Ua7uEMNz62+GiRd9kV5zOTjn/0kTVhk6t42vRJtMXOsjNqNyQERgpaDZ CSaq+twwEKXE7Z6zsFkF46mCW5cIn6p7ij3XYf0IwAnPydJgaugCZu1tXXUW9aqVvBnI f20EGbBEqxXchtMSYElzJ7JafkXyJnCm2f/jQbSW2Fo5kBluq77ZMRg65/aH2rNGbhoT aPdGeF/rb3Oa8Wl1drqy5QpVwTs4ocl4aYeYLRssN9rvMtALU+v0YM9J0/yOTxywmvZy qWlSSYHpXWOJHy3/a4N6qQVfoVFmOnZC9GDCaXhctT4CfOwD6rUgsCDM28Vm36B4zp3H Tyiw== X-Gm-Message-State: AOAM533jbpA8pX58T5R00jpWZ8thMTUAo+26Yf8myTmfbBPWmZP9meG2 CVA4eJHWvYizgUdsCqXX7PJ6uOgL2VwNJnzApBnrlKyM X-Google-Smtp-Source: ABdhPJypMLKCwtGwU1ckiXgvI+GUpxa1h4lksUtuDOxtEZKqiuuAe7eWGYfwxzWaugWHVmzsmFt4IKY8MNzzKv28hVU= X-Received: by 2002:a4a:5257:0:b0:33a:48e1:8e75 with SMTP id d84-20020a4a5257000000b0033a48e18e75mr7125313oob.68.1650923748478; Mon, 25 Apr 2022 14:55:48 -0700 (PDT) MIME-Version: 1.0 References: <20220424090640.1865-1-guozhengkui@vivo.com> In-Reply-To: From: Alex Deucher Date: Mon, 25 Apr 2022 17:55:35 -0400 Message-ID: Subject: Re: [PATCH] drm/amd/display: fix if == else warning To: "Liu, Zhan" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Liu, Charlene" , Guo Zhengkui , "Li, Sun peng \(Leo\)" , "zhengkui_guo@outlook.com" , "Pan, Xinhui" , "Siqueira, Rodrigo" , open list , "open list:AMD DISPLAY CORE" , David Airlie , "open list:DRM DRIVERS" , "Deucher, Alexander" , =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , "Lei, Jun" , "Koenig, Christian" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Applied. Thanks! Alex On Sun, Apr 24, 2022 at 4:15 PM Liu, Zhan wrote: > > [AMD Official Use Only - General] > > > -----Original Message----- > > From: Guo Zhengkui > > Sent: 2022/April/24, Sunday 5:06 AM > > To: Wentland, Harry ; Li, Sun peng (Leo) > > ; Siqueira, Rodrigo ; > > Deucher, Alexander ; Koenig, Christian > > ; Pan, Xinhui ; David Air= lie > > ; Daniel Vetter ; Liu, Charlene > > ; Lei, Jun ; Guo Zhengkui > > ; Liu, Zhan ; Jos=C3=A9 Exp=C3= =B3sito > > ; open list:AMD DISPLAY CORE > gfx@lists.freedesktop.org>; open list:DRM DRIVERS > devel@lists.freedesktop.org>; open list > > Cc: zhengkui_guo@outlook.com > > Subject: [PATCH] drm/amd/display: fix if =3D=3D else warning > > > > Fix the following coccicheck warning: > > > > drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c:98:8-10: > > WARNING: possible condition with no effect (if =3D=3D else) > > > > Signed-off-by: Guo Zhengkui > > Thanks a lot for fixing this warning. > > Reviewed-by: Zhan Liu > > > --- > > drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c > > b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c > > index fe22530242d2..05b3fba9ccce 100644 > > --- a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c > > +++ b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c > > @@ -95,8 +95,6 @@ static void gpu_addr_to_uma(struct dce_hwseq *hwseq, > > } else if (hwseq->fb_offset.quad_part <=3D addr->quad_part && > > addr->quad_part <=3D hwseq->uma_top.quad_part) { > > is_in_uma =3D true; > > - } else if (addr->quad_part =3D=3D 0) { > > - is_in_uma =3D false; > > } else { > > is_in_uma =3D false; > > } > > -- > > 2.20.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4A33C433F5 for ; Mon, 25 Apr 2022 21:55:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AD34A10E32A; Mon, 25 Apr 2022 21:55:50 +0000 (UTC) Received: from mail-oo1-xc2e.google.com (mail-oo1-xc2e.google.com [IPv6:2607:f8b0:4864:20::c2e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3145010E117; Mon, 25 Apr 2022 21:55:49 +0000 (UTC) Received: by mail-oo1-xc2e.google.com with SMTP id m22-20020a056820051600b0033a41079257so3049063ooj.4; Mon, 25 Apr 2022 14:55:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=VRxcdf2w/jvgBn/u4RdkEXeiNvH19TSLvJDSRvR1heQ=; b=JmheJvyryMJtpqVWc5yk3qs+kDpkw5/AYBwMAAJ9S/yHT7qWf0WgTM5yH157BCuqqz ABnLL4htcJOjrRMHGRMc0eEg5K2G2FmWdA78ERk4N6OdcIVCDKjVMmbdbSviBlS856Wh 5BrKL7kdyoG2wunDb0si928fF0y/g784bnByLh1ogTWakYahSOIqlRa2nzX62hShABDS WMIasoWg1V+K+1wex8bvsNtfzwf0McLxCG8HFL6Zv8fgstAKPaJzHBGvZmqJrtcxi1Tx nX5msTlvEb6cEkHd+meuTJrm69i2LeU5v9S0wjVeJMlDfVsyKoSwzXy0yyI3onsZj/b3 T1Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=VRxcdf2w/jvgBn/u4RdkEXeiNvH19TSLvJDSRvR1heQ=; b=zaiozFPCv/Ua7uEMNz62+GiRd9kV5zOTjn/0kTVhk6t42vRJtMXOsjNqNyQERgpaDZ CSaq+twwEKXE7Z6zsFkF46mCW5cIn6p7ij3XYf0IwAnPydJgaugCZu1tXXUW9aqVvBnI f20EGbBEqxXchtMSYElzJ7JafkXyJnCm2f/jQbSW2Fo5kBluq77ZMRg65/aH2rNGbhoT aPdGeF/rb3Oa8Wl1drqy5QpVwTs4ocl4aYeYLRssN9rvMtALU+v0YM9J0/yOTxywmvZy qWlSSYHpXWOJHy3/a4N6qQVfoVFmOnZC9GDCaXhctT4CfOwD6rUgsCDM28Vm36B4zp3H Tyiw== X-Gm-Message-State: AOAM533jbpA8pX58T5R00jpWZ8thMTUAo+26Yf8myTmfbBPWmZP9meG2 CVA4eJHWvYizgUdsCqXX7PJ6uOgL2VwNJnzApBnrlKyM X-Google-Smtp-Source: ABdhPJypMLKCwtGwU1ckiXgvI+GUpxa1h4lksUtuDOxtEZKqiuuAe7eWGYfwxzWaugWHVmzsmFt4IKY8MNzzKv28hVU= X-Received: by 2002:a4a:5257:0:b0:33a:48e1:8e75 with SMTP id d84-20020a4a5257000000b0033a48e18e75mr7125313oob.68.1650923748478; Mon, 25 Apr 2022 14:55:48 -0700 (PDT) MIME-Version: 1.0 References: <20220424090640.1865-1-guozhengkui@vivo.com> In-Reply-To: From: Alex Deucher Date: Mon, 25 Apr 2022 17:55:35 -0400 Message-ID: Subject: Re: [PATCH] drm/amd/display: fix if == else warning To: "Liu, Zhan" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Liu, Charlene" , Guo Zhengkui , "Li, Sun peng \(Leo\)" , "zhengkui_guo@outlook.com" , "Pan, Xinhui" , "Siqueira, Rodrigo" , open list , "open list:AMD DISPLAY CORE" , David Airlie , "open list:DRM DRIVERS" , Daniel Vetter , "Deucher, Alexander" , =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , "Lei, Jun" , "Wentland, Harry" , "Koenig, Christian" Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Applied. Thanks! Alex On Sun, Apr 24, 2022 at 4:15 PM Liu, Zhan wrote: > > [AMD Official Use Only - General] > > > -----Original Message----- > > From: Guo Zhengkui > > Sent: 2022/April/24, Sunday 5:06 AM > > To: Wentland, Harry ; Li, Sun peng (Leo) > > ; Siqueira, Rodrigo ; > > Deucher, Alexander ; Koenig, Christian > > ; Pan, Xinhui ; David Air= lie > > ; Daniel Vetter ; Liu, Charlene > > ; Lei, Jun ; Guo Zhengkui > > ; Liu, Zhan ; Jos=C3=A9 Exp=C3= =B3sito > > ; open list:AMD DISPLAY CORE > gfx@lists.freedesktop.org>; open list:DRM DRIVERS > devel@lists.freedesktop.org>; open list > > Cc: zhengkui_guo@outlook.com > > Subject: [PATCH] drm/amd/display: fix if =3D=3D else warning > > > > Fix the following coccicheck warning: > > > > drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c:98:8-10: > > WARNING: possible condition with no effect (if =3D=3D else) > > > > Signed-off-by: Guo Zhengkui > > Thanks a lot for fixing this warning. > > Reviewed-by: Zhan Liu > > > --- > > drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c > > b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c > > index fe22530242d2..05b3fba9ccce 100644 > > --- a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c > > +++ b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c > > @@ -95,8 +95,6 @@ static void gpu_addr_to_uma(struct dce_hwseq *hwseq, > > } else if (hwseq->fb_offset.quad_part <=3D addr->quad_part && > > addr->quad_part <=3D hwseq->uma_top.quad_part) { > > is_in_uma =3D true; > > - } else if (addr->quad_part =3D=3D 0) { > > - is_in_uma =3D false; > > } else { > > is_in_uma =3D false; > > } > > -- > > 2.20.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B247BC433F5 for ; Mon, 25 Apr 2022 22:24:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237110AbiDYW1G (ORCPT ); Mon, 25 Apr 2022 18:27:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343641AbiDYV6y (ORCPT ); Mon, 25 Apr 2022 17:58:54 -0400 Received: from mail-oo1-xc36.google.com (mail-oo1-xc36.google.com [IPv6:2607:f8b0:4864:20::c36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 276AB3298E for ; Mon, 25 Apr 2022 14:55:49 -0700 (PDT) Received: by mail-oo1-xc36.google.com with SMTP id g30-20020a4a251e000000b0033a39d8340aso3046944ooa.5 for ; Mon, 25 Apr 2022 14:55:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=VRxcdf2w/jvgBn/u4RdkEXeiNvH19TSLvJDSRvR1heQ=; b=JmheJvyryMJtpqVWc5yk3qs+kDpkw5/AYBwMAAJ9S/yHT7qWf0WgTM5yH157BCuqqz ABnLL4htcJOjrRMHGRMc0eEg5K2G2FmWdA78ERk4N6OdcIVCDKjVMmbdbSviBlS856Wh 5BrKL7kdyoG2wunDb0si928fF0y/g784bnByLh1ogTWakYahSOIqlRa2nzX62hShABDS WMIasoWg1V+K+1wex8bvsNtfzwf0McLxCG8HFL6Zv8fgstAKPaJzHBGvZmqJrtcxi1Tx nX5msTlvEb6cEkHd+meuTJrm69i2LeU5v9S0wjVeJMlDfVsyKoSwzXy0yyI3onsZj/b3 T1Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=VRxcdf2w/jvgBn/u4RdkEXeiNvH19TSLvJDSRvR1heQ=; b=cXicOT+104CfrpHKVPTM02rckpLB2wTJXXZNPfjR0iHpC4bSEoso1IYxeC5H+zloCs 67YFnJobvTjt8fHERckog45WI7QPg6GHSHQuEQesV8j2zqRtI/doa21AWz7oey9RJyFp WUjZ80vkO2dPkmoONwI7fHxlpEuvwd0XsyyyQdk9H90/v4RJzGppxyhLlE1yJYt+XfD3 qm87cCzBpO4df35/AfGfd7cw7j54PIAO7rK4+I/u5pKrZW/Xh78AXIWgm47qPRz13Raw ZLgqQwpQSrPdhgvLBXksYSJPW14O3P0V2zZNp+rphprv41y5tR4YhUqFTdYfKzGf1VPN nUGg== X-Gm-Message-State: AOAM533BdT1sn8ZPXw20B9snqcGZHQMQd7Evev8z/dAZV7ZVsUt7NVFW WN90jrGD1DcX2Cq4LHf3hiz3Een6Vv5txWv2FwA= X-Google-Smtp-Source: ABdhPJypMLKCwtGwU1ckiXgvI+GUpxa1h4lksUtuDOxtEZKqiuuAe7eWGYfwxzWaugWHVmzsmFt4IKY8MNzzKv28hVU= X-Received: by 2002:a4a:5257:0:b0:33a:48e1:8e75 with SMTP id d84-20020a4a5257000000b0033a48e18e75mr7125313oob.68.1650923748478; Mon, 25 Apr 2022 14:55:48 -0700 (PDT) MIME-Version: 1.0 References: <20220424090640.1865-1-guozhengkui@vivo.com> In-Reply-To: From: Alex Deucher Date: Mon, 25 Apr 2022 17:55:35 -0400 Message-ID: Subject: Re: [PATCH] drm/amd/display: fix if == else warning To: "Liu, Zhan" Cc: Guo Zhengkui , "Wentland, Harry" , "Li, Sun peng (Leo)" , "Siqueira, Rodrigo" , "Deucher, Alexander" , "Koenig, Christian" , "Pan, Xinhui" , David Airlie , Daniel Vetter , "Liu, Charlene" , "Lei, Jun" , =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , "open list:AMD DISPLAY CORE" , "open list:DRM DRIVERS" , open list , "zhengkui_guo@outlook.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied. Thanks! Alex On Sun, Apr 24, 2022 at 4:15 PM Liu, Zhan wrote: > > [AMD Official Use Only - General] > > > -----Original Message----- > > From: Guo Zhengkui > > Sent: 2022/April/24, Sunday 5:06 AM > > To: Wentland, Harry ; Li, Sun peng (Leo) > > ; Siqueira, Rodrigo ; > > Deucher, Alexander ; Koenig, Christian > > ; Pan, Xinhui ; David Air= lie > > ; Daniel Vetter ; Liu, Charlene > > ; Lei, Jun ; Guo Zhengkui > > ; Liu, Zhan ; Jos=C3=A9 Exp=C3= =B3sito > > ; open list:AMD DISPLAY CORE > gfx@lists.freedesktop.org>; open list:DRM DRIVERS > devel@lists.freedesktop.org>; open list > > Cc: zhengkui_guo@outlook.com > > Subject: [PATCH] drm/amd/display: fix if =3D=3D else warning > > > > Fix the following coccicheck warning: > > > > drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c:98:8-10: > > WARNING: possible condition with no effect (if =3D=3D else) > > > > Signed-off-by: Guo Zhengkui > > Thanks a lot for fixing this warning. > > Reviewed-by: Zhan Liu > > > --- > > drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c > > b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c > > index fe22530242d2..05b3fba9ccce 100644 > > --- a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c > > +++ b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c > > @@ -95,8 +95,6 @@ static void gpu_addr_to_uma(struct dce_hwseq *hwseq, > > } else if (hwseq->fb_offset.quad_part <=3D addr->quad_part && > > addr->quad_part <=3D hwseq->uma_top.quad_part) { > > is_in_uma =3D true; > > - } else if (addr->quad_part =3D=3D 0) { > > - is_in_uma =3D false; > > } else { > > is_in_uma =3D false; > > } > > -- > > 2.20.1 >