From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH 4/7] drm/amdgpu: initialize GDS/GWS/OA domains even when they are zero sized Date: Fri, 14 Sep 2018 16:14:45 -0400 Message-ID: References: <20180914191246.1609-1-christian.koenig@amd.com> <20180914191246.1609-4-christian.koenig@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180914191246.1609-4-christian.koenig-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: amd-gfx list T24gRnJpLCBTZXAgMTQsIDIwMTggYXQgMzoxMiBQTSBDaHJpc3RpYW4gS8O2bmlnCjxja29lbmln LmxlaWNodHp1bWVya2VuQGdtYWlsLmNvbT4gd3JvdGU6Cj4KPiBTdG9wcyBjcmFzaGluZyBvbiBT SS4KPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdA YW1kLmNvbT4KClByZXN1bWFibHkgdHRtIGFsbG93cyB0aGlzPwpBY2tlZC1ieTogQWxleCBEZXVj aGVyIDxhbGV4YW5kZXIuZGV1Y2hlckBhbWQuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5jIHwgNDggKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0t LS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAzMCBkZWxldGlvbnMo LSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRt LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRtLmMKPiBpbmRleCAzZTQ1 MDE1OWZlMWYuLjcxMGU3NzUxYzU2NyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfdHRtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h bWRncHVfdHRtLmMKPiBAQCAtMTg0MywzNCArMTg0MywyNSBAQCBpbnQgYW1kZ3B1X3R0bV9pbml0 KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQo+ICAgICAgICAgICAgICAgICAgKHVuc2lnbmVk KShndHRfc2l6ZSAvICgxMDI0ICogMTAyNCkpKTsKPgo+ICAgICAgICAgLyogSW5pdGlhbGl6ZSB2 YXJpb3VzIG9uLWNoaXAgbWVtb3J5IHBvb2xzICovCj4gLSAgICAgICAvKiBHRFMgTWVtb3J5ICov Cj4gLSAgICAgICBpZiAoYWRldi0+Z2RzLm1lbS50b3RhbF9zaXplKSB7Cj4gLSAgICAgICAgICAg ICAgIHIgPSB0dG1fYm9faW5pdF9tbSgmYWRldi0+bW1hbi5iZGV2LCBBTURHUFVfUExfR0RTLAo+ IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYWRldi0+Z2RzLm1lbS50b3RhbF9z aXplKTsKPiAtICAgICAgICAgICAgICAgaWYgKHIpIHsKPiAtICAgICAgICAgICAgICAgICAgICAg ICBEUk1fRVJST1IoIkZhaWxlZCBpbml0aWFsaXppbmcgR0RTIGhlYXAuXG4iKTsKPiAtICAgICAg ICAgICAgICAgICAgICAgICByZXR1cm4gcjsKPiAtICAgICAgICAgICAgICAgfQo+ICsgICAgICAg ciA9IHR0bV9ib19pbml0X21tKCZhZGV2LT5tbWFuLmJkZXYsIEFNREdQVV9QTF9HRFMsCj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgYWRldi0+Z2RzLm1lbS50b3RhbF9zaXplKTsKPiArICAg ICAgIGlmIChyKSB7Cj4gKyAgICAgICAgICAgICAgIERSTV9FUlJPUigiRmFpbGVkIGluaXRpYWxp emluZyBHRFMgaGVhcC5cbiIpOwo+ICsgICAgICAgICAgICAgICByZXR1cm4gcjsKPiAgICAgICAg IH0KPgo+IC0gICAgICAgLyogR1dTICovCj4gLSAgICAgICBpZiAoYWRldi0+Z2RzLmd3cy50b3Rh bF9zaXplKSB7Cj4gLSAgICAgICAgICAgICAgIHIgPSB0dG1fYm9faW5pdF9tbSgmYWRldi0+bW1h bi5iZGV2LCBBTURHUFVfUExfR1dTLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgYWRldi0+Z2RzLmd3cy50b3RhbF9zaXplKTsKPiAtICAgICAgICAgICAgICAgaWYgKHIpIHsK PiAtICAgICAgICAgICAgICAgICAgICAgICBEUk1fRVJST1IoIkZhaWxlZCBpbml0aWFsaXppbmcg Z3dzIGhlYXAuXG4iKTsKPiAtICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gcjsKPiAtICAg ICAgICAgICAgICAgfQo+ICsgICAgICAgciA9IHR0bV9ib19pbml0X21tKCZhZGV2LT5tbWFuLmJk ZXYsIEFNREdQVV9QTF9HV1MsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgYWRldi0+Z2Rz Lmd3cy50b3RhbF9zaXplKTsKPiArICAgICAgIGlmIChyKSB7Cj4gKyAgICAgICAgICAgICAgIERS TV9FUlJPUigiRmFpbGVkIGluaXRpYWxpemluZyBnd3MgaGVhcC5cbiIpOwo+ICsgICAgICAgICAg ICAgICByZXR1cm4gcjsKPiAgICAgICAgIH0KPgo+IC0gICAgICAgLyogT0EgKi8KPiAtICAgICAg IGlmIChhZGV2LT5nZHMub2EudG90YWxfc2l6ZSkgewo+IC0gICAgICAgICAgICAgICByID0gdHRt X2JvX2luaXRfbW0oJmFkZXYtPm1tYW4uYmRldiwgQU1ER1BVX1BMX09BLAo+IC0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgYWRldi0+Z2RzLm9hLnRvdGFsX3NpemUpOwo+IC0gICAg ICAgICAgICAgICBpZiAocikgewo+IC0gICAgICAgICAgICAgICAgICAgICAgIERSTV9FUlJPUigi RmFpbGVkIGluaXRpYWxpemluZyBvYSBoZWFwLlxuIik7Cj4gLSAgICAgICAgICAgICAgICAgICAg ICAgcmV0dXJuIHI7Cj4gLSAgICAgICAgICAgICAgIH0KPiArICAgICAgIHIgPSB0dG1fYm9faW5p dF9tbSgmYWRldi0+bW1hbi5iZGV2LCBBTURHUFVfUExfT0EsCj4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgYWRldi0+Z2RzLm9hLnRvdGFsX3NpemUpOwo+ICsgICAgICAgaWYgKHIpIHsKPiAr ICAgICAgICAgICAgICAgRFJNX0VSUk9SKCJGYWlsZWQgaW5pdGlhbGl6aW5nIG9hIGhlYXAuXG4i KTsKPiArICAgICAgICAgICAgICAgcmV0dXJuIHI7Cj4gICAgICAgICB9Cj4KPiAgICAgICAgIC8q IFJlZ2lzdGVyIGRlYnVnZnMgZW50cmllcyBmb3IgYW1kZ3B1X3R0bSAqLwo+IEBAIC0xOTA3LDEy ICsxODk4LDkgQEAgdm9pZCBhbWRncHVfdHRtX2Zpbmkoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFk ZXYpCj4KPiAgICAgICAgIHR0bV9ib19jbGVhbl9tbSgmYWRldi0+bW1hbi5iZGV2LCBUVE1fUExf VlJBTSk7Cj4gICAgICAgICB0dG1fYm9fY2xlYW5fbW0oJmFkZXYtPm1tYW4uYmRldiwgVFRNX1BM X1RUKTsKPiAtICAgICAgIGlmIChhZGV2LT5nZHMubWVtLnRvdGFsX3NpemUpCj4gLSAgICAgICAg ICAgICAgIHR0bV9ib19jbGVhbl9tbSgmYWRldi0+bW1hbi5iZGV2LCBBTURHUFVfUExfR0RTKTsK PiAtICAgICAgIGlmIChhZGV2LT5nZHMuZ3dzLnRvdGFsX3NpemUpCj4gLSAgICAgICAgICAgICAg IHR0bV9ib19jbGVhbl9tbSgmYWRldi0+bW1hbi5iZGV2LCBBTURHUFVfUExfR1dTKTsKPiAtICAg ICAgIGlmIChhZGV2LT5nZHMub2EudG90YWxfc2l6ZSkKPiAtICAgICAgICAgICAgICAgdHRtX2Jv X2NsZWFuX21tKCZhZGV2LT5tbWFuLmJkZXYsIEFNREdQVV9QTF9PQSk7Cj4gKyAgICAgICB0dG1f Ym9fY2xlYW5fbW0oJmFkZXYtPm1tYW4uYmRldiwgQU1ER1BVX1BMX0dEUyk7Cj4gKyAgICAgICB0 dG1fYm9fY2xlYW5fbW0oJmFkZXYtPm1tYW4uYmRldiwgQU1ER1BVX1BMX0dXUyk7Cj4gKyAgICAg ICB0dG1fYm9fY2xlYW5fbW0oJmFkZXYtPm1tYW4uYmRldiwgQU1ER1BVX1BMX09BKTsKPiAgICAg ICAgIHR0bV9ib19kZXZpY2VfcmVsZWFzZSgmYWRldi0+bW1hbi5iZGV2KTsKPiAgICAgICAgIGFt ZGdwdV90dG1fZ2xvYmFsX2ZpbmkoYWRldik7Cj4gICAgICAgICBhZGV2LT5tbWFuLmluaXRpYWxp emVkID0gZmFsc2U7Cj4gLS0KPiAyLjE0LjEKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCj4gYW1kLWdmeCBtYWlsaW5nIGxpc3QKPiBhbWQtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vYW1kLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1n ZngK