From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965909AbeEITub (ORCPT ); Wed, 9 May 2018 15:50:31 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:46814 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965454AbeEITu2 (ORCPT ); Wed, 9 May 2018 15:50:28 -0400 X-Google-Smtp-Source: AB8JxZqSmGx064PwgBQvqiLwJ3hai3rxFBVmLrM1iQMFOSTwKiXTfEIGbj2JLfKm9VnpsWgFBPrCHn1OG84+33URk6A= MIME-Version: 1.0 In-Reply-To: References: <20180502144316.32056-1-colin.king@canonical.com> From: Alex Deucher Date: Wed, 9 May 2018 15:50:26 -0400 Message-ID: Subject: Re: [PATCH] drm/amd/display: clean up assignment of amdgpu_crtc To: Harry Wentland Cc: Colin King , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , David Zhou , David Airlie , amd-gfx list , Maling list - DRI developers , kernel-janitors@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 2, 2018 at 11:04 AM, Harry Wentland wrote: > On 2018-05-02 10:43 AM, Colin King wrote: >> From: Colin Ian King >> >> The declaration of pointer amdgpu_crtc has a redundant assignment to >> amdgpu_crtc. Clean this up by removing it. >> >> Detected by CoverityScan, CID#1460299 ("Evaluation order violation") >> >> Signed-off-by: Colin Ian King > > Looks like i goofed. Thanks for fixing this. > > Reviewed-by: Harry Wentland Applied. Thanks! Alex > > Harry > >> --- >> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c >> index 1dd1142246c2..2beb8821e19e 100644 >> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c >> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c >> @@ -3773,7 +3773,7 @@ static void remove_stream(struct amdgpu_device *adev, >> static int get_cursor_position(struct drm_plane *plane, struct drm_crtc *crtc, >> struct dc_cursor_position *position) >> { >> - struct amdgpu_crtc *amdgpu_crtc = amdgpu_crtc = to_amdgpu_crtc(crtc); >> + struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc); >> int x, y; >> int xorigin = 0, yorigin = 0; >> >> > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Date: Wed, 09 May 2018 19:50:26 +0000 Subject: Re: [PATCH] drm/amd/display: clean up assignment of amdgpu_crtc Message-Id: List-Id: References: <20180502144316.32056-1-colin.king@canonical.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Harry Wentland Cc: David Zhou , David Airlie , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML , amd-gfx list , Maling list - DRI developers , Alex Deucher , Colin King , =?UTF-8?Q?Christian_K=C3=B6nig?= On Wed, May 2, 2018 at 11:04 AM, Harry Wentland wrote: > On 2018-05-02 10:43 AM, Colin King wrote: >> From: Colin Ian King >> >> The declaration of pointer amdgpu_crtc has a redundant assignment to >> amdgpu_crtc. Clean this up by removing it. >> >> Detected by CoverityScan, CID#1460299 ("Evaluation order violation") >> >> Signed-off-by: Colin Ian King > > Looks like i goofed. Thanks for fixing this. > > Reviewed-by: Harry Wentland Applied. Thanks! Alex > > Harry > >> --- >> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c >> index 1dd1142246c2..2beb8821e19e 100644 >> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c >> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c >> @@ -3773,7 +3773,7 @@ static void remove_stream(struct amdgpu_device *adev, >> static int get_cursor_position(struct drm_plane *plane, struct drm_crtc *crtc, >> struct dc_cursor_position *position) >> { >> - struct amdgpu_crtc *amdgpu_crtc = amdgpu_crtc = to_amdgpu_crtc(crtc); >> + struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc); >> int x, y; >> int xorigin = 0, yorigin = 0; >> >> > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH] drm/amd/display: clean up assignment of amdgpu_crtc Date: Wed, 9 May 2018 15:50:26 -0400 Message-ID: References: <20180502144316.32056-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Harry Wentland Cc: David Zhou , David Airlie , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML , amd-gfx list , Maling list - DRI developers , Alex Deucher , Colin King , =?UTF-8?Q?Christian_K=C3=B6nig?= List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBNYXkgMiwgMjAxOCBhdCAxMTowNCBBTSwgSGFycnkgV2VudGxhbmQgPGhhcnJ5Lndl bnRsYW5kQGFtZC5jb20+IHdyb3RlOgo+IE9uIDIwMTgtMDUtMDIgMTA6NDMgQU0sIENvbGluIEtp bmcgd3JvdGU6Cj4+IEZyb206IENvbGluIElhbiBLaW5nIDxjb2xpbi5raW5nQGNhbm9uaWNhbC5j b20+Cj4+Cj4+IFRoZSBkZWNsYXJhdGlvbiBvZiBwb2ludGVyIGFtZGdwdV9jcnRjIGhhcyBhIHJl ZHVuZGFudCBhc3NpZ25tZW50IHRvCj4+IGFtZGdwdV9jcnRjLiBDbGVhbiB0aGlzIHVwIGJ5IHJl bW92aW5nIGl0Lgo+Pgo+PiBEZXRlY3RlZCBieSBDb3Zlcml0eVNjYW4sIENJRCMxNDYwMjk5ICgi RXZhbHVhdGlvbiBvcmRlciB2aW9sYXRpb24iKQo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBDb2xpbiBJ YW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPgo+Cj4gTG9va3MgbGlrZSBpIGdvb2Zl ZC4gVGhhbmtzIGZvciBmaXhpbmcgdGhpcy4KPgo+IFJldmlld2VkLWJ5OiBIYXJyeSBXZW50bGFu ZCA8aGFycnkud2VudGxhbmRAYW1kLmNvbT4KCgpBcHBsaWVkLiAgVGhhbmtzIQoKQWxleAoKPgo+ IEhhcnJ5Cj4KPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2Rt L2FtZGdwdV9kbS5jIHwgMiArLQo+PiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAx IGRlbGV0aW9uKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3Bs YXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2Ft ZGdwdV9kbS9hbWRncHVfZG0uYwo+PiBpbmRleCAxZGQxMTQyMjQ2YzIuLjJiZWI4ODIxZTE5ZSAx MDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9hbWRn cHVfZG0uYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2Ft ZGdwdV9kbS5jCj4+IEBAIC0zNzczLDcgKzM3NzMsNyBAQCBzdGF0aWMgdm9pZCByZW1vdmVfc3Ry ZWFtKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAo+PiAgc3RhdGljIGludCBnZXRfY3Vyc29y X3Bvc2l0aW9uKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLCBzdHJ1Y3QgZHJtX2NydGMgKmNydGMs Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGRjX2N1cnNvcl9wb3NpdGlv biAqcG9zaXRpb24pCj4+ICB7Cj4+IC0gICAgIHN0cnVjdCBhbWRncHVfY3J0YyAqYW1kZ3B1X2Ny dGMgPSBhbWRncHVfY3J0YyA9IHRvX2FtZGdwdV9jcnRjKGNydGMpOwo+PiArICAgICBzdHJ1Y3Qg YW1kZ3B1X2NydGMgKmFtZGdwdV9jcnRjID0gdG9fYW1kZ3B1X2NydGMoY3J0Yyk7Cj4+ICAgICAg IGludCB4LCB5Owo+PiAgICAgICBpbnQgeG9yaWdpbiA9IDAsIHlvcmlnaW4gPSAwOwo+Pgo+Pgo+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gYW1kLWdm eCBtYWlsaW5nIGxpc3QKPiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlz dAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK