From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4641CC56202 for ; Fri, 20 Nov 2020 22:43:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDBC82236F for ; Fri, 20 Nov 2020 22:43:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vLazJgTb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728923AbgKTWnj (ORCPT ); Fri, 20 Nov 2020 17:43:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728540AbgKTWni (ORCPT ); Fri, 20 Nov 2020 17:43:38 -0500 Received: from mail-yb1-xb41.google.com (mail-yb1-xb41.google.com [IPv6:2607:f8b0:4864:20::b41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FC0DC0613CF; Fri, 20 Nov 2020 14:43:38 -0800 (PST) Received: by mail-yb1-xb41.google.com with SMTP id o144so10018719ybg.7; Fri, 20 Nov 2020 14:43:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nu9Pci9XSkyd2dQdu9gYuDXeZiilDMpuYrk/Rd2PDx0=; b=vLazJgTbtfbaGpmbkmH9kjLDe/7YdZSR3IjSdTOC3a7M45J/PvYmtJ/ATBlPLtCXnS B9HxkvDhjflDpD9Je6i2J5DMk7XoIAuV+CgpkIE/GgKxvF081o4pPQZ7gGHBtBgIdozW a7gdWKUoPTaXlyivSbYHWO3GQFZuSqcPgv/qsmgMLwOAfQKjfjopSamtnb/TXGqobEhq cRMY/udYpwC+qW64oD+Kym32KEcD/EhXx/v2i960ZlYjlm+QAPJ1cpWunMuXQJ6H7fox m06GBTkn6shJ6Hk8qlWcQoLAGEg7fPky6YI3HaLP1o07U5OWbTUA5YtULqsV0Z71AA+S oppw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nu9Pci9XSkyd2dQdu9gYuDXeZiilDMpuYrk/Rd2PDx0=; b=Qiec+gpid1pLwrKegOezeR4YZyVVLmQ8TG858t4hEIfxSCptoNgEechQ3T5zGdvZPd 2SbPNPRUwV6JWbNlW7KDMlnuEbf8jYr6qrSqbaBNu+nB2fmOzokXKpiG9XV0KfHpzGXE D9cugnOWjpUdOESJ2Lt7dIo//pfe0IANOdNk1vfcIPGvYIQSzKfE4NVOC61ljr9blLtX x6aiZchD3u3AZZAuGS02I2sMwAresSTiOOtYPIjMtt52sCYG50iCg/t6i1E9YCCG1AGr LkE1fF0PIJcngxnw1Zl12S986Xy/i+AVVeUqg/XPlHv1oen1B3C0HWqNGalzs0waTMd4 vuZw== X-Gm-Message-State: AOAM531Iivp6tAKm11FOf+pwDsB0Rfsylou1Z8QUyhIr0IeQ65tMNYgx RTPErOQLuy48CwK9lY7Us1+FA+D6CiUSU/XH3Gk= X-Google-Smtp-Source: ABdhPJwtW2ZdxXKGprnW3kFvpKNwPgrQ+lYf1VfvdBm8kxziqaJ0nTDG9tH90wmo+KGpy9hxejETqZf0R7aZrzO+0cs= X-Received: by 2002:a05:6902:102a:: with SMTP id x10mr20678016ybt.130.1605912217819; Fri, 20 Nov 2020 14:43:37 -0800 (PST) MIME-Version: 1.0 References: <4737ca598d8548f06e5cae6333c0e100b74ffa65.1605896059.git.gustavoars@kernel.org> In-Reply-To: <4737ca598d8548f06e5cae6333c0e100b74ffa65.1605896059.git.gustavoars@kernel.org> From: Alex Deucher Date: Fri, 20 Nov 2020 17:43:26 -0500 Message-ID: Subject: Re: [PATCH 005/141] drm/radeon: Fix fall-through warnings for Clang To: "Gustavo A. R. Silva" Cc: Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , David Airlie , Daniel Vetter , linux-hardening@vger.kernel.org, Maling list - DRI developers , amd-gfx list , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 20, 2020 at 1:24 PM Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple fallthrough pseudo-keyword macros, > as replacement for /* fall through */ comments. > > Notice that Clang doesn't recognize /* fall through */ comments as > implicit fall-through markings. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/ci_dpm.c | 2 +- > drivers/gpu/drm/radeon/r300.c | 1 + > drivers/gpu/drm/radeon/si_dpm.c | 2 +- > 3 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/ci_dpm.c b/drivers/gpu/drm/radeon/ci_dpm.c > index 886e9959496f..3d0a2e81b2de 100644 > --- a/drivers/gpu/drm/radeon/ci_dpm.c > +++ b/drivers/gpu/drm/radeon/ci_dpm.c > @@ -4860,8 +4860,8 @@ static void ci_request_link_speed_change_before_state_change(struct radeon_devic > case RADEON_PCIE_GEN2: > if (radeon_acpi_pcie_performance_request(rdev, PCIE_PERF_REQ_PECI_GEN2, false) == 0) > break; > + fallthrough; > #endif > - /* fall through */ > default: > pi->force_pcie_gen = ci_get_current_pcie_speed(rdev); > break; > diff --git a/drivers/gpu/drm/radeon/r300.c b/drivers/gpu/drm/radeon/r300.c > index 73f67bf222e1..213dc49b6322 100644 > --- a/drivers/gpu/drm/radeon/r300.c > +++ b/drivers/gpu/drm/radeon/r300.c > @@ -1162,6 +1162,7 @@ static int r300_packet0_check(struct radeon_cs_parser *p, > /* valid register only on RV530 */ > if (p->rdev->family == CHIP_RV530) > break; > + fallthrough; > /* fallthrough do not move */ > default: > goto fail; > diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c > index d1c73e9db889..d19c08e0ad5a 100644 > --- a/drivers/gpu/drm/radeon/si_dpm.c > +++ b/drivers/gpu/drm/radeon/si_dpm.c > @@ -5748,8 +5748,8 @@ static void si_request_link_speed_change_before_state_change(struct radeon_devic > case RADEON_PCIE_GEN2: > if (radeon_acpi_pcie_performance_request(rdev, PCIE_PERF_REQ_PECI_GEN2, false) == 0) > break; > + fallthrough; > #endif > - /* fall through */ > default: > si_pi->force_pcie_gen = si_get_current_pcie_speed(rdev); > break; > -- > 2.27.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07556C2D0E4 for ; Fri, 20 Nov 2020 22:43:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A203E2240C for ; Fri, 20 Nov 2020 22:43:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vLazJgTb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A203E2240C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D815489FF9; Fri, 20 Nov 2020 22:43:39 +0000 (UTC) Received: from mail-yb1-xb42.google.com (mail-yb1-xb42.google.com [IPv6:2607:f8b0:4864:20::b42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C1FF89FF9; Fri, 20 Nov 2020 22:43:38 +0000 (UTC) Received: by mail-yb1-xb42.google.com with SMTP id t33so10038077ybd.0; Fri, 20 Nov 2020 14:43:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nu9Pci9XSkyd2dQdu9gYuDXeZiilDMpuYrk/Rd2PDx0=; b=vLazJgTbtfbaGpmbkmH9kjLDe/7YdZSR3IjSdTOC3a7M45J/PvYmtJ/ATBlPLtCXnS B9HxkvDhjflDpD9Je6i2J5DMk7XoIAuV+CgpkIE/GgKxvF081o4pPQZ7gGHBtBgIdozW a7gdWKUoPTaXlyivSbYHWO3GQFZuSqcPgv/qsmgMLwOAfQKjfjopSamtnb/TXGqobEhq cRMY/udYpwC+qW64oD+Kym32KEcD/EhXx/v2i960ZlYjlm+QAPJ1cpWunMuXQJ6H7fox m06GBTkn6shJ6Hk8qlWcQoLAGEg7fPky6YI3HaLP1o07U5OWbTUA5YtULqsV0Z71AA+S oppw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nu9Pci9XSkyd2dQdu9gYuDXeZiilDMpuYrk/Rd2PDx0=; b=Mrp8HYpxzaDFSjBwbGEZ8pXzFaTnWHRoHWJ9OTY1FMnMnU7nD0WfEd4dUuP6cBV3zJ pvRCCpij9S+iELh6Lk5JN6u+zlZQC7J4dTkv0WaagF2IUergfLd+SGTdXDrlMXuUvCaB SSg3y2uZbfUdr/A9Hxu+AsimCQ03tUlQ2XYyLwEH7qIZvO5/l/zYQPUa4fWtVf6Gbrou fkEu70sglV9xv/x8E0rFe/LNnkmWFIGcy28D9PoD0Tp5taE8i7krTsVM5NkXBrz56pZF L4S5MpK1pPg85KdiYN/I5ZqUKiK6filemnAdKjqq9+V+8VnyXH8og7VQJj7Ilg0MmoHV hWtw== X-Gm-Message-State: AOAM530I8B2eNM6bsAJlONbU+dYiEo+q+gkGYd5POzujFZM9j9vg8eG2 DnjDXLoZYSNp7hKN2SPgycl/VEGhvObIj8TnU4I= X-Google-Smtp-Source: ABdhPJwtW2ZdxXKGprnW3kFvpKNwPgrQ+lYf1VfvdBm8kxziqaJ0nTDG9tH90wmo+KGpy9hxejETqZf0R7aZrzO+0cs= X-Received: by 2002:a05:6902:102a:: with SMTP id x10mr20678016ybt.130.1605912217819; Fri, 20 Nov 2020 14:43:37 -0800 (PST) MIME-Version: 1.0 References: <4737ca598d8548f06e5cae6333c0e100b74ffa65.1605896059.git.gustavoars@kernel.org> In-Reply-To: <4737ca598d8548f06e5cae6333c0e100b74ffa65.1605896059.git.gustavoars@kernel.org> From: Alex Deucher Date: Fri, 20 Nov 2020 17:43:26 -0500 Message-ID: Subject: Re: [PATCH 005/141] drm/radeon: Fix fall-through warnings for Clang To: "Gustavo A. R. Silva" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amd-gfx list , David Airlie , LKML , Maling list - DRI developers , linux-hardening@vger.kernel.org, Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Nov 20, 2020 at 1:24 PM Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple fallthrough pseudo-keyword macros, > as replacement for /* fall through */ comments. > > Notice that Clang doesn't recognize /* fall through */ comments as > implicit fall-through markings. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/ci_dpm.c | 2 +- > drivers/gpu/drm/radeon/r300.c | 1 + > drivers/gpu/drm/radeon/si_dpm.c | 2 +- > 3 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/ci_dpm.c b/drivers/gpu/drm/radeon/ci_dpm.c > index 886e9959496f..3d0a2e81b2de 100644 > --- a/drivers/gpu/drm/radeon/ci_dpm.c > +++ b/drivers/gpu/drm/radeon/ci_dpm.c > @@ -4860,8 +4860,8 @@ static void ci_request_link_speed_change_before_state_change(struct radeon_devic > case RADEON_PCIE_GEN2: > if (radeon_acpi_pcie_performance_request(rdev, PCIE_PERF_REQ_PECI_GEN2, false) == 0) > break; > + fallthrough; > #endif > - /* fall through */ > default: > pi->force_pcie_gen = ci_get_current_pcie_speed(rdev); > break; > diff --git a/drivers/gpu/drm/radeon/r300.c b/drivers/gpu/drm/radeon/r300.c > index 73f67bf222e1..213dc49b6322 100644 > --- a/drivers/gpu/drm/radeon/r300.c > +++ b/drivers/gpu/drm/radeon/r300.c > @@ -1162,6 +1162,7 @@ static int r300_packet0_check(struct radeon_cs_parser *p, > /* valid register only on RV530 */ > if (p->rdev->family == CHIP_RV530) > break; > + fallthrough; > /* fallthrough do not move */ > default: > goto fail; > diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c > index d1c73e9db889..d19c08e0ad5a 100644 > --- a/drivers/gpu/drm/radeon/si_dpm.c > +++ b/drivers/gpu/drm/radeon/si_dpm.c > @@ -5748,8 +5748,8 @@ static void si_request_link_speed_change_before_state_change(struct radeon_devic > case RADEON_PCIE_GEN2: > if (radeon_acpi_pcie_performance_request(rdev, PCIE_PERF_REQ_PECI_GEN2, false) == 0) > break; > + fallthrough; > #endif > - /* fall through */ > default: > si_pi->force_pcie_gen = si_get_current_pcie_speed(rdev); > break; > -- > 2.27.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E376AC63798 for ; Fri, 20 Nov 2020 22:43:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9084A2236F for ; Fri, 20 Nov 2020 22:43:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vLazJgTb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9084A2236F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 05B786E937; Fri, 20 Nov 2020 22:43:40 +0000 (UTC) Received: from mail-yb1-xb42.google.com (mail-yb1-xb42.google.com [IPv6:2607:f8b0:4864:20::b42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C1FF89FF9; Fri, 20 Nov 2020 22:43:38 +0000 (UTC) Received: by mail-yb1-xb42.google.com with SMTP id t33so10038077ybd.0; Fri, 20 Nov 2020 14:43:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nu9Pci9XSkyd2dQdu9gYuDXeZiilDMpuYrk/Rd2PDx0=; b=vLazJgTbtfbaGpmbkmH9kjLDe/7YdZSR3IjSdTOC3a7M45J/PvYmtJ/ATBlPLtCXnS B9HxkvDhjflDpD9Je6i2J5DMk7XoIAuV+CgpkIE/GgKxvF081o4pPQZ7gGHBtBgIdozW a7gdWKUoPTaXlyivSbYHWO3GQFZuSqcPgv/qsmgMLwOAfQKjfjopSamtnb/TXGqobEhq cRMY/udYpwC+qW64oD+Kym32KEcD/EhXx/v2i960ZlYjlm+QAPJ1cpWunMuXQJ6H7fox m06GBTkn6shJ6Hk8qlWcQoLAGEg7fPky6YI3HaLP1o07U5OWbTUA5YtULqsV0Z71AA+S oppw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nu9Pci9XSkyd2dQdu9gYuDXeZiilDMpuYrk/Rd2PDx0=; b=Mrp8HYpxzaDFSjBwbGEZ8pXzFaTnWHRoHWJ9OTY1FMnMnU7nD0WfEd4dUuP6cBV3zJ pvRCCpij9S+iELh6Lk5JN6u+zlZQC7J4dTkv0WaagF2IUergfLd+SGTdXDrlMXuUvCaB SSg3y2uZbfUdr/A9Hxu+AsimCQ03tUlQ2XYyLwEH7qIZvO5/l/zYQPUa4fWtVf6Gbrou fkEu70sglV9xv/x8E0rFe/LNnkmWFIGcy28D9PoD0Tp5taE8i7krTsVM5NkXBrz56pZF L4S5MpK1pPg85KdiYN/I5ZqUKiK6filemnAdKjqq9+V+8VnyXH8og7VQJj7Ilg0MmoHV hWtw== X-Gm-Message-State: AOAM530I8B2eNM6bsAJlONbU+dYiEo+q+gkGYd5POzujFZM9j9vg8eG2 DnjDXLoZYSNp7hKN2SPgycl/VEGhvObIj8TnU4I= X-Google-Smtp-Source: ABdhPJwtW2ZdxXKGprnW3kFvpKNwPgrQ+lYf1VfvdBm8kxziqaJ0nTDG9tH90wmo+KGpy9hxejETqZf0R7aZrzO+0cs= X-Received: by 2002:a05:6902:102a:: with SMTP id x10mr20678016ybt.130.1605912217819; Fri, 20 Nov 2020 14:43:37 -0800 (PST) MIME-Version: 1.0 References: <4737ca598d8548f06e5cae6333c0e100b74ffa65.1605896059.git.gustavoars@kernel.org> In-Reply-To: <4737ca598d8548f06e5cae6333c0e100b74ffa65.1605896059.git.gustavoars@kernel.org> From: Alex Deucher Date: Fri, 20 Nov 2020 17:43:26 -0500 Message-ID: Subject: Re: [PATCH 005/141] drm/radeon: Fix fall-through warnings for Clang To: "Gustavo A. R. Silva" X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amd-gfx list , David Airlie , LKML , Maling list - DRI developers , linux-hardening@vger.kernel.org, Daniel Vetter , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Fri, Nov 20, 2020 at 1:24 PM Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple fallthrough pseudo-keyword macros, > as replacement for /* fall through */ comments. > > Notice that Clang doesn't recognize /* fall through */ comments as > implicit fall-through markings. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/ci_dpm.c | 2 +- > drivers/gpu/drm/radeon/r300.c | 1 + > drivers/gpu/drm/radeon/si_dpm.c | 2 +- > 3 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/ci_dpm.c b/drivers/gpu/drm/radeon/ci_dpm.c > index 886e9959496f..3d0a2e81b2de 100644 > --- a/drivers/gpu/drm/radeon/ci_dpm.c > +++ b/drivers/gpu/drm/radeon/ci_dpm.c > @@ -4860,8 +4860,8 @@ static void ci_request_link_speed_change_before_state_change(struct radeon_devic > case RADEON_PCIE_GEN2: > if (radeon_acpi_pcie_performance_request(rdev, PCIE_PERF_REQ_PECI_GEN2, false) == 0) > break; > + fallthrough; > #endif > - /* fall through */ > default: > pi->force_pcie_gen = ci_get_current_pcie_speed(rdev); > break; > diff --git a/drivers/gpu/drm/radeon/r300.c b/drivers/gpu/drm/radeon/r300.c > index 73f67bf222e1..213dc49b6322 100644 > --- a/drivers/gpu/drm/radeon/r300.c > +++ b/drivers/gpu/drm/radeon/r300.c > @@ -1162,6 +1162,7 @@ static int r300_packet0_check(struct radeon_cs_parser *p, > /* valid register only on RV530 */ > if (p->rdev->family == CHIP_RV530) > break; > + fallthrough; > /* fallthrough do not move */ > default: > goto fail; > diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c > index d1c73e9db889..d19c08e0ad5a 100644 > --- a/drivers/gpu/drm/radeon/si_dpm.c > +++ b/drivers/gpu/drm/radeon/si_dpm.c > @@ -5748,8 +5748,8 @@ static void si_request_link_speed_change_before_state_change(struct radeon_devic > case RADEON_PCIE_GEN2: > if (radeon_acpi_pcie_performance_request(rdev, PCIE_PERF_REQ_PECI_GEN2, false) == 0) > break; > + fallthrough; > #endif > - /* fall through */ > default: > si_pi->force_pcie_gen = si_get_current_pcie_speed(rdev); > break; > -- > 2.27.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx