From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8019C388F7 for ; Tue, 10 Nov 2020 23:57:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7262F20809 for ; Tue, 10 Nov 2020 23:57:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WtSIs1xD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731996AbgKJX50 (ORCPT ); Tue, 10 Nov 2020 18:57:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727275AbgKJX5S (ORCPT ); Tue, 10 Nov 2020 18:57:18 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68D7CC0613D1 for ; Tue, 10 Nov 2020 15:57:18 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id b8so441042wrn.0 for ; Tue, 10 Nov 2020 15:57:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=LE0afzOkIj/zw0NBe6e0ObJGwDPaqDvyeJKttoSBeoM=; b=WtSIs1xD+MaXeb4ffhufvVlCIwYGYGl3mt6GnySmJpVCXy5bBDmq+7ZXsWg3iG8Rp/ gdEDCYi+ni0pe3NodHC0IZ0pKlWwiuA/Htn995ZPkOosIEVz9Sj/Ui8N4XZ+9nLKw1/e OqSmVIUrZvbNsiCqB4t2kV/o183c6ZRCPVV8TQOYYKdeSk/oamorEmFGsNLnr5YVnAjG qWVpvtldJORI1nYMNUu6Ih15+efFTYnqy+YX8Ly0nC5Ahb0bvnEur4AJIFtlmdLaKJBW /7q4rf8oVpVbr0YdzAkbr6dnCpGlMUlY6NvCWZL+bFaEk2ah9aCqamm2zRH8+FPUyZmH S34g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=LE0afzOkIj/zw0NBe6e0ObJGwDPaqDvyeJKttoSBeoM=; b=Z7aMpUah+WHB3VU5eF5CcGER9RYYkBsYhSf7l+wwLBh6GKpWVEph9rzaKIVd9K2J/j pOyx3vPqOPxE0iBZ/KomhftUIjOwfhMxqdRyqwTPYe9BT+tgqJD8T7OsuxqcozJRo9sb /J2RDUQlUyUte+gfQ4fwwxM2YvTzAgLxcphOgsO/aWy2Kh4QeFRQx7PKxppImkM4AEo/ 7eHJg1SZWGyYvIf5dXd8C4aYE3xWvTj3to0GNVMtAI1kf1bdNjTjpaf7WZRHX/CcVKkS HAroe+FJxHla2ndEGE4TsDYZy/0sviQD1CBNn9AQ0LRg5Ld3N43e5J1B+ek1HuDU97ga fvtg== X-Gm-Message-State: AOAM533tPG+jhU8SRnlpimD8cxi4Kdy7DT8ysktU78LkoD4A7upWJYUO gN89TAKVbpA1sSYUM83lFFi88kmyVoSX+UURKm/AQG7w X-Google-Smtp-Source: ABdhPJx3T38wEbSDtMYgkoopvqAG8NVHXxX+0Z2QyanoquRAnGIg4EhxIojZyJp498+74haST3uNYCspixYe2oDURp8= X-Received: by 2002:adf:e551:: with SMTP id z17mr27350227wrm.374.1605052637210; Tue, 10 Nov 2020 15:57:17 -0800 (PST) MIME-Version: 1.0 References: <20201110193112.988999-1-lee.jones@linaro.org> <20201110193112.988999-19-lee.jones@linaro.org> In-Reply-To: <20201110193112.988999-19-lee.jones@linaro.org> From: Alex Deucher Date: Tue, 10 Nov 2020 18:57:05 -0500 Message-ID: Subject: Re: [PATCH 18/30] drm/radeon/evergreen_cs: Fix misnaming issues surrounding 'p' param To: Lee Jones Cc: David Airlie , LKML , amd-gfx list , Maling list - DRI developers , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2020 at 2:31 PM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/radeon/evergreen_cs.c:1026: warning: Function parameter = or member 'p' not described in 'evergreen_cs_packet_parse_vline' > drivers/gpu/drm/radeon/evergreen_cs.c:1026: warning: Excess function par= ameter 'parser' description in 'evergreen_cs_packet_parse_vline' > drivers/gpu/drm/radeon/evergreen_cs.c:1095: warning: Function parameter = or member 'p' not described in 'evergreen_cs_handle_reg' > drivers/gpu/drm/radeon/evergreen_cs.c:1095: warning: Excess function par= ameter 'parser' description in 'evergreen_cs_handle_reg' > drivers/gpu/drm/radeon/evergreen_cs.c:1757: warning: Function parameter = or member 'p' not described in 'evergreen_is_safe_reg' > drivers/gpu/drm/radeon/evergreen_cs.c:1757: warning: Excess function par= ameter 'parser' description in 'evergreen_is_safe_reg' > > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/evergreen_cs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/rade= on/evergreen_cs.c > index c410cad28f19f..53b75cf201958 100644 > --- a/drivers/gpu/drm/radeon/evergreen_cs.c > +++ b/drivers/gpu/drm/radeon/evergreen_cs.c > @@ -1015,7 +1015,7 @@ static int evergreen_cs_track_check(struct radeon_c= s_parser *p) > > /** > * evergreen_cs_packet_parse_vline() - parse userspace VLINE packet > - * @parser: parser structure holding parsing context. > + * @p: parser structure holding parsing context. > * > * This is an Evergreen(+)-specific function for parsing VLINE packets. > * Real work is done by r600_cs_common_vline_parse function. > @@ -1087,7 +1087,7 @@ static int evergreen_cs_parse_packet0(struct radeon= _cs_parser *p, > > /** > * evergreen_cs_handle_reg() - process registers that need special handl= ing. > - * @parser: parser structure holding parsing context > + * @p: parser structure holding parsing context > * @reg: register we are testing > * @idx: index into the cs buffer > */ > @@ -1747,7 +1747,7 @@ static int evergreen_cs_handle_reg(struct radeon_cs= _parser *p, u32 reg, u32 idx) > > /** > * evergreen_is_safe_reg() - check if register is authorized or not > - * @parser: parser structure holding parsing context > + * @p: parser structure holding parsing context > * @reg: register we are testing > * > * This function will test against reg_safe_bm and return true > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4382C55ABD for ; Tue, 10 Nov 2020 23:57:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4794A20809 for ; Tue, 10 Nov 2020 23:57:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WtSIs1xD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4794A20809 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4A5CA89D60; Tue, 10 Nov 2020 23:57:19 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 771A989D5E; Tue, 10 Nov 2020 23:57:18 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id j7so427817wrp.3; Tue, 10 Nov 2020 15:57:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=LE0afzOkIj/zw0NBe6e0ObJGwDPaqDvyeJKttoSBeoM=; b=WtSIs1xD+MaXeb4ffhufvVlCIwYGYGl3mt6GnySmJpVCXy5bBDmq+7ZXsWg3iG8Rp/ gdEDCYi+ni0pe3NodHC0IZ0pKlWwiuA/Htn995ZPkOosIEVz9Sj/Ui8N4XZ+9nLKw1/e OqSmVIUrZvbNsiCqB4t2kV/o183c6ZRCPVV8TQOYYKdeSk/oamorEmFGsNLnr5YVnAjG qWVpvtldJORI1nYMNUu6Ih15+efFTYnqy+YX8Ly0nC5Ahb0bvnEur4AJIFtlmdLaKJBW /7q4rf8oVpVbr0YdzAkbr6dnCpGlMUlY6NvCWZL+bFaEk2ah9aCqamm2zRH8+FPUyZmH S34g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=LE0afzOkIj/zw0NBe6e0ObJGwDPaqDvyeJKttoSBeoM=; b=c2q9RNEwoQNF+HQemXwovgeO95IZqFnF7LWyEvHg8l863iU9TlCzlj7SK07130o8HO X1BsXhbmIYSM/u6pXODnjZg+qVqqoXnavm92UzJiBaipV8GMv3GIn0H4Dkp9bqlflzHi LtWILJnsZbcAfHf1PqNNecthsS8a44j4tbvagSFJDFAqqjhLgjKksgstNLMmKJn8Jyyn 3/6ME6nZy1yFKkWN5KS3SyoAH6hMSyhp3USJRIyg+U16d3iIH5GhXsNk+juzCSnM/nwn twcj5aLJUW+bnvaqzavoMYA5UqaITUF7zTNXPAgvbajxxBsyQeAD/LT5n8vv7zYCXraL 74BQ== X-Gm-Message-State: AOAM533iWGcyS0zrZgJtnP1vElT4JCmQM9jMOnV/y7sAbrx1U1vNoIIN yJo4tNkAL3XwJcB8yNAGr3jFbYgB1fz5WBIhPXo= X-Google-Smtp-Source: ABdhPJx3T38wEbSDtMYgkoopvqAG8NVHXxX+0Z2QyanoquRAnGIg4EhxIojZyJp498+74haST3uNYCspixYe2oDURp8= X-Received: by 2002:adf:e551:: with SMTP id z17mr27350227wrm.374.1605052637210; Tue, 10 Nov 2020 15:57:17 -0800 (PST) MIME-Version: 1.0 References: <20201110193112.988999-1-lee.jones@linaro.org> <20201110193112.988999-19-lee.jones@linaro.org> In-Reply-To: <20201110193112.988999-19-lee.jones@linaro.org> From: Alex Deucher Date: Tue, 10 Nov 2020 18:57:05 -0500 Message-ID: Subject: Re: [PATCH 18/30] drm/radeon/evergreen_cs: Fix misnaming issues surrounding 'p' param To: Lee Jones X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , amd-gfx list , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCBOb3YgMTAsIDIwMjAgYXQgMjozMSBQTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5h cm8ub3JnPiB3cm90ZToKPgo+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3 YXJuaW5nKHMpOgo+Cj4gIGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vZXZlcmdyZWVuX2NzLmM6MTAy Njogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1lbWJlciAncCcgbm90IGRlc2NyaWJl ZCBpbiAnZXZlcmdyZWVuX2NzX3BhY2tldF9wYXJzZV92bGluZScKPiAgZHJpdmVycy9ncHUvZHJt L3JhZGVvbi9ldmVyZ3JlZW5fY3MuYzoxMDI2OiB3YXJuaW5nOiBFeGNlc3MgZnVuY3Rpb24gcGFy YW1ldGVyICdwYXJzZXInIGRlc2NyaXB0aW9uIGluICdldmVyZ3JlZW5fY3NfcGFja2V0X3BhcnNl X3ZsaW5lJwo+ICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL2V2ZXJncmVlbl9jcy5jOjEwOTU6IHdh cm5pbmc6IEZ1bmN0aW9uIHBhcmFtZXRlciBvciBtZW1iZXIgJ3AnIG5vdCBkZXNjcmliZWQgaW4g J2V2ZXJncmVlbl9jc19oYW5kbGVfcmVnJwo+ICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL2V2ZXJn cmVlbl9jcy5jOjEwOTU6IHdhcm5pbmc6IEV4Y2VzcyBmdW5jdGlvbiBwYXJhbWV0ZXIgJ3BhcnNl cicgZGVzY3JpcHRpb24gaW4gJ2V2ZXJncmVlbl9jc19oYW5kbGVfcmVnJwo+ICBkcml2ZXJzL2dw dS9kcm0vcmFkZW9uL2V2ZXJncmVlbl9jcy5jOjE3NTc6IHdhcm5pbmc6IEZ1bmN0aW9uIHBhcmFt ZXRlciBvciBtZW1iZXIgJ3AnIG5vdCBkZXNjcmliZWQgaW4gJ2V2ZXJncmVlbl9pc19zYWZlX3Jl ZycKPiAgZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9ldmVyZ3JlZW5fY3MuYzoxNzU3OiB3YXJuaW5n OiBFeGNlc3MgZnVuY3Rpb24gcGFyYW1ldGVyICdwYXJzZXInIGRlc2NyaXB0aW9uIGluICdldmVy Z3JlZW5faXNfc2FmZV9yZWcnCj4KPiBDYzogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1Y2hl ckBhbWQuY29tPgo+IENjOiAiQ2hyaXN0aWFuIEvDtm5pZyIgPGNocmlzdGlhbi5rb2VuaWdAYW1k LmNvbT4KPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgo+IENjOiBEYW5pZWwg VmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gQ2M6IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBTaWduZWQtb2ZmLWJ5 OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgoKQXBwbGllZC4gIFRoYW5rcyEKCkFs ZXgKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vZXZlcmdyZWVuX2NzLmMgfCA2ICsr Ky0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vZXZlcmdyZWVuX2NzLmMgYi9k cml2ZXJzL2dwdS9kcm0vcmFkZW9uL2V2ZXJncmVlbl9jcy5jCj4gaW5kZXggYzQxMGNhZDI4ZjE5 Zi4uNTNiNzVjZjIwMTk1OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL2V2 ZXJncmVlbl9jcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9ldmVyZ3JlZW5fY3Mu Ywo+IEBAIC0xMDE1LDcgKzEwMTUsNyBAQCBzdGF0aWMgaW50IGV2ZXJncmVlbl9jc190cmFja19j aGVjayhzdHJ1Y3QgcmFkZW9uX2NzX3BhcnNlciAqcCkKPgo+ICAvKioKPiAgICogZXZlcmdyZWVu X2NzX3BhY2tldF9wYXJzZV92bGluZSgpIC0gcGFyc2UgdXNlcnNwYWNlIFZMSU5FIHBhY2tldAo+ IC0gKiBAcGFyc2VyOiAgICAgICAgICAgIHBhcnNlciBzdHJ1Y3R1cmUgaG9sZGluZyBwYXJzaW5n IGNvbnRleHQuCj4gKyAqIEBwOiAgICAgICAgIHBhcnNlciBzdHJ1Y3R1cmUgaG9sZGluZyBwYXJz aW5nIGNvbnRleHQuCj4gICAqCj4gICAqIFRoaXMgaXMgYW4gRXZlcmdyZWVuKCspLXNwZWNpZmlj IGZ1bmN0aW9uIGZvciBwYXJzaW5nIFZMSU5FIHBhY2tldHMuCj4gICAqIFJlYWwgd29yayBpcyBk b25lIGJ5IHI2MDBfY3NfY29tbW9uX3ZsaW5lX3BhcnNlIGZ1bmN0aW9uLgo+IEBAIC0xMDg3LDcg KzEwODcsNyBAQCBzdGF0aWMgaW50IGV2ZXJncmVlbl9jc19wYXJzZV9wYWNrZXQwKHN0cnVjdCBy YWRlb25fY3NfcGFyc2VyICpwLAo+Cj4gIC8qKgo+ICAgKiBldmVyZ3JlZW5fY3NfaGFuZGxlX3Jl ZygpIC0gcHJvY2VzcyByZWdpc3RlcnMgdGhhdCBuZWVkIHNwZWNpYWwgaGFuZGxpbmcuCj4gLSAq IEBwYXJzZXI6IHBhcnNlciBzdHJ1Y3R1cmUgaG9sZGluZyBwYXJzaW5nIGNvbnRleHQKPiArICog QHA6IHBhcnNlciBzdHJ1Y3R1cmUgaG9sZGluZyBwYXJzaW5nIGNvbnRleHQKPiAgICogQHJlZzog cmVnaXN0ZXIgd2UgYXJlIHRlc3RpbmcKPiAgICogQGlkeDogaW5kZXggaW50byB0aGUgY3MgYnVm ZmVyCj4gICAqLwo+IEBAIC0xNzQ3LDcgKzE3NDcsNyBAQCBzdGF0aWMgaW50IGV2ZXJncmVlbl9j c19oYW5kbGVfcmVnKHN0cnVjdCByYWRlb25fY3NfcGFyc2VyICpwLCB1MzIgcmVnLCB1MzIgaWR4 KQo+Cj4gIC8qKgo+ICAgKiBldmVyZ3JlZW5faXNfc2FmZV9yZWcoKSAtIGNoZWNrIGlmIHJlZ2lz dGVyIGlzIGF1dGhvcml6ZWQgb3Igbm90Cj4gLSAqIEBwYXJzZXI6IHBhcnNlciBzdHJ1Y3R1cmUg aG9sZGluZyBwYXJzaW5nIGNvbnRleHQKPiArICogQHA6IHBhcnNlciBzdHJ1Y3R1cmUgaG9sZGlu ZyBwYXJzaW5nIGNvbnRleHQKPiAgICogQHJlZzogcmVnaXN0ZXIgd2UgYXJlIHRlc3RpbmcKPiAg ICoKPiAgICogVGhpcyBmdW5jdGlvbiB3aWxsIHRlc3QgYWdhaW5zdCByZWdfc2FmZV9ibSBhbmQg cmV0dXJuIHRydWUKPiAtLQo+IDIuMjUuMQo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CEDCC388F7 for ; Tue, 10 Nov 2020 23:57:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0330207FB for ; Tue, 10 Nov 2020 23:57:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WtSIs1xD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0330207FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3504E89D5E; Tue, 10 Nov 2020 23:57:19 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 771A989D5E; Tue, 10 Nov 2020 23:57:18 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id j7so427817wrp.3; Tue, 10 Nov 2020 15:57:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=LE0afzOkIj/zw0NBe6e0ObJGwDPaqDvyeJKttoSBeoM=; b=WtSIs1xD+MaXeb4ffhufvVlCIwYGYGl3mt6GnySmJpVCXy5bBDmq+7ZXsWg3iG8Rp/ gdEDCYi+ni0pe3NodHC0IZ0pKlWwiuA/Htn995ZPkOosIEVz9Sj/Ui8N4XZ+9nLKw1/e OqSmVIUrZvbNsiCqB4t2kV/o183c6ZRCPVV8TQOYYKdeSk/oamorEmFGsNLnr5YVnAjG qWVpvtldJORI1nYMNUu6Ih15+efFTYnqy+YX8Ly0nC5Ahb0bvnEur4AJIFtlmdLaKJBW /7q4rf8oVpVbr0YdzAkbr6dnCpGlMUlY6NvCWZL+bFaEk2ah9aCqamm2zRH8+FPUyZmH S34g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=LE0afzOkIj/zw0NBe6e0ObJGwDPaqDvyeJKttoSBeoM=; b=c2q9RNEwoQNF+HQemXwovgeO95IZqFnF7LWyEvHg8l863iU9TlCzlj7SK07130o8HO X1BsXhbmIYSM/u6pXODnjZg+qVqqoXnavm92UzJiBaipV8GMv3GIn0H4Dkp9bqlflzHi LtWILJnsZbcAfHf1PqNNecthsS8a44j4tbvagSFJDFAqqjhLgjKksgstNLMmKJn8Jyyn 3/6ME6nZy1yFKkWN5KS3SyoAH6hMSyhp3USJRIyg+U16d3iIH5GhXsNk+juzCSnM/nwn twcj5aLJUW+bnvaqzavoMYA5UqaITUF7zTNXPAgvbajxxBsyQeAD/LT5n8vv7zYCXraL 74BQ== X-Gm-Message-State: AOAM533iWGcyS0zrZgJtnP1vElT4JCmQM9jMOnV/y7sAbrx1U1vNoIIN yJo4tNkAL3XwJcB8yNAGr3jFbYgB1fz5WBIhPXo= X-Google-Smtp-Source: ABdhPJx3T38wEbSDtMYgkoopvqAG8NVHXxX+0Z2QyanoquRAnGIg4EhxIojZyJp498+74haST3uNYCspixYe2oDURp8= X-Received: by 2002:adf:e551:: with SMTP id z17mr27350227wrm.374.1605052637210; Tue, 10 Nov 2020 15:57:17 -0800 (PST) MIME-Version: 1.0 References: <20201110193112.988999-1-lee.jones@linaro.org> <20201110193112.988999-19-lee.jones@linaro.org> In-Reply-To: <20201110193112.988999-19-lee.jones@linaro.org> From: Alex Deucher Date: Tue, 10 Nov 2020 18:57:05 -0500 Message-ID: Subject: Re: [PATCH 18/30] drm/radeon/evergreen_cs: Fix misnaming issues surrounding 'p' param To: Lee Jones X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , amd-gfx list , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" T24gVHVlLCBOb3YgMTAsIDIwMjAgYXQgMjozMSBQTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5h cm8ub3JnPiB3cm90ZToKPgo+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3 YXJuaW5nKHMpOgo+Cj4gIGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vZXZlcmdyZWVuX2NzLmM6MTAy Njogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1lbWJlciAncCcgbm90IGRlc2NyaWJl ZCBpbiAnZXZlcmdyZWVuX2NzX3BhY2tldF9wYXJzZV92bGluZScKPiAgZHJpdmVycy9ncHUvZHJt L3JhZGVvbi9ldmVyZ3JlZW5fY3MuYzoxMDI2OiB3YXJuaW5nOiBFeGNlc3MgZnVuY3Rpb24gcGFy YW1ldGVyICdwYXJzZXInIGRlc2NyaXB0aW9uIGluICdldmVyZ3JlZW5fY3NfcGFja2V0X3BhcnNl X3ZsaW5lJwo+ICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL2V2ZXJncmVlbl9jcy5jOjEwOTU6IHdh cm5pbmc6IEZ1bmN0aW9uIHBhcmFtZXRlciBvciBtZW1iZXIgJ3AnIG5vdCBkZXNjcmliZWQgaW4g J2V2ZXJncmVlbl9jc19oYW5kbGVfcmVnJwo+ICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL2V2ZXJn cmVlbl9jcy5jOjEwOTU6IHdhcm5pbmc6IEV4Y2VzcyBmdW5jdGlvbiBwYXJhbWV0ZXIgJ3BhcnNl cicgZGVzY3JpcHRpb24gaW4gJ2V2ZXJncmVlbl9jc19oYW5kbGVfcmVnJwo+ICBkcml2ZXJzL2dw dS9kcm0vcmFkZW9uL2V2ZXJncmVlbl9jcy5jOjE3NTc6IHdhcm5pbmc6IEZ1bmN0aW9uIHBhcmFt ZXRlciBvciBtZW1iZXIgJ3AnIG5vdCBkZXNjcmliZWQgaW4gJ2V2ZXJncmVlbl9pc19zYWZlX3Jl ZycKPiAgZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9ldmVyZ3JlZW5fY3MuYzoxNzU3OiB3YXJuaW5n OiBFeGNlc3MgZnVuY3Rpb24gcGFyYW1ldGVyICdwYXJzZXInIGRlc2NyaXB0aW9uIGluICdldmVy Z3JlZW5faXNfc2FmZV9yZWcnCj4KPiBDYzogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1Y2hl ckBhbWQuY29tPgo+IENjOiAiQ2hyaXN0aWFuIEvDtm5pZyIgPGNocmlzdGlhbi5rb2VuaWdAYW1k LmNvbT4KPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgo+IENjOiBEYW5pZWwg VmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gQ2M6IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBTaWduZWQtb2ZmLWJ5 OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgoKQXBwbGllZC4gIFRoYW5rcyEKCkFs ZXgKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vZXZlcmdyZWVuX2NzLmMgfCA2ICsr Ky0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vZXZlcmdyZWVuX2NzLmMgYi9k cml2ZXJzL2dwdS9kcm0vcmFkZW9uL2V2ZXJncmVlbl9jcy5jCj4gaW5kZXggYzQxMGNhZDI4ZjE5 Zi4uNTNiNzVjZjIwMTk1OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL2V2 ZXJncmVlbl9jcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9ldmVyZ3JlZW5fY3Mu Ywo+IEBAIC0xMDE1LDcgKzEwMTUsNyBAQCBzdGF0aWMgaW50IGV2ZXJncmVlbl9jc190cmFja19j aGVjayhzdHJ1Y3QgcmFkZW9uX2NzX3BhcnNlciAqcCkKPgo+ICAvKioKPiAgICogZXZlcmdyZWVu X2NzX3BhY2tldF9wYXJzZV92bGluZSgpIC0gcGFyc2UgdXNlcnNwYWNlIFZMSU5FIHBhY2tldAo+ IC0gKiBAcGFyc2VyOiAgICAgICAgICAgIHBhcnNlciBzdHJ1Y3R1cmUgaG9sZGluZyBwYXJzaW5n IGNvbnRleHQuCj4gKyAqIEBwOiAgICAgICAgIHBhcnNlciBzdHJ1Y3R1cmUgaG9sZGluZyBwYXJz aW5nIGNvbnRleHQuCj4gICAqCj4gICAqIFRoaXMgaXMgYW4gRXZlcmdyZWVuKCspLXNwZWNpZmlj IGZ1bmN0aW9uIGZvciBwYXJzaW5nIFZMSU5FIHBhY2tldHMuCj4gICAqIFJlYWwgd29yayBpcyBk b25lIGJ5IHI2MDBfY3NfY29tbW9uX3ZsaW5lX3BhcnNlIGZ1bmN0aW9uLgo+IEBAIC0xMDg3LDcg KzEwODcsNyBAQCBzdGF0aWMgaW50IGV2ZXJncmVlbl9jc19wYXJzZV9wYWNrZXQwKHN0cnVjdCBy YWRlb25fY3NfcGFyc2VyICpwLAo+Cj4gIC8qKgo+ICAgKiBldmVyZ3JlZW5fY3NfaGFuZGxlX3Jl ZygpIC0gcHJvY2VzcyByZWdpc3RlcnMgdGhhdCBuZWVkIHNwZWNpYWwgaGFuZGxpbmcuCj4gLSAq IEBwYXJzZXI6IHBhcnNlciBzdHJ1Y3R1cmUgaG9sZGluZyBwYXJzaW5nIGNvbnRleHQKPiArICog QHA6IHBhcnNlciBzdHJ1Y3R1cmUgaG9sZGluZyBwYXJzaW5nIGNvbnRleHQKPiAgICogQHJlZzog cmVnaXN0ZXIgd2UgYXJlIHRlc3RpbmcKPiAgICogQGlkeDogaW5kZXggaW50byB0aGUgY3MgYnVm ZmVyCj4gICAqLwo+IEBAIC0xNzQ3LDcgKzE3NDcsNyBAQCBzdGF0aWMgaW50IGV2ZXJncmVlbl9j c19oYW5kbGVfcmVnKHN0cnVjdCByYWRlb25fY3NfcGFyc2VyICpwLCB1MzIgcmVnLCB1MzIgaWR4 KQo+Cj4gIC8qKgo+ICAgKiBldmVyZ3JlZW5faXNfc2FmZV9yZWcoKSAtIGNoZWNrIGlmIHJlZ2lz dGVyIGlzIGF1dGhvcml6ZWQgb3Igbm90Cj4gLSAqIEBwYXJzZXI6IHBhcnNlciBzdHJ1Y3R1cmUg aG9sZGluZyBwYXJzaW5nIGNvbnRleHQKPiArICogQHA6IHBhcnNlciBzdHJ1Y3R1cmUgaG9sZGlu ZyBwYXJzaW5nIGNvbnRleHQKPiAgICogQHJlZzogcmVnaXN0ZXIgd2UgYXJlIHRlc3RpbmcKPiAg ICoKPiAgICogVGhpcyBmdW5jdGlvbiB3aWxsIHRlc3QgYWdhaW5zdCByZWdfc2FmZV9ibSBhbmQg cmV0dXJuIHRydWUKPiAtLQo+IDIuMjUuMQo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v YW1kLWdmeAo=