From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7750ECCA47C for ; Wed, 6 Jul 2022 21:52:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234142AbiGFVwe (ORCPT ); Wed, 6 Jul 2022 17:52:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230412AbiGFVwc (ORCPT ); Wed, 6 Jul 2022 17:52:32 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3B131A810 for ; Wed, 6 Jul 2022 14:52:31 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id z41so20928814ede.1 for ; Wed, 06 Jul 2022 14:52:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=sVKNj9SkoISChFSURoq2rBmW/pxSFV/VJJFMmSbwpGs=; b=Go6ki17JNkyXFJID7151VQQd1gPh6zHpB+PcndVXU8y0ABMMSTBToYa/eIYvSK0+nt xvVRXlhHDTD3/ZMHoWQuT9s8dvQ2nhyc9v9p+4zD+KO/gkOlU5ZPTtnff73hgNZgX5mS WExsn+cJai5DENSjsWBJ3RGP/mqkpMNI19J6/oHh5hTTzqOQ56NUmsbZJvW/Q8b4ECWy +Z4En8Lv+px8oAX8JJ26vUMDDxlPQkokxMHCt59JrX9lOHimc1UzUYU5hzn81E1TaPrE AO11+uiyE8vIAs0/M14C+ifm18MYO+hRBZGPbvL9v2QQT68n/33CaDc00uNr+093nIYD vduA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=sVKNj9SkoISChFSURoq2rBmW/pxSFV/VJJFMmSbwpGs=; b=Zy4htpDvTZ/p4JCxAdupU3esid1bRCmvJxXI3AAPEleXD6TCChofS3XKE0KLVOURKe cfbqCwVBoSRXyaNycbVCPj7i/9f+uVXl0lllC5fgQDuo1HIPYxkeI/PT2wMF0KoHIVr8 p58CpHc7ot6eCwylZIZhF7muAkNDqM7p5y0MVwzkCh+S28VVhfUszPwwBIJ4cQCr9F8e ga1cgIBS4mNbsj3POvpl0K19/nUxwHCYbs61W6XL1SvgmU4ssax8yAsYvD8Wq1Ua4Yfo YNlTbqieg+mXAraKEnfLwvKMRZwLH6dYTa6visOxrdX70xyPV2YY5pR46odhaJtVZAOM D9PA== X-Gm-Message-State: AJIora+G+OYAhvKRftYTjJVmAv5DY5+5XCorcsaTvXp6CEkRZV/TvAHQ LWBW1RjUWR5ZNZgyCWbWV0poA8ZAcNmWLJUfe0laESJe X-Google-Smtp-Source: AGRyM1uTE+GtqSHSfiDE+D7/pQfZittO31nLWCwKLry3URJ/yUFOSww0ibrgZU0AWs4loA76jNinpLCiuO4GqUAR8tE= X-Received: by 2002:aa7:de88:0:b0:435:9a54:168a with SMTP id j8-20020aa7de88000000b004359a54168amr55951504edv.73.1657144350408; Wed, 06 Jul 2022 14:52:30 -0700 (PDT) MIME-Version: 1.0 References: <20220706200144.68851-1-mat.jonczyk@o2.pl> In-Reply-To: <20220706200144.68851-1-mat.jonczyk@o2.pl> From: Alex Deucher Date: Wed, 6 Jul 2022 17:52:18 -0400 Message-ID: Subject: Re: [PATCH] drm/radeon: avoid bogus "vram limit (0) must be a power of 2" warning To: =?UTF-8?Q?Mateusz_Jo=C5=84czyk?= Cc: amd-gfx list , Maling list - DRI developers , LKML , Jonathan Gray , "Pan, Xinhui" , David Airlie , Daniel Vetter , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied. Thanks! Alex On Wed, Jul 6, 2022 at 5:40 PM Mateusz Jo=C5=84czyk wro= te: > > I was getting the following message on boot on Linux 5.19-rc5: > radeon 0000:01:05.0: vram limit (0) must be a power of 2 > (I didn't use any radeon.vramlimit commandline parameter). > > This is caused by > commit 8c2d34eb53b9 ("drm/radeon: use kernel is_power_of_2 rather than lo= cal version") > which removed radeon_check_pot_argument() and converted its users to > is_power_of_2(). The two functions differ in its handling of 0, which is > the default value of radeon_vram_limit: radeon_check_pot_argument() > "incorrectly" considered it a power of 2, while is_power_of_2() does not. > > An appropriate conditional silences the warning message. > > It is not necessary to add a similar test to other callers of > is_power_of_2() in radeon_device.c. The matching commit in amdgpu: > commit 761175078466 ("drm/amdgpu: use kernel is_power_of_2 rather than lo= cal version") > is unaffected by this bug. > > Tested on Radeon HD 3200. > > Not ccing stable, this is not serious enough. > > Fixes: 8c2d34eb53b9 ("drm/radeon: use kernel is_power_of_2 rather than lo= cal version") > Cc: Alex Deucher > Cc: Christian K=C3=B6nig > Cc: "Pan, Xinhui" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Jonathan Gray > Signed-off-by: Mateusz Jo=C5=84czyk > --- > drivers/gpu/drm/radeon/radeon_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/rad= eon/radeon_device.c > index 15692cb241fc..429644d5ddc6 100644 > --- a/drivers/gpu/drm/radeon/radeon_device.c > +++ b/drivers/gpu/drm/radeon/radeon_device.c > @@ -1113,7 +1113,7 @@ static int radeon_gart_size_auto(enum radeon_family= family) > static void radeon_check_arguments(struct radeon_device *rdev) > { > /* vramlimit must be a power of two */ > - if (!is_power_of_2(radeon_vram_limit)) { > + if (radeon_vram_limit !=3D 0 && !is_power_of_2(radeon_vram_limit)= ) { > dev_warn(rdev->dev, "vram limit (%d) must be a power of 2= \n", > radeon_vram_limit); > radeon_vram_limit =3D 0; > > base-commit: 88084a3df1672e131ddc1b4e39eeacfd39864acf > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4ED33C43334 for ; Wed, 6 Jul 2022 21:52:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2FD0A10E8E0; Wed, 6 Jul 2022 21:52:34 +0000 (UTC) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by gabe.freedesktop.org (Postfix) with ESMTPS id E627C10E72B; Wed, 6 Jul 2022 21:52:32 +0000 (UTC) Received: by mail-ed1-x533.google.com with SMTP id fd6so20892600edb.5; Wed, 06 Jul 2022 14:52:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=sVKNj9SkoISChFSURoq2rBmW/pxSFV/VJJFMmSbwpGs=; b=Go6ki17JNkyXFJID7151VQQd1gPh6zHpB+PcndVXU8y0ABMMSTBToYa/eIYvSK0+nt xvVRXlhHDTD3/ZMHoWQuT9s8dvQ2nhyc9v9p+4zD+KO/gkOlU5ZPTtnff73hgNZgX5mS WExsn+cJai5DENSjsWBJ3RGP/mqkpMNI19J6/oHh5hTTzqOQ56NUmsbZJvW/Q8b4ECWy +Z4En8Lv+px8oAX8JJ26vUMDDxlPQkokxMHCt59JrX9lOHimc1UzUYU5hzn81E1TaPrE AO11+uiyE8vIAs0/M14C+ifm18MYO+hRBZGPbvL9v2QQT68n/33CaDc00uNr+093nIYD vduA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=sVKNj9SkoISChFSURoq2rBmW/pxSFV/VJJFMmSbwpGs=; b=s17J9Fk1Pb49InLdVHaFn2ppC5YVRfCzZKjft2o23qkWOJzii0kbFeDrvCThVQHLko sNf9xeqUxq3A/8JYKuJ/DMH+blbtFJdPnLJ1LiLum1M3vOueJ0afjXRs4xTB6sdhc+u/ rVscewQoxhfmcskfOTCd6FdvMJ5L/mBZlHO5lUjpzSVaiJpw2iBlBlsaJZjtPW4K8vOa 4WsWGTYYk4nndeDqUtYvR2SPIDDnC/DFnFkxHQ7CW1yr7x3e33YfkEBIx1p6rB+/e2Fk z6hhN3HwPeQ6kD/MfiTodCTIjRwKIBj6ULdAZ3VmcZ6gRt7MapnmnYlIM4FExp57CD4G 4zBA== X-Gm-Message-State: AJIora+eGlyiFkfjnyJsUQ+FeIVIeL+7k/HTt98br7rrfgjWXEJARqS7 MA3EimNdG1i6hbC6xeKCRISXhd5y3L8BUspdfFU= X-Google-Smtp-Source: AGRyM1uTE+GtqSHSfiDE+D7/pQfZittO31nLWCwKLry3URJ/yUFOSww0ibrgZU0AWs4loA76jNinpLCiuO4GqUAR8tE= X-Received: by 2002:aa7:de88:0:b0:435:9a54:168a with SMTP id j8-20020aa7de88000000b004359a54168amr55951504edv.73.1657144350408; Wed, 06 Jul 2022 14:52:30 -0700 (PDT) MIME-Version: 1.0 References: <20220706200144.68851-1-mat.jonczyk@o2.pl> In-Reply-To: <20220706200144.68851-1-mat.jonczyk@o2.pl> From: Alex Deucher Date: Wed, 6 Jul 2022 17:52:18 -0400 Message-ID: Subject: Re: [PATCH] drm/radeon: avoid bogus "vram limit (0) must be a power of 2" warning To: =?UTF-8?Q?Mateusz_Jo=C5=84czyk?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , "Pan, Xinhui" , LKML , Maling list - DRI developers , amd-gfx list , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Applied. Thanks! Alex On Wed, Jul 6, 2022 at 5:40 PM Mateusz Jo=C5=84czyk wro= te: > > I was getting the following message on boot on Linux 5.19-rc5: > radeon 0000:01:05.0: vram limit (0) must be a power of 2 > (I didn't use any radeon.vramlimit commandline parameter). > > This is caused by > commit 8c2d34eb53b9 ("drm/radeon: use kernel is_power_of_2 rather than lo= cal version") > which removed radeon_check_pot_argument() and converted its users to > is_power_of_2(). The two functions differ in its handling of 0, which is > the default value of radeon_vram_limit: radeon_check_pot_argument() > "incorrectly" considered it a power of 2, while is_power_of_2() does not. > > An appropriate conditional silences the warning message. > > It is not necessary to add a similar test to other callers of > is_power_of_2() in radeon_device.c. The matching commit in amdgpu: > commit 761175078466 ("drm/amdgpu: use kernel is_power_of_2 rather than lo= cal version") > is unaffected by this bug. > > Tested on Radeon HD 3200. > > Not ccing stable, this is not serious enough. > > Fixes: 8c2d34eb53b9 ("drm/radeon: use kernel is_power_of_2 rather than lo= cal version") > Cc: Alex Deucher > Cc: Christian K=C3=B6nig > Cc: "Pan, Xinhui" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Jonathan Gray > Signed-off-by: Mateusz Jo=C5=84czyk > --- > drivers/gpu/drm/radeon/radeon_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/rad= eon/radeon_device.c > index 15692cb241fc..429644d5ddc6 100644 > --- a/drivers/gpu/drm/radeon/radeon_device.c > +++ b/drivers/gpu/drm/radeon/radeon_device.c > @@ -1113,7 +1113,7 @@ static int radeon_gart_size_auto(enum radeon_family= family) > static void radeon_check_arguments(struct radeon_device *rdev) > { > /* vramlimit must be a power of two */ > - if (!is_power_of_2(radeon_vram_limit)) { > + if (radeon_vram_limit !=3D 0 && !is_power_of_2(radeon_vram_limit)= ) { > dev_warn(rdev->dev, "vram limit (%d) must be a power of 2= \n", > radeon_vram_limit); > radeon_vram_limit =3D 0; > > base-commit: 88084a3df1672e131ddc1b4e39eeacfd39864acf > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F00FC433EF for ; Wed, 6 Jul 2022 21:52:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9C36910E8A1; Wed, 6 Jul 2022 21:52:33 +0000 (UTC) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by gabe.freedesktop.org (Postfix) with ESMTPS id E627C10E72B; Wed, 6 Jul 2022 21:52:32 +0000 (UTC) Received: by mail-ed1-x533.google.com with SMTP id fd6so20892600edb.5; Wed, 06 Jul 2022 14:52:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=sVKNj9SkoISChFSURoq2rBmW/pxSFV/VJJFMmSbwpGs=; b=Go6ki17JNkyXFJID7151VQQd1gPh6zHpB+PcndVXU8y0ABMMSTBToYa/eIYvSK0+nt xvVRXlhHDTD3/ZMHoWQuT9s8dvQ2nhyc9v9p+4zD+KO/gkOlU5ZPTtnff73hgNZgX5mS WExsn+cJai5DENSjsWBJ3RGP/mqkpMNI19J6/oHh5hTTzqOQ56NUmsbZJvW/Q8b4ECWy +Z4En8Lv+px8oAX8JJ26vUMDDxlPQkokxMHCt59JrX9lOHimc1UzUYU5hzn81E1TaPrE AO11+uiyE8vIAs0/M14C+ifm18MYO+hRBZGPbvL9v2QQT68n/33CaDc00uNr+093nIYD vduA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=sVKNj9SkoISChFSURoq2rBmW/pxSFV/VJJFMmSbwpGs=; b=s17J9Fk1Pb49InLdVHaFn2ppC5YVRfCzZKjft2o23qkWOJzii0kbFeDrvCThVQHLko sNf9xeqUxq3A/8JYKuJ/DMH+blbtFJdPnLJ1LiLum1M3vOueJ0afjXRs4xTB6sdhc+u/ rVscewQoxhfmcskfOTCd6FdvMJ5L/mBZlHO5lUjpzSVaiJpw2iBlBlsaJZjtPW4K8vOa 4WsWGTYYk4nndeDqUtYvR2SPIDDnC/DFnFkxHQ7CW1yr7x3e33YfkEBIx1p6rB+/e2Fk z6hhN3HwPeQ6kD/MfiTodCTIjRwKIBj6ULdAZ3VmcZ6gRt7MapnmnYlIM4FExp57CD4G 4zBA== X-Gm-Message-State: AJIora+eGlyiFkfjnyJsUQ+FeIVIeL+7k/HTt98br7rrfgjWXEJARqS7 MA3EimNdG1i6hbC6xeKCRISXhd5y3L8BUspdfFU= X-Google-Smtp-Source: AGRyM1uTE+GtqSHSfiDE+D7/pQfZittO31nLWCwKLry3URJ/yUFOSww0ibrgZU0AWs4loA76jNinpLCiuO4GqUAR8tE= X-Received: by 2002:aa7:de88:0:b0:435:9a54:168a with SMTP id j8-20020aa7de88000000b004359a54168amr55951504edv.73.1657144350408; Wed, 06 Jul 2022 14:52:30 -0700 (PDT) MIME-Version: 1.0 References: <20220706200144.68851-1-mat.jonczyk@o2.pl> In-Reply-To: <20220706200144.68851-1-mat.jonczyk@o2.pl> From: Alex Deucher Date: Wed, 6 Jul 2022 17:52:18 -0400 Message-ID: Subject: Re: [PATCH] drm/radeon: avoid bogus "vram limit (0) must be a power of 2" warning To: =?UTF-8?Q?Mateusz_Jo=C5=84czyk?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , David Airlie , "Pan, Xinhui" , LKML , Maling list - DRI developers , amd-gfx list , Jonathan Gray , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Applied. Thanks! Alex On Wed, Jul 6, 2022 at 5:40 PM Mateusz Jo=C5=84czyk wro= te: > > I was getting the following message on boot on Linux 5.19-rc5: > radeon 0000:01:05.0: vram limit (0) must be a power of 2 > (I didn't use any radeon.vramlimit commandline parameter). > > This is caused by > commit 8c2d34eb53b9 ("drm/radeon: use kernel is_power_of_2 rather than lo= cal version") > which removed radeon_check_pot_argument() and converted its users to > is_power_of_2(). The two functions differ in its handling of 0, which is > the default value of radeon_vram_limit: radeon_check_pot_argument() > "incorrectly" considered it a power of 2, while is_power_of_2() does not. > > An appropriate conditional silences the warning message. > > It is not necessary to add a similar test to other callers of > is_power_of_2() in radeon_device.c. The matching commit in amdgpu: > commit 761175078466 ("drm/amdgpu: use kernel is_power_of_2 rather than lo= cal version") > is unaffected by this bug. > > Tested on Radeon HD 3200. > > Not ccing stable, this is not serious enough. > > Fixes: 8c2d34eb53b9 ("drm/radeon: use kernel is_power_of_2 rather than lo= cal version") > Cc: Alex Deucher > Cc: Christian K=C3=B6nig > Cc: "Pan, Xinhui" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Jonathan Gray > Signed-off-by: Mateusz Jo=C5=84czyk > --- > drivers/gpu/drm/radeon/radeon_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/rad= eon/radeon_device.c > index 15692cb241fc..429644d5ddc6 100644 > --- a/drivers/gpu/drm/radeon/radeon_device.c > +++ b/drivers/gpu/drm/radeon/radeon_device.c > @@ -1113,7 +1113,7 @@ static int radeon_gart_size_auto(enum radeon_family= family) > static void radeon_check_arguments(struct radeon_device *rdev) > { > /* vramlimit must be a power of two */ > - if (!is_power_of_2(radeon_vram_limit)) { > + if (radeon_vram_limit !=3D 0 && !is_power_of_2(radeon_vram_limit)= ) { > dev_warn(rdev->dev, "vram limit (%d) must be a power of 2= \n", > radeon_vram_limit); > radeon_vram_limit =3D 0; > > base-commit: 88084a3df1672e131ddc1b4e39eeacfd39864acf > -- > 2.25.1 >