From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 2/2] drm/amdgpu: Avoid overflows/divide-by-zero in
 latency_watermark calculations.
Date: Thu, 30 Mar 2017 15:24:37 -0400
Message-ID: <CADnq5_OSNV0JyHjVT_Gx4pjCiMdsF4vfwTaYvLfyr9p93v=Dww@mail.gmail.com>
References: <1490818152-10891-1-git-send-email-mario.kleiner.de@gmail.com>
 <1490818152-10891-3-git-send-email-mario.kleiner.de@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
In-Reply-To: <1490818152-10891-3-git-send-email-mario.kleiner.de-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/amd-gfx>
List-Post: <mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
List-Help: <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=subscribe>
Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Sender: "amd-gfx" <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
To: Mario Kleiner <mario.kleiner.de-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "Deucher, Alexander" <alexander.deucher-5C7GfCeVMHo@public.gmane.org>, amd-gfx list <amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>, Maling list - DRI developers <dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
List-Id: dri-devel@lists.freedesktop.org

T24gV2VkLCBNYXIgMjksIDIwMTcgYXQgNDowOSBQTSwgTWFyaW8gS2xlaW5lcgo8bWFyaW8ua2xl
aW5lci5kZUBnbWFpbC5jb20+IHdyb3RlOgo+IEF0IGRvdCBjbG9ja3MgPiBhcHByb3guIDI1MCBN
aHosIHNvbWUgb2YgdGhlc2UgY2FsY3Mgd2lsbCBvdmVyZmxvdyBhbmQKPiBjYXVzZSBtaXNjYWxj
dWxhdGlvbiBvZiBsYXRlbmN5IHdhdGVybWFya3MsIGFuZCBmb3Igc29tZSBvdmVyZmxvd3MgYWxz
bwo+IGRpdmlkZS1ieS16ZXJvIGRyaXZlciBjcmFzaCAoImRpdmlkZSBlcnJvcjogMDAwMCBbIzFd
IFBSRUVNUFQgU01QIiBpbgo+ICJkY2VfdjEwXzBfbGF0ZW5jeV93YXRlcm1hcmsrMHgxMmQvMHgx
OTAiKS4KPgo+IFRoaXMgemVyby1kaXZpZGUgaGFwcGVuZWQsIGUuZy4sIG9uIEFNRCBUb25nYSBQ
cm8gdW5kZXIgRENFLTEwLAo+IG9uIGEgRGlzcGxheXBvcnQgcGFuZWwgd2hlbiB0cnlpbmcgdG8g
c2V0IGEgdmlkZW8gbW9kZSBvZiAyNTYweDE0NDAKPiBhdCAxNjUgSHogdnJlZnJlc2ggd2l0aCBh
IGRvdCBjbG9jayBvZiA2MzUuNTQwIE1oei4KPgo+IFJlZmluZSBjYWxjdWxhdGlvbnMgdG8gYXZv
aWQgdGhlIG92ZXJmbG93cy4KPgo+IFRlc3RlZCBmb3IgRENFLTEwIHdpdGggUjkgMzgwIFRvbmdh
ICsgQVNVUyBST0cgUEcyNzkgcGFuZWwuCj4KPiBTaWduZWQtb2ZmLWJ5OiBNYXJpbyBLbGVpbmVy
IDxtYXJpby5rbGVpbmVyLmRlQGdtYWlsLmNvbT4KCkFwcGxpZWQgdGhlIHNlcmllcy4gIHRoYW5r
cyEKCkFsZXgKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2RjZV92MTBfMC5j
IHwgMTkgKysrLS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9k
Y2VfdjExXzAuYyB8IDE5ICsrKy0tLS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2Ft
ZC9hbWRncHUvZGNlX3Y2XzAuYyAgfCAxOSArKystLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMv
Z3B1L2RybS9hbWQvYW1kZ3B1L2RjZV92OF8wLmMgIHwgMTkgKysrLS0tLS0tLS0tLS0tLS0tLQo+
ICA0IGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDY0IGRlbGV0aW9ucygtKQo+Cj4g
ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2RjZV92MTBfMC5jIGIvZHJp
dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZGNlX3YxMF8wLmMKPiBpbmRleCBkM2RiOTIxLi4zMzU0
MWFjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2RjZV92MTBfMC5j
Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZGNlX3YxMF8wLmMKPiBAQCAtMTA5
MCwyMyArMTA5MCwxMCBAQCBzdGF0aWMgdTMyIGRjZV92MTBfMF9sYXRlbmN5X3dhdGVybWFyayhz
dHJ1Y3QgZGNlMTBfd21fcGFyYW1zICp3bSkKPiAgICAgICAgIGEuZnVsbCA9IGRmaXhlZF9jb25z
dChhdmFpbGFibGVfYmFuZHdpZHRoKTsKPiAgICAgICAgIGIuZnVsbCA9IGRmaXhlZF9jb25zdCh3
bS0+bnVtX2hlYWRzKTsKPiAgICAgICAgIGEuZnVsbCA9IGRmaXhlZF9kaXYoYSwgYik7Cj4gKyAg
ICAgICB0bXAgPSBkaXZfdTY0KCh1NjQpIGRtaWZfc2l6ZSAqICh1NjQpIHdtLT5kaXNwX2Nsaywg
bWNfbGF0ZW5jeSArIDUxMik7Cj4gKyAgICAgICB0bXAgPSBtaW4oZGZpeGVkX3RydW5jKGEpLCB0
bXApOwo+Cj4gLSAgICAgICBiLmZ1bGwgPSBkZml4ZWRfY29uc3QobWNfbGF0ZW5jeSArIDUxMik7
Cj4gLSAgICAgICBjLmZ1bGwgPSBkZml4ZWRfY29uc3Qod20tPmRpc3BfY2xrKTsKPiAtICAgICAg
IGIuZnVsbCA9IGRmaXhlZF9kaXYoYiwgYyk7Cj4gLQo+IC0gICAgICAgYy5mdWxsID0gZGZpeGVk
X2NvbnN0KGRtaWZfc2l6ZSk7Cj4gLSAgICAgICBiLmZ1bGwgPSBkZml4ZWRfZGl2KGMsIGIpOwo+
IC0KPiAtICAgICAgIHRtcCA9IG1pbihkZml4ZWRfdHJ1bmMoYSksIGRmaXhlZF90cnVuYyhiKSk7
Cj4gLQo+IC0gICAgICAgYi5mdWxsID0gZGZpeGVkX2NvbnN0KDEwMDApOwo+IC0gICAgICAgYy5m
dWxsID0gZGZpeGVkX2NvbnN0KHdtLT5kaXNwX2Nsayk7Cj4gLSAgICAgICBiLmZ1bGwgPSBkZml4
ZWRfZGl2KGMsIGIpOwo+IC0gICAgICAgYy5mdWxsID0gZGZpeGVkX2NvbnN0KHdtLT5ieXRlc19w
ZXJfcGl4ZWwpOwo+IC0gICAgICAgYi5mdWxsID0gZGZpeGVkX211bChiLCBjKTsKPiAtCj4gLSAg
ICAgICBsYl9maWxsX2J3ID0gbWluKHRtcCwgZGZpeGVkX3RydW5jKGIpKTsKPiArICAgICAgIGxi
X2ZpbGxfYncgPSBtaW4odG1wLCB3bS0+ZGlzcF9jbGsgKiB3bS0+Ynl0ZXNfcGVyX3BpeGVsIC8g
MTAwMCk7Cj4KPiAgICAgICAgIGEuZnVsbCA9IGRmaXhlZF9jb25zdChtYXhfc3JjX2xpbmVzX3Bl
cl9kc3RfbGluZSAqIHdtLT5zcmNfd2lkdGggKiB3bS0+Ynl0ZXNfcGVyX3BpeGVsKTsKPiAgICAg
ICAgIGIuZnVsbCA9IGRmaXhlZF9jb25zdCgxMDAwKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n
cHUvZHJtL2FtZC9hbWRncHUvZGNlX3YxMV8wLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw
dS9kY2VfdjExXzAuYwo+IGluZGV4IDE1ZWU4ZWIuLjEzODhmOGEgMTAwNjQ0Cj4gLS0tIGEvZHJp
dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZGNlX3YxMV8wLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k
cm0vYW1kL2FtZGdwdS9kY2VfdjExXzAuYwo+IEBAIC0xMDU5LDIzICsxMDU5LDEwIEBAIHN0YXRp
YyB1MzIgZGNlX3YxMV8wX2xhdGVuY3lfd2F0ZXJtYXJrKHN0cnVjdCBkY2UxMF93bV9wYXJhbXMg
KndtKQo+ICAgICAgICAgYS5mdWxsID0gZGZpeGVkX2NvbnN0KGF2YWlsYWJsZV9iYW5kd2lkdGgp
Owo+ICAgICAgICAgYi5mdWxsID0gZGZpeGVkX2NvbnN0KHdtLT5udW1faGVhZHMpOwo+ICAgICAg
ICAgYS5mdWxsID0gZGZpeGVkX2RpdihhLCBiKTsKPiArICAgICAgIHRtcCA9IGRpdl91NjQoKHU2
NCkgZG1pZl9zaXplICogKHU2NCkgd20tPmRpc3BfY2xrLCBtY19sYXRlbmN5ICsgNTEyKTsKPiAr
ICAgICAgIHRtcCA9IG1pbihkZml4ZWRfdHJ1bmMoYSksIHRtcCk7Cj4KPiAtICAgICAgIGIuZnVs
bCA9IGRmaXhlZF9jb25zdChtY19sYXRlbmN5ICsgNTEyKTsKPiAtICAgICAgIGMuZnVsbCA9IGRm
aXhlZF9jb25zdCh3bS0+ZGlzcF9jbGspOwo+IC0gICAgICAgYi5mdWxsID0gZGZpeGVkX2Rpdihi
LCBjKTsKPiAtCj4gLSAgICAgICBjLmZ1bGwgPSBkZml4ZWRfY29uc3QoZG1pZl9zaXplKTsKPiAt
ICAgICAgIGIuZnVsbCA9IGRmaXhlZF9kaXYoYywgYik7Cj4gLQo+IC0gICAgICAgdG1wID0gbWlu
KGRmaXhlZF90cnVuYyhhKSwgZGZpeGVkX3RydW5jKGIpKTsKPiAtCj4gLSAgICAgICBiLmZ1bGwg
PSBkZml4ZWRfY29uc3QoMTAwMCk7Cj4gLSAgICAgICBjLmZ1bGwgPSBkZml4ZWRfY29uc3Qod20t
PmRpc3BfY2xrKTsKPiAtICAgICAgIGIuZnVsbCA9IGRmaXhlZF9kaXYoYywgYik7Cj4gLSAgICAg
ICBjLmZ1bGwgPSBkZml4ZWRfY29uc3Qod20tPmJ5dGVzX3Blcl9waXhlbCk7Cj4gLSAgICAgICBi
LmZ1bGwgPSBkZml4ZWRfbXVsKGIsIGMpOwo+IC0KPiAtICAgICAgIGxiX2ZpbGxfYncgPSBtaW4o
dG1wLCBkZml4ZWRfdHJ1bmMoYikpOwo+ICsgICAgICAgbGJfZmlsbF9idyA9IG1pbih0bXAsIHdt
LT5kaXNwX2NsayAqIHdtLT5ieXRlc19wZXJfcGl4ZWwgLyAxMDAwKTsKPgo+ICAgICAgICAgYS5m
dWxsID0gZGZpeGVkX2NvbnN0KG1heF9zcmNfbGluZXNfcGVyX2RzdF9saW5lICogd20tPnNyY193
aWR0aCAqIHdtLT5ieXRlc19wZXJfcGl4ZWwpOwo+ICAgICAgICAgYi5mdWxsID0gZGZpeGVkX2Nv
bnN0KDEwMDApOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9kY2Vf
djZfMC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZGNlX3Y2XzAuYwo+IGluZGV4IGNi
OTE1OGIuLmJhZDUyYzAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv
ZGNlX3Y2XzAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2RjZV92Nl8wLmMK
PiBAQCAtODYxLDIzICs4NjEsMTAgQEAgc3RhdGljIHUzMiBkY2VfdjZfMF9sYXRlbmN5X3dhdGVy
bWFyayhzdHJ1Y3QgZGNlNl93bV9wYXJhbXMgKndtKQo+ICAgICAgICAgYS5mdWxsID0gZGZpeGVk
X2NvbnN0KGF2YWlsYWJsZV9iYW5kd2lkdGgpOwo+ICAgICAgICAgYi5mdWxsID0gZGZpeGVkX2Nv
bnN0KHdtLT5udW1faGVhZHMpOwo+ICAgICAgICAgYS5mdWxsID0gZGZpeGVkX2RpdihhLCBiKTsK
PiArICAgICAgIHRtcCA9IGRpdl91NjQoKHU2NCkgZG1pZl9zaXplICogKHU2NCkgd20tPmRpc3Bf
Y2xrLCBtY19sYXRlbmN5ICsgNTEyKTsKPiArICAgICAgIHRtcCA9IG1pbihkZml4ZWRfdHJ1bmMo
YSksIHRtcCk7Cj4KPiAtICAgICAgIGIuZnVsbCA9IGRmaXhlZF9jb25zdChtY19sYXRlbmN5ICsg
NTEyKTsKPiAtICAgICAgIGMuZnVsbCA9IGRmaXhlZF9jb25zdCh3bS0+ZGlzcF9jbGspOwo+IC0g
ICAgICAgYi5mdWxsID0gZGZpeGVkX2RpdihiLCBjKTsKPiAtCj4gLSAgICAgICBjLmZ1bGwgPSBk
Zml4ZWRfY29uc3QoZG1pZl9zaXplKTsKPiAtICAgICAgIGIuZnVsbCA9IGRmaXhlZF9kaXYoYywg
Yik7Cj4gLQo+IC0gICAgICAgdG1wID0gbWluKGRmaXhlZF90cnVuYyhhKSwgZGZpeGVkX3RydW5j
KGIpKTsKPiAtCj4gLSAgICAgICBiLmZ1bGwgPSBkZml4ZWRfY29uc3QoMTAwMCk7Cj4gLSAgICAg
ICBjLmZ1bGwgPSBkZml4ZWRfY29uc3Qod20tPmRpc3BfY2xrKTsKPiAtICAgICAgIGIuZnVsbCA9
IGRmaXhlZF9kaXYoYywgYik7Cj4gLSAgICAgICBjLmZ1bGwgPSBkZml4ZWRfY29uc3Qod20tPmJ5
dGVzX3Blcl9waXhlbCk7Cj4gLSAgICAgICBiLmZ1bGwgPSBkZml4ZWRfbXVsKGIsIGMpOwo+IC0K
PiAtICAgICAgIGxiX2ZpbGxfYncgPSBtaW4odG1wLCBkZml4ZWRfdHJ1bmMoYikpOwo+ICsgICAg
ICAgbGJfZmlsbF9idyA9IG1pbih0bXAsIHdtLT5kaXNwX2NsayAqIHdtLT5ieXRlc19wZXJfcGl4
ZWwgLyAxMDAwKTsKPgo+ICAgICAgICAgYS5mdWxsID0gZGZpeGVkX2NvbnN0KG1heF9zcmNfbGlu
ZXNfcGVyX2RzdF9saW5lICogd20tPnNyY193aWR0aCAqIHdtLT5ieXRlc19wZXJfcGl4ZWwpOwo+
ICAgICAgICAgYi5mdWxsID0gZGZpeGVkX2NvbnN0KDEwMDApOwo+IGRpZmYgLS1naXQgYS9kcml2
ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9kY2VfdjhfMC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9h
bWRncHUvZGNlX3Y4XzAuYwo+IGluZGV4IGQ1NDdiY2YuLmU1MmZjOTIgMTAwNjQ0Cj4gLS0tIGEv
ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZGNlX3Y4XzAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1
L2RybS9hbWQvYW1kZ3B1L2RjZV92OF8wLmMKPiBAQCAtOTc0LDIzICs5NzQsMTAgQEAgc3RhdGlj
IHUzMiBkY2VfdjhfMF9sYXRlbmN5X3dhdGVybWFyayhzdHJ1Y3QgZGNlOF93bV9wYXJhbXMgKndt
KQo+ICAgICAgICAgYS5mdWxsID0gZGZpeGVkX2NvbnN0KGF2YWlsYWJsZV9iYW5kd2lkdGgpOwo+
ICAgICAgICAgYi5mdWxsID0gZGZpeGVkX2NvbnN0KHdtLT5udW1faGVhZHMpOwo+ICAgICAgICAg
YS5mdWxsID0gZGZpeGVkX2RpdihhLCBiKTsKPiArICAgICAgIHRtcCA9IGRpdl91NjQoKHU2NCkg
ZG1pZl9zaXplICogKHU2NCkgd20tPmRpc3BfY2xrLCBtY19sYXRlbmN5ICsgNTEyKTsKPiArICAg
ICAgIHRtcCA9IG1pbihkZml4ZWRfdHJ1bmMoYSksIHRtcCk7Cj4KPiAtICAgICAgIGIuZnVsbCA9
IGRmaXhlZF9jb25zdChtY19sYXRlbmN5ICsgNTEyKTsKPiAtICAgICAgIGMuZnVsbCA9IGRmaXhl
ZF9jb25zdCh3bS0+ZGlzcF9jbGspOwo+IC0gICAgICAgYi5mdWxsID0gZGZpeGVkX2RpdihiLCBj
KTsKPiAtCj4gLSAgICAgICBjLmZ1bGwgPSBkZml4ZWRfY29uc3QoZG1pZl9zaXplKTsKPiAtICAg
ICAgIGIuZnVsbCA9IGRmaXhlZF9kaXYoYywgYik7Cj4gLQo+IC0gICAgICAgdG1wID0gbWluKGRm
aXhlZF90cnVuYyhhKSwgZGZpeGVkX3RydW5jKGIpKTsKPiAtCj4gLSAgICAgICBiLmZ1bGwgPSBk
Zml4ZWRfY29uc3QoMTAwMCk7Cj4gLSAgICAgICBjLmZ1bGwgPSBkZml4ZWRfY29uc3Qod20tPmRp
c3BfY2xrKTsKPiAtICAgICAgIGIuZnVsbCA9IGRmaXhlZF9kaXYoYywgYik7Cj4gLSAgICAgICBj
LmZ1bGwgPSBkZml4ZWRfY29uc3Qod20tPmJ5dGVzX3Blcl9waXhlbCk7Cj4gLSAgICAgICBiLmZ1
bGwgPSBkZml4ZWRfbXVsKGIsIGMpOwo+IC0KPiAtICAgICAgIGxiX2ZpbGxfYncgPSBtaW4odG1w
LCBkZml4ZWRfdHJ1bmMoYikpOwo+ICsgICAgICAgbGJfZmlsbF9idyA9IG1pbih0bXAsIHdtLT5k
aXNwX2NsayAqIHdtLT5ieXRlc19wZXJfcGl4ZWwgLyAxMDAwKTsKPgo+ICAgICAgICAgYS5mdWxs
ID0gZGZpeGVkX2NvbnN0KG1heF9zcmNfbGluZXNfcGVyX2RzdF9saW5lICogd20tPnNyY193aWR0
aCAqIHdtLT5ieXRlc19wZXJfcGl4ZWwpOwo+ICAgICAgICAgYi5mdWxsID0gZGZpeGVkX2NvbnN0
KDEwMDApOwo+IC0tCj4gMi43LjQKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fCj4gYW1kLWdmeCBtYWlsaW5nIGxpc3QKPiBhbWQtZ2Z4QGxpc3RzLmZy
ZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz
dGluZm8vYW1kLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo
dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK