From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH] drm: Split out drm_probe_helper.h Date: Tue, 15 Jan 2019 22:30:11 -0500 Message-ID: References: <20190115104137.25695-1-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190115104137.25695-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Daniel Vetter Cc: nouveau , DRI Development , "open list:VIRTIO CORE, NET..." , Laurent Pinchart , Benjamin Gaignard , Daniel Vetter , Sam Ravnborg , linux-stm32-XDFAJ8BFU24N7RejjzZ/Li2xQDfSxrLKVpNB7YpNyf8@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, amd-gfx list , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, spice-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-arm-msm , Intel Graphics Development , etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Jani Nikula , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rodrigo Vivi , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel@li List-Id: linux-tegra@vger.kernel.org T24gVHVlLCBKYW4gMTUsIDIwMTkgYXQgNTo0MSBBTSBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0 dGVyQGZmd2xsLmNoPiB3cm90ZToKPgo+IEhhdmluZyB0aGUgcHJvYmUgaGVscGVyIHN0dWZmICh3 aGljaCBwcmV0dHkgbXVjaCBldmVyeW9uZSBuZWVkcykgaW4KPiB0aGUgZHJtX2NydGNfaGVscGVy LmggZmlsZSAod2hpY2ggYXRvbWljIGRyaXZlcnMgc2hvdWxkIG5ldmVyIG5lZWQpIGlzCj4gY29u ZnVzaW5nLiBTcGxpdCB0aGVtIG91dC4KPgo+IFRvIG1ha2Ugc3VyZSBJIGFjdHVhbGx5IGFjaGll dmVkIHRoZSBnb2FsIGhlcmUgSSB3ZW50IHRocm91Z2ggYWxsCj4gZHJpdmVycy4gQW5kIGluZGVl ZCwgYWxsIGF0b21pYyBkcml2ZXJzIGFyZSBub3cgZnJlZSBvZgo+IGRybV9jcnRjX2hlbHBlci5o IGluY2x1ZGVzLgo+Cj4gdjI6IE1ha2UgaXQgY29tcGlsZS4gVGhlcmUgd2FzIHNvIG11Y2ggY29t cGlsZSBmYWlsIG9uIGFybSBkcml2ZXJzCj4gdGhhdCBJIGZpZ3VyZWQgSSdsbCBiZXR0ZXIgbm90 IGluY2x1ZGUgYW55IG9mIHRoZSBhY2tzIG9uIHYxLgo+Cj4gdjM6IE1hc3NpdmUgcmViYXNlIGJl Y2F1c2UgaTkxNSBoYXMgbG9zdCBhIGxvdCBvZiBkcm1QLmggaW5jbHVkZXMsIGJ1dAo+IG5vdCBh bGw6IFRocm91Z2ggZHJtX2NydGNfaGVscGVyLmggPiBkcm1fbW9kZXNldF9oZWxwZXIuaCAtPiBk cm1QLmgKPiB0aGVyZSB3YXMgc3RpbGwgb25lLCB3aGljaCB0aGlzIHBhdGNoIGxhcmdlbHkgcmVt b3Zlcy4gV2hpY2ggbWVhbnMKPiByb2xsaW5nIG91dCBsb3RzIG1vcmUgaW5jbHVkZXMgYWxsIG92 ZXIuCj4KPiBUaGlzIHdpbGwgYWxzbyBjb25mbGljdCB3aXRoIG9uZ29pbmcgZHJtUC5oIGNsZWFu dXAgYnkgb3RoZXJzIEkKPiBleHBlY3QuCj4KPiB2MzogUmViYXNlIG9uIHRvcCBvZiBhdG9taWMg Ym9jaHMuCj4KPiBDYzogU2FtIFJhdm5ib3JnIDxzYW1AcmF2bmJvcmcub3JnPgo+IENjOiBKYW5p IE5pa3VsYSA8amFuaS5uaWt1bGFAbGludXguaW50ZWwuY29tPgo+IENjOiBMYXVyZW50IFBpbmNo YXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4gQWNrZWQtYnk6IFJvZHJp Z28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4gKHYyKQo+IEFja2VkLWJ5OiBCZW5qYW1p biBHYWlnbmFyZCA8YmVuamFtaW4uZ2FpZ25hcmRAbGluYXJvLm9yZz4gKHYyKQo+IFNpZ25lZC1v ZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+IENjOiBsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBDYzogdmlydHVhbGl6YXRpb25AbGlz dHMubGludXgtZm91bmRhdGlvbi5vcmcKPiBDYzogZXRuYXZpdkBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPiBDYzogbGludXgtc2Ftc3VuZy1zb2NAdmdlci5rZXJuZWwub3JnCj4gQ2M6IGludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBDYzogbGludXgtbWVkaWF0ZWtAbGlzdHMuaW5mcmFk ZWFkLm9yZwo+IENjOiBsaW51eC1hbWxvZ2ljQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBDYzogbGlu dXgtYXJtLW1zbUB2Z2VyLmtlcm5lbC5vcmcKPiBDYzogZnJlZWRyZW5vQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+IENjOiBub3V2ZWF1QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IENjOiBzcGljZS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBDYzogYW1kLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPiBDYzogbGludXgtcmVuZXNhcy1zb2NAdmdlci5rZXJuZWwub3JnCj4gQ2M6IGxpbnV4 LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBDYzogbGludXgtc3RtMzJAc3QtbWQtbWFp bG1hbi5zdG9ybXJlcGx5LmNvbQo+IENjOiBsaW51eC10ZWdyYUB2Z2VyLmtlcm5lbC5vcmcKPiBD YzogeGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKPiAtLS0KPiBNZXJnaW5nIHRoaXMgaXMgZ29pbmcg dG8gYmUgYSBiaXQgYSBtZXNzIGR1ZSB0byBhbGwgdGhlIG9uZ29pbmcgZHJtUC5oCj4gY2xlYW51 cHMuIEkgdGhpbmsgdGhlIGZvbGxvd2luZyBzaG91bGQgd29yazoKPiAtIEFwcGx5IFNhbSdzIHBy ZXAgcGF0Y2hlcyBmb3IgcmVtb3ZpbmcgZHJtUC5oIGZyb20KPiAgIGRybV9tb2Rlc2V0X2hlbHBl ci5oCj4gLSBHZXQgdGhlIGk5MTUgZHJtUC5oIGNsZWFudXAgYmFja21lcmdlZCBpbnRvIGRybS1t aXNjLW5leHQKPiAtIEFwcGx5IHRoaXMgcGF0Y2guCj4gLSBBcHBseSBTYW0ncyBwYXRjaCB0byBy ZW1vdmUgZHJtUC5oIGZyb20gZHJtX21vZGVzZXRfaGVscGVyLmgKPiAtIEFsbCB0aHJvdWdoIGRy bS1taXNjLW5leHQsIHdoaWNoIGhhcyBzb21lIHBvdGVudGlhbCBmb3IgdHJpdmlhbAo+ICAgY29u ZmxpY3RzIGFyb3VuZCAjaW5jbHVkZXMgd2l0aCBvdGhlciBkcml2ZXJzIHVuZm9ydHVuYXRlbHku Cj4KPiBJIGhvcGUgdGhlcmUncyBubyBvdGhlciBkcml2ZXIgd2hvJ2xsIGJsb3cgdXAgYWNjaWRl bnRhbGx5IGJlY2F1c2UKPiBzb21lb25lIGVsc2UgaXMgZG9pbmcgYSBkcm1QLmggY2xlYW51cC4g TGF1cmVudCBtYXliZT8KPgo+IEphbmksIGFjayBvbiB0aGlzPwo+IC1EYW5pZWwKCmFtZGdwdSBh bmQgcmFkZW9uOgpBY2tlZC1ieTogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1Y2hlckBhbWQu Y29tPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpGcmVl ZHJlbm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJlbm8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07355C43387 for ; Wed, 16 Jan 2019 03:30:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C33C32086D for ; Wed, 16 Jan 2019 03:30:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uFLLHJdd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731019AbfAPDa0 (ORCPT ); Tue, 15 Jan 2019 22:30:26 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:46719 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730639AbfAPDa0 (ORCPT ); Tue, 15 Jan 2019 22:30:26 -0500 Received: by mail-wr1-f65.google.com with SMTP id l9so5210130wrt.13; Tue, 15 Jan 2019 19:30:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DAB7bOvCpjeEgqAU23iWSznTCf2WSBgkvOBydTcb6wI=; b=uFLLHJddp3hHH4nf6OgRarrAc4KoBIr18Rg8TI2mRyVZwatnUMvF8Oz2lx8HRiQ43K 60CBvCl/+IJbH40zxdlD1OCusEm/kNHS1bLeKkz9ksUjPUIdF6EF0TvnHH3fRlJh9Mxi JFrGHdknEZWggYUo8qkgdxFvjcsDDsiPZsOq7xHrLN8gDyYX1SX8eN8l4nvSWhhBU+Jx vADM7lSxRTt9/G8iXSbxhnMMJHxGkLYUpi/UHI501Hgr6ZLNijXRqSPqr+wHTjoD02gn 5T47olbOz3ahOnG/2xJgXfwJH1rTtVv5zLYfuJ1eZYWfHhOwRhgawQmxExSqitbHTpSK dpkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DAB7bOvCpjeEgqAU23iWSznTCf2WSBgkvOBydTcb6wI=; b=DtRke3F3GFGz2RC2JVkuQRWetJjM9mQGS6Y4qlgud/6uuStmMJLedq5sIQ2D9Zz7Ti jn5cA20ynnOyMU8mvB27+3cEDjnoNwkS/7Zso8DX9pmAmFraegQmpyfcPnhPujUEYKKA lJmC+e+klqbBefV8CrUlKHj+zGcgnZzkXomubEU//G8nOZlKflTkwBI7bNACxbWvERO9 ftPUJAUGbBrKg7HWwxv0MOR2sFEvy/WGCd8pE1oR/LbBe5ySfCc6NINufvm38BxN/3hP F5geGyKz59r82L9cfJxNK6dJPjx8BcX2YMq1SszpSh6i6mavUNk+Lo6QniMak0iJgh7k xkBQ== X-Gm-Message-State: AJcUukfDnFR/nt3NwBBaN+x1NnxmjnTyqxJdZgD8ujAz3cEA8r95V79/ DUA2Jmy9DXGtCcmjIYUaY3TCTE1sXTFEKUNnUSz/2XUfa8Q= X-Google-Smtp-Source: ALg8bN7cxSJGppag4xxGzhM4PxdbCoQCVPdZ0OtFy2Ew9NaqrdEByk31K9k1/6DgDg1uk9zX2XiehKYFhzIF7C9uslQ= X-Received: by 2002:a5d:488f:: with SMTP id g15mr5564831wrq.15.1547609423651; Tue, 15 Jan 2019 19:30:23 -0800 (PST) MIME-Version: 1.0 References: <20190115104137.25695-1-daniel.vetter@ffwll.ch> In-Reply-To: <20190115104137.25695-1-daniel.vetter@ffwll.ch> From: Alex Deucher Date: Tue, 15 Jan 2019 22:30:11 -0500 Message-ID: Subject: Re: [PATCH] drm: Split out drm_probe_helper.h To: Daniel Vetter Cc: Intel Graphics Development , DRI Development , "open list:VIRTIO CORE, NET..." , Laurent Pinchart , Benjamin Gaignard , Daniel Vetter , Sam Ravnborg , linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx list , linux-rockchip@lists.infradead.org, nouveau , spice-devel@lists.freedesktop.org, linux-arm-msm , etnaviv@lists.freedesktop.org, Jani Nikula , linux-mediatek@lists.infradead.org, Rodrigo Vivi , linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xen.org, linux-renesas-soc@vger.kernel.org, freedreno Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Tue, Jan 15, 2019 at 5:41 AM Daniel Vetter wrote: > > Having the probe helper stuff (which pretty much everyone needs) in > the drm_crtc_helper.h file (which atomic drivers should never need) is > confusing. Split them out. > > To make sure I actually achieved the goal here I went through all > drivers. And indeed, all atomic drivers are now free of > drm_crtc_helper.h includes. > > v2: Make it compile. There was so much compile fail on arm drivers > that I figured I'll better not include any of the acks on v1. > > v3: Massive rebase because i915 has lost a lot of drmP.h includes, but > not all: Through drm_crtc_helper.h > drm_modeset_helper.h -> drmP.h > there was still one, which this patch largely removes. Which means > rolling out lots more includes all over. > > This will also conflict with ongoing drmP.h cleanup by others I > expect. > > v3: Rebase on top of atomic bochs. > > Cc: Sam Ravnborg > Cc: Jani Nikula > Cc: Laurent Pinchart > Acked-by: Rodrigo Vivi (v2) > Acked-by: Benjamin Gaignard (v2) > Signed-off-by: Daniel Vetter > Cc: linux-arm-kernel@lists.infradead.org > Cc: virtualization@lists.linux-foundation.org > Cc: etnaviv@lists.freedesktop.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: intel-gfx@lists.freedesktop.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-arm-msm@vger.kernel.org > Cc: freedreno@lists.freedesktop.org > Cc: nouveau@lists.freedesktop.org > Cc: spice-devel@lists.freedesktop.org > Cc: amd-gfx@lists.freedesktop.org > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-tegra@vger.kernel.org > Cc: xen-devel@lists.xen.org > --- > Merging this is going to be a bit a mess due to all the ongoing drmP.h > cleanups. I think the following should work: > - Apply Sam's prep patches for removing drmP.h from > drm_modeset_helper.h > - Get the i915 drmP.h cleanup backmerged into drm-misc-next > - Apply this patch. > - Apply Sam's patch to remove drmP.h from drm_modeset_helper.h > - All through drm-misc-next, which has some potential for trivial > conflicts around #includes with other drivers unfortunately. > > I hope there's no other driver who'll blow up accidentally because > someone else is doing a drmP.h cleanup. Laurent maybe? > > Jani, ack on this? > -Daniel amdgpu and radeon: Acked-by: Alex Deucher From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D523CC43387 for ; Wed, 16 Jan 2019 03:30:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98E91204FD for ; Wed, 16 Jan 2019 03:30:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AiVAUQR8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uFLLHJdd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98E91204FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GDXXAqT0l+ShjnmOohEXGUFBuB+8fJ6CmElPmPqp1Us=; b=AiVAUQR8pNQkhF wcH4BNuutwvrlETGVX/SGbuUPe3FHhpzQAVofoPafpcF6JPzf0Rl6ERdwlwGUJkEwIAEaNu8h/kGd XbQEhT3eMmlHCWlmrKgJUMaMrBCIBUpc8MrJ/yZMuWjbIvmzMfjM2BAUAPC6g0Bf5zGgjAZGwzvkI TlMhvGyYsKkFCcNo366ddn32BKTVHHU7sTkfQ9N0NUgGnpgItCVPuQ+u5NzM7C224iXdQX4PgfCeZ KHyR//av3Y+0ccM139yZRRbpZzdjQWUPd42isxCjHmOPHeh4Uk43T/yFUXbL/oJZyKOPEx7Kt064D WN7yOf7AQrX/MH/lOSGA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gjbuS-0005Qv-Og; Wed, 16 Jan 2019 03:30:32 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gjbuM-0005OH-5T; Wed, 16 Jan 2019 03:30:27 +0000 Received: by mail-wr1-x442.google.com with SMTP id t6so5220857wrr.12; Tue, 15 Jan 2019 19:30:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DAB7bOvCpjeEgqAU23iWSznTCf2WSBgkvOBydTcb6wI=; b=uFLLHJddp3hHH4nf6OgRarrAc4KoBIr18Rg8TI2mRyVZwatnUMvF8Oz2lx8HRiQ43K 60CBvCl/+IJbH40zxdlD1OCusEm/kNHS1bLeKkz9ksUjPUIdF6EF0TvnHH3fRlJh9Mxi JFrGHdknEZWggYUo8qkgdxFvjcsDDsiPZsOq7xHrLN8gDyYX1SX8eN8l4nvSWhhBU+Jx vADM7lSxRTt9/G8iXSbxhnMMJHxGkLYUpi/UHI501Hgr6ZLNijXRqSPqr+wHTjoD02gn 5T47olbOz3ahOnG/2xJgXfwJH1rTtVv5zLYfuJ1eZYWfHhOwRhgawQmxExSqitbHTpSK dpkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DAB7bOvCpjeEgqAU23iWSznTCf2WSBgkvOBydTcb6wI=; b=Nbpa/GtwfQ1DCKtgiRclj3res4CWCQV3QDACHGLTi86COqsL1ry01jlMTWdNaa51JG /hafoCFa/cSHPoTkue9pa1pARRnrly75fVSqTCcms7u2Kx2IzYXMp9537cD0Nuj2v5y9 ZyDPi7DbN74cm7e7+zWLaJKEWw7ChR3Qg0YYq5lrzu8B/5ly2J2GJBQICSBxawKpGZKg i8mCO5zljCe6aCzBvPTZhwBbrLpsVN07xetswy8NZwF+SEl8SVx6rn88M2KZPI+eYdzk DUGJ41Z1TWVSMK1JoZnyh5eFPOXfUBuhB5DyHKR1knOCgEJE2iL/y6owGf4ReaRz32V5 pAWw== X-Gm-Message-State: AJcUukfSAtFLNlnTxuDB87OaswpefIoj4H02K88FnWkG3JEWOlts3x+d YDLEof9xDC3bODFgJqMjhZ+KSXN8MIfp1yU9v8k= X-Google-Smtp-Source: ALg8bN7cxSJGppag4xxGzhM4PxdbCoQCVPdZ0OtFy2Ew9NaqrdEByk31K9k1/6DgDg1uk9zX2XiehKYFhzIF7C9uslQ= X-Received: by 2002:a5d:488f:: with SMTP id g15mr5564831wrq.15.1547609423651; Tue, 15 Jan 2019 19:30:23 -0800 (PST) MIME-Version: 1.0 References: <20190115104137.25695-1-daniel.vetter@ffwll.ch> In-Reply-To: <20190115104137.25695-1-daniel.vetter@ffwll.ch> From: Alex Deucher Date: Tue, 15 Jan 2019 22:30:11 -0500 Message-ID: Subject: Re: [PATCH] drm: Split out drm_probe_helper.h To: Daniel Vetter X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190115_193026_208512_99399BC6 X-CRM114-Status: GOOD ( 15.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau , DRI Development , "open list:VIRTIO CORE, NET..." , Laurent Pinchart , Benjamin Gaignard , Daniel Vetter , Sam Ravnborg , linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx list , linux-rockchip@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-arm-msm , Intel Graphics Development , etnaviv@lists.freedesktop.org, Jani Nikula , linux-mediatek@lists.infradead.org, Rodrigo Vivi , linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xen.org, linux-renesas-soc@vger.kernel.org, freedreno Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 15, 2019 at 5:41 AM Daniel Vetter wrote: > > Having the probe helper stuff (which pretty much everyone needs) in > the drm_crtc_helper.h file (which atomic drivers should never need) is > confusing. Split them out. > > To make sure I actually achieved the goal here I went through all > drivers. And indeed, all atomic drivers are now free of > drm_crtc_helper.h includes. > > v2: Make it compile. There was so much compile fail on arm drivers > that I figured I'll better not include any of the acks on v1. > > v3: Massive rebase because i915 has lost a lot of drmP.h includes, but > not all: Through drm_crtc_helper.h > drm_modeset_helper.h -> drmP.h > there was still one, which this patch largely removes. Which means > rolling out lots more includes all over. > > This will also conflict with ongoing drmP.h cleanup by others I > expect. > > v3: Rebase on top of atomic bochs. > > Cc: Sam Ravnborg > Cc: Jani Nikula > Cc: Laurent Pinchart > Acked-by: Rodrigo Vivi (v2) > Acked-by: Benjamin Gaignard (v2) > Signed-off-by: Daniel Vetter > Cc: linux-arm-kernel@lists.infradead.org > Cc: virtualization@lists.linux-foundation.org > Cc: etnaviv@lists.freedesktop.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: intel-gfx@lists.freedesktop.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-arm-msm@vger.kernel.org > Cc: freedreno@lists.freedesktop.org > Cc: nouveau@lists.freedesktop.org > Cc: spice-devel@lists.freedesktop.org > Cc: amd-gfx@lists.freedesktop.org > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-tegra@vger.kernel.org > Cc: xen-devel@lists.xen.org > --- > Merging this is going to be a bit a mess due to all the ongoing drmP.h > cleanups. I think the following should work: > - Apply Sam's prep patches for removing drmP.h from > drm_modeset_helper.h > - Get the i915 drmP.h cleanup backmerged into drm-misc-next > - Apply this patch. > - Apply Sam's patch to remove drmP.h from drm_modeset_helper.h > - All through drm-misc-next, which has some potential for trivial > conflicts around #includes with other drivers unfortunately. > > I hope there's no other driver who'll blow up accidentally because > someone else is doing a drmP.h cleanup. Laurent maybe? > > Jani, ack on this? > -Daniel amdgpu and radeon: Acked-by: Alex Deucher _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA542C43612 for ; Wed, 16 Jan 2019 03:30:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B5B0204FD for ; Wed, 16 Jan 2019 03:30:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TFb4pOaC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uFLLHJdd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B5B0204FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bo6rtk+PwBXGwcIN5AeJFuYY86ArnheYKdhXhnQU2Gw=; b=TFb4pOaCXb59g8 f6e4f/j9Ya3+YuDc9yvOnYwIPvJqjqcfZrjtWPrJQ7YYaxAkYjYfuunA4V2yINgY8X2AeHnptREqf rfuvbmFPjES0TroW8qhANGhorbQzKjvD6VO1ji5CVZlru1qceQd1poq9pwMLSxwBwzERZLPSJTWJX w49T4Tnz179K1tN0vhyn7aAKngK5x3CZGDjSRA/38tQ5fAuciI9Ot4dWdZLY8Ta04LQLP81rHIgCI iEPrEaCN+dunwO44Iu7UYJT2EUPiYbKAT/XLsqv/6BwbznYcLUSiqXJ8nAFlNQgYyG3qgzURYj2T8 wYGemQtzKZE+s1lKiyYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gjbuQ-0005Pg-TL; Wed, 16 Jan 2019 03:30:30 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gjbuM-0005OH-5T; Wed, 16 Jan 2019 03:30:27 +0000 Received: by mail-wr1-x442.google.com with SMTP id t6so5220857wrr.12; Tue, 15 Jan 2019 19:30:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DAB7bOvCpjeEgqAU23iWSznTCf2WSBgkvOBydTcb6wI=; b=uFLLHJddp3hHH4nf6OgRarrAc4KoBIr18Rg8TI2mRyVZwatnUMvF8Oz2lx8HRiQ43K 60CBvCl/+IJbH40zxdlD1OCusEm/kNHS1bLeKkz9ksUjPUIdF6EF0TvnHH3fRlJh9Mxi JFrGHdknEZWggYUo8qkgdxFvjcsDDsiPZsOq7xHrLN8gDyYX1SX8eN8l4nvSWhhBU+Jx vADM7lSxRTt9/G8iXSbxhnMMJHxGkLYUpi/UHI501Hgr6ZLNijXRqSPqr+wHTjoD02gn 5T47olbOz3ahOnG/2xJgXfwJH1rTtVv5zLYfuJ1eZYWfHhOwRhgawQmxExSqitbHTpSK dpkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DAB7bOvCpjeEgqAU23iWSznTCf2WSBgkvOBydTcb6wI=; b=Nbpa/GtwfQ1DCKtgiRclj3res4CWCQV3QDACHGLTi86COqsL1ry01jlMTWdNaa51JG /hafoCFa/cSHPoTkue9pa1pARRnrly75fVSqTCcms7u2Kx2IzYXMp9537cD0Nuj2v5y9 ZyDPi7DbN74cm7e7+zWLaJKEWw7ChR3Qg0YYq5lrzu8B/5ly2J2GJBQICSBxawKpGZKg i8mCO5zljCe6aCzBvPTZhwBbrLpsVN07xetswy8NZwF+SEl8SVx6rn88M2KZPI+eYdzk DUGJ41Z1TWVSMK1JoZnyh5eFPOXfUBuhB5DyHKR1knOCgEJE2iL/y6owGf4ReaRz32V5 pAWw== X-Gm-Message-State: AJcUukfSAtFLNlnTxuDB87OaswpefIoj4H02K88FnWkG3JEWOlts3x+d YDLEof9xDC3bODFgJqMjhZ+KSXN8MIfp1yU9v8k= X-Google-Smtp-Source: ALg8bN7cxSJGppag4xxGzhM4PxdbCoQCVPdZ0OtFy2Ew9NaqrdEByk31K9k1/6DgDg1uk9zX2XiehKYFhzIF7C9uslQ= X-Received: by 2002:a5d:488f:: with SMTP id g15mr5564831wrq.15.1547609423651; Tue, 15 Jan 2019 19:30:23 -0800 (PST) MIME-Version: 1.0 References: <20190115104137.25695-1-daniel.vetter@ffwll.ch> In-Reply-To: <20190115104137.25695-1-daniel.vetter@ffwll.ch> From: Alex Deucher Date: Tue, 15 Jan 2019 22:30:11 -0500 Message-ID: Subject: Re: [PATCH] drm: Split out drm_probe_helper.h To: Daniel Vetter X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190115_193026_208512_99399BC6 X-CRM114-Status: GOOD ( 15.17 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau , DRI Development , "open list:VIRTIO CORE, NET..." , Laurent Pinchart , Benjamin Gaignard , Daniel Vetter , Sam Ravnborg , linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx list , linux-rockchip@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-arm-msm , Intel Graphics Development , etnaviv@lists.freedesktop.org, Jani Nikula , linux-mediatek@lists.infradead.org, Rodrigo Vivi , linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xen.org, linux-renesas-soc@vger.kernel.org, freedreno Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Tue, Jan 15, 2019 at 5:41 AM Daniel Vetter wrote: > > Having the probe helper stuff (which pretty much everyone needs) in > the drm_crtc_helper.h file (which atomic drivers should never need) is > confusing. Split them out. > > To make sure I actually achieved the goal here I went through all > drivers. And indeed, all atomic drivers are now free of > drm_crtc_helper.h includes. > > v2: Make it compile. There was so much compile fail on arm drivers > that I figured I'll better not include any of the acks on v1. > > v3: Massive rebase because i915 has lost a lot of drmP.h includes, but > not all: Through drm_crtc_helper.h > drm_modeset_helper.h -> drmP.h > there was still one, which this patch largely removes. Which means > rolling out lots more includes all over. > > This will also conflict with ongoing drmP.h cleanup by others I > expect. > > v3: Rebase on top of atomic bochs. > > Cc: Sam Ravnborg > Cc: Jani Nikula > Cc: Laurent Pinchart > Acked-by: Rodrigo Vivi (v2) > Acked-by: Benjamin Gaignard (v2) > Signed-off-by: Daniel Vetter > Cc: linux-arm-kernel@lists.infradead.org > Cc: virtualization@lists.linux-foundation.org > Cc: etnaviv@lists.freedesktop.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: intel-gfx@lists.freedesktop.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-arm-msm@vger.kernel.org > Cc: freedreno@lists.freedesktop.org > Cc: nouveau@lists.freedesktop.org > Cc: spice-devel@lists.freedesktop.org > Cc: amd-gfx@lists.freedesktop.org > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-tegra@vger.kernel.org > Cc: xen-devel@lists.xen.org > --- > Merging this is going to be a bit a mess due to all the ongoing drmP.h > cleanups. I think the following should work: > - Apply Sam's prep patches for removing drmP.h from > drm_modeset_helper.h > - Get the i915 drmP.h cleanup backmerged into drm-misc-next > - Apply this patch. > - Apply Sam's patch to remove drmP.h from drm_modeset_helper.h > - All through drm-misc-next, which has some potential for trivial > conflicts around #includes with other drivers unfortunately. > > I hope there's no other driver who'll blow up accidentally because > someone else is doing a drmP.h cleanup. Laurent maybe? > > Jani, ack on this? > -Daniel amdgpu and radeon: Acked-by: Alex Deucher _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic