* [PATCH] drm/amd/display: Reduce stack size in the mode support function
@ 2022-07-22 17:56 Rodrigo Siqueira
2022-07-22 18:12 ` Alex Deucher
0 siblings, 1 reply; 6+ messages in thread
From: Rodrigo Siqueira @ 2022-07-22 17:56 UTC (permalink / raw)
To: amd-gfx; +Cc: Alex Deucher, Stephen Rothwell, Aurabindo Pillai, Harry Wentland
When we use the allmodconfig option we see the following error:
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function 'dml32_ModeSupportAndSystemConfigurationFull':
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:3799:1: error: the frame size of 2464 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
3799 | } // ModeSupportAndSystemConfigurationFull
This commit fixes this issue by moving part of the mode support
operation from ModeSupportAndSystemConfigurationFull to a dedicated
function.
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
---
.../dc/dml/dcn32/display_mode_vba_32.c | 132 ++++++++++--------
1 file changed, 70 insertions(+), 62 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c
index 573504de1789..465fd240b8fb 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c
@@ -1654,6 +1654,75 @@ static void DISPCLKDPPCLKDCFCLKDeepSleepPrefetchParametersWatermarksAndPerforman
#endif
}
+static void mode_support_configuration(struct vba_vars_st *v,
+ struct display_mode_lib *mode_lib)
+{
+ int i, j;
+
+ for (i = v->soc.num_states - 1; i >= 0; i--) {
+ for (j = 0; j < 2; j++) {
+ if (mode_lib->vba.ScaleRatioAndTapsSupport == true
+ && mode_lib->vba.SourceFormatPixelAndScanSupport == true
+ && mode_lib->vba.ViewportSizeSupport[i][j] == true
+ && !mode_lib->vba.LinkRateDoesNotMatchDPVersion
+ && !mode_lib->vba.LinkRateForMultistreamNotIndicated
+ && !mode_lib->vba.BPPForMultistreamNotIndicated
+ && !mode_lib->vba.MultistreamWithHDMIOreDP
+ && !mode_lib->vba.ExceededMultistreamSlots[i]
+ && !mode_lib->vba.MSOOrODMSplitWithNonDPLink
+ && !mode_lib->vba.NotEnoughLanesForMSO
+ && mode_lib->vba.LinkCapacitySupport[i] == true && !mode_lib->vba.P2IWith420
+ && !mode_lib->vba.DSCOnlyIfNecessaryWithBPP
+ && !mode_lib->vba.DSC422NativeNotSupported
+ && !mode_lib->vba.MPCCombineMethodIncompatible
+ && mode_lib->vba.ODMCombine2To1SupportCheckOK[i] == true
+ && mode_lib->vba.ODMCombine4To1SupportCheckOK[i] == true
+ && mode_lib->vba.NotEnoughDSCUnits[i] == false
+ && !mode_lib->vba.NotEnoughDSCSlices[i]
+ && !mode_lib->vba.ImmediateFlipOrHostVMAndPStateWithMALLFullFrameOrPhantomPipe
+ && !mode_lib->vba.InvalidCombinationOfMALLUseForPStateAndStaticScreen
+ && mode_lib->vba.DSCCLKRequiredMoreThanSupported[i] == false
+ && mode_lib->vba.PixelsPerLinePerDSCUnitSupport[i]
+ && mode_lib->vba.DTBCLKRequiredMoreThanSupported[i] == false
+ && !mode_lib->vba.InvalidCombinationOfMALLUseForPState
+ && !mode_lib->vba.ImmediateFlipRequiredButTheRequirementForEachSurfaceIsNotSpecified
+ && mode_lib->vba.ROBSupport[i][j] == true
+ && mode_lib->vba.DISPCLK_DPPCLK_Support[i][j] == true
+ && mode_lib->vba.TotalAvailablePipesSupport[i][j] == true
+ && mode_lib->vba.NumberOfOTGSupport == true
+ && mode_lib->vba.NumberOfHDMIFRLSupport == true
+ && mode_lib->vba.EnoughWritebackUnits == true
+ && mode_lib->vba.WritebackLatencySupport == true
+ && mode_lib->vba.WritebackScaleRatioAndTapsSupport == true
+ && mode_lib->vba.CursorSupport == true && mode_lib->vba.PitchSupport == true
+ && mode_lib->vba.ViewportExceedsSurface == false
+ && mode_lib->vba.PrefetchSupported[i][j] == true
+ && mode_lib->vba.VActiveBandwithSupport[i][j] == true
+ && mode_lib->vba.DynamicMetadataSupported[i][j] == true
+ && mode_lib->vba.TotalVerticalActiveBandwidthSupport[i][j] == true
+ && mode_lib->vba.VRatioInPrefetchSupported[i][j] == true
+ && mode_lib->vba.PTEBufferSizeNotExceeded[i][j] == true
+ && mode_lib->vba.DCCMetaBufferSizeNotExceeded[i][j] == true
+ && mode_lib->vba.NonsupportedDSCInputBPC == false
+ && !mode_lib->vba.ExceededMALLSize
+ && ((mode_lib->vba.HostVMEnable == false
+ && !mode_lib->vba.ImmediateFlipRequiredFinal)
+ || mode_lib->vba.ImmediateFlipSupportedForState[i][j])
+ && (!mode_lib->vba.DRAMClockChangeRequirementFinal
+ || i == v->soc.num_states - 1
+ || mode_lib->vba.DRAMClockChangeSupport[i][j] != dm_dram_clock_change_unsupported)
+ && (!mode_lib->vba.FCLKChangeRequirementFinal || i == v->soc.num_states - 1
+ || mode_lib->vba.FCLKChangeSupport[i][j] != dm_fclock_change_unsupported)
+ && (!mode_lib->vba.USRRetrainingRequiredFinal
+ || &mode_lib->vba.USRRetrainingSupport[i][j])) {
+ mode_lib->vba.ModeSupport[i][j] = true;
+ } else {
+ mode_lib->vba.ModeSupport[i][j] = false;
+ }
+ }
+ }
+}
+
void dml32_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_lib)
{
struct vba_vars_st *v = &mode_lib->vba;
@@ -3632,68 +3701,7 @@ void dml32_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l
}
/*Mode Support, Voltage State and SOC Configuration*/
- for (i = v->soc.num_states - 1; i >= 0; i--) {
- for (j = 0; j < 2; j++) {
- if (mode_lib->vba.ScaleRatioAndTapsSupport == true
- && mode_lib->vba.SourceFormatPixelAndScanSupport == true
- && mode_lib->vba.ViewportSizeSupport[i][j] == true
- && !mode_lib->vba.LinkRateDoesNotMatchDPVersion
- && !mode_lib->vba.LinkRateForMultistreamNotIndicated
- && !mode_lib->vba.BPPForMultistreamNotIndicated
- && !mode_lib->vba.MultistreamWithHDMIOreDP
- && !mode_lib->vba.ExceededMultistreamSlots[i]
- && !mode_lib->vba.MSOOrODMSplitWithNonDPLink
- && !mode_lib->vba.NotEnoughLanesForMSO
- && mode_lib->vba.LinkCapacitySupport[i] == true && !mode_lib->vba.P2IWith420
- && !mode_lib->vba.DSCOnlyIfNecessaryWithBPP
- && !mode_lib->vba.DSC422NativeNotSupported
- && !mode_lib->vba.MPCCombineMethodIncompatible
- && mode_lib->vba.ODMCombine2To1SupportCheckOK[i] == true
- && mode_lib->vba.ODMCombine4To1SupportCheckOK[i] == true
- && mode_lib->vba.NotEnoughDSCUnits[i] == false
- && !mode_lib->vba.NotEnoughDSCSlices[i]
- && !mode_lib->vba.ImmediateFlipOrHostVMAndPStateWithMALLFullFrameOrPhantomPipe
- && !mode_lib->vba.InvalidCombinationOfMALLUseForPStateAndStaticScreen
- && mode_lib->vba.DSCCLKRequiredMoreThanSupported[i] == false
- && mode_lib->vba.PixelsPerLinePerDSCUnitSupport[i]
- && mode_lib->vba.DTBCLKRequiredMoreThanSupported[i] == false
- && !mode_lib->vba.InvalidCombinationOfMALLUseForPState
- && !mode_lib->vba.ImmediateFlipRequiredButTheRequirementForEachSurfaceIsNotSpecified
- && mode_lib->vba.ROBSupport[i][j] == true
- && mode_lib->vba.DISPCLK_DPPCLK_Support[i][j] == true
- && mode_lib->vba.TotalAvailablePipesSupport[i][j] == true
- && mode_lib->vba.NumberOfOTGSupport == true
- && mode_lib->vba.NumberOfHDMIFRLSupport == true
- && mode_lib->vba.EnoughWritebackUnits == true
- && mode_lib->vba.WritebackLatencySupport == true
- && mode_lib->vba.WritebackScaleRatioAndTapsSupport == true
- && mode_lib->vba.CursorSupport == true && mode_lib->vba.PitchSupport == true
- && mode_lib->vba.ViewportExceedsSurface == false
- && mode_lib->vba.PrefetchSupported[i][j] == true
- && mode_lib->vba.VActiveBandwithSupport[i][j] == true
- && mode_lib->vba.DynamicMetadataSupported[i][j] == true
- && mode_lib->vba.TotalVerticalActiveBandwidthSupport[i][j] == true
- && mode_lib->vba.VRatioInPrefetchSupported[i][j] == true
- && mode_lib->vba.PTEBufferSizeNotExceeded[i][j] == true
- && mode_lib->vba.DCCMetaBufferSizeNotExceeded[i][j] == true
- && mode_lib->vba.NonsupportedDSCInputBPC == false
- && !mode_lib->vba.ExceededMALLSize
- && ((mode_lib->vba.HostVMEnable == false
- && !mode_lib->vba.ImmediateFlipRequiredFinal)
- || mode_lib->vba.ImmediateFlipSupportedForState[i][j])
- && (!mode_lib->vba.DRAMClockChangeRequirementFinal
- || i == v->soc.num_states - 1
- || mode_lib->vba.DRAMClockChangeSupport[i][j] != dm_dram_clock_change_unsupported)
- && (!mode_lib->vba.FCLKChangeRequirementFinal || i == v->soc.num_states - 1
- || mode_lib->vba.FCLKChangeSupport[i][j] != dm_fclock_change_unsupported)
- && (!mode_lib->vba.USRRetrainingRequiredFinal
- || &mode_lib->vba.USRRetrainingSupport[i][j])) {
- mode_lib->vba.ModeSupport[i][j] = true;
- } else {
- mode_lib->vba.ModeSupport[i][j] = false;
- }
- }
- }
+ mode_support_configuration(v, mode_lib);
MaximumMPCCombine = 0;
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: Reduce stack size in the mode support function
2022-07-22 17:56 [PATCH] drm/amd/display: Reduce stack size in the mode support function Rodrigo Siqueira
@ 2022-07-22 18:12 ` Alex Deucher
2022-07-24 21:41 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Alex Deucher @ 2022-07-22 18:12 UTC (permalink / raw)
To: Rodrigo Siqueira
Cc: Alex Deucher, Stephen Rothwell, Aurabindo Pillai, Harry Wentland,
amd-gfx
On Fri, Jul 22, 2022 at 1:56 PM Rodrigo Siqueira
<Rodrigo.Siqueira@amd.com> wrote:
>
> When we use the allmodconfig option we see the following error:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function 'dml32_ModeSupportAndSystemConfigurationFull':
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:3799:1: error: the frame size of 2464 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> 3799 | } // ModeSupportAndSystemConfigurationFull
>
> This commit fixes this issue by moving part of the mode support
> operation from ModeSupportAndSystemConfigurationFull to a dedicated
> function.
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Thanks for sorting this out!
Acked-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> .../dc/dml/dcn32/display_mode_vba_32.c | 132 ++++++++++--------
> 1 file changed, 70 insertions(+), 62 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c
> index 573504de1789..465fd240b8fb 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c
> @@ -1654,6 +1654,75 @@ static void DISPCLKDPPCLKDCFCLKDeepSleepPrefetchParametersWatermarksAndPerforman
> #endif
> }
>
> +static void mode_support_configuration(struct vba_vars_st *v,
> + struct display_mode_lib *mode_lib)
> +{
> + int i, j;
> +
> + for (i = v->soc.num_states - 1; i >= 0; i--) {
> + for (j = 0; j < 2; j++) {
> + if (mode_lib->vba.ScaleRatioAndTapsSupport == true
> + && mode_lib->vba.SourceFormatPixelAndScanSupport == true
> + && mode_lib->vba.ViewportSizeSupport[i][j] == true
> + && !mode_lib->vba.LinkRateDoesNotMatchDPVersion
> + && !mode_lib->vba.LinkRateForMultistreamNotIndicated
> + && !mode_lib->vba.BPPForMultistreamNotIndicated
> + && !mode_lib->vba.MultistreamWithHDMIOreDP
> + && !mode_lib->vba.ExceededMultistreamSlots[i]
> + && !mode_lib->vba.MSOOrODMSplitWithNonDPLink
> + && !mode_lib->vba.NotEnoughLanesForMSO
> + && mode_lib->vba.LinkCapacitySupport[i] == true && !mode_lib->vba.P2IWith420
> + && !mode_lib->vba.DSCOnlyIfNecessaryWithBPP
> + && !mode_lib->vba.DSC422NativeNotSupported
> + && !mode_lib->vba.MPCCombineMethodIncompatible
> + && mode_lib->vba.ODMCombine2To1SupportCheckOK[i] == true
> + && mode_lib->vba.ODMCombine4To1SupportCheckOK[i] == true
> + && mode_lib->vba.NotEnoughDSCUnits[i] == false
> + && !mode_lib->vba.NotEnoughDSCSlices[i]
> + && !mode_lib->vba.ImmediateFlipOrHostVMAndPStateWithMALLFullFrameOrPhantomPipe
> + && !mode_lib->vba.InvalidCombinationOfMALLUseForPStateAndStaticScreen
> + && mode_lib->vba.DSCCLKRequiredMoreThanSupported[i] == false
> + && mode_lib->vba.PixelsPerLinePerDSCUnitSupport[i]
> + && mode_lib->vba.DTBCLKRequiredMoreThanSupported[i] == false
> + && !mode_lib->vba.InvalidCombinationOfMALLUseForPState
> + && !mode_lib->vba.ImmediateFlipRequiredButTheRequirementForEachSurfaceIsNotSpecified
> + && mode_lib->vba.ROBSupport[i][j] == true
> + && mode_lib->vba.DISPCLK_DPPCLK_Support[i][j] == true
> + && mode_lib->vba.TotalAvailablePipesSupport[i][j] == true
> + && mode_lib->vba.NumberOfOTGSupport == true
> + && mode_lib->vba.NumberOfHDMIFRLSupport == true
> + && mode_lib->vba.EnoughWritebackUnits == true
> + && mode_lib->vba.WritebackLatencySupport == true
> + && mode_lib->vba.WritebackScaleRatioAndTapsSupport == true
> + && mode_lib->vba.CursorSupport == true && mode_lib->vba.PitchSupport == true
> + && mode_lib->vba.ViewportExceedsSurface == false
> + && mode_lib->vba.PrefetchSupported[i][j] == true
> + && mode_lib->vba.VActiveBandwithSupport[i][j] == true
> + && mode_lib->vba.DynamicMetadataSupported[i][j] == true
> + && mode_lib->vba.TotalVerticalActiveBandwidthSupport[i][j] == true
> + && mode_lib->vba.VRatioInPrefetchSupported[i][j] == true
> + && mode_lib->vba.PTEBufferSizeNotExceeded[i][j] == true
> + && mode_lib->vba.DCCMetaBufferSizeNotExceeded[i][j] == true
> + && mode_lib->vba.NonsupportedDSCInputBPC == false
> + && !mode_lib->vba.ExceededMALLSize
> + && ((mode_lib->vba.HostVMEnable == false
> + && !mode_lib->vba.ImmediateFlipRequiredFinal)
> + || mode_lib->vba.ImmediateFlipSupportedForState[i][j])
> + && (!mode_lib->vba.DRAMClockChangeRequirementFinal
> + || i == v->soc.num_states - 1
> + || mode_lib->vba.DRAMClockChangeSupport[i][j] != dm_dram_clock_change_unsupported)
> + && (!mode_lib->vba.FCLKChangeRequirementFinal || i == v->soc.num_states - 1
> + || mode_lib->vba.FCLKChangeSupport[i][j] != dm_fclock_change_unsupported)
> + && (!mode_lib->vba.USRRetrainingRequiredFinal
> + || &mode_lib->vba.USRRetrainingSupport[i][j])) {
> + mode_lib->vba.ModeSupport[i][j] = true;
> + } else {
> + mode_lib->vba.ModeSupport[i][j] = false;
> + }
> + }
> + }
> +}
> +
> void dml32_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_lib)
> {
> struct vba_vars_st *v = &mode_lib->vba;
> @@ -3632,68 +3701,7 @@ void dml32_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l
> }
>
> /*Mode Support, Voltage State and SOC Configuration*/
> - for (i = v->soc.num_states - 1; i >= 0; i--) {
> - for (j = 0; j < 2; j++) {
> - if (mode_lib->vba.ScaleRatioAndTapsSupport == true
> - && mode_lib->vba.SourceFormatPixelAndScanSupport == true
> - && mode_lib->vba.ViewportSizeSupport[i][j] == true
> - && !mode_lib->vba.LinkRateDoesNotMatchDPVersion
> - && !mode_lib->vba.LinkRateForMultistreamNotIndicated
> - && !mode_lib->vba.BPPForMultistreamNotIndicated
> - && !mode_lib->vba.MultistreamWithHDMIOreDP
> - && !mode_lib->vba.ExceededMultistreamSlots[i]
> - && !mode_lib->vba.MSOOrODMSplitWithNonDPLink
> - && !mode_lib->vba.NotEnoughLanesForMSO
> - && mode_lib->vba.LinkCapacitySupport[i] == true && !mode_lib->vba.P2IWith420
> - && !mode_lib->vba.DSCOnlyIfNecessaryWithBPP
> - && !mode_lib->vba.DSC422NativeNotSupported
> - && !mode_lib->vba.MPCCombineMethodIncompatible
> - && mode_lib->vba.ODMCombine2To1SupportCheckOK[i] == true
> - && mode_lib->vba.ODMCombine4To1SupportCheckOK[i] == true
> - && mode_lib->vba.NotEnoughDSCUnits[i] == false
> - && !mode_lib->vba.NotEnoughDSCSlices[i]
> - && !mode_lib->vba.ImmediateFlipOrHostVMAndPStateWithMALLFullFrameOrPhantomPipe
> - && !mode_lib->vba.InvalidCombinationOfMALLUseForPStateAndStaticScreen
> - && mode_lib->vba.DSCCLKRequiredMoreThanSupported[i] == false
> - && mode_lib->vba.PixelsPerLinePerDSCUnitSupport[i]
> - && mode_lib->vba.DTBCLKRequiredMoreThanSupported[i] == false
> - && !mode_lib->vba.InvalidCombinationOfMALLUseForPState
> - && !mode_lib->vba.ImmediateFlipRequiredButTheRequirementForEachSurfaceIsNotSpecified
> - && mode_lib->vba.ROBSupport[i][j] == true
> - && mode_lib->vba.DISPCLK_DPPCLK_Support[i][j] == true
> - && mode_lib->vba.TotalAvailablePipesSupport[i][j] == true
> - && mode_lib->vba.NumberOfOTGSupport == true
> - && mode_lib->vba.NumberOfHDMIFRLSupport == true
> - && mode_lib->vba.EnoughWritebackUnits == true
> - && mode_lib->vba.WritebackLatencySupport == true
> - && mode_lib->vba.WritebackScaleRatioAndTapsSupport == true
> - && mode_lib->vba.CursorSupport == true && mode_lib->vba.PitchSupport == true
> - && mode_lib->vba.ViewportExceedsSurface == false
> - && mode_lib->vba.PrefetchSupported[i][j] == true
> - && mode_lib->vba.VActiveBandwithSupport[i][j] == true
> - && mode_lib->vba.DynamicMetadataSupported[i][j] == true
> - && mode_lib->vba.TotalVerticalActiveBandwidthSupport[i][j] == true
> - && mode_lib->vba.VRatioInPrefetchSupported[i][j] == true
> - && mode_lib->vba.PTEBufferSizeNotExceeded[i][j] == true
> - && mode_lib->vba.DCCMetaBufferSizeNotExceeded[i][j] == true
> - && mode_lib->vba.NonsupportedDSCInputBPC == false
> - && !mode_lib->vba.ExceededMALLSize
> - && ((mode_lib->vba.HostVMEnable == false
> - && !mode_lib->vba.ImmediateFlipRequiredFinal)
> - || mode_lib->vba.ImmediateFlipSupportedForState[i][j])
> - && (!mode_lib->vba.DRAMClockChangeRequirementFinal
> - || i == v->soc.num_states - 1
> - || mode_lib->vba.DRAMClockChangeSupport[i][j] != dm_dram_clock_change_unsupported)
> - && (!mode_lib->vba.FCLKChangeRequirementFinal || i == v->soc.num_states - 1
> - || mode_lib->vba.FCLKChangeSupport[i][j] != dm_fclock_change_unsupported)
> - && (!mode_lib->vba.USRRetrainingRequiredFinal
> - || &mode_lib->vba.USRRetrainingSupport[i][j])) {
> - mode_lib->vba.ModeSupport[i][j] = true;
> - } else {
> - mode_lib->vba.ModeSupport[i][j] = false;
> - }
> - }
> - }
> + mode_support_configuration(v, mode_lib);
>
> MaximumMPCCombine = 0;
>
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: Reduce stack size in the mode support function
2022-07-22 18:12 ` Alex Deucher
@ 2022-07-24 21:41 ` Stephen Rothwell
2022-07-24 21:45 ` Stephen Rothwell
2022-07-27 16:27 ` Rodrigo Siqueira Jordao
0 siblings, 2 replies; 6+ messages in thread
From: Stephen Rothwell @ 2022-07-24 21:41 UTC (permalink / raw)
To: Alex Deucher
Cc: Stephen Rothwell, Rodrigo Siqueira, amd-gfx, Aurabindo Pillai,
Alex Deucher, Harry Wentland
[-- Attachment #1: Type: text/plain, Size: 1719 bytes --]
Hi all,
On Fri, 22 Jul 2022 14:12:44 -0400 Alex Deucher <alexdeucher@gmail.com> wrote:
>
> On Fri, Jul 22, 2022 at 1:56 PM Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> wrote:
> >
> > When we use the allmodconfig option we see the following error:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function 'dml32_ModeSupportAndSystemConfigurationFull':
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:3799:1: error: the frame size of 2464 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> > 3799 | } // ModeSupportAndSystemConfigurationFull
> >
> > This commit fixes this issue by moving part of the mode support
> > operation from ModeSupportAndSystemConfigurationFull to a dedicated
> > function.
> >
> > Cc: Harry Wentland <harry.wentland@amd.com>
> > Cc: Alex Deucher <alexander.deucher@amd.com>
> > Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
> > Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> > Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>
> Thanks for sorting this out!
> Acked-by: Alex Deucher <alexander.deucher@amd.com>
Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
Also, after applying the above patch, the following commits are no
longer needed:
987949933127 drm/amd/display: reduce stack for dml32_CalculatePrefetchSchedule
8f08cd32b767 drm/amd/display: reduce stack for dml32_CalculateWatermarksMALLUseAndDRAMSpeedChangeSupport
5d526d124fe3 drm/amd/display: reduce stack for dml32_CalculateVMRowAndSwath
f6ceebcc7825 drm/amd/display: reduce stack for dml32_CalculateSwathAndDETConfiguration
and could be reverted (or removed).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: Reduce stack size in the mode support function
2022-07-24 21:41 ` Stephen Rothwell
@ 2022-07-24 21:45 ` Stephen Rothwell
2022-07-27 16:27 ` Rodrigo Siqueira Jordao
1 sibling, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2022-07-24 21:45 UTC (permalink / raw)
To: Alex Deucher
Cc: Alex Deucher, Harry Wentland, Aurabindo Pillai, Rodrigo Siqueira,
amd-gfx
[-- Attachment #1: Type: text/plain, Size: 2259 bytes --]
Hi all,
On Mon, 25 Jul 2022 07:41:09 +1000 Stephen Rothwell <sfr@rothwell.id.au> wrote:
>
> On Fri, 22 Jul 2022 14:12:44 -0400 Alex Deucher <alexdeucher@gmail.com> wrote:
> >
> > On Fri, Jul 22, 2022 at 1:56 PM Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> wrote:
> > >
> > > When we use the allmodconfig option we see the following error:
> > >
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function 'dml32_ModeSupportAndSystemConfigurationFull':
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:3799:1: error: the frame size of 2464 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> > > 3799 | } // ModeSupportAndSystemConfigurationFull
> > >
> > > This commit fixes this issue by moving part of the mode support
> > > operation from ModeSupportAndSystemConfigurationFull to a dedicated
> > > function.
> > >
> > > Cc: Harry Wentland <harry.wentland@amd.com>
> > > Cc: Alex Deucher <alexander.deucher@amd.com>
> > > Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
> > > Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> > > Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> >
> > Thanks for sorting this out!
> > Acked-by: Alex Deucher <alexander.deucher@amd.com>
>
> Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Also, after applying the above patch, the following commits are no
> longer needed:
>
> 987949933127 drm/amd/display: reduce stack for dml32_CalculatePrefetchSchedule
> 8f08cd32b767 drm/amd/display: reduce stack for dml32_CalculateWatermarksMALLUseAndDRAMSpeedChangeSupport
> 5d526d124fe3 drm/amd/display: reduce stack for dml32_CalculateVMRowAndSwath
> f6ceebcc7825 drm/amd/display: reduce stack for dml32_CalculateSwathAndDETConfiguration
>
> and could be reverted (or removed).
Actually, they are now:
2623c2c90981 drm/amd/display: reduce stack for dml32_CalculatePrefetchSchedule
7d5c4fd7c543 drm/amd/display: reduce stack for dml32_CalculateWatermarksMALLUseAndDRAMSpeedChangeSupport
65f946cee7be drm/amd/display: reduce stack for dml32_CalculateVMRowAndSwath
d35fa7f64f4f drm/amd/display: reduce stack for dml32_CalculateSwathAndDETConfiguration
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: Reduce stack size in the mode support function
2022-07-24 21:41 ` Stephen Rothwell
2022-07-24 21:45 ` Stephen Rothwell
@ 2022-07-27 16:27 ` Rodrigo Siqueira Jordao
2022-07-27 16:32 ` Alex Deucher
1 sibling, 1 reply; 6+ messages in thread
From: Rodrigo Siqueira Jordao @ 2022-07-27 16:27 UTC (permalink / raw)
To: Stephen Rothwell, Alex Deucher
Cc: Alex Deucher, Stephen Rothwell, Aurabindo Pillai, Harry Wentland,
amd-gfx
On 2022-07-24 17:41, Stephen Rothwell wrote:
> Hi all,
>
> On Fri, 22 Jul 2022 14:12:44 -0400 Alex Deucher <alexdeucher@gmail.com> wrote:
>>
>> On Fri, Jul 22, 2022 at 1:56 PM Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> wrote:
>>>
>>> When we use the allmodconfig option we see the following error:
>>>
>>> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function 'dml32_ModeSupportAndSystemConfigurationFull':
>>> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:3799:1: error: the frame size of 2464 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
>>> 3799 | } // ModeSupportAndSystemConfigurationFull
>>>
>>> This commit fixes this issue by moving part of the mode support
>>> operation from ModeSupportAndSystemConfigurationFull to a dedicated
>>> function.
>>>
>>> Cc: Harry Wentland <harry.wentland@amd.com>
>>> Cc: Alex Deucher <alexander.deucher@amd.com>
>>> Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
>>> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
>>> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>>
>> Thanks for sorting this out!
>> Acked-by: Alex Deucher <alexander.deucher@amd.com>
>
> Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Also, after applying the above patch, the following commits are no
> longer needed:
>
> 987949933127 drm/amd/display: reduce stack for dml32_CalculatePrefetchSchedule
> 8f08cd32b767 drm/amd/display: reduce stack for dml32_CalculateWatermarksMALLUseAndDRAMSpeedChangeSupport
> 5d526d124fe3 drm/amd/display: reduce stack for dml32_CalculateVMRowAndSwath
> f6ceebcc7825 drm/amd/display: reduce stack for dml32_CalculateSwathAndDETConfiguration
>
> and could be reverted (or removed).
Ohhh... that's nice!
Alex, if you don't mind, I would prefer to revert the above patches to
keep things simpler. If it is ok for you, I can prepare the revert patches.
Thanks
Siqueira
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: Reduce stack size in the mode support function
2022-07-27 16:27 ` Rodrigo Siqueira Jordao
@ 2022-07-27 16:32 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2022-07-27 16:32 UTC (permalink / raw)
To: Rodrigo Siqueira Jordao
Cc: Stephen Rothwell, Stephen Rothwell, amd-gfx, Aurabindo Pillai,
Alex Deucher, Harry Wentland
On Wed, Jul 27, 2022 at 12:27 PM Rodrigo Siqueira Jordao
<Rodrigo.Siqueira@amd.com> wrote:
>
>
>
> On 2022-07-24 17:41, Stephen Rothwell wrote:
> > Hi all,
> >
> > On Fri, 22 Jul 2022 14:12:44 -0400 Alex Deucher <alexdeucher@gmail.com> wrote:
> >>
> >> On Fri, Jul 22, 2022 at 1:56 PM Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> wrote:
> >>>
> >>> When we use the allmodconfig option we see the following error:
> >>>
> >>> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function 'dml32_ModeSupportAndSystemConfigurationFull':
> >>> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:3799:1: error: the frame size of 2464 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> >>> 3799 | } // ModeSupportAndSystemConfigurationFull
> >>>
> >>> This commit fixes this issue by moving part of the mode support
> >>> operation from ModeSupportAndSystemConfigurationFull to a dedicated
> >>> function.
> >>>
> >>> Cc: Harry Wentland <harry.wentland@amd.com>
> >>> Cc: Alex Deucher <alexander.deucher@amd.com>
> >>> Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
> >>> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> >>> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> >>
> >> Thanks for sorting this out!
> >> Acked-by: Alex Deucher <alexander.deucher@amd.com>
> >
> > Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
> >
> > Also, after applying the above patch, the following commits are no
> > longer needed:
> >
> > 987949933127 drm/amd/display: reduce stack for dml32_CalculatePrefetchSchedule
> > 8f08cd32b767 drm/amd/display: reduce stack for dml32_CalculateWatermarksMALLUseAndDRAMSpeedChangeSupport
> > 5d526d124fe3 drm/amd/display: reduce stack for dml32_CalculateVMRowAndSwath
> > f6ceebcc7825 drm/amd/display: reduce stack for dml32_CalculateSwathAndDETConfiguration
> >
> > and could be reverted (or removed).
>
> Ohhh... that's nice!
>
> Alex, if you don't mind, I would prefer to revert the above patches to
> keep things simpler. If it is ok for you, I can prepare the revert patches.
Sure. Please go ahead.
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Alex
>
> Thanks
> Siqueira
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-27 16:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-22 17:56 [PATCH] drm/amd/display: Reduce stack size in the mode support function Rodrigo Siqueira
2022-07-22 18:12 ` Alex Deucher
2022-07-24 21:41 ` Stephen Rothwell
2022-07-24 21:45 ` Stephen Rothwell
2022-07-27 16:27 ` Rodrigo Siqueira Jordao
2022-07-27 16:32 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.