From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752470AbbFZRB0 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 26 Jun 2015 13:01:26 -0400
Received: from mail-yk0-f182.google.com ([209.85.160.182]:34248 "EHLO
	mail-yk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751829AbbFZRBZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 26 Jun 2015 13:01:25 -0400
MIME-Version: 1.0
In-Reply-To: <1435305417-3276-1-git-send-email-maninder1.s@samsung.com>
References: <1435305417-3276-1-git-send-email-maninder1.s@samsung.com>
Date: Fri, 26 Jun 2015 13:01:24 -0400
Message-ID: <CADnq5_Of_+3qvZKnBUqexGHfNJxWGmEFJ+MXxhhpv-veLXYCbA@mail.gmail.com>
Subject: Re: [PATCH v2] drm/amdgpu: remove unnecessary check before kfree
From: Alex Deucher <alexdeucher@gmail.com>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: Dave Airlie <airlied@linux.ie>,
        "Deucher, Alexander" <alexander.deucher@amd.com>,
        Christian Koenig <christian.koenig@amd.com>,
        "Zhou, Jammy" <Jammy.Zhou@amd.com>, yanyang1 <young.yang@amd.com>,
        "Li, Samuel" <samuel.li@amd.com>,
        =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= <marek.olsak@amd.com>,
        Maling list - DRI developers 
	<dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>, pankaj.m@samsung.com
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 26, 2015 at 3:56 AM, Maninder Singh <maninder1.s@samsung.com> wrote:
> kfree(NULL) is safe and this check is probably not required
>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Reviewed-by: Vaneet Narang <v.narang@samsung.com>
> Reviewed-by: Christian Konig <christian.koenig@amd.com>

Applied.  thanks!

Alex

> ---
> v2: Chnged shortlog prefix - gpu/amdgpu
>
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index fec487d..a85cd08 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1575,8 +1575,7 @@ void amdgpu_device_fini(struct amdgpu_device *adev)
>         amdgpu_fence_driver_fini(adev);
>         amdgpu_fbdev_fini(adev);
>         r = amdgpu_fini(adev);
> -       if (adev->ip_block_enabled)
> -               kfree(adev->ip_block_enabled);
> +       kfree(adev->ip_block_enabled);
>         adev->ip_block_enabled = NULL;
>         adev->accel_working = false;
>         /* free i2c buses */
> --
> 1.7.9.5
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel