From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751105AbdKBEBz (ORCPT ); Thu, 2 Nov 2017 00:01:55 -0400 Received: from mail-yw0-f194.google.com ([209.85.161.194]:47530 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750704AbdKBEBy (ORCPT ); Thu, 2 Nov 2017 00:01:54 -0400 X-Google-Smtp-Source: ABhQp+RFRogtkTAywwgZj0VK2FEUGQjTXsUzt8z4CQ6vN4TFiAKnkkfkCKUZkLN35d6mkEh4OqHN1DuJhZdjHrNLzZU= MIME-Version: 1.0 In-Reply-To: <20171101140630.2884-1-Liviu.Dudau@arm.com> References: <20171101140630.2884-1-Liviu.Dudau@arm.com> From: Alex Deucher Date: Thu, 2 Nov 2017 00:01:53 -0400 Message-ID: Subject: Re: [PATCH] dma-buf: Cleanup comments on dma_buf_map_attachment() To: Liviu Dudau Cc: Sumit Semwal , LKML , DRI-devel , Linux Media ML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 1, 2017 at 10:06 AM, Liviu Dudau wrote: > Mappings need to be unmapped by calling dma_buf_unmap_attachment() and > not by calling again dma_buf_map_attachment(). Also fix some spelling > mistakes. > > Signed-off-by: Liviu Dudau Reviewed-by: Alex Deucher > --- > drivers/dma-buf/dma-buf.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > index bc1cb284111cb..1792385405f0e 100644 > --- a/drivers/dma-buf/dma-buf.c > +++ b/drivers/dma-buf/dma-buf.c > @@ -351,13 +351,13 @@ static inline int is_dma_buf_file(struct file *file) > * > * 2. Userspace passes this file-descriptors to all drivers it wants this buffer > * to share with: First the filedescriptor is converted to a &dma_buf using > - * dma_buf_get(). The the buffer is attached to the device using > + * dma_buf_get(). Then the buffer is attached to the device using > * dma_buf_attach(). > * > * Up to this stage the exporter is still free to migrate or reallocate the > * backing storage. > * > - * 3. Once the buffer is attached to all devices userspace can inniate DMA > + * 3. Once the buffer is attached to all devices userspace can initiate DMA > * access to the shared buffer. In the kernel this is done by calling > * dma_buf_map_attachment() and dma_buf_unmap_attachment(). > * > @@ -617,7 +617,7 @@ EXPORT_SYMBOL_GPL(dma_buf_detach); > * Returns sg_table containing the scatterlist to be returned; returns ERR_PTR > * on error. May return -EINTR if it is interrupted by a signal. > * > - * A mapping must be unmapped again using dma_buf_map_attachment(). Note that > + * A mapping must be unmapped by using dma_buf_unmap_attachment(). Note that > * the underlying backing storage is pinned for as long as a mapping exists, > * therefore users/importers should not hold onto a mapping for undue amounts of > * time. > -- > 2.14.3 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH] dma-buf: Cleanup comments on dma_buf_map_attachment() Date: Thu, 2 Nov 2017 00:01:53 -0400 Message-ID: References: <20171101140630.2884-1-Liviu.Dudau@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw0-x243.google.com (mail-yw0-x243.google.com [IPv6:2607:f8b0:4002:c05::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 749A06E2AF for ; Thu, 2 Nov 2017 04:01:54 +0000 (UTC) Received: by mail-yw0-x243.google.com with SMTP id q1so3656031ywh.5 for ; Wed, 01 Nov 2017 21:01:54 -0700 (PDT) In-Reply-To: <20171101140630.2884-1-Liviu.Dudau@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Liviu Dudau Cc: Linux Media ML , DRI-devel , LKML List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgMSwgMjAxNyBhdCAxMDowNiBBTSwgTGl2aXUgRHVkYXUgPExpdml1LkR1ZGF1 QGFybS5jb20+IHdyb3RlOgo+IE1hcHBpbmdzIG5lZWQgdG8gYmUgdW5tYXBwZWQgYnkgY2FsbGlu ZyBkbWFfYnVmX3VubWFwX2F0dGFjaG1lbnQoKSBhbmQKPiBub3QgYnkgY2FsbGluZyBhZ2FpbiBk bWFfYnVmX21hcF9hdHRhY2htZW50KCkuIEFsc28gZml4IHNvbWUgc3BlbGxpbmcKPiBtaXN0YWtl cy4KPgo+IFNpZ25lZC1vZmYtYnk6IExpdml1IER1ZGF1IDxsaXZpdS5kdWRhdUBhcm0uY29tPgoK UmV2aWV3ZWQtYnk6IEFsZXggRGV1Y2hlciA8YWxleGFuZGVyLmRldWNoZXJAYW1kLmNvbT4KCj4g LS0tCj4gIGRyaXZlcnMvZG1hLWJ1Zi9kbWEtYnVmLmMgfCA2ICsrKy0tLQo+ICAxIGZpbGUgY2hh bmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZG1hLWJ1Zi9kbWEtYnVmLmMgYi9kcml2ZXJzL2RtYS1idWYvZG1hLWJ1Zi5jCj4gaW5k ZXggYmMxY2IyODQxMTFjYi4uMTc5MjM4NTQwNWYwZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2Rt YS1idWYvZG1hLWJ1Zi5jCj4gKysrIGIvZHJpdmVycy9kbWEtYnVmL2RtYS1idWYuYwo+IEBAIC0z NTEsMTMgKzM1MSwxMyBAQCBzdGF0aWMgaW5saW5lIGludCBpc19kbWFfYnVmX2ZpbGUoc3RydWN0 IGZpbGUgKmZpbGUpCj4gICAqCj4gICAqIDIuIFVzZXJzcGFjZSBwYXNzZXMgdGhpcyBmaWxlLWRl c2NyaXB0b3JzIHRvIGFsbCBkcml2ZXJzIGl0IHdhbnRzIHRoaXMgYnVmZmVyCj4gICAqICAgIHRv IHNoYXJlIHdpdGg6IEZpcnN0IHRoZSBmaWxlZGVzY3JpcHRvciBpcyBjb252ZXJ0ZWQgdG8gYSAm ZG1hX2J1ZiB1c2luZwo+IC0gKiAgICBkbWFfYnVmX2dldCgpLiBUaGUgdGhlIGJ1ZmZlciBpcyBh dHRhY2hlZCB0byB0aGUgZGV2aWNlIHVzaW5nCj4gKyAqICAgIGRtYV9idWZfZ2V0KCkuIFRoZW4g dGhlIGJ1ZmZlciBpcyBhdHRhY2hlZCB0byB0aGUgZGV2aWNlIHVzaW5nCj4gICAqICAgIGRtYV9i dWZfYXR0YWNoKCkuCj4gICAqCj4gICAqICAgIFVwIHRvIHRoaXMgc3RhZ2UgdGhlIGV4cG9ydGVy IGlzIHN0aWxsIGZyZWUgdG8gbWlncmF0ZSBvciByZWFsbG9jYXRlIHRoZQo+ICAgKiAgICBiYWNr aW5nIHN0b3JhZ2UuCj4gICAqCj4gLSAqIDMuIE9uY2UgdGhlIGJ1ZmZlciBpcyBhdHRhY2hlZCB0 byBhbGwgZGV2aWNlcyB1c2Vyc3BhY2UgY2FuIGlubmlhdGUgRE1BCj4gKyAqIDMuIE9uY2UgdGhl IGJ1ZmZlciBpcyBhdHRhY2hlZCB0byBhbGwgZGV2aWNlcyB1c2Vyc3BhY2UgY2FuIGluaXRpYXRl IERNQQo+ICAgKiAgICBhY2Nlc3MgdG8gdGhlIHNoYXJlZCBidWZmZXIuIEluIHRoZSBrZXJuZWwg dGhpcyBpcyBkb25lIGJ5IGNhbGxpbmcKPiAgICogICAgZG1hX2J1Zl9tYXBfYXR0YWNobWVudCgp IGFuZCBkbWFfYnVmX3VubWFwX2F0dGFjaG1lbnQoKS4KPiAgICoKPiBAQCAtNjE3LDcgKzYxNyw3 IEBAIEVYUE9SVF9TWU1CT0xfR1BMKGRtYV9idWZfZGV0YWNoKTsKPiAgICogUmV0dXJucyBzZ190 YWJsZSBjb250YWluaW5nIHRoZSBzY2F0dGVybGlzdCB0byBiZSByZXR1cm5lZDsgcmV0dXJucyBF UlJfUFRSCj4gICAqIG9uIGVycm9yLiBNYXkgcmV0dXJuIC1FSU5UUiBpZiBpdCBpcyBpbnRlcnJ1 cHRlZCBieSBhIHNpZ25hbC4KPiAgICoKPiAtICogQSBtYXBwaW5nIG11c3QgYmUgdW5tYXBwZWQg YWdhaW4gdXNpbmcgZG1hX2J1Zl9tYXBfYXR0YWNobWVudCgpLiBOb3RlIHRoYXQKPiArICogQSBt YXBwaW5nIG11c3QgYmUgdW5tYXBwZWQgYnkgdXNpbmcgZG1hX2J1Zl91bm1hcF9hdHRhY2htZW50 KCkuIE5vdGUgdGhhdAo+ICAgKiB0aGUgdW5kZXJseWluZyBiYWNraW5nIHN0b3JhZ2UgaXMgcGlu bmVkIGZvciBhcyBsb25nIGFzIGEgbWFwcGluZyBleGlzdHMsCj4gICAqIHRoZXJlZm9yZSB1c2Vy cy9pbXBvcnRlcnMgc2hvdWxkIG5vdCBob2xkIG9udG8gYSBtYXBwaW5nIGZvciB1bmR1ZSBhbW91 bnRzIG9mCj4gICAqIHRpbWUuCj4gLS0KPiAyLjE0LjMKPgo+IF9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbApfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK