From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26238C5519F for ; Fri, 20 Nov 2020 22:43:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D45382222A for ; Fri, 20 Nov 2020 22:43:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YnUi7YuN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729218AbgKTWmw (ORCPT ); Fri, 20 Nov 2020 17:42:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728220AbgKTWmv (ORCPT ); Fri, 20 Nov 2020 17:42:51 -0500 Received: from mail-yb1-xb42.google.com (mail-yb1-xb42.google.com [IPv6:2607:f8b0:4864:20::b42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 394D8C0613CF; Fri, 20 Nov 2020 14:42:51 -0800 (PST) Received: by mail-yb1-xb42.google.com with SMTP id 2so9982341ybc.12; Fri, 20 Nov 2020 14:42:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E+/p0vsaZaZ5eJ4n4W/6kpMXGlN10lE2LER/KFN9S5s=; b=YnUi7YuNuw8mKKyydLvw5QmsWlZh9G7Hpn1spIT8RDTKUXYY13Bdxmk2fyzYfaErqE Asbi0nrX6Dkr+ZsTTAmv2yPPxoNN5RBSKqB6jgsNcvaCfd/NyrS79hQRaD+ZjC3hak7i neGJNQiXMdMH2t/nVgmdGZV9/ZEPtbs829cRB1laYEDnvivjitpGDwIofQ2fzZroA62j 5YPYQlzIggcV4spdaMob8NPflrEt4tOAJ9eydFDf162XehoY+LkQmJZyV6enRbfV7zDL RuiTSBs7Lrn3O4YvLm6si/JY31SdwPVSGSV7o18NonKTuaze082T1eyGembEoKNEBVsi 7lFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E+/p0vsaZaZ5eJ4n4W/6kpMXGlN10lE2LER/KFN9S5s=; b=NONkbjWLL8NfMFQ10l59KZxvjGk7eJH6zOWdaxFQxp+VL+kkuRqT/j1YJpYS5t+FlS /abVIJc2Cs6rxhyIzI1c29FwJ0x5Fd89E8vBgd2cRlrqeoBNaZbvnmrMRPl2rNbUnQP7 e3sNDsdxoi3ZrOSkzdFlVF4G15b5kjQyne4J4Qy1yb8TAzPCYka1Zwm+kyBpOO3tWklY vT3bNAvd/qru8hdypUC4rVRtqqP7WAT6OKvZG6CyzfwKKHYnrYCd6lHYd5+A4xp3sjNA mjFHuYafXfMa/wESZaaz0V5TdnWX1IvBbxZJ7sOCSnD4o5le3gSyephLbbXX8TqsTJNa 11Og== X-Gm-Message-State: AOAM533oc1sIc1pVk+1OjKw3+4pOhzjomZm1pjDQWVAy1OB35p2PuB22 ljFHdETTKmB+my6G68onj9x/TELiCQy1AkRZj30= X-Google-Smtp-Source: ABdhPJznvvvinnh9ZMC/o+FJus/kMLARw94VjcalVRGgnDnpdX/NRwfA7QFMoYTZF4aZs0JOYd/9VAXxpWa9YkmSLkg= X-Received: by 2002:a25:7614:: with SMTP id r20mr25968047ybc.157.1605912170528; Fri, 20 Nov 2020 14:42:50 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alex Deucher Date: Fri, 20 Nov 2020 17:42:38 -0500 Message-ID: Subject: Re: [PATCH 004/141] drm/amdgpu: Fix fall-through warnings for Clang To: "Gustavo A. R. Silva" Cc: Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , David Airlie , Daniel Vetter , linux-hardening@vger.kernel.org, Maling list - DRI developers , amd-gfx list , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 20, 2020 at 1:24 PM Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple break statements instead of just > letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/vi.c | 1 + > 4 files changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > index 3579565e0eab..98ca6b976b6e 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > @@ -8398,6 +8398,7 @@ static int gfx_v10_0_set_priv_inst_fault_state(struct amdgpu_device *adev, > WREG32_FIELD15(GC, 0, CP_INT_CNTL_RING0, > PRIV_INSTR_INT_ENABLE, > state == AMDGPU_IRQ_STATE_ENABLE ? 1 : 0); > + break; > default: > break; > } > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > index 0d8e203b10ef..e61121629b93 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > @@ -5683,6 +5683,7 @@ static int gfx_v9_0_set_priv_inst_fault_state(struct amdgpu_device *adev, > WREG32_FIELD15(GC, 0, CP_INT_CNTL_RING0, > PRIV_INSTR_INT_ENABLE, > state == AMDGPU_IRQ_STATE_ENABLE ? 1 : 0); > + break; > default: > break; > } > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > index 3ebbddb63705..584b99b80c29 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > @@ -502,6 +502,7 @@ static int gmc_v9_0_vm_fault_interrupt_state(struct amdgpu_device *adev, > WREG32(reg, tmp); > } > } > + break; > default: > break; > } > diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c > index 9bcd0eebc6d7..d56b474b3a21 100644 > --- a/drivers/gpu/drm/amd/amdgpu/vi.c > +++ b/drivers/gpu/drm/amd/amdgpu/vi.c > @@ -1645,6 +1645,7 @@ static int vi_common_set_clockgating_state(void *handle, > case CHIP_POLARIS12: > case CHIP_VEGAM: > vi_common_set_clockgating_state_by_smu(adev, state); > + break; > default: > break; > } > -- > 2.27.0 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DB74C5519F for ; Fri, 20 Nov 2020 22:42:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9BB32242A for ; Fri, 20 Nov 2020 22:42:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YnUi7YuN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9BB32242A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 14C886E937; Fri, 20 Nov 2020 22:42:52 +0000 (UTC) Received: from mail-yb1-xb44.google.com (mail-yb1-xb44.google.com [IPv6:2607:f8b0:4864:20::b44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 502896E937; Fri, 20 Nov 2020 22:42:51 +0000 (UTC) Received: by mail-yb1-xb44.google.com with SMTP id t33so10036660ybd.0; Fri, 20 Nov 2020 14:42:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E+/p0vsaZaZ5eJ4n4W/6kpMXGlN10lE2LER/KFN9S5s=; b=YnUi7YuNuw8mKKyydLvw5QmsWlZh9G7Hpn1spIT8RDTKUXYY13Bdxmk2fyzYfaErqE Asbi0nrX6Dkr+ZsTTAmv2yPPxoNN5RBSKqB6jgsNcvaCfd/NyrS79hQRaD+ZjC3hak7i neGJNQiXMdMH2t/nVgmdGZV9/ZEPtbs829cRB1laYEDnvivjitpGDwIofQ2fzZroA62j 5YPYQlzIggcV4spdaMob8NPflrEt4tOAJ9eydFDf162XehoY+LkQmJZyV6enRbfV7zDL RuiTSBs7Lrn3O4YvLm6si/JY31SdwPVSGSV7o18NonKTuaze082T1eyGembEoKNEBVsi 7lFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E+/p0vsaZaZ5eJ4n4W/6kpMXGlN10lE2LER/KFN9S5s=; b=U5i2KDP7s8hERxU1m+WsCeazBiUdvNOKvXTTHWfe9hLv9SdspygZf1t8ORbhQZoh2l QOLTeVWM++4W7k4eKYoT1Tpzl+rpkW/9UkwFKhaTReXiKVveyFg4aKhNH08Rh0u+N9Wq /CmDRGvwgJiYd/rPQz5hdpzzZzxprAq4nTtzdVpFVjN9DfQBonp5DqbuOTPHP/PaaQ4/ bOVwF+JqKUJ1rKqfiBsG/ruKSZwQNji5B9JJv7TH/y8IpZyspacDxsWEtMK2KT28anO5 x8iU21XBAX/3OXlewGc2FxQOAOmOQzAydU0mpJ3hCMsIuOSGmrOqDZs38UwPlDtROTol Sslw== X-Gm-Message-State: AOAM532676wrv1l/F8086NLlqfoIsnuqdiQu97UM/i+dQgiTxrWqZiXt 4Fzth4Ij3sftBtQq3YKwY8oboCvOKzlll/8O6/I= X-Google-Smtp-Source: ABdhPJznvvvinnh9ZMC/o+FJus/kMLARw94VjcalVRGgnDnpdX/NRwfA7QFMoYTZF4aZs0JOYd/9VAXxpWa9YkmSLkg= X-Received: by 2002:a25:7614:: with SMTP id r20mr25968047ybc.157.1605912170528; Fri, 20 Nov 2020 14:42:50 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alex Deucher Date: Fri, 20 Nov 2020 17:42:38 -0500 Message-ID: Subject: Re: [PATCH 004/141] drm/amdgpu: Fix fall-through warnings for Clang To: "Gustavo A. R. Silva" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amd-gfx list , David Airlie , LKML , Maling list - DRI developers , linux-hardening@vger.kernel.org, Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Nov 20, 2020 at 1:24 PM Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple break statements instead of just > letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/vi.c | 1 + > 4 files changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > index 3579565e0eab..98ca6b976b6e 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > @@ -8398,6 +8398,7 @@ static int gfx_v10_0_set_priv_inst_fault_state(struct amdgpu_device *adev, > WREG32_FIELD15(GC, 0, CP_INT_CNTL_RING0, > PRIV_INSTR_INT_ENABLE, > state == AMDGPU_IRQ_STATE_ENABLE ? 1 : 0); > + break; > default: > break; > } > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > index 0d8e203b10ef..e61121629b93 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > @@ -5683,6 +5683,7 @@ static int gfx_v9_0_set_priv_inst_fault_state(struct amdgpu_device *adev, > WREG32_FIELD15(GC, 0, CP_INT_CNTL_RING0, > PRIV_INSTR_INT_ENABLE, > state == AMDGPU_IRQ_STATE_ENABLE ? 1 : 0); > + break; > default: > break; > } > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > index 3ebbddb63705..584b99b80c29 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > @@ -502,6 +502,7 @@ static int gmc_v9_0_vm_fault_interrupt_state(struct amdgpu_device *adev, > WREG32(reg, tmp); > } > } > + break; > default: > break; > } > diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c > index 9bcd0eebc6d7..d56b474b3a21 100644 > --- a/drivers/gpu/drm/amd/amdgpu/vi.c > +++ b/drivers/gpu/drm/amd/amdgpu/vi.c > @@ -1645,6 +1645,7 @@ static int vi_common_set_clockgating_state(void *handle, > case CHIP_POLARIS12: > case CHIP_VEGAM: > vi_common_set_clockgating_state_by_smu(adev, state); > + break; > default: > break; > } > -- > 2.27.0 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AF95C2D0E4 for ; Fri, 20 Nov 2020 22:42:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18D682242A for ; Fri, 20 Nov 2020 22:42:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YnUi7YuN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18D682242A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A1066E938; Fri, 20 Nov 2020 22:42:52 +0000 (UTC) Received: from mail-yb1-xb44.google.com (mail-yb1-xb44.google.com [IPv6:2607:f8b0:4864:20::b44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 502896E937; Fri, 20 Nov 2020 22:42:51 +0000 (UTC) Received: by mail-yb1-xb44.google.com with SMTP id t33so10036660ybd.0; Fri, 20 Nov 2020 14:42:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E+/p0vsaZaZ5eJ4n4W/6kpMXGlN10lE2LER/KFN9S5s=; b=YnUi7YuNuw8mKKyydLvw5QmsWlZh9G7Hpn1spIT8RDTKUXYY13Bdxmk2fyzYfaErqE Asbi0nrX6Dkr+ZsTTAmv2yPPxoNN5RBSKqB6jgsNcvaCfd/NyrS79hQRaD+ZjC3hak7i neGJNQiXMdMH2t/nVgmdGZV9/ZEPtbs829cRB1laYEDnvivjitpGDwIofQ2fzZroA62j 5YPYQlzIggcV4spdaMob8NPflrEt4tOAJ9eydFDf162XehoY+LkQmJZyV6enRbfV7zDL RuiTSBs7Lrn3O4YvLm6si/JY31SdwPVSGSV7o18NonKTuaze082T1eyGembEoKNEBVsi 7lFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E+/p0vsaZaZ5eJ4n4W/6kpMXGlN10lE2LER/KFN9S5s=; b=U5i2KDP7s8hERxU1m+WsCeazBiUdvNOKvXTTHWfe9hLv9SdspygZf1t8ORbhQZoh2l QOLTeVWM++4W7k4eKYoT1Tpzl+rpkW/9UkwFKhaTReXiKVveyFg4aKhNH08Rh0u+N9Wq /CmDRGvwgJiYd/rPQz5hdpzzZzxprAq4nTtzdVpFVjN9DfQBonp5DqbuOTPHP/PaaQ4/ bOVwF+JqKUJ1rKqfiBsG/ruKSZwQNji5B9JJv7TH/y8IpZyspacDxsWEtMK2KT28anO5 x8iU21XBAX/3OXlewGc2FxQOAOmOQzAydU0mpJ3hCMsIuOSGmrOqDZs38UwPlDtROTol Sslw== X-Gm-Message-State: AOAM532676wrv1l/F8086NLlqfoIsnuqdiQu97UM/i+dQgiTxrWqZiXt 4Fzth4Ij3sftBtQq3YKwY8oboCvOKzlll/8O6/I= X-Google-Smtp-Source: ABdhPJznvvvinnh9ZMC/o+FJus/kMLARw94VjcalVRGgnDnpdX/NRwfA7QFMoYTZF4aZs0JOYd/9VAXxpWa9YkmSLkg= X-Received: by 2002:a25:7614:: with SMTP id r20mr25968047ybc.157.1605912170528; Fri, 20 Nov 2020 14:42:50 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alex Deucher Date: Fri, 20 Nov 2020 17:42:38 -0500 Message-ID: Subject: Re: [PATCH 004/141] drm/amdgpu: Fix fall-through warnings for Clang To: "Gustavo A. R. Silva" X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amd-gfx list , David Airlie , LKML , Maling list - DRI developers , linux-hardening@vger.kernel.org, Daniel Vetter , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Fri, Nov 20, 2020 at 1:24 PM Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple break statements instead of just > letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/vi.c | 1 + > 4 files changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > index 3579565e0eab..98ca6b976b6e 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > @@ -8398,6 +8398,7 @@ static int gfx_v10_0_set_priv_inst_fault_state(struct amdgpu_device *adev, > WREG32_FIELD15(GC, 0, CP_INT_CNTL_RING0, > PRIV_INSTR_INT_ENABLE, > state == AMDGPU_IRQ_STATE_ENABLE ? 1 : 0); > + break; > default: > break; > } > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > index 0d8e203b10ef..e61121629b93 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > @@ -5683,6 +5683,7 @@ static int gfx_v9_0_set_priv_inst_fault_state(struct amdgpu_device *adev, > WREG32_FIELD15(GC, 0, CP_INT_CNTL_RING0, > PRIV_INSTR_INT_ENABLE, > state == AMDGPU_IRQ_STATE_ENABLE ? 1 : 0); > + break; > default: > break; > } > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > index 3ebbddb63705..584b99b80c29 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > @@ -502,6 +502,7 @@ static int gmc_v9_0_vm_fault_interrupt_state(struct amdgpu_device *adev, > WREG32(reg, tmp); > } > } > + break; > default: > break; > } > diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c > index 9bcd0eebc6d7..d56b474b3a21 100644 > --- a/drivers/gpu/drm/amd/amdgpu/vi.c > +++ b/drivers/gpu/drm/amd/amdgpu/vi.c > @@ -1645,6 +1645,7 @@ static int vi_common_set_clockgating_state(void *handle, > case CHIP_POLARIS12: > case CHIP_VEGAM: > vi_common_set_clockgating_state_by_smu(adev, state); > + break; > default: > break; > } > -- > 2.27.0 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx