From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88EC4CCA47F for ; Tue, 28 Jun 2022 14:38:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347221AbiF1OiC (ORCPT ); Tue, 28 Jun 2022 10:38:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346842AbiF1OiB (ORCPT ); Tue, 28 Jun 2022 10:38:01 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 668992DD70; Tue, 28 Jun 2022 07:38:00 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id mf9so26337414ejb.0; Tue, 28 Jun 2022 07:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8hQk/b0dG+ocD4kJkrdVLcqXI9aTRhPcr2tzOyCb7mk=; b=FftgfCRZNOFK3Y04oOXzjZwBv01ZPqBAsXGdkky+kO4cE8jNkzJjWL1lyBbv5cCMzt 8ZHo7aDVBL4WTzIKpcJFig+44I2dHAu4WuZE2hWqbj43Oy9+kz8VZRWuxIAC1IVWr7r+ 7UVFPFEvmhpI+l8mWNF7XiuJKkzRo8CIEcU60klYX480FgZciwWg/mQsXS2iLpsukq1V 8LC6NWfqzLKNmrE1prgCNsO9NdbH6n5xqJV7Ty70dkNZNbGOraGm3unIOTuvrQCWoh1l ZQbMrtIhZYzd3Ha5wSzQC8ZMAS6ZQInJTuZ9miKlPSmiuiOFX58iU+qS0nwHu6FHEvYZ h+aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8hQk/b0dG+ocD4kJkrdVLcqXI9aTRhPcr2tzOyCb7mk=; b=MrrNMXEansr9S42JfGAMV9IFmIuL5gzFkUv1K4wTVCvKMqO9ft6iEAG7MB+61/WFE8 0Eo2ohHiwTuoU7Yj6LQJPHcZjJK73RPY6EdRlP+vQWSsYHb8ZTd2CFdF67ps41o+17Si y/Y3d66YMAeuuz6ThIKlHoavQWlk8TBZzLz5bnSsOBhQtYFWmY1XlrpCdjfbn8Fmv6o1 63ZQ6oWqy3qTLlWmQ85MBwEWsjhZvBN+4V953AwYJzYjxBjEhhvbhY4XHDIGcL5VGpwM JCrjOu653LsA7LpqDlWwY83soyV/9xhGm2rB+uVvN0fZRbhZ+GjadWe9+zCvgTYc3+Ho p+jA== X-Gm-Message-State: AJIora9dtcEdMGwEPGmx3JVB2cokwHZaFbjUUegBIVh198XyRRveI58s xEZe5K1SMKWlPhoX8BQ2rK7Rs8EUax9NiPvlbGGIsG6s X-Google-Smtp-Source: AGRyM1sjewq/YDh9ewRpgbEn647mcNCTsFzlz2ApXt/lWtI5R9O39yhXZpkP6sUScjKV7B7HZKEprynWngvkhAfQV4M= X-Received: by 2002:a17:907:a40f:b0:726:a8f5:1031 with SMTP id sg15-20020a170907a40f00b00726a8f51031mr9317125ejc.185.1656427078995; Tue, 28 Jun 2022 07:37:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alex Deucher Date: Tue, 28 Jun 2022 10:37:47 -0400 Message-ID: Subject: Re: [PATCH 10/22] drm: amdgpu: amdgpu_device.c: fix a kernel-doc markup To: Mauro Carvalho Chehab Cc: Linux Doc Mailing List , Andrey Grodzovsky , Evan Quan , Guchun Chen , Jonathan Corbet , Mauro Carvalho Chehab , Somalapuram Amaranath , "Pan, Xinhui" , LKML , amd-gfx list , David Airlie , Maling list - DRI developers , Daniel Vetter , Kevin Wang , Alex Deucher , Lang Yu , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 28, 2022 at 5:46 AM Mauro Carvalho Chehab wrote: > > The function was renamed without renaming also kernel-doc markup: > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:5095: warning: expecting prototype for amdgpu_device_gpu_recover_imp(). Prototype was for amdgpu_device_gpu_recover() instead > > Signed-off-by: Mauro Carvalho Chehab I actually sent out the same patch a few days ago, however, the code has since changed with Andrey's recent GPU reset series and the patch is no longer applicable. Thanks, Alex > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. > See [PATCH 00/22] at: https://lore.kernel.org/all/cover.1656409369.git.mchehab@kernel.org/ > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 9d6418bb963e..6d74767591e7 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -5079,7 +5079,7 @@ static inline void amdggpu_device_stop_pedning_resets(struct amdgpu_device *adev > > > /** > - * amdgpu_device_gpu_recover_imp - reset the asic and recover scheduler > + * amdgpu_device_gpu_recover - reset the asic and recover scheduler > * > * @adev: amdgpu_device pointer > * @job: which job trigger hang > -- > 2.36.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0552ECCA480 for ; Tue, 28 Jun 2022 14:38:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 377A810F260; Tue, 28 Jun 2022 14:38:02 +0000 (UTC) Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8EAD510E2FE; Tue, 28 Jun 2022 14:38:00 +0000 (UTC) Received: by mail-ej1-x62a.google.com with SMTP id ay16so26230828ejb.6; Tue, 28 Jun 2022 07:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8hQk/b0dG+ocD4kJkrdVLcqXI9aTRhPcr2tzOyCb7mk=; b=FftgfCRZNOFK3Y04oOXzjZwBv01ZPqBAsXGdkky+kO4cE8jNkzJjWL1lyBbv5cCMzt 8ZHo7aDVBL4WTzIKpcJFig+44I2dHAu4WuZE2hWqbj43Oy9+kz8VZRWuxIAC1IVWr7r+ 7UVFPFEvmhpI+l8mWNF7XiuJKkzRo8CIEcU60klYX480FgZciwWg/mQsXS2iLpsukq1V 8LC6NWfqzLKNmrE1prgCNsO9NdbH6n5xqJV7Ty70dkNZNbGOraGm3unIOTuvrQCWoh1l ZQbMrtIhZYzd3Ha5wSzQC8ZMAS6ZQInJTuZ9miKlPSmiuiOFX58iU+qS0nwHu6FHEvYZ h+aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8hQk/b0dG+ocD4kJkrdVLcqXI9aTRhPcr2tzOyCb7mk=; b=7+ttgWPLzgZneIGf7j6wNcQdoxhRG8glXMvOFK/MspXqdkP/0sumR1okYjsZuEcB+c 42prT1zE1rfquV2ZcMEvKhH0Zgtv5g5Ckd7VwV/bw79c9+v0sQFLOKSNkDk9YSTSGiR3 4284QFmgsosNAqdG8ofV3PvHrUJnIGuZBTE+h8brb7rOU7Uoz7bcnAoqH2XlTkIlfYXM /B6+H/n+9G1BaqKzLmWxLa6PpuAZOrE+OxYNq+ShoYw1je75JBkmxVh4+prWhHVEOHte m8QtcKG4HNYhHUpT+A2LmePOa9klg6cCj2CbAWrEf8FTtwHCZG+d1PW4F+bBz3ggeNTb HnIg== X-Gm-Message-State: AJIora9lAPvGwKJP78gagjGo6MzlfR00AzkRwILqQ0fEr/lRrvENwuNd obIiI2eEtmiUHCyVfOE7FkkHRywXCzh5xX1/Ooo= X-Google-Smtp-Source: AGRyM1sjewq/YDh9ewRpgbEn647mcNCTsFzlz2ApXt/lWtI5R9O39yhXZpkP6sUScjKV7B7HZKEprynWngvkhAfQV4M= X-Received: by 2002:a17:907:a40f:b0:726:a8f5:1031 with SMTP id sg15-20020a170907a40f00b00726a8f51031mr9317125ejc.185.1656427078995; Tue, 28 Jun 2022 07:37:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alex Deucher Date: Tue, 28 Jun 2022 10:37:47 -0400 Message-ID: Subject: Re: [PATCH 10/22] drm: amdgpu: amdgpu_device.c: fix a kernel-doc markup To: Mauro Carvalho Chehab Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Somalapuram Amaranath , Guchun Chen , Jonathan Corbet , Mauro Carvalho Chehab , "Pan, Xinhui" , Linux Doc Mailing List , LKML , amd-gfx list , David Airlie , Maling list - DRI developers , Kevin Wang , Alex Deucher , Evan Quan , Lang Yu , =?UTF-8?Q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jun 28, 2022 at 5:46 AM Mauro Carvalho Chehab wrote: > > The function was renamed without renaming also kernel-doc markup: > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:5095: warning: expecting prototype for amdgpu_device_gpu_recover_imp(). Prototype was for amdgpu_device_gpu_recover() instead > > Signed-off-by: Mauro Carvalho Chehab I actually sent out the same patch a few days ago, however, the code has since changed with Andrey's recent GPU reset series and the patch is no longer applicable. Thanks, Alex > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. > See [PATCH 00/22] at: https://lore.kernel.org/all/cover.1656409369.git.mchehab@kernel.org/ > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 9d6418bb963e..6d74767591e7 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -5079,7 +5079,7 @@ static inline void amdggpu_device_stop_pedning_resets(struct amdgpu_device *adev > > > /** > - * amdgpu_device_gpu_recover_imp - reset the asic and recover scheduler > + * amdgpu_device_gpu_recover - reset the asic and recover scheduler > * > * @adev: amdgpu_device pointer > * @job: which job trigger hang > -- > 2.36.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A14ECCA479 for ; Tue, 28 Jun 2022 14:38:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 57BEE10F362; Tue, 28 Jun 2022 14:38:02 +0000 (UTC) Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8EAD510E2FE; Tue, 28 Jun 2022 14:38:00 +0000 (UTC) Received: by mail-ej1-x62a.google.com with SMTP id ay16so26230828ejb.6; Tue, 28 Jun 2022 07:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8hQk/b0dG+ocD4kJkrdVLcqXI9aTRhPcr2tzOyCb7mk=; b=FftgfCRZNOFK3Y04oOXzjZwBv01ZPqBAsXGdkky+kO4cE8jNkzJjWL1lyBbv5cCMzt 8ZHo7aDVBL4WTzIKpcJFig+44I2dHAu4WuZE2hWqbj43Oy9+kz8VZRWuxIAC1IVWr7r+ 7UVFPFEvmhpI+l8mWNF7XiuJKkzRo8CIEcU60klYX480FgZciwWg/mQsXS2iLpsukq1V 8LC6NWfqzLKNmrE1prgCNsO9NdbH6n5xqJV7Ty70dkNZNbGOraGm3unIOTuvrQCWoh1l ZQbMrtIhZYzd3Ha5wSzQC8ZMAS6ZQInJTuZ9miKlPSmiuiOFX58iU+qS0nwHu6FHEvYZ h+aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8hQk/b0dG+ocD4kJkrdVLcqXI9aTRhPcr2tzOyCb7mk=; b=7+ttgWPLzgZneIGf7j6wNcQdoxhRG8glXMvOFK/MspXqdkP/0sumR1okYjsZuEcB+c 42prT1zE1rfquV2ZcMEvKhH0Zgtv5g5Ckd7VwV/bw79c9+v0sQFLOKSNkDk9YSTSGiR3 4284QFmgsosNAqdG8ofV3PvHrUJnIGuZBTE+h8brb7rOU7Uoz7bcnAoqH2XlTkIlfYXM /B6+H/n+9G1BaqKzLmWxLa6PpuAZOrE+OxYNq+ShoYw1je75JBkmxVh4+prWhHVEOHte m8QtcKG4HNYhHUpT+A2LmePOa9klg6cCj2CbAWrEf8FTtwHCZG+d1PW4F+bBz3ggeNTb HnIg== X-Gm-Message-State: AJIora9lAPvGwKJP78gagjGo6MzlfR00AzkRwILqQ0fEr/lRrvENwuNd obIiI2eEtmiUHCyVfOE7FkkHRywXCzh5xX1/Ooo= X-Google-Smtp-Source: AGRyM1sjewq/YDh9ewRpgbEn647mcNCTsFzlz2ApXt/lWtI5R9O39yhXZpkP6sUScjKV7B7HZKEprynWngvkhAfQV4M= X-Received: by 2002:a17:907:a40f:b0:726:a8f5:1031 with SMTP id sg15-20020a170907a40f00b00726a8f51031mr9317125ejc.185.1656427078995; Tue, 28 Jun 2022 07:37:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alex Deucher Date: Tue, 28 Jun 2022 10:37:47 -0400 Message-ID: Subject: Re: [PATCH 10/22] drm: amdgpu: amdgpu_device.c: fix a kernel-doc markup To: Mauro Carvalho Chehab Content-Type: text/plain; charset="UTF-8" X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Grodzovsky , Somalapuram Amaranath , Guchun Chen , Jonathan Corbet , Mauro Carvalho Chehab , "Pan, Xinhui" , Linux Doc Mailing List , LKML , amd-gfx list , David Airlie , Maling list - DRI developers , Daniel Vetter , Kevin Wang , Alex Deucher , Evan Quan , Lang Yu , =?UTF-8?Q?Christian_K=C3=B6nig?= Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Tue, Jun 28, 2022 at 5:46 AM Mauro Carvalho Chehab wrote: > > The function was renamed without renaming also kernel-doc markup: > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:5095: warning: expecting prototype for amdgpu_device_gpu_recover_imp(). Prototype was for amdgpu_device_gpu_recover() instead > > Signed-off-by: Mauro Carvalho Chehab I actually sent out the same patch a few days ago, however, the code has since changed with Andrey's recent GPU reset series and the patch is no longer applicable. Thanks, Alex > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. > See [PATCH 00/22] at: https://lore.kernel.org/all/cover.1656409369.git.mchehab@kernel.org/ > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 9d6418bb963e..6d74767591e7 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -5079,7 +5079,7 @@ static inline void amdggpu_device_stop_pedning_resets(struct amdgpu_device *adev > > > /** > - * amdgpu_device_gpu_recover_imp - reset the asic and recover scheduler > + * amdgpu_device_gpu_recover - reset the asic and recover scheduler > * > * @adev: amdgpu_device pointer > * @job: which job trigger hang > -- > 2.36.1 >