From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CC86C433F5 for ; Thu, 10 Feb 2022 04:09:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B2A8110E3EB; Thu, 10 Feb 2022 04:09:01 +0000 (UTC) Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2DD0510E3EB for ; Thu, 10 Feb 2022 04:09:00 +0000 (UTC) Received: by mail-oi1-x22a.google.com with SMTP id x193so4785721oix.0 for ; Wed, 09 Feb 2022 20:09:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zc0OhJe+0kPHEDXiXSnmplSzL4cLFdiYwvqvNqemGE0=; b=bInW5Gbf4ffXCMuudCNDF70vL/uLa6+MpAXTihiAQcdR/i5zCqIImg7BE2gcVaI/U7 c7UQJtIw15BTQ73cQ+n4Ch/23VD7w+8stQCau+1cqcX5B+iIBVyCz0DiOONKa2zE521O UuSDUlLJ6d/5QTGyDsIqzElTSIkpTiTU34SC+rZIQmdsz0m1vWsRjuk0rL8jpx2GrsA+ dR0ZIisYchRCPMktWJKI4dw14BZ60XMRRnE9z5ImqjMH4FrO+sTfDD6edodhLuimvvxx XXorPgl+bUtpuX692kauRqUgXdgcO5OJBbIaZX7Iuv0I6dvHm2LCDyXgagG5AJp0PBF+ bohg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zc0OhJe+0kPHEDXiXSnmplSzL4cLFdiYwvqvNqemGE0=; b=khh/60C2nFA+UGGokUf1CeEiG1Of8vGstDARIKJVTC9MfZJLE9QeK0UhVQCk8iM0w6 yUnsQmUbF0RBTNfYwesHyWI890izkbghsfq3XBlZBIsry6iaXsjJNdJctZSldhHpIG8g hIqZaPbHpLDQrhPUwHZ+oxj5ACcTel3nqkKvk+N6ABYW+ijWp3uHguH8hRlpYEareZCD PI8TWKb7wAKLqQ+GYA6MmhW5YQl1ypUOI8N0d2NqAwsuRq3C+CUh7CammZif38pG2RQS s11CESFOI8C0C3CV6B1UXUAXxVFNhU/zvfx2hZfoF963A10eALQKISBJbgeF36bR/exm IalQ== X-Gm-Message-State: AOAM530yD68pjIQ9Vj5rlqMTtvej39XevviuHuKDXLFLar2gJxAPN2Wp DX9/Bd1z1Ikxm2NLJY85NWOF7iBHdMSoj8RYypD8sQeh X-Google-Smtp-Source: ABdhPJyCTyeeDoim+BqySwVpvzvCmMoq4LKOKRe14gH8yNysXfMIGbwdXPRqfyIsJU0KpLzkcA2pcgJEZicF60NGJS0= X-Received: by 2002:a05:6808:2011:: with SMTP id q17mr294604oiw.199.1644466139288; Wed, 09 Feb 2022 20:08:59 -0800 (PST) MIME-Version: 1.0 References: <20220210014700.856667-1-evan.quan@amd.com> In-Reply-To: <20220210014700.856667-1-evan.quan@amd.com> From: Alex Deucher Date: Wed, 9 Feb 2022 23:08:47 -0500 Message-ID: Subject: Re: [PATCH] drm/amd/pm: fix enabled features retrieving on Renoir and Cyan Skillfish To: Evan Quan Content-Type: text/plain; charset="UTF-8" X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Deucher, Alexander" , Nathan Chancellor , "Lazar, Lijo" , Roman Li , amd-gfx list Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Wed, Feb 9, 2022 at 8:47 PM Evan Quan wrote: > > For Cyan Skillfish and Renoir, there is no interface provided by PMFW > to retrieve the enabled features. So, we assume all features are enabled. > > Fixes: 7ade3ca9cdb5 ("drm/amd/pm: correct the usage for 'supported' member of smu_feature structure") > > Signed-off-by: Evan Quan Acked-by: Alex Deucher > Change-Id: I1231f146405a229a11aa7ac608c8c932d3c90ee4 > -- > v1->v2: > - add back the logic for supporting those ASICs which have > no feature_map available > v2->v3: > - update the check for smu_cmn_feature_is_enabled to use a more > generic way instead of asic type > > Change-Id: I7dfa453ffc086f5364848f7f32decd57a5a5b0e6 > --- > .../amd/pm/swsmu/smu11/cyan_skillfish_ppt.c | 1 + > drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 27 ++++++++++++++----- > drivers/gpu/drm/amd/pm/swsmu/smu_internal.h | 2 +- > 3 files changed, 22 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/cyan_skillfish_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/cyan_skillfish_ppt.c > index 2b38a9154dd4..b3a0f3fb3e65 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/cyan_skillfish_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/cyan_skillfish_ppt.c > @@ -562,6 +562,7 @@ static const struct pptable_funcs cyan_skillfish_ppt_funcs = { > .fini_smc_tables = smu_v11_0_fini_smc_tables, > .read_sensor = cyan_skillfish_read_sensor, > .print_clk_levels = cyan_skillfish_print_clk_levels, > + .get_enabled_mask = smu_cmn_get_enabled_mask, > .is_dpm_running = cyan_skillfish_is_dpm_running, > .get_gpu_metrics = cyan_skillfish_get_gpu_metrics, > .od_edit_dpm_table = cyan_skillfish_od_edit_dpm_table, > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c > index 2a6b752a6996..4c12abcd995d 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c > @@ -500,7 +500,17 @@ int smu_cmn_feature_is_enabled(struct smu_context *smu, > uint64_t enabled_features; > int feature_id; > > - if (smu->is_apu && adev->family < AMDGPU_FAMILY_VGH) > + if (smu_cmn_get_enabled_mask(smu, &enabled_features)) { > + dev_err(adev->dev, "Failed to retrieve enabled ppfeatures!\n"); > + return 0; > + } > + > + /* > + * For Renoir and Cyan Skillfish, they are assumed to have all features > + * enabled. Also considering they have no feature_map available, the > + * check here can avoid unwanted feature_map check below. > + */ > + if (enabled_features == ULLONG_MAX) > return 1; > > feature_id = smu_cmn_to_asic_specific_index(smu, > @@ -509,11 +519,6 @@ int smu_cmn_feature_is_enabled(struct smu_context *smu, > if (feature_id < 0) > return 0; > > - if (smu_cmn_get_enabled_mask(smu, &enabled_features)) { > - dev_err(adev->dev, "Failed to retrieve enabled ppfeatures!\n"); > - return 0; > - } > - > return test_bit(feature_id, (unsigned long *)&enabled_features); > } > > @@ -559,7 +564,7 @@ int smu_cmn_get_enabled_mask(struct smu_context *smu, > feature_mask_high = &((uint32_t *)feature_mask)[1]; > > switch (adev->ip_versions[MP1_HWIP][0]) { > - case IP_VERSION(11, 0, 8): > + /* For Vangogh and Yellow Carp */ > case IP_VERSION(11, 5, 0): > case IP_VERSION(13, 0, 1): > case IP_VERSION(13, 0, 3): > @@ -575,8 +580,16 @@ int smu_cmn_get_enabled_mask(struct smu_context *smu, > 1, > feature_mask_high); > break; > + /* > + * For Cyan Skillfish and Renoir, there is no interface provided by PMFW > + * to retrieve the enabled features. So, we assume all features are enabled. > + * TODO: add other APU ASICs which suffer from the same issue here > + */ > + case IP_VERSION(11, 0, 8): > case IP_VERSION(12, 0, 0): > case IP_VERSION(12, 0, 1): > + memset(feature_mask, 0xff, sizeof(*feature_mask)); > + break; > /* other dGPU ASICs */ > default: > ret = smu_cmn_send_smc_msg(smu, > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_internal.h b/drivers/gpu/drm/amd/pm/swsmu/smu_internal.h > index 530be44e00ec..15bcf72b8e56 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu_internal.h > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu_internal.h > @@ -55,7 +55,7 @@ > #define smu_send_smc_msg(smu, msg, read_arg) smu_ppt_funcs(send_smc_msg, 0, smu, msg, read_arg) > #define smu_init_display_count(smu, count) smu_ppt_funcs(init_display_count, 0, smu, count) > #define smu_feature_set_allowed_mask(smu) smu_ppt_funcs(set_allowed_mask, 0, smu) > -#define smu_feature_get_enabled_mask(smu, mask) smu_ppt_funcs(get_enabled_mask, 0, smu, mask) > +#define smu_feature_get_enabled_mask(smu, mask) smu_ppt_funcs(get_enabled_mask, -EOPNOTSUPP, smu, mask) > #define smu_feature_is_enabled(smu, mask) smu_ppt_funcs(feature_is_enabled, 0, smu, mask) > #define smu_disable_all_features_with_exception(smu, mask) smu_ppt_funcs(disable_all_features_with_exception, 0, smu, mask) > #define smu_is_dpm_running(smu) smu_ppt_funcs(is_dpm_running, 0 , smu) > -- > 2.29.0 >