From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6FF3C433E0 for ; Fri, 22 May 2020 19:10:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CA76206D5 for ; Fri, 22 May 2020 19:10:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FqxcnY6a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CA76206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3A1576EA36; Fri, 22 May 2020 19:10:55 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9DBF46EA32 for ; Fri, 22 May 2020 19:10:53 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id l17so11201173wrr.4 for ; Fri, 22 May 2020 12:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q5iXRODobZJ2FNcUNousfU3RzCb0dgFJ5J0gsEfMWyQ=; b=FqxcnY6aQBlAiB08L/IFIfI049U/0C4j7yfxguq6TF5e72mOhgBoYsO3DP3bTdm65i tPO/mMM9wWAsb1rAyoEg3C9hxbMdTtMOF2z0vzDSfbzGSBfpF4XV4cFajHqfGCxTUq6I 7LhL/fPwNlsQklBzQOlGJTczfsUfjH6Tcvf4l59itQCdKkfkKNqW2AssAfkeA8AhCMDw sRNVCRJRXres/2kvgFcmvEbAiRJoc0+GPrZUdhe63wKBzAi+M69jtW00VEYUf8I9oIYj rvABn66zZWkbA5wOZqNjQ+ORfffrIB0FLjw2X8I37NHWnuN6rMDUY/1mXowvavN5SIdp NqwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q5iXRODobZJ2FNcUNousfU3RzCb0dgFJ5J0gsEfMWyQ=; b=EJMC94RTmDp2g0YLSn2sgKrANpZZYXQg/7DWwHpCvA0ktURssO5QPzxLXlnwyV1Zg3 mKc7bxu8GnJg7HT2DQ2xvFmSnl2NQvJm6OGARxBB66H+qdoYds9hxiKFmTkdRUqTHphJ e5UU+W4zdG4Bz5ATZybYlEVwdOJH50+AJ+cSMe0tSvRgOJ57XTh7j9enMWFa+IoRYQpG KlFNbpL1J4mW2w9w/DI6VrYRNCfTYyKMGu5npWD91CctSH8hmi7gTDjaO0OyOcnyw7Ce qiV0QmtShrxKnLxiXxZqAnJcR0qDdfE+SYHwjbuZ8pL9d15Zhxz5SULgweIkZ3GoD/fk lILg== X-Gm-Message-State: AOAM533iZyhxwLtPVEr6/jf3/EyxxDpqdD542Kk5uGHt2ZlF8+/yYqL6 XznkWzM8dE7bg0wYiRzhxqYM/AX5rU311uDqnVdM5w== X-Google-Smtp-Source: ABdhPJwIeTJNH4IdbOWLuOPXv9uqQdWVEKLHU8Fm8Tmt97XBDzQB8iF9EXBZs+HZdJdjlctHi9Q1uA22FBre6liXRTQ= X-Received: by 2002:a05:6000:14b:: with SMTP id r11mr4817354wrx.124.1590174652309; Fri, 22 May 2020 12:10:52 -0700 (PDT) MIME-Version: 1.0 References: <20200522181931.277182-1-Gavin.Wan@amd.com> In-Reply-To: <20200522181931.277182-1-Gavin.Wan@amd.com> From: Alex Deucher Date: Fri, 22 May 2020 15:10:40 -0400 Message-ID: Subject: Re: [PATCH] drm/amd/amdgpu: Fix the CGCG setting is overwritten for SRIOV. To: Gavin Wan X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amd-gfx list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Fri, May 22, 2020 at 2:20 PM Gavin Wan wrote: > > For SRIOV, since the CP_INT_CNTL_RING0 is programed on host side. > The Guest should not program CP_INT_CNTL_RING0 again. > > Change-Id: Ic336fab3b23b8371c9e9e192182a3ba14a8db8e1 > Signed-off-by: Gavin Wan > --- > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > index bd5dd4f64311..39275bf79448 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > @@ -4558,6 +4558,9 @@ static void gfx_v10_0_constants_init(struct amdgpu_device *adev) > static void gfx_v10_0_enable_gui_idle_interrupt(struct amdgpu_device *adev, > bool enable) > { > + if (amdgpu_sriov_vf(adev)) > + return; > + This needs to be below the stack variable declarations or you'll get a warning. Alex > u32 tmp = RREG32_SOC15(GC, 0, mmCP_INT_CNTL_RING0); > > tmp = REG_SET_FIELD(tmp, CP_INT_CNTL_RING0, CNTX_BUSY_INT_ENABLE, > -- > 2.25.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx