From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D31A8C433F5 for ; Mon, 24 Jan 2022 22:10:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A843710E1C6; Mon, 24 Jan 2022 22:10:08 +0000 (UTC) Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 744C510E1E7; Mon, 24 Jan 2022 22:10:07 +0000 (UTC) Received: by mail-ot1-x32d.google.com with SMTP id s6-20020a0568301e0600b0059ea5472c98so8486028otr.11; Mon, 24 Jan 2022 14:10:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dfQ1Cr8MOGNWzImPgM3FPvJ3DRDIShXaWCzTw2fuiGo=; b=Z+F0etylmIPRLfXkQxHrbCduqN93SYw7wl/ke/YpNeM4rPaukRCnKxTe71ymWVnYxP 7Vp4nnlA+M4Rm1eAhkuZw7yqe9BkTYhucCx+9Fsb6LaMeeQg6V2LonO6YxMnEKLTLNWf ThtFvcc/fRFn4UZPlVRhL+vS5U3wQmnxEtFLUPWE3obBRz8H/TwYkyRptXqFHff3vgKB jcy7q9coHrKyr3wha1pNcOuLmgUKjtbpCVRunpmpzDKtiFy4PTDQ6ZyeH6WC1swXj9wH 1gUQHxkh7d72RWBkcPCYm2r14IlbhITnuWDjv0rAlIdb7LUIu60GlZpkmIhgWB5EqtZk o1eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dfQ1Cr8MOGNWzImPgM3FPvJ3DRDIShXaWCzTw2fuiGo=; b=BvOkELI/kCteyfck7GqPEx4DlDiIf0XIvso4lsilvmrgUpVZBuVGeBm5o+EkLvML87 g0ase4dQrfN2tp90pPEGmJV8wQq1bMpQxZcVXgnn29huaG8sXv4z9NUMo9cNVniGcvMQ zoeACXMy2jJV9DEBJedB2ToIM5xsbcEE0uVh3WS1tQiDsFYG2GotwS6QoPUrZpE+/E6B Ix2+m9KavbFu9ckIitxqTqfunInZh5QsYnAMfjWWPvidMbBOE6xpEo4vm8q0TT11cccm nYEpB4E7GdybAH3bmthtb0hE9lPgwfaC64t3me3RF+xxVugiMii6QJV7nbMDVhf++Q4q pEWg== X-Gm-Message-State: AOAM532yAvmUGhgqeMubcalMeTG48bsVLNczyP2WjPRoE+ASOf/LlzV8 hCyEER3Y8BIPuLMiKM/OO6OYFIORgwVrQVTbqgI= X-Google-Smtp-Source: ABdhPJwvLyrL8/z3f3oeYcfh5RaeZB2rvDsalLA+HVQ+FDuwfMu1r9GNC9grwWebJSLxVHBZqstuKTAHNHQYm1JYjGE= X-Received: by 2002:a05:6830:1d90:: with SMTP id y16mr13147279oti.200.1643062206810; Mon, 24 Jan 2022 14:10:06 -0800 (PST) MIME-Version: 1.0 References: <20220119224628.123084-1-colin.i.king@gmail.com> In-Reply-To: From: Alex Deucher Date: Mon, 24 Jan 2022 17:09:55 -0500 Message-ID: Subject: Re: [PATCH] drm/radeon: remove redundant assignment to reg To: Nick Desaulniers Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: llvm@lists.linux.dev, David Airlie , xinhui pan , kernel-janitors@vger.kernel.org, LKML , amd-gfx list , Maling list - DRI developers , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , Colin Ian King Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Applied. Thanks! Alex On Mon, Jan 24, 2022 at 3:21 PM Nick Desaulniers wrote: > > On Wed, Jan 19, 2022 at 2:46 PM Colin Ian King wrote: > > > > The pointer reg is being assigned a value that is not read, the > > exit path via label 'out' never accesses it. The assignment is > > redundant and can be removed. > > > > Cleans up clang scan build warning: > > drivers/gpu/drm/radeon/radeon_object.c:570:3: warning: Value > > stored to 'reg' is never read [deadcode.DeadStores] > > > > Signed-off-by: Colin Ian King > > Thanks for the patch! > Reviewed-by: Nick Desaulniers > > > --- > > drivers/gpu/drm/radeon/radeon_object.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c > > index 56ede9d63b12..87536d205593 100644 > > --- a/drivers/gpu/drm/radeon/radeon_object.c > > +++ b/drivers/gpu/drm/radeon/radeon_object.c > > @@ -567,7 +567,6 @@ int radeon_bo_get_surface_reg(struct radeon_bo *bo) > > return 0; > > > > if (bo->surface_reg >= 0) { > > - reg = &rdev->surface_regs[bo->surface_reg]; > > i = bo->surface_reg; > > goto out; > > } > > -- > > 2.33.1 > > > > > > > -- > Thanks, > ~Nick Desaulniers From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A610A2CA7 for ; Mon, 24 Jan 2022 22:10:07 +0000 (UTC) Received: by mail-ot1-f50.google.com with SMTP id v8-20020a9d6048000000b005960952c694so24172027otj.12 for ; Mon, 24 Jan 2022 14:10:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dfQ1Cr8MOGNWzImPgM3FPvJ3DRDIShXaWCzTw2fuiGo=; b=Z+F0etylmIPRLfXkQxHrbCduqN93SYw7wl/ke/YpNeM4rPaukRCnKxTe71ymWVnYxP 7Vp4nnlA+M4Rm1eAhkuZw7yqe9BkTYhucCx+9Fsb6LaMeeQg6V2LonO6YxMnEKLTLNWf ThtFvcc/fRFn4UZPlVRhL+vS5U3wQmnxEtFLUPWE3obBRz8H/TwYkyRptXqFHff3vgKB jcy7q9coHrKyr3wha1pNcOuLmgUKjtbpCVRunpmpzDKtiFy4PTDQ6ZyeH6WC1swXj9wH 1gUQHxkh7d72RWBkcPCYm2r14IlbhITnuWDjv0rAlIdb7LUIu60GlZpkmIhgWB5EqtZk o1eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dfQ1Cr8MOGNWzImPgM3FPvJ3DRDIShXaWCzTw2fuiGo=; b=IVKWTxQB8xu6AOXRLvo5iLNmJCAJM3o21kX7NV4WC73dZanTuRmq+mMnouckdQ65DT 0ENDEA0XIJrxbx0gaiRp6IJgpIFP9f8asJYW/YkTiNulzOTYJ4i+YQer8JrwyAA/MO1v +VQV6DHDM8fmRAbJ6TyqxErtl9HR1V9LEE0nFP8NMLzzAXPUc7d3lmpShwEDrk/IfG3j hrvityTT0/b00zRDng+IOb7Bsn+pe2SjJMzG3ohPnM2r0gLM9/VbHcuFjEDpNeptCFz0 Xaz9RbxAS5+lxUOddatlImKdFm6GXarPozPkvHbPJzxCoBCED7uFbytNlIGQYtD6vRsU RtfA== X-Gm-Message-State: AOAM530j0+20yXKXaUP+yYt0T3xBCY/u4hwvpck8uORQRaewzQbB3DfA 7qf2lCx/8ycXtS/y2LNlGfBIOH+gkeC+KUXorMk= X-Google-Smtp-Source: ABdhPJwvLyrL8/z3f3oeYcfh5RaeZB2rvDsalLA+HVQ+FDuwfMu1r9GNC9grwWebJSLxVHBZqstuKTAHNHQYm1JYjGE= X-Received: by 2002:a05:6830:1d90:: with SMTP id y16mr13147279oti.200.1643062206810; Mon, 24 Jan 2022 14:10:06 -0800 (PST) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220119224628.123084-1-colin.i.king@gmail.com> In-Reply-To: From: Alex Deucher Date: Mon, 24 Jan 2022 17:09:55 -0500 Message-ID: Subject: Re: [PATCH] drm/radeon: remove redundant assignment to reg To: Nick Desaulniers Cc: Colin Ian King , llvm@lists.linux.dev, David Airlie , xinhui pan , kernel-janitors@vger.kernel.org, LKML , amd-gfx list , Maling list - DRI developers , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Applied. Thanks! Alex On Mon, Jan 24, 2022 at 3:21 PM Nick Desaulniers wrote: > > On Wed, Jan 19, 2022 at 2:46 PM Colin Ian King wrote: > > > > The pointer reg is being assigned a value that is not read, the > > exit path via label 'out' never accesses it. The assignment is > > redundant and can be removed. > > > > Cleans up clang scan build warning: > > drivers/gpu/drm/radeon/radeon_object.c:570:3: warning: Value > > stored to 'reg' is never read [deadcode.DeadStores] > > > > Signed-off-by: Colin Ian King > > Thanks for the patch! > Reviewed-by: Nick Desaulniers > > > --- > > drivers/gpu/drm/radeon/radeon_object.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c > > index 56ede9d63b12..87536d205593 100644 > > --- a/drivers/gpu/drm/radeon/radeon_object.c > > +++ b/drivers/gpu/drm/radeon/radeon_object.c > > @@ -567,7 +567,6 @@ int radeon_bo_get_surface_reg(struct radeon_bo *bo) > > return 0; > > > > if (bo->surface_reg >= 0) { > > - reg = &rdev->surface_regs[bo->surface_reg]; > > i = bo->surface_reg; > > goto out; > > } > > -- > > 2.33.1 > > > > > > > -- > Thanks, > ~Nick Desaulniers