From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F12D0C63777 for ; Mon, 30 Nov 2020 23:10:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8340020857 for ; Mon, 30 Nov 2020 23:10:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nOPRVaN2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731143AbgK3XKB (ORCPT ); Mon, 30 Nov 2020 18:10:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730406AbgK3XKA (ORCPT ); Mon, 30 Nov 2020 18:10:00 -0500 Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A753FC0613CF for ; Mon, 30 Nov 2020 15:09:20 -0800 (PST) Received: by mail-ot1-x341.google.com with SMTP id f12so13008541oto.10 for ; Mon, 30 Nov 2020 15:09:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=J/JA2QHuMpYftB+Osd3l6b/sOo2jHBKPSU8ic35WqME=; b=nOPRVaN2A1Le1NwZHS3q6mYRIhcuB7foKxQN64YeNJn/uuBx+RG1P6JclOCG+oy8ko pvpNgIfCshDjKK4kooB7p2oIYcytgpwmg9zut0uWDNyPs38wXK0M8p3XbNtWlM86VrYb ADl3XIIMGbPHST15YX8aRdqbIoC7i11VKjQHJMRNqLy+8zXvIbiNWoACkqbdp7XaJr+D A5I4ipaXHMUEI5EfUpWafL8vgzvBd3YY54S4/WX9TF/0cyZkRKTncu6JZPTp/zm93WnN Bz+sucYWuLVcZj4dGBsoSxFiNlUgM1jfxiG69rS6N9i9/4MOxHoaV3j44s7yZhWbi+zB 2nkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=J/JA2QHuMpYftB+Osd3l6b/sOo2jHBKPSU8ic35WqME=; b=TqaYRkT+SKazpxV3jB75MQV9MdDjvVS6m/HaRzeh47fO2N7ig07gjeeNxgLS6EoFgT cnUkk5wrOtU9m0RD5rJvt7eA/yeBDskR+jbi78I5kdGQStiHggEj6de+9PAVrmvOV26o xdQa2UpmY4bkOb2mvR+Rgr1saSTKMLcx9/YuO0VlBC2h3FWbZRgzXU11raVL0nzfepsr tulAnV9QwpR51+zs51KZOO5dIE0vYAdjaeNOkwUX57flNxNEV5TDZ2/DyzSFDbo6wMta 7B7dJ8coHIFQkyByRH6w/Kn9caPj/08UHSQ18M7La8FTz3oJO4BmsDNcarcVKElAldY3 yNKw== X-Gm-Message-State: AOAM531goMUor1cTzb7+socpnTEUj5DSxDu+1uBmrpXcMwAZb8Jfbxsn EmWhsRDWW/JT0G5WpEyIyvjrY0nTHA5Kan4IGreHxMEJ X-Google-Smtp-Source: ABdhPJxCSXUMPP0ZI97R0IC/K40/cxIU5+ZMkCy3yWJIZXmdRE+bjla5Nxc+Y2fG7e73MWuOH4H9h70bydvMKNOy2MI= X-Received: by 2002:a9d:4713:: with SMTP id a19mr19320659otf.132.1606777760122; Mon, 30 Nov 2020 15:09:20 -0800 (PST) MIME-Version: 1.0 References: <20201126134240.3214176-1-lee.jones@linaro.org> <20201126134240.3214176-2-lee.jones@linaro.org> In-Reply-To: <20201126134240.3214176-2-lee.jones@linaro.org> From: Alex Deucher Date: Mon, 30 Nov 2020 18:09:08 -0500 Message-ID: Subject: Re: [PATCH 01/40] drm/amd/pm/powerplay/smumgr/tonga_smumgr: Remove set but unused variable 'res' To: Lee Jones Cc: David Airlie , LKML , amd-gfx list , Maling list - DRI developers , Alex Deucher , Evan Quan , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 26, 2020 at 8:42 AM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/tonga_smumgr.c: In fun= ction =E2=80=98tonga_thermal_setup_fan_table=E2=80=99: > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/tonga_smumgr.c:2469:6:= warning: variable =E2=80=98res=E2=80=99 set but not used [-Wunused-but-set= -variable] > > Cc: Evan Quan > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones > --- > drivers/gpu/drm/amd/pm/powerplay/smumgr/tonga_smumgr.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/tonga_smumgr.c b/dri= vers/gpu/drm/amd/pm/powerplay/smumgr/tonga_smumgr.c > index 4bfadb49521bc..c28f3e1299701 100644 > --- a/drivers/gpu/drm/amd/pm/powerplay/smumgr/tonga_smumgr.c > +++ b/drivers/gpu/drm/amd/pm/powerplay/smumgr/tonga_smumgr.c > @@ -2466,7 +2466,6 @@ static int tonga_thermal_setup_fan_table(struct pp_= hwmgr *hwmgr) > uint32_t t_diff1, t_diff2, pwm_diff1, pwm_diff2; > uint16_t fdo_min, slope1, slope2; > uint32_t reference_clock; > - int res; > uint64_t tmp64; > > if (!phm_cap_enabled(hwmgr->platform_descriptor.platformCaps, > @@ -2539,11 +2538,9 @@ static int tonga_thermal_setup_fan_table(struct pp= _hwmgr *hwmgr) > > fan_table.FanControl_GL_Flag =3D 1; > > - res =3D smu7_copy_bytes_to_smc(hwmgr, > - smu_data->smu7_data.fan_table_sta= rt, > - (uint8_t *)&fan_table, > - (uint32_t)sizeof(fan_table), > - SMC_RAM_END); > + smu7_copy_bytes_to_smc(hwmgr, smu_data->smu7_data.fan_table_start= , > + (uint8_t *)&fan_table, > + (uint32_t)sizeof(fan_table), SMC_RAM_END); > We should probably return the error here rather than dropping it. I'll send out a patch. Thanks, Alex > return 0; > } > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70671C63777 for ; Mon, 30 Nov 2020 23:09:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC8902076C for ; Mon, 30 Nov 2020 23:09:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nOPRVaN2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC8902076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F02FF8997E; Mon, 30 Nov 2020 23:09:21 +0000 (UTC) Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id B4BAD8996F; Mon, 30 Nov 2020 23:09:20 +0000 (UTC) Received: by mail-ot1-x343.google.com with SMTP id h19so13083948otr.1; Mon, 30 Nov 2020 15:09:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=J/JA2QHuMpYftB+Osd3l6b/sOo2jHBKPSU8ic35WqME=; b=nOPRVaN2A1Le1NwZHS3q6mYRIhcuB7foKxQN64YeNJn/uuBx+RG1P6JclOCG+oy8ko pvpNgIfCshDjKK4kooB7p2oIYcytgpwmg9zut0uWDNyPs38wXK0M8p3XbNtWlM86VrYb ADl3XIIMGbPHST15YX8aRdqbIoC7i11VKjQHJMRNqLy+8zXvIbiNWoACkqbdp7XaJr+D A5I4ipaXHMUEI5EfUpWafL8vgzvBd3YY54S4/WX9TF/0cyZkRKTncu6JZPTp/zm93WnN Bz+sucYWuLVcZj4dGBsoSxFiNlUgM1jfxiG69rS6N9i9/4MOxHoaV3j44s7yZhWbi+zB 2nkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=J/JA2QHuMpYftB+Osd3l6b/sOo2jHBKPSU8ic35WqME=; b=DaC1wHEU2b6HgEXYrBOesZad1lj4LUuHH7JHr6SXRJJY2YONZ3FXxssyL6GlGJWnAK oXZbdIEmDYb2av2XgOxIWLHntpz1Xue+H2Aw1/tUtn30MD7fqEHUFRqnxt0GvSVQI3HJ 37Zt59tDp3kGZ3POkfZjqvPDlK0oMdA45UNkhF9KbknfvDgEdSHC902zCsSsINrBtOwm AZWqYknthxW3kQYPoXUC1UkHI0efvk7tArAzGNisMNfe4mRTlEUsBt4aGa2d3Ww1s4OT m/GUgqzedSti7A6H4jy3bs0WMG+2lK13zee+Ek9WljlZsp4ATrHV53k5r/UaV3k4m3Av Xdow== X-Gm-Message-State: AOAM53092ggcioMLYZVAQ2bfJpUp24Ic5hInMTu0YbHBJDNFagT8f2DE s8PNnJb7zhRWoia0sY8JenlTiDQzJKia/dUgCrQ= X-Google-Smtp-Source: ABdhPJxCSXUMPP0ZI97R0IC/K40/cxIU5+ZMkCy3yWJIZXmdRE+bjla5Nxc+Y2fG7e73MWuOH4H9h70bydvMKNOy2MI= X-Received: by 2002:a9d:4713:: with SMTP id a19mr19320659otf.132.1606777760122; Mon, 30 Nov 2020 15:09:20 -0800 (PST) MIME-Version: 1.0 References: <20201126134240.3214176-1-lee.jones@linaro.org> <20201126134240.3214176-2-lee.jones@linaro.org> In-Reply-To: <20201126134240.3214176-2-lee.jones@linaro.org> From: Alex Deucher Date: Mon, 30 Nov 2020 18:09:08 -0500 Message-ID: Subject: Re: [PATCH 01/40] drm/amd/pm/powerplay/smumgr/tonga_smumgr: Remove set but unused variable 'res' To: Lee Jones X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , amd-gfx list , Alex Deucher , Evan Quan , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVGh1LCBOb3YgMjYsIDIwMjAgYXQgODo0MiBBTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5h cm8ub3JnPiB3cm90ZToKPgo+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3 YXJuaW5nKHMpOgo+Cj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1Ly4uL3BtL3Bvd2VycGxh eS9zbXVtZ3IvdG9uZ2Ffc211bWdyLmM6IEluIGZ1bmN0aW9uIOKAmHRvbmdhX3RoZXJtYWxfc2V0 dXBfZmFuX3RhYmxl4oCZOgo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS8uLi9wbS9wb3dl cnBsYXkvc211bWdyL3RvbmdhX3NtdW1nci5jOjI0Njk6Njogd2FybmluZzogdmFyaWFibGUg4oCY cmVz4oCZIHNldCBidXQgbm90IHVzZWQgWy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGVdCj4KPiBD YzogRXZhbiBRdWFuIDxldmFuLnF1YW5AYW1kLmNvbT4KPiBDYzogQWxleCBEZXVjaGVyIDxhbGV4 YW5kZXIuZGV1Y2hlckBhbWQuY29tPgo+IENjOiAiQ2hyaXN0aWFuIEvDtm5pZyIgPGNocmlzdGlh bi5rb2VuaWdAYW1kLmNvbT4KPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgo+ IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gQ2M6IGFtZC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBT aWduZWQtb2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vYW1kL3BtL3Bvd2VycGxheS9zbXVtZ3IvdG9uZ2Ffc211bWdyLmMgfCA5 ICsrKy0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9u cygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG0vcG93ZXJwbGF5L3Nt dW1nci90b25nYV9zbXVtZ3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG0vcG93ZXJwbGF5L3Nt dW1nci90b25nYV9zbXVtZ3IuYwo+IGluZGV4IDRiZmFkYjQ5NTIxYmMuLmMyOGYzZTEyOTk3MDEg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9wbS9wb3dlcnBsYXkvc211bWdyL3Rv bmdhX3NtdW1nci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9wbS9wb3dlcnBsYXkvc211 bWdyL3RvbmdhX3NtdW1nci5jCj4gQEAgLTI0NjYsNyArMjQ2Niw2IEBAIHN0YXRpYyBpbnQgdG9u Z2FfdGhlcm1hbF9zZXR1cF9mYW5fdGFibGUoc3RydWN0IHBwX2h3bWdyICpod21ncikKPiAgICAg ICAgIHVpbnQzMl90IHRfZGlmZjEsIHRfZGlmZjIsIHB3bV9kaWZmMSwgcHdtX2RpZmYyOwo+ICAg ICAgICAgdWludDE2X3QgZmRvX21pbiwgc2xvcGUxLCBzbG9wZTI7Cj4gICAgICAgICB1aW50MzJf dCByZWZlcmVuY2VfY2xvY2s7Cj4gLSAgICAgICBpbnQgcmVzOwo+ICAgICAgICAgdWludDY0X3Qg dG1wNjQ7Cj4KPiAgICAgICAgIGlmICghcGhtX2NhcF9lbmFibGVkKGh3bWdyLT5wbGF0Zm9ybV9k ZXNjcmlwdG9yLnBsYXRmb3JtQ2FwcywKPiBAQCAtMjUzOSwxMSArMjUzOCw5IEBAIHN0YXRpYyBp bnQgdG9uZ2FfdGhlcm1hbF9zZXR1cF9mYW5fdGFibGUoc3RydWN0IHBwX2h3bWdyICpod21ncikK Pgo+ICAgICAgICAgZmFuX3RhYmxlLkZhbkNvbnRyb2xfR0xfRmxhZyA9IDE7Cj4KPiAtICAgICAg IHJlcyA9IHNtdTdfY29weV9ieXRlc190b19zbWMoaHdtZ3IsCj4gLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHNtdV9kYXRhLT5zbXU3X2RhdGEuZmFuX3RhYmxlX3N0YXJ0 LAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAodWludDhfdCAqKSZm YW5fdGFibGUsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICh1aW50 MzJfdClzaXplb2YoZmFuX3RhYmxlKSwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgU01DX1JBTV9FTkQpOwo+ICsgICAgICAgc211N19jb3B5X2J5dGVzX3RvX3NtYyho d21nciwgc211X2RhdGEtPnNtdTdfZGF0YS5mYW5fdGFibGVfc3RhcnQsCj4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICh1aW50OF90ICopJmZhbl90YWJsZSwKPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKHVpbnQzMl90KXNpemVvZihmYW5fdGFibGUpLCBTTUNfUkFNX0VO RCk7Cj4KCldlIHNob3VsZCBwcm9iYWJseSByZXR1cm4gdGhlIGVycm9yIGhlcmUgcmF0aGVyIHRo YW4gZHJvcHBpbmcgaXQuCkknbGwgc2VuZCBvdXQgYSBwYXRjaC4KClRoYW5rcywKCkFsZXgKCgo+ ICAgICAgICAgcmV0dXJuIDA7Cj4gIH0KPiAtLQo+IDIuMjUuMQo+Cj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0 Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BBEBC64E7B for ; Mon, 30 Nov 2020 23:09:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6E922076C for ; Mon, 30 Nov 2020 23:09:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nOPRVaN2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6E922076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3742C8996F; Mon, 30 Nov 2020 23:09:21 +0000 (UTC) Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id B4BAD8996F; Mon, 30 Nov 2020 23:09:20 +0000 (UTC) Received: by mail-ot1-x343.google.com with SMTP id h19so13083948otr.1; Mon, 30 Nov 2020 15:09:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=J/JA2QHuMpYftB+Osd3l6b/sOo2jHBKPSU8ic35WqME=; b=nOPRVaN2A1Le1NwZHS3q6mYRIhcuB7foKxQN64YeNJn/uuBx+RG1P6JclOCG+oy8ko pvpNgIfCshDjKK4kooB7p2oIYcytgpwmg9zut0uWDNyPs38wXK0M8p3XbNtWlM86VrYb ADl3XIIMGbPHST15YX8aRdqbIoC7i11VKjQHJMRNqLy+8zXvIbiNWoACkqbdp7XaJr+D A5I4ipaXHMUEI5EfUpWafL8vgzvBd3YY54S4/WX9TF/0cyZkRKTncu6JZPTp/zm93WnN Bz+sucYWuLVcZj4dGBsoSxFiNlUgM1jfxiG69rS6N9i9/4MOxHoaV3j44s7yZhWbi+zB 2nkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=J/JA2QHuMpYftB+Osd3l6b/sOo2jHBKPSU8ic35WqME=; b=DaC1wHEU2b6HgEXYrBOesZad1lj4LUuHH7JHr6SXRJJY2YONZ3FXxssyL6GlGJWnAK oXZbdIEmDYb2av2XgOxIWLHntpz1Xue+H2Aw1/tUtn30MD7fqEHUFRqnxt0GvSVQI3HJ 37Zt59tDp3kGZ3POkfZjqvPDlK0oMdA45UNkhF9KbknfvDgEdSHC902zCsSsINrBtOwm AZWqYknthxW3kQYPoXUC1UkHI0efvk7tArAzGNisMNfe4mRTlEUsBt4aGa2d3Ww1s4OT m/GUgqzedSti7A6H4jy3bs0WMG+2lK13zee+Ek9WljlZsp4ATrHV53k5r/UaV3k4m3Av Xdow== X-Gm-Message-State: AOAM53092ggcioMLYZVAQ2bfJpUp24Ic5hInMTu0YbHBJDNFagT8f2DE s8PNnJb7zhRWoia0sY8JenlTiDQzJKia/dUgCrQ= X-Google-Smtp-Source: ABdhPJxCSXUMPP0ZI97R0IC/K40/cxIU5+ZMkCy3yWJIZXmdRE+bjla5Nxc+Y2fG7e73MWuOH4H9h70bydvMKNOy2MI= X-Received: by 2002:a9d:4713:: with SMTP id a19mr19320659otf.132.1606777760122; Mon, 30 Nov 2020 15:09:20 -0800 (PST) MIME-Version: 1.0 References: <20201126134240.3214176-1-lee.jones@linaro.org> <20201126134240.3214176-2-lee.jones@linaro.org> In-Reply-To: <20201126134240.3214176-2-lee.jones@linaro.org> From: Alex Deucher Date: Mon, 30 Nov 2020 18:09:08 -0500 Message-ID: Subject: Re: [PATCH 01/40] drm/amd/pm/powerplay/smumgr/tonga_smumgr: Remove set but unused variable 'res' To: Lee Jones X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , amd-gfx list , Alex Deucher , Evan Quan , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" T24gVGh1LCBOb3YgMjYsIDIwMjAgYXQgODo0MiBBTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5h cm8ub3JnPiB3cm90ZToKPgo+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3 YXJuaW5nKHMpOgo+Cj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1Ly4uL3BtL3Bvd2VycGxh eS9zbXVtZ3IvdG9uZ2Ffc211bWdyLmM6IEluIGZ1bmN0aW9uIOKAmHRvbmdhX3RoZXJtYWxfc2V0 dXBfZmFuX3RhYmxl4oCZOgo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS8uLi9wbS9wb3dl cnBsYXkvc211bWdyL3RvbmdhX3NtdW1nci5jOjI0Njk6Njogd2FybmluZzogdmFyaWFibGUg4oCY cmVz4oCZIHNldCBidXQgbm90IHVzZWQgWy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGVdCj4KPiBD YzogRXZhbiBRdWFuIDxldmFuLnF1YW5AYW1kLmNvbT4KPiBDYzogQWxleCBEZXVjaGVyIDxhbGV4 YW5kZXIuZGV1Y2hlckBhbWQuY29tPgo+IENjOiAiQ2hyaXN0aWFuIEvDtm5pZyIgPGNocmlzdGlh bi5rb2VuaWdAYW1kLmNvbT4KPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgo+ IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gQ2M6IGFtZC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBT aWduZWQtb2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vYW1kL3BtL3Bvd2VycGxheS9zbXVtZ3IvdG9uZ2Ffc211bWdyLmMgfCA5 ICsrKy0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9u cygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG0vcG93ZXJwbGF5L3Nt dW1nci90b25nYV9zbXVtZ3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG0vcG93ZXJwbGF5L3Nt dW1nci90b25nYV9zbXVtZ3IuYwo+IGluZGV4IDRiZmFkYjQ5NTIxYmMuLmMyOGYzZTEyOTk3MDEg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9wbS9wb3dlcnBsYXkvc211bWdyL3Rv bmdhX3NtdW1nci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9wbS9wb3dlcnBsYXkvc211 bWdyL3RvbmdhX3NtdW1nci5jCj4gQEAgLTI0NjYsNyArMjQ2Niw2IEBAIHN0YXRpYyBpbnQgdG9u Z2FfdGhlcm1hbF9zZXR1cF9mYW5fdGFibGUoc3RydWN0IHBwX2h3bWdyICpod21ncikKPiAgICAg ICAgIHVpbnQzMl90IHRfZGlmZjEsIHRfZGlmZjIsIHB3bV9kaWZmMSwgcHdtX2RpZmYyOwo+ICAg ICAgICAgdWludDE2X3QgZmRvX21pbiwgc2xvcGUxLCBzbG9wZTI7Cj4gICAgICAgICB1aW50MzJf dCByZWZlcmVuY2VfY2xvY2s7Cj4gLSAgICAgICBpbnQgcmVzOwo+ICAgICAgICAgdWludDY0X3Qg dG1wNjQ7Cj4KPiAgICAgICAgIGlmICghcGhtX2NhcF9lbmFibGVkKGh3bWdyLT5wbGF0Zm9ybV9k ZXNjcmlwdG9yLnBsYXRmb3JtQ2FwcywKPiBAQCAtMjUzOSwxMSArMjUzOCw5IEBAIHN0YXRpYyBp bnQgdG9uZ2FfdGhlcm1hbF9zZXR1cF9mYW5fdGFibGUoc3RydWN0IHBwX2h3bWdyICpod21ncikK Pgo+ICAgICAgICAgZmFuX3RhYmxlLkZhbkNvbnRyb2xfR0xfRmxhZyA9IDE7Cj4KPiAtICAgICAg IHJlcyA9IHNtdTdfY29weV9ieXRlc190b19zbWMoaHdtZ3IsCj4gLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHNtdV9kYXRhLT5zbXU3X2RhdGEuZmFuX3RhYmxlX3N0YXJ0 LAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAodWludDhfdCAqKSZm YW5fdGFibGUsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICh1aW50 MzJfdClzaXplb2YoZmFuX3RhYmxlKSwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgU01DX1JBTV9FTkQpOwo+ICsgICAgICAgc211N19jb3B5X2J5dGVzX3RvX3NtYyho d21nciwgc211X2RhdGEtPnNtdTdfZGF0YS5mYW5fdGFibGVfc3RhcnQsCj4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICh1aW50OF90ICopJmZhbl90YWJsZSwKPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKHVpbnQzMl90KXNpemVvZihmYW5fdGFibGUpLCBTTUNfUkFNX0VO RCk7Cj4KCldlIHNob3VsZCBwcm9iYWJseSByZXR1cm4gdGhlIGVycm9yIGhlcmUgcmF0aGVyIHRo YW4gZHJvcHBpbmcgaXQuCkknbGwgc2VuZCBvdXQgYSBwYXRjaC4KClRoYW5rcywKCkFsZXgKCgo+ ICAgICAgICAgcmV0dXJuIDA7Cj4gIH0KPiAtLQo+IDIuMjUuMQo+Cj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0 Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vYW1kLWdmeAo=