From: Alex Deucher <alexdeucher@gmail.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Roman Li <Roman.Li@amd.com>,
amd-gfx list <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v3] drm/amd/display: Look at firmware version to determine using dmub on dcn21
Date: Tue, 2 Nov 2021 11:57:43 -0400 [thread overview]
Message-ID: <CADnq5_P6osKedfyZoENxx471hg7jbsjEfP=2n7rniDq2+fHp3A@mail.gmail.com> (raw)
In-Reply-To: <20211102150437.19370-1-mario.limonciello@amd.com>
On Tue, Nov 2, 2021 at 11:04 AM Mario Limonciello
<mario.limonciello@amd.com> wrote:
>
> commit b1c61212d8dc ("drm/amd/display: Fully switch to dmub for all dcn21
> asics") switched over to using dmub on Renoir to fix Gitlab 1735, but this
> implied a new dependency on newer firmware which might not be met on older
> kernel versions.
>
> Since sw_init runs before hw_init, there is an opportunity to determine
> whether or not the firmware version is new to adjust the behavior.
>
> Cc: Roman.Li@amd.com
> BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1772
> BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1735
> Fixes: b1c61212d8dc ("drm/amd/display: Fully switch to dmub for all dcn21 asics")
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> Changes from v2->v3:
> * Don't special case Green Sardine / Renoir anymore
> * Special case the two Renoir firmware that have this problem
> (that weren't released for green sardine)
> * Special case development version of ucode version
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index b48f3cb5ddeb..dcc97ef28c50 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -1410,7 +1410,15 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
> switch (adev->ip_versions[DCE_HWIP][0]) {
> case IP_VERSION(2, 1, 0):
> init_data.flags.gpu_vm_support = true;
> + switch (adev->dm.dmcub_fw_version) {
> + case 0: /* development */
> + case 0x1: /* linux-firmware.git hash 6d9f399 */
> + case 0x01000000: /* linux-firmware.git hash 9a0b0f4 */
> + init_data.flags.disable_dmcu = false;
> + break;
> + default:
> init_data.flags.disable_dmcu = true;
> + }
> break;
> case IP_VERSION(1, 0, 0):
> case IP_VERSION(1, 0, 1):
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-11-02 15:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 15:04 [PATCH v3] drm/amd/display: Look at firmware version to determine using dmub on dcn21 Mario Limonciello
2021-11-02 15:57 ` Alex Deucher [this message]
2021-11-02 16:09 ` Li, Roman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_P6osKedfyZoENxx471hg7jbsjEfP=2n7rniDq2+fHp3A@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=Roman.Li@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=mario.limonciello@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.