From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B342C433EF for ; Wed, 23 Mar 2022 21:42:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344968AbiCWVn7 (ORCPT ); Wed, 23 Mar 2022 17:43:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234033AbiCWVn6 (ORCPT ); Wed, 23 Mar 2022 17:43:58 -0400 Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1540E85952 for ; Wed, 23 Mar 2022 14:42:28 -0700 (PDT) Received: by mail-ot1-x32e.google.com with SMTP id i23-20020a9d6117000000b005cb58c354e6so1996459otj.10 for ; Wed, 23 Mar 2022 14:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gauJU+/Ukt87qElnbOCar/GeP644jnPenO1H+olAZxI=; b=cswYNs/WyXAL6DSvgYLR3dF6cUIcVKCxSQGRNXV786efwrusYDE0bclQvwL/1eYS9t vThDuK/9GhGm5Ws+5z71Qd6WANakCW1IxYdEHRVO7aP16V8R06I2LqJrdw4RATCO1HP0 UUGnJhwwcsp+xk/fmmMo/rX+1/XfoPXgN3W38qwm7MH+c8m3HzAOcpFmrbcAhGuFJHfX Vw5+f9RS596X3GChcf3jnVR4yHuJTrMPuhPEsnm8gzpHE3KwO/joTbHm5QXM0P67HP7h kV7tMbBorXJ887ivq0y7jr9VBFPDYpcw9XRIV3B7VBq9qM221sxbmH/8tVfi1WkmyQp0 i0dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gauJU+/Ukt87qElnbOCar/GeP644jnPenO1H+olAZxI=; b=50h7k0kKQ+JdkpR0dWkCgvHNv7G93l0ocIBsJ3UHD/vvRbtFxF8C+OMJuC6B1+wiPF RYgKbC3/eTlJ7cZASAUOBnYg8U4Ptp+qyqfJWm6sZYXMasTDm5gnhdbr/HivfRKQutaF ZELvcgTp9HviwGf5v5MQxob29vC8QbUKXKaex58mXXKs3BLC3OEZA/HSlKqhrsEORnar //yKNIcY11lXS+mXpSOqO8/rlRQwAYptvvfGcIXq5BZ4QeDTCBWTCDB/3zq9wdPjZa/6 1a2E4rXm2CJPqCLf+hRN99yZUe69PP45XO85zkTk7Ph39VPzkOPYy4z/e4+ZVLf+Z0hp tKKQ== X-Gm-Message-State: AOAM533TZvhRuKov+8YV+9It3xDR00H4YIBPh30KMwFvM5KYoLIO1vAn PT1bTtnlglFsdZgx1C6oyqZTmrkTYAWu2kR9Z8o= X-Google-Smtp-Source: ABdhPJxUgqnvMju0kQuK4cFRp3woy6+I3sh81LdOzyl9ntgr/e/GmMKsqkaDy48Yz3SiqBg8bmw7SQ3TapKKosYD62I= X-Received: by 2002:a05:6830:10c3:b0:5cd:481a:148a with SMTP id z3-20020a05683010c300b005cd481a148amr913080oto.200.1648071747457; Wed, 23 Mar 2022 14:42:27 -0700 (PDT) MIME-Version: 1.0 References: <1647943132-31250-1-git-send-email-baihaowen@meizu.com> In-Reply-To: <1647943132-31250-1-git-send-email-baihaowen@meizu.com> From: Alex Deucher Date: Wed, 23 Mar 2022 17:42:16 -0400 Message-ID: Subject: Re: [PATCH] drm/amd/display: use NULL instead of using plain integer as pointer To: Haowen Bai Cc: "Wentland, Harry" , "Leo (Sunpeng) Li" , "Siqueira, Rodrigo" , "Deucher, Alexander" , Christian Koenig , xinhui pan , Maling list - DRI developers , amd-gfx list , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for the patches. I've already applied fixes from others for these issues. Alex On Tue, Mar 22, 2022 at 9:05 AM Haowen Bai wrote: > > This fixes the following sparse warnings: > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dsc/rc_calc_fpu.c:71:40: warning: Using > plain integer as NULL pointer > > Signed-off-by: Haowen Bai > --- > drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c b/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c > index ec636d0..ef75eb7 100644 > --- a/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c > +++ b/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c > @@ -68,7 +68,7 @@ static void get_qp_set(qp_set qps, enum colour_mode cm, enum bits_per_comp bpc, > int sel = table_hash(mode, bpc, max_min); > int table_size = 0; > int index; > - const struct qp_entry *table = 0L; > + const struct qp_entry *table = NULL; > > // alias enum > enum { min = DAL_MM_MIN, max = DAL_MM_MAX }; > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1EEEC433FE for ; Wed, 23 Mar 2022 21:42:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0098710E072; Wed, 23 Mar 2022 21:42:29 +0000 (UTC) Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2608610E072; Wed, 23 Mar 2022 21:42:28 +0000 (UTC) Received: by mail-ot1-x334.google.com with SMTP id d15-20020a9d72cf000000b005cda54187c3so2014834otk.2; Wed, 23 Mar 2022 14:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gauJU+/Ukt87qElnbOCar/GeP644jnPenO1H+olAZxI=; b=cswYNs/WyXAL6DSvgYLR3dF6cUIcVKCxSQGRNXV786efwrusYDE0bclQvwL/1eYS9t vThDuK/9GhGm5Ws+5z71Qd6WANakCW1IxYdEHRVO7aP16V8R06I2LqJrdw4RATCO1HP0 UUGnJhwwcsp+xk/fmmMo/rX+1/XfoPXgN3W38qwm7MH+c8m3HzAOcpFmrbcAhGuFJHfX Vw5+f9RS596X3GChcf3jnVR4yHuJTrMPuhPEsnm8gzpHE3KwO/joTbHm5QXM0P67HP7h kV7tMbBorXJ887ivq0y7jr9VBFPDYpcw9XRIV3B7VBq9qM221sxbmH/8tVfi1WkmyQp0 i0dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gauJU+/Ukt87qElnbOCar/GeP644jnPenO1H+olAZxI=; b=UpkuTs7QPTgCm2fKgTc323YP88GaEhJkYc5C577jH9kRcFck0bGk3UutAoXK4nN+SB PH+JjW1VwCq2DIUkjofAJFVb1PXoZkzPuS6NnpTNrLtb9bKyMaw/9kGewZYRDpK2TnVS CwaMCSGb/aMzRJfCzQUfBjKDbAVnhU37QJfLOlA30ul954qkkP+gtgZVCmW2Zh1BQoJz xryf7T51wGcNrFAfJPdNMy88FbPw0elCkOKuSCy7s43Ku5Zht7+C//2Wg29Lj6QZ1QSG pTLMtba1ZVZFr1uPpno50MHwmRQkmosxUTTeYwXfe0etogAY4WW7U3l6G3dLFh81BS8n 5m0w== X-Gm-Message-State: AOAM533iOB9r5X/9aG0kQdK2IHsqU18iyvWHUh9fKBXz+0AJEu+SzI6g f1Kj418w9PMkBfEZl1gsbG0aGHtFWAwBZMU96LcCBDod+bU= X-Google-Smtp-Source: ABdhPJxUgqnvMju0kQuK4cFRp3woy6+I3sh81LdOzyl9ntgr/e/GmMKsqkaDy48Yz3SiqBg8bmw7SQ3TapKKosYD62I= X-Received: by 2002:a05:6830:10c3:b0:5cd:481a:148a with SMTP id z3-20020a05683010c300b005cd481a148amr913080oto.200.1648071747457; Wed, 23 Mar 2022 14:42:27 -0700 (PDT) MIME-Version: 1.0 References: <1647943132-31250-1-git-send-email-baihaowen@meizu.com> In-Reply-To: <1647943132-31250-1-git-send-email-baihaowen@meizu.com> From: Alex Deucher Date: Wed, 23 Mar 2022 17:42:16 -0400 Message-ID: Subject: Re: [PATCH] drm/amd/display: use NULL instead of using plain integer as pointer To: Haowen Bai Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Leo \(Sunpeng\) Li" , xinhui pan , "Siqueira, Rodrigo" , LKML , Maling list - DRI developers , amd-gfx list , "Deucher, Alexander" , Christian Koenig Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thanks for the patches. I've already applied fixes from others for these issues. Alex On Tue, Mar 22, 2022 at 9:05 AM Haowen Bai wrote: > > This fixes the following sparse warnings: > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dsc/rc_calc_fpu.c:71:40: warning: Using > plain integer as NULL pointer > > Signed-off-by: Haowen Bai > --- > drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c b/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c > index ec636d0..ef75eb7 100644 > --- a/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c > +++ b/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c > @@ -68,7 +68,7 @@ static void get_qp_set(qp_set qps, enum colour_mode cm, enum bits_per_comp bpc, > int sel = table_hash(mode, bpc, max_min); > int table_size = 0; > int index; > - const struct qp_entry *table = 0L; > + const struct qp_entry *table = NULL; > > // alias enum > enum { min = DAL_MM_MIN, max = DAL_MM_MAX }; > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8918CC433F5 for ; Wed, 23 Mar 2022 21:42:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 723AC10E0A3; Wed, 23 Mar 2022 21:42:29 +0000 (UTC) Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2608610E072; Wed, 23 Mar 2022 21:42:28 +0000 (UTC) Received: by mail-ot1-x334.google.com with SMTP id d15-20020a9d72cf000000b005cda54187c3so2014834otk.2; Wed, 23 Mar 2022 14:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gauJU+/Ukt87qElnbOCar/GeP644jnPenO1H+olAZxI=; b=cswYNs/WyXAL6DSvgYLR3dF6cUIcVKCxSQGRNXV786efwrusYDE0bclQvwL/1eYS9t vThDuK/9GhGm5Ws+5z71Qd6WANakCW1IxYdEHRVO7aP16V8R06I2LqJrdw4RATCO1HP0 UUGnJhwwcsp+xk/fmmMo/rX+1/XfoPXgN3W38qwm7MH+c8m3HzAOcpFmrbcAhGuFJHfX Vw5+f9RS596X3GChcf3jnVR4yHuJTrMPuhPEsnm8gzpHE3KwO/joTbHm5QXM0P67HP7h kV7tMbBorXJ887ivq0y7jr9VBFPDYpcw9XRIV3B7VBq9qM221sxbmH/8tVfi1WkmyQp0 i0dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gauJU+/Ukt87qElnbOCar/GeP644jnPenO1H+olAZxI=; b=UpkuTs7QPTgCm2fKgTc323YP88GaEhJkYc5C577jH9kRcFck0bGk3UutAoXK4nN+SB PH+JjW1VwCq2DIUkjofAJFVb1PXoZkzPuS6NnpTNrLtb9bKyMaw/9kGewZYRDpK2TnVS CwaMCSGb/aMzRJfCzQUfBjKDbAVnhU37QJfLOlA30ul954qkkP+gtgZVCmW2Zh1BQoJz xryf7T51wGcNrFAfJPdNMy88FbPw0elCkOKuSCy7s43Ku5Zht7+C//2Wg29Lj6QZ1QSG pTLMtba1ZVZFr1uPpno50MHwmRQkmosxUTTeYwXfe0etogAY4WW7U3l6G3dLFh81BS8n 5m0w== X-Gm-Message-State: AOAM533iOB9r5X/9aG0kQdK2IHsqU18iyvWHUh9fKBXz+0AJEu+SzI6g f1Kj418w9PMkBfEZl1gsbG0aGHtFWAwBZMU96LcCBDod+bU= X-Google-Smtp-Source: ABdhPJxUgqnvMju0kQuK4cFRp3woy6+I3sh81LdOzyl9ntgr/e/GmMKsqkaDy48Yz3SiqBg8bmw7SQ3TapKKosYD62I= X-Received: by 2002:a05:6830:10c3:b0:5cd:481a:148a with SMTP id z3-20020a05683010c300b005cd481a148amr913080oto.200.1648071747457; Wed, 23 Mar 2022 14:42:27 -0700 (PDT) MIME-Version: 1.0 References: <1647943132-31250-1-git-send-email-baihaowen@meizu.com> In-Reply-To: <1647943132-31250-1-git-send-email-baihaowen@meizu.com> From: Alex Deucher Date: Wed, 23 Mar 2022 17:42:16 -0400 Message-ID: Subject: Re: [PATCH] drm/amd/display: use NULL instead of using plain integer as pointer To: Haowen Bai Content-Type: text/plain; charset="UTF-8" X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Leo \(Sunpeng\) Li" , xinhui pan , "Siqueira, Rodrigo" , LKML , Maling list - DRI developers , amd-gfx list , "Deucher, Alexander" , "Wentland, Harry" , Christian Koenig Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Thanks for the patches. I've already applied fixes from others for these issues. Alex On Tue, Mar 22, 2022 at 9:05 AM Haowen Bai wrote: > > This fixes the following sparse warnings: > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dsc/rc_calc_fpu.c:71:40: warning: Using > plain integer as NULL pointer > > Signed-off-by: Haowen Bai > --- > drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c b/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c > index ec636d0..ef75eb7 100644 > --- a/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c > +++ b/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c > @@ -68,7 +68,7 @@ static void get_qp_set(qp_set qps, enum colour_mode cm, enum bits_per_comp bpc, > int sel = table_hash(mode, bpc, max_min); > int table_size = 0; > int index; > - const struct qp_entry *table = 0L; > + const struct qp_entry *table = NULL; > > // alias enum > enum { min = DAL_MM_MIN, max = DAL_MM_MAX }; > -- > 2.7.4 >