From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines. Date: Mon, 14 Mar 2016 10:30:50 -0400 Message-ID: References: <1457504045-12738-1-git-send-email-airlied@gmail.com> <2736217.utxPzJExd5@vostro.rjw.lan> <20160311105815.GS1796@lahna.fi.intel.com> <2759763.dR5D0KopkA@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dave Airlie Cc: "Rafael J. Wysocki" , Linux PCI , "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" , Linux Kernel Mailing List , dri-devel , ACPI Devel Maling List , Mika Westerberg List-Id: linux-acpi@vger.kernel.org T24gU3VuLCBNYXIgMTMsIDIwMTYgYXQgMTA6MTkgUE0sIERhdmUgQWlybGllIDxhaXJsaWVkQGdt YWlsLmNvbT4gd3JvdGU6Cj4gT24gMTEgTWFyY2ggMjAxNiBhdCAyMzo0NSwgUmFmYWVsIEouIFd5 c29ja2kgPHJqd0Byand5c29ja2kubmV0PiB3cm90ZToKPj4gT24gRnJpZGF5LCBNYXJjaCAxMSwg MjAxNiAxMjo1ODoxNSBQTSBNaWthIFdlc3RlcmJlcmcgd3JvdGU6Cj4+PiBPbiBUaHUsIE1hciAx MCwgMjAxNiBhdCAwOTo1NzowOVBNICswMTAwLCBSYWZhZWwgSi4gV3lzb2NraSB3cm90ZToKPj4+ ID4gPiBJdCBkb2Vzbid0IHNlZW0gdG8gZG8gYW55IHJ1bnRpbWUgUE0sCj4+PiA+ID4gSSBkbyB3 b25kZXIgaWYgcGNpZXBvcnQgc2hvdWxkIGJlIGRvaW5nIGl0J3Mgb3duIHJ1bnRpbWUgUE0gaGFu ZGxpbmcsCj4+PiA+ID4gYnV0IHRoYXQgaXMgYQo+Pj4gPiA+IGxhcmdlciB0YXNrIHRoYW4gSSdt IHRoaW5raW5nIHRvIHRhY2tsZSBoZXJlLgo+Pj4gPgo+Pj4gPiBQQ0llIHBvcnRzIGRvbid0IGRv IFBNIC0geWV0LiAgTWlrYSBoYXMgcG9zdGVkIGEgc2VyaWVzIG9mIHBhdGNoZXMgdG8gaW1wbGVt ZW50Cj4+PiA+IHRoYXQsIGhvd2V2ZXIsIHRoYXQgYXJlIHdhaXRpbmcgZm9yIGNvbW1lbnRzIG5v dzoKPj4+ID4KPj4+ID4gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC84NDUzMzEx Lwo+Pj4gPiBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzg0NTMzODEvCj4+PiA+ IGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gvODQ1MzM5MS8KPj4+ID4gaHR0cHM6 Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC84NDUzNDExLwo+Pj4gPiBodHRwczovL3BhdGNo d29yay5rZXJuZWwub3JnL3BhdGNoLzg0NTMzNzEvCj4+PiA+IGh0dHBzOi8vcGF0Y2h3b3JrLmtl cm5lbC5vcmcvcGF0Y2gvODQ1MzM1MS8KPj4+ID4KPj4+ID4gPiBNYXliZSBJIHNob3VsZCBiZSBk b2luZwo+Pj4gPiA+Cj4+PiA+ID4gcGNpX3NldF9wb3dlcl9zdGF0ZShwZGV2LT5idXMtPnNlbGYs IFBDSV9EM2NvbGQpID8gSSdtIG5vdCByZWFsbHkgc3VyZS4KPj4+ID4KPj4+ID4gVXNpbmcgcGNp X3NldF9wb3dlcl9zdGF0ZSgpIHdvdWxkIGJlIG1vcmUgYXBwcm9wcmlhdGUgSU1PLCBidXQgeW91 IGNhbiBnZXQKPj4+ID4gdG8gdGhlIGJyaWRnZSB2aWEgZGV2LT5wYXJlbnQgdG9vLCBjYW4ndCB5 b3U/Cj4+PiA+Cj4+PiA+IEluIGFueSBjYXNlLCBpdCBsb29rcyBsaWtlIHlvdSBhbmQgTWlrYSBu ZWVkIHRvIHRhbGsuIDotKQo+Pj4KPj4+IFdoZW4gdGhlIHZnYV9zd2l0Y2hlcm9vIGRldmljZSBn ZXRzIHJ1bnRpbWUgc3VzcGVuZGVkICh3aXRoIHRoZSBhYm92ZQo+Pj4gcnVudGltZSBQTSBwYXRj aHMgZm9yIFBDSWUgcm9vdCBwb3J0cykgdGhlIHJvb3QgcG9ydCBzaG91bGQgYWxzbyBiZQo+Pj4g cnVudGltZSBzdXNwZW5kZWQgYnkgdGhlIFBNIGNvcmUuCj4+Cj4+IFJpZ2h0LCBhZnRlciB5b3Vy IHBhdGNoZXMgaGF2ZSBiZWVuIGFwcGxpZWQsIHRoZSBhZGRpdGlvbmFsIGhhbmRsaW5nCj4+IHdv bid0IGJlIG5lZWRlZC4KPj4KPj4gU28gRGF2ZSwgbWF5YmUgeW91IGNhbiBjaGVjayBpZiB0aGUg TWlrYSdzIHBhdGNoZXMgaGVscD8KPgo+IEhpIE1pa2EsCj4KPiBJIHRlc3RlZCB5b3VyIHBhdGNo ZXMgd2l0aCBhIGNvdXBsZSBvZiBjaGFuZ2VzIG9uIHRoZSBMZW5vdm8gVzU0MS4KPgo+IFRoZSBh dHRhY2hlZCBwYXRjaCBjb250YWlucyB0aGUgdHdvIHRoaW5ncyBJIG5lZWRlZCB0byBnZXQgdGhl IHNhbWUKPiBmdW5jdGlvbmFsaXR5Cj4gYXMgbXkgcGF0Y2hlcy4KPgo+IEknbSByZWFsbHkgbm90 IGluIGxvdmUgd2l0aCB0aGUgcGVyLWNoaXBzZXQgZW5hYmxlbWVudCBmb3IgdGhpcywKPiByZWFs bHkgYW55IGNoaXBzZXRzCj4gYWZ0ZXIgYSBjZXJ0YWluIHllYXIgc2hvdWxkIHByb2JhYmx5IGJl IGJldHRlciwgYXMgd2UnbGwgY29uc3RhbnRseSBiZQo+IGFkZGluZyBQQ0kgSWRzCj4gZm9yIGV2 ZXJ5IGNoaXBzZXQgZXZlciBtYWRlLCBhbmQgSSBleHBlY3Qgd2UnbGwgZm9yZ2V0IHNvbWUuCgoK WWVhaCwgSSBkb24ndCBjYXJlIG9mIHRoYXQgZWl0aGVyLiAgVGhlcmUgYXJlIGFsd2F5cyBnb2lu ZyB0byBiZQpjaGlwc2V0cyBmYWxsaW5nIHRocm91Z2ggdGhlIGNyYWNrcy4KCkFsZXgKCj4KPiBE YXZlLgo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K PiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCj4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965274AbcCNObA (ORCPT ); Mon, 14 Mar 2016 10:31:00 -0400 Received: from mail-yw0-f169.google.com ([209.85.161.169]:32807 "EHLO mail-yw0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934396AbcCNOav (ORCPT ); Mon, 14 Mar 2016 10:30:51 -0400 MIME-Version: 1.0 In-Reply-To: References: <1457504045-12738-1-git-send-email-airlied@gmail.com> <2736217.utxPzJExd5@vostro.rjw.lan> <20160311105815.GS1796@lahna.fi.intel.com> <2759763.dR5D0KopkA@vostro.rjw.lan> Date: Mon, 14 Mar 2016 10:30:50 -0400 Message-ID: Subject: Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines. From: Alex Deucher To: Dave Airlie Cc: "Rafael J. Wysocki" , "linux-pm@vger.kernel.org" , Linux PCI , "Rafael J. Wysocki" , Linux Kernel Mailing List , dri-devel , ACPI Devel Maling List , Mika Westerberg Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 13, 2016 at 10:19 PM, Dave Airlie wrote: > On 11 March 2016 at 23:45, Rafael J. Wysocki wrote: >> On Friday, March 11, 2016 12:58:15 PM Mika Westerberg wrote: >>> On Thu, Mar 10, 2016 at 09:57:09PM +0100, Rafael J. Wysocki wrote: >>> > > It doesn't seem to do any runtime PM, >>> > > I do wonder if pcieport should be doing it's own runtime PM handling, >>> > > but that is a >>> > > larger task than I'm thinking to tackle here. >>> > >>> > PCIe ports don't do PM - yet. Mika has posted a series of patches to implement >>> > that, however, that are waiting for comments now: >>> > >>> > https://patchwork.kernel.org/patch/8453311/ >>> > https://patchwork.kernel.org/patch/8453381/ >>> > https://patchwork.kernel.org/patch/8453391/ >>> > https://patchwork.kernel.org/patch/8453411/ >>> > https://patchwork.kernel.org/patch/8453371/ >>> > https://patchwork.kernel.org/patch/8453351/ >>> > >>> > > Maybe I should be doing >>> > > >>> > > pci_set_power_state(pdev->bus->self, PCI_D3cold) ? I'm not really sure. >>> > >>> > Using pci_set_power_state() would be more appropriate IMO, but you can get >>> > to the bridge via dev->parent too, can't you? >>> > >>> > In any case, it looks like you and Mika need to talk. :-) >>> >>> When the vga_switcheroo device gets runtime suspended (with the above >>> runtime PM patchs for PCIe root ports) the root port should also be >>> runtime suspended by the PM core. >> >> Right, after your patches have been applied, the additional handling >> won't be needed. >> >> So Dave, maybe you can check if the Mika's patches help? > > Hi Mika, > > I tested your patches with a couple of changes on the Lenovo W541. > > The attached patch contains the two things I needed to get the same > functionality > as my patches. > > I'm really not in love with the per-chipset enablement for this, > really any chipsets > after a certain year should probably be better, as we'll constantly be > adding PCI Ids > for every chipset ever made, and I expect we'll forget some. Yeah, I don't care of that either. There are always going to be chipsets falling through the cracks. Alex > > Dave. > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel >