From: Alex Deucher <alexdeucher@gmail.com>
To: Jerome Glisse <j.glisse@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: Fix GPU triggering random system read after VRAM start change
Date: Tue, 31 Jul 2012 11:22:26 -0400 [thread overview]
Message-ID: <CADnq5_PNqTOeTWkgaUtufGAPbeZmg5G7hHaboH+Jj6TYVyg_Cw@mail.gmail.com> (raw)
In-Reply-To: <CAH3drwZAtM-FCEZ=086MB7xKcQE2fjk7zKSfatFtNd9xL1TTdg@mail.gmail.com>
On Tue, Jul 31, 2012 at 11:15 AM, Jerome Glisse <j.glisse@gmail.com> wrote:
> On Tue, Jul 31, 2012 at 10:56 AM, Alex Deucher <alexdeucher@gmail.com> wrote:
>> On Fri, Jul 27, 2012 at 4:32 PM, <j.glisse@gmail.com> wrote:
>>> So first patch is a fix in itself, smallest possible and should go to
>>> stable. Second patch is an improvement as a first step to flicker free
>>> boot.
>>
>> First patch looks ok. In mc_stop we should disable the crtc and then
>> poll CRTC_CONTROL.CRTC_CURRENT_MASTER_EN_STATE until it goes to 0 to
>> make sure the crtc has actually stopped reading before we change the
>> mc config. Other than that,
>
> In all my test is was instantaneous, ie less than 1us to take effect,
> so i did not wanted to make the patch bigger than it is. But if you
> really think we should do that i can readd that code in patch 1.
Thinking about it more, It should fine as is since we take the crtc lock.
Alex
prev parent reply other threads:[~2012-07-31 15:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 20:32 Fix GPU triggering random system read after VRAM start change j.glisse
2012-07-27 20:32 ` [PATCH 1/3] drm/radeon: do not reenable crtc after moving vram start address j.glisse
2012-09-05 4:39 ` Brad Campbell
2012-09-05 14:28 ` Jerome Glisse
2012-09-05 17:07 ` Brad Campbell
2012-07-27 20:32 ` [PATCH 2/3] drm/radeon: try to keep current vram GPU address j.glisse
2012-07-31 14:56 ` Fix GPU triggering random system read after VRAM start change Alex Deucher
2012-07-31 15:15 ` Jerome Glisse
2012-07-31 15:22 ` Alex Deucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_PNqTOeTWkgaUtufGAPbeZmg5G7hHaboH+Jj6TYVyg_Cw@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=j.glisse@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.