All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Deucher <alexdeucher@gmail.com>
To: Lang Yu <lang.yu@amd.com>
Cc: amd-gfx list <amd-gfx@lists.freedesktop.org>,
	Alex Deucher <alexander.deucher@amd.com>,
	Huang Rui <ray.huang@amd.com>
Subject: Re: [PATCH] drm/amdgpu: enable display for cyan skillfish
Date: Tue, 12 Oct 2021 15:41:36 -0400	[thread overview]
Message-ID: <CADnq5_PPkGYkYGxQ7gXhZexGmbCEO44-YziW9R47HaCxpvb64Q@mail.gmail.com> (raw)
In-Reply-To: <20211012061605.809634-1-lang.yu@amd.com>

On Tue, Oct 12, 2021 at 2:16 AM Lang Yu <lang.yu@amd.com> wrote:
>
> Display support for cyan skillfish is ready now. Enable it!
>
> Signed-off-by: Lang Yu <lang.yu@amd.com>

Whoops. this is my mistake.  I lost the display enablement when the IP
discovery patches and the cyan skillfish display patches crossed.

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> index 2bebd2ce6474..4228c7964175 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> @@ -736,6 +736,7 @@ static int amdgpu_discovery_set_display_ip_blocks(struct amdgpu_device *adev)
>                 case IP_VERSION(1, 0, 1):
>                 case IP_VERSION(2, 0, 2):
>                 case IP_VERSION(2, 0, 0):
> +               case IP_VERSION(2, 0, 3):
>                 case IP_VERSION(2, 1, 0):
>                 case IP_VERSION(3, 0, 0):
>                 case IP_VERSION(3, 0, 2):
> @@ -745,8 +746,6 @@ static int amdgpu_discovery_set_display_ip_blocks(struct amdgpu_device *adev)
>                 case IP_VERSION(3, 1, 3):
>                         amdgpu_device_ip_block_add(adev, &dm_ip_block);
>                         break;
> -               case IP_VERSION(2, 0, 3):
> -                       break;
>                 default:
>                         return -EINVAL;
>                 }
> --
> 2.25.1
>

      parent reply	other threads:[~2021-10-12 19:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12  6:16 [PATCH] drm/amdgpu: enable display for cyan skillfish Lang Yu
2021-10-12  7:56 ` Huang, Ray
2021-10-12  8:51 ` Paul Menzel
2021-10-12  9:18   ` Yu, Lang
2021-10-12 19:41 ` Alex Deucher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADnq5_PPkGYkYGxQ7gXhZexGmbCEO44-YziW9R47HaCxpvb64Q@mail.gmail.com \
    --to=alexdeucher@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=lang.yu@amd.com \
    --cc=ray.huang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.