From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1A81ECAAD3 for ; Fri, 9 Sep 2022 20:46:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CE75F10EE56; Fri, 9 Sep 2022 20:46:23 +0000 (UTC) Received: from mail-oa1-x31.google.com (mail-oa1-x31.google.com [IPv6:2001:4860:4864:20::31]) by gabe.freedesktop.org (Postfix) with ESMTPS id E0B9210EE55; Fri, 9 Sep 2022 20:46:19 +0000 (UTC) Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-1278a61bd57so6978547fac.7; Fri, 09 Sep 2022 13:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=fIWWFRWToSyjND5u32f5EwlAkJEA8KQOjYH9kYp+XHw=; b=ii/jSDrdVYygo+6BfJIU+E/q04lrQEhFJv/UxSLRbbQ76BmfzhBfe938IDSrQS6Y+e 6LJlYHvRDS7tLmEIJdHcl3B2P5L+Asems9NCYW2weKImyBqW+je0Oii+bwvX69oNQLDd nTguM0fs6zP5RqTIFTaiCz8UqDpOBk+jWjJmIKA4ux5Nd6ycTm/fpAmfXdeDfWf+/Qm3 hh443dUp58IIfeWJz7ddTeVXvJiYkCn1UJfXbCf4xJdCaEyEigZFMntYh9OBJtVbsnno Dople/SpP1j2Ol+i0CqEJ9qw/i0I0/NINIuuXAUW9WQvbOGtcTCwK3WJ0BWbF0J+Xq+y u69A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=fIWWFRWToSyjND5u32f5EwlAkJEA8KQOjYH9kYp+XHw=; b=0qrJI9sbglnOFl0u1JGdjFiXFnROfB3ihr+bpfV+nmveEpnz1hRq2EFD6A6V1M2YNx P6FI3HZes7Bx2+lvxG+w8N+h4P2Ybsi6YGqPQbOKs1BsGodMplkiGV2WYNq1J+eAFzoU eN2VBIil08SoCNY/ca6maz5sbYiVdLgpZ402iSI954+qX8Y8xYOkdpf+DggYY/PfsoJl H7q63Iqp3xSoVOTj3RXpS22sQNBblNwbdLNhiMwQrKL57l5tKtWjjni9QFKOkuUfhpu8 /x7EQ0047OEbt+jKK4LVcxFQO0tU0bikh+9mP1HUgB8t5v63CC4xuSFZEiOq2+R82SIB PxrQ== X-Gm-Message-State: ACgBeo0iLzIFi9RNmQOWcMRJjmVLNhR590JmTXQj5pEw/HL8igjYFQSI mKgDw930BCY+sETNpSog3o30aGNTSeZQjL2F0xQ= X-Google-Smtp-Source: AA6agR5xiiLiZPpsFq6YQrxT7/tHRboxJGNQw12HUSDCAvkjWrEy6Cg42aJ/OF36IUtsRmY4md2+xpswpxG5l7N94ZQ= X-Received: by 2002:a05:6808:138e:b0:345:13d1:fd66 with SMTP id c14-20020a056808138e00b0034513d1fd66mr4521225oiw.96.1662756379115; Fri, 09 Sep 2022 13:46:19 -0700 (PDT) MIME-Version: 1.0 References: <20220902073320.319673-1-ye.xingchen@zte.com.cn> In-Reply-To: <20220902073320.319673-1-ye.xingchen@zte.com.cn> From: Alex Deucher Date: Fri, 9 Sep 2022 16:46:07 -0400 Message-ID: Subject: Re: [PATCH linux-next] drm/radeon: Remove the unneeded result variable To: cgel.zte@gmail.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, ye xingchen , Zeal Robot , Xinhui.Pan@amd.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com, christian.koenig@amd.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Applied. Thanks! Alex On Fri, Sep 2, 2022 at 3:33 AM wrote: > > From: ye xingchen > > Return the value radeon_drm_ioctl() directly instead of storing it in > another redundant variable. > > Reported-by: Zeal Robot > Signed-off-by: ye xingchen > --- > drivers/gpu/drm/radeon/radeon_drv.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c > index a28d5ceab628..6cbe1ab81aba 100644 > --- a/drivers/gpu/drm/radeon/radeon_drv.c > +++ b/drivers/gpu/drm/radeon/radeon_drv.c > @@ -512,14 +512,11 @@ long radeon_drm_ioctl(struct file *filp, > static long radeon_kms_compat_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) > { > unsigned int nr = DRM_IOCTL_NR(cmd); > - int ret; > > if (nr < DRM_COMMAND_BASE) > return drm_compat_ioctl(filp, cmd, arg); > > - ret = radeon_drm_ioctl(filp, cmd, arg); > - > - return ret; > + return radeon_drm_ioctl(filp, cmd, arg); > } > #endif > > -- > 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F0F7ECAAA1 for ; Fri, 9 Sep 2022 20:47:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230268AbiIIUrI (ORCPT ); Fri, 9 Sep 2022 16:47:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231450AbiIIUqg (ORCPT ); Fri, 9 Sep 2022 16:46:36 -0400 Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B63F1475C9 for ; Fri, 9 Sep 2022 13:46:20 -0700 (PDT) Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-12ab0eaa366so6935575fac.13 for ; Fri, 09 Sep 2022 13:46:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=fIWWFRWToSyjND5u32f5EwlAkJEA8KQOjYH9kYp+XHw=; b=ii/jSDrdVYygo+6BfJIU+E/q04lrQEhFJv/UxSLRbbQ76BmfzhBfe938IDSrQS6Y+e 6LJlYHvRDS7tLmEIJdHcl3B2P5L+Asems9NCYW2weKImyBqW+je0Oii+bwvX69oNQLDd nTguM0fs6zP5RqTIFTaiCz8UqDpOBk+jWjJmIKA4ux5Nd6ycTm/fpAmfXdeDfWf+/Qm3 hh443dUp58IIfeWJz7ddTeVXvJiYkCn1UJfXbCf4xJdCaEyEigZFMntYh9OBJtVbsnno Dople/SpP1j2Ol+i0CqEJ9qw/i0I0/NINIuuXAUW9WQvbOGtcTCwK3WJ0BWbF0J+Xq+y u69A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=fIWWFRWToSyjND5u32f5EwlAkJEA8KQOjYH9kYp+XHw=; b=6yw5wQG90Rz7nmY9rh22FsvNSMlORnSL1FHxE+eZ6ACZa0lG6CK541Oj4SsFp6fBCZ FIm4rhLGXMzDODBeusQNiWk12Z9IIeuG6jEoVoX5OXnlymt0NllGAvTTLJlM8Ja1HAOQ /TkzLUvyptak1vb6d58KlDB23i4RLQSUENMNsWy3E3QZ/40wFkCAyGl9Q9u4s/PdMxja kUmx/VuC9f4r+Dj9dOpXN4cOM7Zdkqo8ptKZbe0BLs0saxKNyHMWZospq0R0FOliiaDS +3XZ1lGPQ5zDd9+BHrCjGYRXaJZbOcTMgY1nt7YR/uIdtBdocuKEUXh2KD7QmtQjHxx5 YmCA== X-Gm-Message-State: ACgBeo2RlzHeAljRan5h2LvL9eUCm7K6tzXC66B5lMe0xQ+q9WUXKgjv 8njXFNvnwslAYHPgyy4CaGN8gVktee0fLthLHkE= X-Google-Smtp-Source: AA6agR5xiiLiZPpsFq6YQrxT7/tHRboxJGNQw12HUSDCAvkjWrEy6Cg42aJ/OF36IUtsRmY4md2+xpswpxG5l7N94ZQ= X-Received: by 2002:a05:6808:138e:b0:345:13d1:fd66 with SMTP id c14-20020a056808138e00b0034513d1fd66mr4521225oiw.96.1662756379115; Fri, 09 Sep 2022 13:46:19 -0700 (PDT) MIME-Version: 1.0 References: <20220902073320.319673-1-ye.xingchen@zte.com.cn> In-Reply-To: <20220902073320.319673-1-ye.xingchen@zte.com.cn> From: Alex Deucher Date: Fri, 9 Sep 2022 16:46:07 -0400 Message-ID: Subject: Re: [PATCH linux-next] drm/radeon: Remove the unneeded result variable To: cgel.zte@gmail.com Cc: alexander.deucher@amd.com, airlied@linux.ie, ye xingchen , Zeal Robot , Xinhui.Pan@amd.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, christian.koenig@amd.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied. Thanks! Alex On Fri, Sep 2, 2022 at 3:33 AM wrote: > > From: ye xingchen > > Return the value radeon_drm_ioctl() directly instead of storing it in > another redundant variable. > > Reported-by: Zeal Robot > Signed-off-by: ye xingchen > --- > drivers/gpu/drm/radeon/radeon_drv.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c > index a28d5ceab628..6cbe1ab81aba 100644 > --- a/drivers/gpu/drm/radeon/radeon_drv.c > +++ b/drivers/gpu/drm/radeon/radeon_drv.c > @@ -512,14 +512,11 @@ long radeon_drm_ioctl(struct file *filp, > static long radeon_kms_compat_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) > { > unsigned int nr = DRM_IOCTL_NR(cmd); > - int ret; > > if (nr < DRM_COMMAND_BASE) > return drm_compat_ioctl(filp, cmd, arg); > > - ret = radeon_drm_ioctl(filp, cmd, arg); > - > - return ret; > + return radeon_drm_ioctl(filp, cmd, arg); > } > #endif > > -- > 2.25.1