From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755575AbaLHPor (ORCPT ); Mon, 8 Dec 2014 10:44:47 -0500 Received: from mail-qc0-f179.google.com ([209.85.216.179]:44891 "EHLO mail-qc0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751967AbaLHPop (ORCPT ); Mon, 8 Dec 2014 10:44:45 -0500 MIME-Version: 1.0 In-Reply-To: <1417980062-25151-21-git-send-email-Julia.Lawall@lip6.fr> References: <1417980062-25151-1-git-send-email-Julia.Lawall@lip6.fr> <1417980062-25151-21-git-send-email-Julia.Lawall@lip6.fr> Date: Mon, 8 Dec 2014 10:44:44 -0500 Message-ID: Subject: Re: [PATCH 20/20] drm/radeon: fix misspelling of current function in string From: Alex Deucher To: Julia Lawall Cc: Alex Deucher , kernel-janitors@vger.kernel.org, linux@rasmusvillemoes.dk, LKML , Maling list - DRI developers , Joe Perches , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 7, 2014 at 2:21 PM, Julia Lawall wrote: > Replace a misspelled function name by %s and then __func__. > > This was done using Coccinelle, including the use of Levenshtein distance, > as proposed by Rasmus Villemoes. > > Signed-off-by: Julia Lawall Looks fine to me. For consistency, any chance you'd want to fix up the other places that use function names directly with this style patch? Alex > > --- > The semantic patch is difficult to summarize, but is available in the cover > letter of this patch series. > > drivers/gpu/drm/radeon/cik.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c > index 6dcde37..24d5e43 100644 > --- a/drivers/gpu/drm/radeon/cik.c > +++ b/drivers/gpu/drm/radeon/cik.c > @@ -7367,34 +7367,38 @@ int cik_irq_set(struct radeon_device *rdev) > } > if (atomic_read(&rdev->irq.ring_int[CAYMAN_RING_TYPE_CP1_INDEX])) { > struct radeon_ring *ring = &rdev->ring[CAYMAN_RING_TYPE_CP1_INDEX]; > - DRM_DEBUG("si_irq_set: sw int cp1\n"); > + DRM_DEBUG("%s: sw int cp1\n", __func__); > if (ring->me == 1) { > switch (ring->pipe) { > case 0: > cp_m1p0 |= TIME_STAMP_INT_ENABLE; > break; > default: > - DRM_DEBUG("si_irq_set: sw int cp1 invalid pipe %d\n", ring->pipe); > + DRM_DEBUG("%s: sw int cp1 invalid pipe %d\n", > + __func__, ring->pipe); > break; > } > } else { > - DRM_DEBUG("si_irq_set: sw int cp1 invalid me %d\n", ring->me); > + DRM_DEBUG("%s: sw int cp1 invalid me %d\n", __func__, > + ring->me); > } > } > if (atomic_read(&rdev->irq.ring_int[CAYMAN_RING_TYPE_CP2_INDEX])) { > struct radeon_ring *ring = &rdev->ring[CAYMAN_RING_TYPE_CP2_INDEX]; > - DRM_DEBUG("si_irq_set: sw int cp2\n"); > + DRM_DEBUG("%s: sw int cp2\n", __func__); > if (ring->me == 1) { > switch (ring->pipe) { > case 0: > cp_m1p0 |= TIME_STAMP_INT_ENABLE; > break; > default: > - DRM_DEBUG("si_irq_set: sw int cp2 invalid pipe %d\n", ring->pipe); > + DRM_DEBUG("%s: sw int cp2 invalid pipe %d\n", > + __func__, ring->pipe); > break; > } > } else { > - DRM_DEBUG("si_irq_set: sw int cp2 invalid me %d\n", ring->me); > + DRM_DEBUG("%s: sw int cp2 invalid me %d\n", __func__, > + ring->me); > } > } > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Date: Mon, 08 Dec 2014 15:44:44 +0000 Subject: Re: [PATCH 20/20] drm/radeon: fix misspelling of current function in string Message-Id: List-Id: References: <1417980062-25151-1-git-send-email-Julia.Lawall@lip6.fr> <1417980062-25151-21-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1417980062-25151-21-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, linux@rasmusvillemoes.dk, LKML , Maling list - DRI developers , Joe Perches , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= On Sun, Dec 7, 2014 at 2:21 PM, Julia Lawall wrote: > Replace a misspelled function name by %s and then __func__. > > This was done using Coccinelle, including the use of Levenshtein distance, > as proposed by Rasmus Villemoes. > > Signed-off-by: Julia Lawall Looks fine to me. For consistency, any chance you'd want to fix up the other places that use function names directly with this style patch? Alex > > --- > The semantic patch is difficult to summarize, but is available in the cover > letter of this patch series. > > drivers/gpu/drm/radeon/cik.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c > index 6dcde37..24d5e43 100644 > --- a/drivers/gpu/drm/radeon/cik.c > +++ b/drivers/gpu/drm/radeon/cik.c > @@ -7367,34 +7367,38 @@ int cik_irq_set(struct radeon_device *rdev) > } > if (atomic_read(&rdev->irq.ring_int[CAYMAN_RING_TYPE_CP1_INDEX])) { > struct radeon_ring *ring = &rdev->ring[CAYMAN_RING_TYPE_CP1_INDEX]; > - DRM_DEBUG("si_irq_set: sw int cp1\n"); > + DRM_DEBUG("%s: sw int cp1\n", __func__); > if (ring->me = 1) { > switch (ring->pipe) { > case 0: > cp_m1p0 |= TIME_STAMP_INT_ENABLE; > break; > default: > - DRM_DEBUG("si_irq_set: sw int cp1 invalid pipe %d\n", ring->pipe); > + DRM_DEBUG("%s: sw int cp1 invalid pipe %d\n", > + __func__, ring->pipe); > break; > } > } else { > - DRM_DEBUG("si_irq_set: sw int cp1 invalid me %d\n", ring->me); > + DRM_DEBUG("%s: sw int cp1 invalid me %d\n", __func__, > + ring->me); > } > } > if (atomic_read(&rdev->irq.ring_int[CAYMAN_RING_TYPE_CP2_INDEX])) { > struct radeon_ring *ring = &rdev->ring[CAYMAN_RING_TYPE_CP2_INDEX]; > - DRM_DEBUG("si_irq_set: sw int cp2\n"); > + DRM_DEBUG("%s: sw int cp2\n", __func__); > if (ring->me = 1) { > switch (ring->pipe) { > case 0: > cp_m1p0 |= TIME_STAMP_INT_ENABLE; > break; > default: > - DRM_DEBUG("si_irq_set: sw int cp2 invalid pipe %d\n", ring->pipe); > + DRM_DEBUG("%s: sw int cp2 invalid pipe %d\n", > + __func__, ring->pipe); > break; > } > } else { > - DRM_DEBUG("si_irq_set: sw int cp2 invalid me %d\n", ring->me); > + DRM_DEBUG("%s: sw int cp2 invalid me %d\n", __func__, > + ring->me); > } > } > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH 20/20] drm/radeon: fix misspelling of current function in string Date: Mon, 8 Dec 2014 10:44:44 -0500 Message-ID: References: <1417980062-25151-1-git-send-email-Julia.Lawall@lip6.fr> <1417980062-25151-21-git-send-email-Julia.Lawall@lip6.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qc0-f179.google.com (mail-qc0-f179.google.com [209.85.216.179]) by gabe.freedesktop.org (Postfix) with ESMTP id BB8996E3D0 for ; Mon, 8 Dec 2014 07:44:46 -0800 (PST) Received: by mail-qc0-f179.google.com with SMTP id c9so3602762qcz.24 for ; Mon, 08 Dec 2014 07:44:45 -0800 (PST) In-Reply-To: <1417980062-25151-21-git-send-email-Julia.Lawall@lip6.fr> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, linux@rasmusvillemoes.dk, LKML , Maling list - DRI developers , Joe Perches , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBEZWMgNywgMjAxNCBhdCAyOjIxIFBNLCBKdWxpYSBMYXdhbGwgPEp1bGlhLkxhd2Fs bEBsaXA2LmZyPiB3cm90ZToKPiBSZXBsYWNlIGEgbWlzc3BlbGxlZCBmdW5jdGlvbiBuYW1lIGJ5 ICVzIGFuZCB0aGVuIF9fZnVuY19fLgo+Cj4gVGhpcyB3YXMgZG9uZSB1c2luZyBDb2NjaW5lbGxl LCBpbmNsdWRpbmcgdGhlIHVzZSBvZiBMZXZlbnNodGVpbiBkaXN0YW5jZSwKPiBhcyBwcm9wb3Nl ZCBieSBSYXNtdXMgVmlsbGVtb2VzLgo+Cj4gU2lnbmVkLW9mZi1ieTogSnVsaWEgTGF3YWxsIDxK dWxpYS5MYXdhbGxAbGlwNi5mcj4KCkxvb2tzIGZpbmUgdG8gbWUuICBGb3IgY29uc2lzdGVuY3ks IGFueSBjaGFuY2UgeW91J2Qgd2FudCB0byBmaXggdXAKdGhlIG90aGVyIHBsYWNlcyB0aGF0IHVz ZSBmdW5jdGlvbiBuYW1lcyBkaXJlY3RseSB3aXRoIHRoaXMgc3R5bGUKcGF0Y2g/CgpBbGV4Cgo+ Cj4gLS0tCj4gVGhlIHNlbWFudGljIHBhdGNoIGlzIGRpZmZpY3VsdCB0byBzdW1tYXJpemUsIGJ1 dCBpcyBhdmFpbGFibGUgaW4gdGhlIGNvdmVyCj4gbGV0dGVyIG9mIHRoaXMgcGF0Y2ggc2VyaWVz Lgo+Cj4gIGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vY2lrLmMgfCAgIDE2ICsrKysrKysrKystLS0t LS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4K PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9jaWsuYyBiL2RyaXZlcnMvZ3B1 L2RybS9yYWRlb24vY2lrLmMKPiBpbmRleCA2ZGNkZTM3Li4yNGQ1ZTQzIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vY2lrLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmFk ZW9uL2Npay5jCj4gQEAgLTczNjcsMzQgKzczNjcsMzggQEAgaW50IGNpa19pcnFfc2V0KHN0cnVj dCByYWRlb25fZGV2aWNlICpyZGV2KQo+ICAgICAgICAgfQo+ICAgICAgICAgaWYgKGF0b21pY19y ZWFkKCZyZGV2LT5pcnEucmluZ19pbnRbQ0FZTUFOX1JJTkdfVFlQRV9DUDFfSU5ERVhdKSkgewo+ ICAgICAgICAgICAgICAgICBzdHJ1Y3QgcmFkZW9uX3JpbmcgKnJpbmcgPSAmcmRldi0+cmluZ1tD QVlNQU5fUklOR19UWVBFX0NQMV9JTkRFWF07Cj4gLSAgICAgICAgICAgICAgIERSTV9ERUJVRygi c2lfaXJxX3NldDogc3cgaW50IGNwMVxuIik7Cj4gKyAgICAgICAgICAgICAgIERSTV9ERUJVRygi JXM6IHN3IGludCBjcDFcbiIsIF9fZnVuY19fKTsKPiAgICAgICAgICAgICAgICAgaWYgKHJpbmct Pm1lID09IDEpIHsKPiAgICAgICAgICAgICAgICAgICAgICAgICBzd2l0Y2ggKHJpbmctPnBpcGUp IHsKPiAgICAgICAgICAgICAgICAgICAgICAgICBjYXNlIDA6Cj4gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBjcF9tMXAwIHw9IFRJTUVfU1RBTVBfSU5UX0VOQUJMRTsKPiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwo+ICAgICAgICAgICAgICAgICAgICAgICAg IGRlZmF1bHQ6Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBEUk1fREVCVUcoInNp X2lycV9zZXQ6IHN3IGludCBjcDEgaW52YWxpZCBwaXBlICVkXG4iLCByaW5nLT5waXBlKTsKPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIERSTV9ERUJVRygiJXM6IHN3IGludCBjcDEg aW52YWxpZCBwaXBlICVkXG4iLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIF9fZnVuY19fLCByaW5nLT5waXBlKTsKPiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGJyZWFrOwo+ICAgICAgICAgICAgICAgICAgICAgICAgIH0KPiAgICAgICAgICAgICAg ICAgfSBlbHNlIHsKPiAtICAgICAgICAgICAgICAgICAgICAgICBEUk1fREVCVUcoInNpX2lycV9z ZXQ6IHN3IGludCBjcDEgaW52YWxpZCBtZSAlZFxuIiwgcmluZy0+bWUpOwo+ICsgICAgICAgICAg ICAgICAgICAgICAgIERSTV9ERUJVRygiJXM6IHN3IGludCBjcDEgaW52YWxpZCBtZSAlZFxuIiwg X19mdW5jX18sCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJpbmctPm1lKTsK PiAgICAgICAgICAgICAgICAgfQo+ICAgICAgICAgfQo+ICAgICAgICAgaWYgKGF0b21pY19yZWFk KCZyZGV2LT5pcnEucmluZ19pbnRbQ0FZTUFOX1JJTkdfVFlQRV9DUDJfSU5ERVhdKSkgewo+ICAg ICAgICAgICAgICAgICBzdHJ1Y3QgcmFkZW9uX3JpbmcgKnJpbmcgPSAmcmRldi0+cmluZ1tDQVlN QU5fUklOR19UWVBFX0NQMl9JTkRFWF07Cj4gLSAgICAgICAgICAgICAgIERSTV9ERUJVRygic2lf aXJxX3NldDogc3cgaW50IGNwMlxuIik7Cj4gKyAgICAgICAgICAgICAgIERSTV9ERUJVRygiJXM6 IHN3IGludCBjcDJcbiIsIF9fZnVuY19fKTsKPiAgICAgICAgICAgICAgICAgaWYgKHJpbmctPm1l ID09IDEpIHsKPiAgICAgICAgICAgICAgICAgICAgICAgICBzd2l0Y2ggKHJpbmctPnBpcGUpIHsK PiAgICAgICAgICAgICAgICAgICAgICAgICBjYXNlIDA6Cj4gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBjcF9tMXAwIHw9IFRJTUVfU1RBTVBfSU5UX0VOQUJMRTsKPiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwo+ICAgICAgICAgICAgICAgICAgICAgICAgIGRl ZmF1bHQ6Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBEUk1fREVCVUcoInNpX2ly cV9zZXQ6IHN3IGludCBjcDIgaW52YWxpZCBwaXBlICVkXG4iLCByaW5nLT5waXBlKTsKPiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIERSTV9ERUJVRygiJXM6IHN3IGludCBjcDIgaW52 YWxpZCBwaXBlICVkXG4iLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIF9fZnVuY19fLCByaW5nLT5waXBlKTsKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGJyZWFrOwo+ICAgICAgICAgICAgICAgICAgICAgICAgIH0KPiAgICAgICAgICAgICAgICAg fSBlbHNlIHsKPiAtICAgICAgICAgICAgICAgICAgICAgICBEUk1fREVCVUcoInNpX2lycV9zZXQ6 IHN3IGludCBjcDIgaW52YWxpZCBtZSAlZFxuIiwgcmluZy0+bWUpOwo+ICsgICAgICAgICAgICAg ICAgICAgICAgIERSTV9ERUJVRygiJXM6IHN3IGludCBjcDIgaW52YWxpZCBtZSAlZFxuIiwgX19m dW5jX18sCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJpbmctPm1lKTsKPiAg ICAgICAgICAgICAgICAgfQo+ICAgICAgICAgfQo+Cj4KPiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=