From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9DCFC433E0 for ; Fri, 8 Jan 2021 21:20:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DF3923A9B for ; Fri, 8 Jan 2021 21:20:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729764AbhAHVTu (ORCPT ); Fri, 8 Jan 2021 16:19:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727845AbhAHVTr (ORCPT ); Fri, 8 Jan 2021 16:19:47 -0500 Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97978C061757 for ; Fri, 8 Jan 2021 13:19:07 -0800 (PST) Received: by mail-ot1-x329.google.com with SMTP id a109so11082539otc.1 for ; Fri, 08 Jan 2021 13:19:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+BVMFNqO9VtQw50JkrleUaGJ0i7fU8M+bV3fNxrSKxc=; b=pLgTcndfV6cW6spCSGmjB9Fb3TfBg6Tmw3S+ubIj/B1HgTeqyjz5qA9/Z7BpIp2tVT AIAdfrenkZLlqi0vENVzKN5z6sRCG/HRIxDlE7rXaBHDMJ36kgnddELtWGMAWeX+vZVE hG47TowHgJIpYX6BIS+tu8ABMiCtX3NfE+4x2yCa2ADEX5cIBZN4BPcu+oLBeXmVBk2I O4EZVDZdWPKEtDWDquMvP9o7hq9V4ooPyqjY+vttyNwgIS2+V3ZqjNC4mqBtuDuyhFW+ xK7g9eBKmIbWjVWdezeRFWB73Rm+B3xjuqs97WTfGUFhIdphaq81fYQ+YLGkggsDVhJq JEWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+BVMFNqO9VtQw50JkrleUaGJ0i7fU8M+bV3fNxrSKxc=; b=JRfzeEHmcK5yolaZt8vTfoYgLUMk0bJ+1CA/5SCqv67UNOzzElfMtRUgkhzrG7ADZt miOQQmR1vjpqmxuXFJtEAjMncd9N10LRBrxSRb4IDobD8S/I1cTAATCD3RW9Gbaq14Sg pA6gwLD8kqG6yh1x9t9OoZuWzH8IrUEqzc4fkeqPZQMdUgYu3IC6yGAEJb1AamBlEGdm t4BigbWeXM12/m5g7rRuyQ82WT+tUYnhOUMRz+DTTwxm9JTkJY/QlLfkSeZvuYNKTPEo Dnjc27t8M37dJn5oD9TjovJdcUx+cGphN6Sn/iu+2NSaNk0k+KonKPoHQT2DxLl/VfNg ckhw== X-Gm-Message-State: AOAM533jRKJr8IIETInUicXaPOyS3yYuMpCxOjddsQiUz9Xq5hz/Nw2H PY0Us18GBzRyqXBruch3Ktw+WS1jAXOqeMpZfbRB2fUw X-Google-Smtp-Source: ABdhPJxeFs1iL9KeAXeDXqdeEvesZuOa6FUbcR/HvCtgBKTdtd+5IUJYYuhMsC+0OFyPkE66/LzhP1w3wx3BwPOu6CU= X-Received: by 2002:a9d:75d4:: with SMTP id c20mr3901460otl.311.1610140747098; Fri, 08 Jan 2021 13:19:07 -0800 (PST) MIME-Version: 1.0 References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-31-lee.jones@linaro.org> In-Reply-To: <20210108201457.3078600-31-lee.jones@linaro.org> From: Alex Deucher Date: Fri, 8 Jan 2021 16:18:56 -0500 Message-ID: Subject: Re: [PATCH 30/40] drm/amd/display/dc/dce/dce_dmcu: Move 'abm_gain_stepsize' to only source file it's used in To: Lee Jones Cc: Leo Li , Mauro Rossi , LKML , amd-gfx list , David Airlie , Maling list - DRI developers , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 8, 2021 at 3:15 PM Lee Jones wrote: > > And only declare it if it's to be used. > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning:= =E2=80=98abm_gain_stepsize=E2=80=99 defined but not used [-Wunused-const-v= ariable=3D] > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning:= =E2=80=98abm_gain_stepsize=E2=80=99 defined but not used [-Wunused-const-v= ariable=3D] > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning:= =E2=80=98abm_gain_stepsize=E2=80=99 defined but not used [-Wunused-const-v= ariable=3D] > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning:= =E2=80=98abm_gain_stepsize=E2=80=99 defined but not used [-Wunused-const-v= ariable=3D] > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning:= =E2=80=98abm_gain_stepsize=E2=80=99 defined but not used [-Wunused-const-v= ariable=3D] > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning:= =E2=80=98abm_gain_stepsize=E2=80=99 defined but not used [-Wunused-const-v= ariable=3D] > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning:= =E2=80=98abm_gain_stepsize=E2=80=99 defined but not used [-Wunused-const-v= ariable=3D] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Mauro Rossi > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c | 4 ++++ > drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.h | 2 -- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c b/drivers/gpu/= drm/amd/display/dc/dce/dce_dmcu.c > index fa2b47d41ee2f..30264fc151a2b 100644 > --- a/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c > +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c > @@ -65,6 +65,10 @@ > //Register access policy version > #define mmMP0_SMN_C2PMSG_91 0x1609B > > +#if defined(CONFIG_DRM_AMD_DC_DCN) > +static const uint32_t abm_gain_stepsize =3D 0x0060; > +#endif > + > static bool dce_dmcu_init(struct dmcu *dmcu) > { > // Do nothing > diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.h b/drivers/gpu/= drm/amd/display/dc/dce/dce_dmcu.h > index 93e7f34d4775e..cefb7f5bf42cc 100644 > --- a/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.h > +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.h > @@ -317,6 +317,4 @@ struct dmcu *dcn21_dmcu_create( > > void dce_dmcu_destroy(struct dmcu **dmcu); > > -static const uint32_t abm_gain_stepsize =3D 0x0060; > - > #endif /* _DCE_ABM_H_ */ > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD370C433DB for ; Fri, 8 Jan 2021 21:19:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 857C223A9F for ; Fri, 8 Jan 2021 21:19:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 857C223A9F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AE7536E8DE; Fri, 8 Jan 2021 21:19:08 +0000 (UTC) Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id A77BD6E8DE; Fri, 8 Jan 2021 21:19:07 +0000 (UTC) Received: by mail-ot1-x335.google.com with SMTP id w3so11001517otp.13; Fri, 08 Jan 2021 13:19:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+BVMFNqO9VtQw50JkrleUaGJ0i7fU8M+bV3fNxrSKxc=; b=pLgTcndfV6cW6spCSGmjB9Fb3TfBg6Tmw3S+ubIj/B1HgTeqyjz5qA9/Z7BpIp2tVT AIAdfrenkZLlqi0vENVzKN5z6sRCG/HRIxDlE7rXaBHDMJ36kgnddELtWGMAWeX+vZVE hG47TowHgJIpYX6BIS+tu8ABMiCtX3NfE+4x2yCa2ADEX5cIBZN4BPcu+oLBeXmVBk2I O4EZVDZdWPKEtDWDquMvP9o7hq9V4ooPyqjY+vttyNwgIS2+V3ZqjNC4mqBtuDuyhFW+ xK7g9eBKmIbWjVWdezeRFWB73Rm+B3xjuqs97WTfGUFhIdphaq81fYQ+YLGkggsDVhJq JEWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+BVMFNqO9VtQw50JkrleUaGJ0i7fU8M+bV3fNxrSKxc=; b=Sw/VhTzfWZXZeiYqhs7R04dmNuzthzJmzVOlb5EtrszFc0Z5EAfwEAVOn7WV6b/rGf pDYWEdfBAD7eHMMZe+5R7Wnl9SjIQqiZpcRuOtWXgs+6efaFypJ6SLG8E2d0uRO3gADq LaUiAtBiRCx4ibCPWvvAbqTPi/EMXDcYiSbDLOXmRCeTcAXNU3hngIB+pATtOTH1TUA3 aOy+z1kmnfo8BRtAd4nclyRyANpRZUEmUPZ4YVS0O4hCEVseVIlVv50Sd5iwQH95K1gr Eejt6/iRPbPvS9N01zK44ACrMIhNgE1a8/vjPgNF2vCd8+P5djnXMlwjvJ/Zr63buwqH +Ctg== X-Gm-Message-State: AOAM530Fndfm1cv15KRC/h/nVZ2Q3DPdhV+3I34P1tKs1HzpS1m9NXAE SYONXUeVgaOnfaFYeJbiqKOrqFB6g7+ZHur6scc= X-Google-Smtp-Source: ABdhPJxeFs1iL9KeAXeDXqdeEvesZuOa6FUbcR/HvCtgBKTdtd+5IUJYYuhMsC+0OFyPkE66/LzhP1w3wx3BwPOu6CU= X-Received: by 2002:a9d:75d4:: with SMTP id c20mr3901460otl.311.1610140747098; Fri, 08 Jan 2021 13:19:07 -0800 (PST) MIME-Version: 1.0 References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-31-lee.jones@linaro.org> In-Reply-To: <20210108201457.3078600-31-lee.jones@linaro.org> From: Alex Deucher Date: Fri, 8 Jan 2021 16:18:56 -0500 Message-ID: Subject: Re: [PATCH 30/40] drm/amd/display/dc/dce/dce_dmcu: Move 'abm_gain_stepsize' to only source file it's used in To: Lee Jones X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , Mauro Rossi , LKML , Maling list - DRI developers , David Airlie , amd-gfx list , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCBKYW4gOCwgMjAyMSBhdCAzOjE1IFBNIExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFy by5vcmc+IHdyb3RlOgo+Cj4gQW5kIG9ubHkgZGVjbGFyZSBpdCBpZiBpdCdzIHRvIGJlIHVzZWQu Cj4KPiBGaXhlcyB0aGUgZm9sbG93aW5nIFc9MSBrZXJuZWwgYnVpbGQgd2FybmluZyhzKToKPgo+ ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS8uLi9kaXNwbGF5L2RjL2RjZS9kY2VfZG1jdS5o OjMyMDoyMzogd2FybmluZzog4oCYYWJtX2dhaW5fc3RlcHNpemXigJkgZGVmaW5lZCBidXQgbm90 IHVzZWQgWy1XdW51c2VkLWNvbnN0LXZhcmlhYmxlPV0KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvLi4vZGlzcGxheS9kYy9kY2UvZGNlX2RtY3UuaDozMjA6MjM6IHdhcm5pbmc6IOKAmGFi bV9nYWluX3N0ZXBzaXpl4oCZIGRlZmluZWQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1jb25zdC12 YXJpYWJsZT1dCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1Ly4uL2Rpc3BsYXkvZGMvZGNl L2RjZV9kbWN1Lmg6MzIwOjIzOiB3YXJuaW5nOiDigJhhYm1fZ2Fpbl9zdGVwc2l6ZeKAmSBkZWZp bmVkIGJ1dCBub3QgdXNlZCBbLVd1bnVzZWQtY29uc3QtdmFyaWFibGU9XQo+ICBkcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS8uLi9kaXNwbGF5L2RjL2RjZS9kY2VfZG1jdS5oOjMyMDoyMzogd2Fy bmluZzog4oCYYWJtX2dhaW5fc3RlcHNpemXigJkgZGVmaW5lZCBidXQgbm90IHVzZWQgWy1XdW51 c2VkLWNvbnN0LXZhcmlhYmxlPV0KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vZGlz cGxheS9kYy9kY2UvZGNlX2RtY3UuaDozMjA6MjM6IHdhcm5pbmc6IOKAmGFibV9nYWluX3N0ZXBz aXpl4oCZIGRlZmluZWQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1jb25zdC12YXJpYWJsZT1dCj4g IGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1Ly4uL2Rpc3BsYXkvZGMvZGNlL2RjZV9kbWN1Lmg6 MzIwOjIzOiB3YXJuaW5nOiDigJhhYm1fZ2Fpbl9zdGVwc2l6ZeKAmSBkZWZpbmVkIGJ1dCBub3Qg dXNlZCBbLVd1bnVzZWQtY29uc3QtdmFyaWFibGU9XQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS8uLi9kaXNwbGF5L2RjL2RjZS9kY2VfZG1jdS5oOjMyMDoyMzogd2FybmluZzog4oCYYWJt X2dhaW5fc3RlcHNpemXigJkgZGVmaW5lZCBidXQgbm90IHVzZWQgWy1XdW51c2VkLWNvbnN0LXZh cmlhYmxlPV0KPgo+IENjOiBIYXJyeSBXZW50bGFuZCA8aGFycnkud2VudGxhbmRAYW1kLmNvbT4K PiBDYzogTGVvIExpIDxzdW5wZW5nLmxpQGFtZC5jb20+Cj4gQ2M6IEFsZXggRGV1Y2hlciA8YWxl eGFuZGVyLmRldWNoZXJAYW1kLmNvbT4KPiBDYzogIkNocmlzdGlhbiBLw7ZuaWciIDxjaHJpc3Rp YW4ua29lbmlnQGFtZC5jb20+Cj4gQ2M6IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4K PiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPgo+IENjOiBNYXVybyBSb3NzaSA8 aXNzb3Iub3J1YW1AZ21haWwuY29tPgo+IENjOiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gU2lnbmVkLW9mZi1ieTog TGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4KCkFwcGxpZWQuICBUaGFua3MhCgpBbGV4 Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZGNlL2RjZV9kbWN1LmMg fCA0ICsrKysKPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2RjZS9kY2VfZG1jdS5o IHwgMiAtLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMo LSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZGNlL2Rj ZV9kbWN1LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZGNlL2RjZV9kbWN1LmMK PiBpbmRleCBmYTJiNDdkNDFlZTJmLi4zMDI2NGZjMTUxYTJiIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9hbWQvZGlzcGxheS9kYy9kY2UvZGNlX2RtY3UuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9hbWQvZGlzcGxheS9kYy9kY2UvZGNlX2RtY3UuYwo+IEBAIC02NSw2ICs2NSwxMCBA QAo+ICAvL1JlZ2lzdGVyIGFjY2VzcyBwb2xpY3kgdmVyc2lvbgo+ICAjZGVmaW5lIG1tTVAwX1NN Tl9DMlBNU0dfOTEgICAgICAgICAgICAgICAgICAgICAgICAgICAgMHgxNjA5Qgo+Cj4gKyNpZiBk ZWZpbmVkKENPTkZJR19EUk1fQU1EX0RDX0RDTikKPiArc3RhdGljIGNvbnN0IHVpbnQzMl90IGFi bV9nYWluX3N0ZXBzaXplID0gMHgwMDYwOwo+ICsjZW5kaWYKPiArCj4gIHN0YXRpYyBib29sIGRj ZV9kbWN1X2luaXQoc3RydWN0IGRtY3UgKmRtY3UpCj4gIHsKPiAgICAgICAgIC8vIERvIG5vdGhp bmcKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2RjZS9kY2Vf ZG1jdS5oIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2RjZS9kY2VfZG1jdS5oCj4g aW5kZXggOTNlN2YzNGQ0Nzc1ZS4uY2VmYjdmNWJmNDJjYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZGNlL2RjZV9kbWN1LmgKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vYW1kL2Rpc3BsYXkvZGMvZGNlL2RjZV9kbWN1LmgKPiBAQCAtMzE3LDYgKzMxNyw0IEBA IHN0cnVjdCBkbWN1ICpkY24yMV9kbWN1X2NyZWF0ZSgKPgo+ICB2b2lkIGRjZV9kbWN1X2Rlc3Ry b3koc3RydWN0IGRtY3UgKipkbWN1KTsKPgo+IC1zdGF0aWMgY29uc3QgdWludDMyX3QgYWJtX2dh aW5fc3RlcHNpemUgPSAweDAwNjA7Cj4gLQo+ICAjZW5kaWYgLyogX0RDRV9BQk1fSF8gKi8KPiAt LQo+IDIuMjUuMQo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 469D2C433E0 for ; Fri, 8 Jan 2021 21:19:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E93CD23A80 for ; Fri, 8 Jan 2021 21:19:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E93CD23A80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 830FD6E8E7; Fri, 8 Jan 2021 21:19:09 +0000 (UTC) Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id A77BD6E8DE; Fri, 8 Jan 2021 21:19:07 +0000 (UTC) Received: by mail-ot1-x335.google.com with SMTP id w3so11001517otp.13; Fri, 08 Jan 2021 13:19:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+BVMFNqO9VtQw50JkrleUaGJ0i7fU8M+bV3fNxrSKxc=; b=pLgTcndfV6cW6spCSGmjB9Fb3TfBg6Tmw3S+ubIj/B1HgTeqyjz5qA9/Z7BpIp2tVT AIAdfrenkZLlqi0vENVzKN5z6sRCG/HRIxDlE7rXaBHDMJ36kgnddELtWGMAWeX+vZVE hG47TowHgJIpYX6BIS+tu8ABMiCtX3NfE+4x2yCa2ADEX5cIBZN4BPcu+oLBeXmVBk2I O4EZVDZdWPKEtDWDquMvP9o7hq9V4ooPyqjY+vttyNwgIS2+V3ZqjNC4mqBtuDuyhFW+ xK7g9eBKmIbWjVWdezeRFWB73Rm+B3xjuqs97WTfGUFhIdphaq81fYQ+YLGkggsDVhJq JEWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+BVMFNqO9VtQw50JkrleUaGJ0i7fU8M+bV3fNxrSKxc=; b=Sw/VhTzfWZXZeiYqhs7R04dmNuzthzJmzVOlb5EtrszFc0Z5EAfwEAVOn7WV6b/rGf pDYWEdfBAD7eHMMZe+5R7Wnl9SjIQqiZpcRuOtWXgs+6efaFypJ6SLG8E2d0uRO3gADq LaUiAtBiRCx4ibCPWvvAbqTPi/EMXDcYiSbDLOXmRCeTcAXNU3hngIB+pATtOTH1TUA3 aOy+z1kmnfo8BRtAd4nclyRyANpRZUEmUPZ4YVS0O4hCEVseVIlVv50Sd5iwQH95K1gr Eejt6/iRPbPvS9N01zK44ACrMIhNgE1a8/vjPgNF2vCd8+P5djnXMlwjvJ/Zr63buwqH +Ctg== X-Gm-Message-State: AOAM530Fndfm1cv15KRC/h/nVZ2Q3DPdhV+3I34P1tKs1HzpS1m9NXAE SYONXUeVgaOnfaFYeJbiqKOrqFB6g7+ZHur6scc= X-Google-Smtp-Source: ABdhPJxeFs1iL9KeAXeDXqdeEvesZuOa6FUbcR/HvCtgBKTdtd+5IUJYYuhMsC+0OFyPkE66/LzhP1w3wx3BwPOu6CU= X-Received: by 2002:a9d:75d4:: with SMTP id c20mr3901460otl.311.1610140747098; Fri, 08 Jan 2021 13:19:07 -0800 (PST) MIME-Version: 1.0 References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-31-lee.jones@linaro.org> In-Reply-To: <20210108201457.3078600-31-lee.jones@linaro.org> From: Alex Deucher Date: Fri, 8 Jan 2021 16:18:56 -0500 Message-ID: Subject: Re: [PATCH 30/40] drm/amd/display/dc/dce/dce_dmcu: Move 'abm_gain_stepsize' to only source file it's used in To: Lee Jones X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , Mauro Rossi , LKML , Maling list - DRI developers , David Airlie , amd-gfx list , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" T24gRnJpLCBKYW4gOCwgMjAyMSBhdCAzOjE1IFBNIExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFy by5vcmc+IHdyb3RlOgo+Cj4gQW5kIG9ubHkgZGVjbGFyZSBpdCBpZiBpdCdzIHRvIGJlIHVzZWQu Cj4KPiBGaXhlcyB0aGUgZm9sbG93aW5nIFc9MSBrZXJuZWwgYnVpbGQgd2FybmluZyhzKToKPgo+ ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS8uLi9kaXNwbGF5L2RjL2RjZS9kY2VfZG1jdS5o OjMyMDoyMzogd2FybmluZzog4oCYYWJtX2dhaW5fc3RlcHNpemXigJkgZGVmaW5lZCBidXQgbm90 IHVzZWQgWy1XdW51c2VkLWNvbnN0LXZhcmlhYmxlPV0KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvLi4vZGlzcGxheS9kYy9kY2UvZGNlX2RtY3UuaDozMjA6MjM6IHdhcm5pbmc6IOKAmGFi bV9nYWluX3N0ZXBzaXpl4oCZIGRlZmluZWQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1jb25zdC12 YXJpYWJsZT1dCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1Ly4uL2Rpc3BsYXkvZGMvZGNl L2RjZV9kbWN1Lmg6MzIwOjIzOiB3YXJuaW5nOiDigJhhYm1fZ2Fpbl9zdGVwc2l6ZeKAmSBkZWZp bmVkIGJ1dCBub3QgdXNlZCBbLVd1bnVzZWQtY29uc3QtdmFyaWFibGU9XQo+ICBkcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS8uLi9kaXNwbGF5L2RjL2RjZS9kY2VfZG1jdS5oOjMyMDoyMzogd2Fy bmluZzog4oCYYWJtX2dhaW5fc3RlcHNpemXigJkgZGVmaW5lZCBidXQgbm90IHVzZWQgWy1XdW51 c2VkLWNvbnN0LXZhcmlhYmxlPV0KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vZGlz cGxheS9kYy9kY2UvZGNlX2RtY3UuaDozMjA6MjM6IHdhcm5pbmc6IOKAmGFibV9nYWluX3N0ZXBz aXpl4oCZIGRlZmluZWQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1jb25zdC12YXJpYWJsZT1dCj4g IGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1Ly4uL2Rpc3BsYXkvZGMvZGNlL2RjZV9kbWN1Lmg6 MzIwOjIzOiB3YXJuaW5nOiDigJhhYm1fZ2Fpbl9zdGVwc2l6ZeKAmSBkZWZpbmVkIGJ1dCBub3Qg dXNlZCBbLVd1bnVzZWQtY29uc3QtdmFyaWFibGU9XQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS8uLi9kaXNwbGF5L2RjL2RjZS9kY2VfZG1jdS5oOjMyMDoyMzogd2FybmluZzog4oCYYWJt X2dhaW5fc3RlcHNpemXigJkgZGVmaW5lZCBidXQgbm90IHVzZWQgWy1XdW51c2VkLWNvbnN0LXZh cmlhYmxlPV0KPgo+IENjOiBIYXJyeSBXZW50bGFuZCA8aGFycnkud2VudGxhbmRAYW1kLmNvbT4K PiBDYzogTGVvIExpIDxzdW5wZW5nLmxpQGFtZC5jb20+Cj4gQ2M6IEFsZXggRGV1Y2hlciA8YWxl eGFuZGVyLmRldWNoZXJAYW1kLmNvbT4KPiBDYzogIkNocmlzdGlhbiBLw7ZuaWciIDxjaHJpc3Rp YW4ua29lbmlnQGFtZC5jb20+Cj4gQ2M6IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4K PiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPgo+IENjOiBNYXVybyBSb3NzaSA8 aXNzb3Iub3J1YW1AZ21haWwuY29tPgo+IENjOiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gU2lnbmVkLW9mZi1ieTog TGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4KCkFwcGxpZWQuICBUaGFua3MhCgpBbGV4 Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZGNlL2RjZV9kbWN1LmMg fCA0ICsrKysKPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2RjZS9kY2VfZG1jdS5o IHwgMiAtLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMo LSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZGNlL2Rj ZV9kbWN1LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZGNlL2RjZV9kbWN1LmMK PiBpbmRleCBmYTJiNDdkNDFlZTJmLi4zMDI2NGZjMTUxYTJiIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9hbWQvZGlzcGxheS9kYy9kY2UvZGNlX2RtY3UuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9hbWQvZGlzcGxheS9kYy9kY2UvZGNlX2RtY3UuYwo+IEBAIC02NSw2ICs2NSwxMCBA QAo+ICAvL1JlZ2lzdGVyIGFjY2VzcyBwb2xpY3kgdmVyc2lvbgo+ICAjZGVmaW5lIG1tTVAwX1NN Tl9DMlBNU0dfOTEgICAgICAgICAgICAgICAgICAgICAgICAgICAgMHgxNjA5Qgo+Cj4gKyNpZiBk ZWZpbmVkKENPTkZJR19EUk1fQU1EX0RDX0RDTikKPiArc3RhdGljIGNvbnN0IHVpbnQzMl90IGFi bV9nYWluX3N0ZXBzaXplID0gMHgwMDYwOwo+ICsjZW5kaWYKPiArCj4gIHN0YXRpYyBib29sIGRj ZV9kbWN1X2luaXQoc3RydWN0IGRtY3UgKmRtY3UpCj4gIHsKPiAgICAgICAgIC8vIERvIG5vdGhp bmcKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2RjZS9kY2Vf ZG1jdS5oIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2RjZS9kY2VfZG1jdS5oCj4g aW5kZXggOTNlN2YzNGQ0Nzc1ZS4uY2VmYjdmNWJmNDJjYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZGNlL2RjZV9kbWN1LmgKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vYW1kL2Rpc3BsYXkvZGMvZGNlL2RjZV9kbWN1LmgKPiBAQCAtMzE3LDYgKzMxNyw0IEBA IHN0cnVjdCBkbWN1ICpkY24yMV9kbWN1X2NyZWF0ZSgKPgo+ICB2b2lkIGRjZV9kbWN1X2Rlc3Ry b3koc3RydWN0IGRtY3UgKipkbWN1KTsKPgo+IC1zdGF0aWMgY29uc3QgdWludDMyX3QgYWJtX2dh aW5fc3RlcHNpemUgPSAweDAwNjA7Cj4gLQo+ICAjZW5kaWYgLyogX0RDRV9BQk1fSF8gKi8KPiAt LQo+IDIuMjUuMQo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=