From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH 1/6] drm/amdkfd: Consolidate duplicate memory banks info in topology Date: Fri, 13 Jul 2018 15:24:48 -0400 Message-ID: References: <1531430694-23966-1-git-send-email-Felix.Kuehling@amd.com> <1531430694-23966-2-git-send-email-Felix.Kuehling@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1531430694-23966-2-git-send-email-Felix.Kuehling-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Felix Kuehling Cc: Oded Gabbay , Yong Zhao , amd-gfx list T24gVGh1LCBKdWwgMTIsIDIwMTggYXQgNToyNCBQTSwgRmVsaXggS3VlaGxpbmcgPEZlbGl4Lkt1 ZWhsaW5nQGFtZC5jb20+IHdyb3RlOgo+IEZyb206IFlvbmcgWmhhbyA8eW9uZy56aGFvQGFtZC5j b20+Cj4KPiBJZiB0aGVyZSBhcmUgc2V2ZXJhbCBtZW1vcnkgYmFua3MgdGhhdCBoYXMgdGhlIHNh bWUgcHJvcGVydGllcyBpbiBDUkFULAo+IHdlIGFnZ3JlZ2F0ZSB0aGVtIGludG8gb25lIG1lbW9y eSBiYW5rLiBUaGlzIGNsZWFucyB1cCBtZW1vcnkgYmFua3Mgb24KPiBBUFVzIChlLmcuIFJhdmVu KSB3aGVyZSB0aGUgQ1JBVCByZXBvcnRzIGVhY2ggbWVtb3J5IGNoYW5uZWwgYXMgYQo+IHNlcGFy YXRlIGJhbmsuIFRoaXMgb25seSBjb25mdXNlcyB1c2VyIG1vZGUsIHdoaWNoIG9ubHkgZGVhbHMg d2l0aAo+IHZpcnR1YWwgbWVtb3J5Lgo+Cj4gU2lnbmVkLW9mZi1ieTogWW9uZyBaaGFvIDx5b25n LnpoYW9AYW1kLmNvbT4KPiBSZXZpZXdlZC1ieTogRmVsaXggS3VlaGxpbmcgPEZlbGl4Lkt1ZWhs aW5nQGFtZC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogRmVsaXggS3VlaGxpbmcgPEZlbGl4Lkt1ZWhs aW5nQGFtZC5jb20+CgpBY2tlZC1ieTogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1Y2hlckBh bWQuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2NyYXQuYyB8 IDU3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2Vk LCA0NiBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfY3JhdC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRrZmQva2ZkX2NyYXQuYwo+IGluZGV4IDI5NmIzZjIuLmVlNDk5NjAgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2NyYXQuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1ka2ZkL2tmZF9jcmF0LmMKPiBAQCAtMTg5LDYgKzE4OSwyMSBAQCBzdGF0aWMg aW50IGtmZF9wYXJzZV9zdWJ0eXBlX2N1KHN0cnVjdCBjcmF0X3N1YnR5cGVfY29tcHV0ZXVuaXQg KmN1LAo+ICAgICAgICAgcmV0dXJuIDA7Cj4gIH0KPgo+ICtzdGF0aWMgc3RydWN0IGtmZF9tZW1f cHJvcGVydGllcyAqCj4gK2ZpbmRfc3VidHlwZV9tZW0odWludDMyX3QgaGVhcF90eXBlLCB1aW50 MzJfdCBmbGFncywgdWludDMyX3Qgd2lkdGgsCj4gKyAgICAgICAgICAgICAgIHN0cnVjdCBrZmRf dG9wb2xvZ3lfZGV2aWNlICpkZXYpCj4gK3sKPiArICAgICAgIHN0cnVjdCBrZmRfbWVtX3Byb3Bl cnRpZXMgKnByb3BzOwo+ICsKPiArICAgICAgIGxpc3RfZm9yX2VhY2hfZW50cnkocHJvcHMsICZk ZXYtPm1lbV9wcm9wcywgbGlzdCkgewo+ICsgICAgICAgICAgICAgICBpZiAocHJvcHMtPmhlYXBf dHlwZSA9PSBoZWFwX3R5cGUKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICYmIHBy b3BzLT5mbGFncyA9PSBmbGFncwo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJiYg cHJvcHMtPndpZHRoID09IHdpZHRoKQo+ICsgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBw cm9wczsKPiArICAgICAgIH0KPiArCj4gKyAgICAgICByZXR1cm4gTlVMTDsKPiArfQo+ICAvKiBr ZmRfcGFyc2Vfc3VidHlwZV9tZW0gLSBwYXJzZSBtZW1vcnkgc3VidHlwZXMgYW5kIGF0dGFjaCBp dCB0byBjb3JyZWN0Cj4gICAqIHRvcG9sb2d5IGRldmljZSBwcmVzZW50IGluIHRoZSBkZXZpY2Vf bGlzdAo+ICAgKi8KPiBAQCAtMTk3LDM2ICsyMTIsNTYgQEAgc3RhdGljIGludCBrZmRfcGFyc2Vf c3VidHlwZV9tZW0oc3RydWN0IGNyYXRfc3VidHlwZV9tZW1vcnkgKm1lbSwKPiAgewo+ICAgICAg ICAgc3RydWN0IGtmZF9tZW1fcHJvcGVydGllcyAqcHJvcHM7Cj4gICAgICAgICBzdHJ1Y3Qga2Zk X3RvcG9sb2d5X2RldmljZSAqZGV2Owo+ICsgICAgICAgdWludDMyX3QgaGVhcF90eXBlOwo+ICsg ICAgICAgdWludDY0X3Qgc2l6ZV9pbl9ieXRlczsKPiArICAgICAgIHVpbnQzMl90IGZsYWdzID0g MDsKPiArICAgICAgIHVpbnQzMl90IHdpZHRoOwo+Cj4gICAgICAgICBwcl9kZWJ1ZygiRm91bmQg bWVtb3J5IGVudHJ5IGluIENSQVQgdGFibGUgd2l0aCBwcm94aW1pdHlfZG9tYWluPSVkXG4iLAo+ ICAgICAgICAgICAgICAgICAgICAgICAgIG1lbS0+cHJveGltaXR5X2RvbWFpbik7Cj4gICAgICAg ICBsaXN0X2Zvcl9lYWNoX2VudHJ5KGRldiwgZGV2aWNlX2xpc3QsIGxpc3QpIHsKPiAgICAgICAg ICAgICAgICAgaWYgKG1lbS0+cHJveGltaXR5X2RvbWFpbiA9PSBkZXYtPnByb3hpbWl0eV9kb21h aW4pIHsKPiAtICAgICAgICAgICAgICAgICAgICAgICBwcm9wcyA9IGtmZF9hbGxvY19zdHJ1Y3Qo cHJvcHMpOwo+IC0gICAgICAgICAgICAgICAgICAgICAgIGlmICghcHJvcHMpCj4gLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKPiAtCj4gICAgICAgICAgICAg ICAgICAgICAgICAgLyogV2UncmUgb24gR1BVIG5vZGUgKi8KPiAgICAgICAgICAgICAgICAgICAg ICAgICBpZiAoZGV2LT5ub2RlX3Byb3BzLmNwdV9jb3Jlc19jb3VudCA9PSAwKSB7Cj4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAvKiBBUFUgKi8KPiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGlmIChtZW0tPnZpc2liaWxpdHlfdHlwZSA9PSAwKQo+IC0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwcm9wcy0+aGVhcF90eXBlID0KPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaGVhcF90eXBlID0KPiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBIU0FfTUVNX0hFQVBfVFlQRV9G Ql9QUklWQVRFOwo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLyogZEdQVSAqLwo+ ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZWxzZQo+IC0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBwcm9wcy0+aGVhcF90eXBlID0gbWVtLT52aXNpYmlsaXR5 X3R5cGU7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGhlYXBfdHlw ZSA9IG1lbS0+dmlzaWJpbGl0eV90eXBlOwo+ICAgICAgICAgICAgICAgICAgICAgICAgIH0gZWxz ZQo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcHJvcHMtPmhlYXBfdHlwZSA9IEhT QV9NRU1fSEVBUF9UWVBFX1NZU1RFTTsKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGhlYXBfdHlwZSA9IEhTQV9NRU1fSEVBUF9UWVBFX1NZU1RFTTsKPgo+ICAgICAgICAgICAgICAg ICAgICAgICAgIGlmIChtZW0tPmZsYWdzICYgQ1JBVF9NRU1fRkxBR1NfSE9UX1BMVUdHQUJMRSkK PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHByb3BzLT5mbGFncyB8PSBIU0FfTUVN X0ZMQUdTX0hPVF9QTFVHR0FCTEU7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBm bGFncyB8PSBIU0FfTUVNX0ZMQUdTX0hPVF9QTFVHR0FCTEU7Cj4gICAgICAgICAgICAgICAgICAg ICAgICAgaWYgKG1lbS0+ZmxhZ3MgJiBDUkFUX01FTV9GTEFHU19OT05fVk9MQVRJTEUpCj4gLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwcm9wcy0+ZmxhZ3MgfD0gSFNBX01FTV9GTEFH U19OT05fVk9MQVRJTEU7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmbGFncyB8 PSBIU0FfTUVNX0ZMQUdTX05PTl9WT0xBVElMRTsKPgo+IC0gICAgICAgICAgICAgICAgICAgICAg IHByb3BzLT5zaXplX2luX2J5dGVzID0KPiArICAgICAgICAgICAgICAgICAgICAgICBzaXplX2lu X2J5dGVzID0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgodWludDY0X3QpbWVt LT5sZW5ndGhfaGlnaCA8PCAzMikgKwo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgbWVtLT5sZW5ndGhfbG93Owo+IC0gICAgICAgICAgICAg ICAgICAgICAgIHByb3BzLT53aWR0aCA9IG1lbS0+d2lkdGg7Cj4gKyAgICAgICAgICAgICAgICAg ICAgICAgd2lkdGggPSBtZW0tPndpZHRoOwo+ICsKPiArICAgICAgICAgICAgICAgICAgICAgICAv KiBNdWx0aXBsZSBiYW5rcyBvZiB0aGUgc2FtZSB0eXBlIGFyZSBhZ2dyZWdhdGVkIGludG8KPiAr ICAgICAgICAgICAgICAgICAgICAgICAgKiBvbmUuIFVzZXIgbW9kZSBkb2Vzbid0IGNhcmUgYWJv dXQgbXVsdGlwbGUgcGh5c2ljYWwKPiArICAgICAgICAgICAgICAgICAgICAgICAgKiBtZW1vcnkg c2VnbWVudHMuIEl0J3MgbWFuYWdlZCBhcyBhIHNpbmdsZSB2aXJ0dWFsCj4gKyAgICAgICAgICAg ICAgICAgICAgICAgICogaGVhcCBmb3IgdXNlciBtb2RlLgo+ICsgICAgICAgICAgICAgICAgICAg ICAgICAqLwo+ICsgICAgICAgICAgICAgICAgICAgICAgIHByb3BzID0gZmluZF9zdWJ0eXBlX21l bShoZWFwX3R5cGUsIGZsYWdzLCB3aWR0aCwgZGV2KTsKPiArICAgICAgICAgICAgICAgICAgICAg ICBpZiAocHJvcHMpIHsKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHByb3BzLT5z aXplX2luX2J5dGVzICs9IHNpemVfaW5fYnl0ZXM7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBicmVhazsKPiArICAgICAgICAgICAgICAgICAgICAgICB9Cj4gKwo+ICsgICAgICAg ICAgICAgICAgICAgICAgIHByb3BzID0ga2ZkX2FsbG9jX3N0cnVjdChwcm9wcyk7Cj4gKyAgICAg ICAgICAgICAgICAgICAgICAgaWYgKCFwcm9wcykKPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHJldHVybiAtRU5PTUVNOwo+ICsKPiArICAgICAgICAgICAgICAgICAgICAgICBwcm9w cy0+aGVhcF90eXBlID0gaGVhcF90eXBlOwo+ICsgICAgICAgICAgICAgICAgICAgICAgIHByb3Bz LT5mbGFncyA9IGZsYWdzOwo+ICsgICAgICAgICAgICAgICAgICAgICAgIHByb3BzLT5zaXplX2lu X2J5dGVzID0gc2l6ZV9pbl9ieXRlczsKPiArICAgICAgICAgICAgICAgICAgICAgICBwcm9wcy0+ d2lkdGggPSB3aWR0aDsKPgo+ICAgICAgICAgICAgICAgICAgICAgICAgIGRldi0+bm9kZV9wcm9w cy5tZW1fYmFua3NfY291bnQrKzsKPiAgICAgICAgICAgICAgICAgICAgICAgICBsaXN0X2FkZF90 YWlsKCZwcm9wcy0+bGlzdCwgJmRldi0+bWVtX3Byb3BzKTsKPiAtLQo+IDIuNy40Cj4KPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGFtZC1nZnggbWFp bGluZyBsaXN0Cj4gYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1k LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==