From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH 3/5] drm/amdgpu: fix a bunch of coding style issues in amdgpu_gem.c Date: Thu, 15 Sep 2016 14:27:30 -0400 Message-ID: References: <1473945024-8275-1-git-send-email-deathsimple@vodafone.de> <1473945024-8275-3-git-send-email-deathsimple@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1473945024-8275-3-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: amd-gfx list T24gVGh1LCBTZXAgMTUsIDIwMTYgYXQgOToxMCBBTSwgQ2hyaXN0aWFuIEvDtm5pZwo8ZGVhdGhz aW1wbGVAdm9kYWZvbmUuZGU+IHdyb3RlOgo+IEZyb206IENocmlzdGlhbiBLw7ZuaWcgPGNocmlz dGlhbi5rb2VuaWdAYW1kLmNvbT4KPgo+IE5vIGludGVudGVkIGZ1bmN0aW9uYWwgY2hhbmdlLgo+ CgoiaW50ZW5kZWQiCgpJbiBnZW5lcmFsLCB3aXRoIHJlc3BlY3QgdG8gdGhlIHdoaXRlIHNwYWNl IGNoYW5nZXMsIEkgdGhpbmsgdGhlIGNvZGUKaXMgbW9yZSByZWFkYWJsZSBhcyBpcywgYnV0IEkg ZG9uJ3QgaGF2ZSBhIHN0cm9uZyBvcGluaW9uIGVpdGhlciB3YXksCmlmIHlvdSBwcmVmZXIgdGhp cy4KCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0Bh bWQuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ2VtLmMg fCAxOCArKysrKysrKysrKystLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMo KyksIDYgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dl bS5jCj4gaW5kZXggODhmYmVkMi4uNzBlMjk0YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vYW1kL2FtZGdwdS9hbWRncHVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9hbWRncHVfZ2VtLmMKPiBAQCAtNTgsNyArNTgsOCBAQCBpbnQgYW1kZ3B1X2dlbV9vYmpl Y3RfY3JlYXRlKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LCB1bnNpZ25lZCBsb25nIHNpemUs Cj4gICAgICAgICAgICAgICAgIGFsaWdubWVudCA9IFBBR0VfU0laRTsKPiAgICAgICAgIH0KPgo+ IC0gICAgICAgaWYgKCEoaW5pdGlhbF9kb21haW4gJiAoQU1ER1BVX0dFTV9ET01BSU5fR0RTIHwg QU1ER1BVX0dFTV9ET01BSU5fR1dTIHwgQU1ER1BVX0dFTV9ET01BSU5fT0EpKSkgewo+ICsgICAg ICAgaWYgKCEoaW5pdGlhbF9kb21haW4gJiAoQU1ER1BVX0dFTV9ET01BSU5fR0RTIHwgQU1ER1BV X0dFTV9ET01BSU5fR1dTIHwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEFNREdQ VV9HRU1fRE9NQUlOX09BKSkpIHsKPiAgICAgICAgICAgICAgICAgLyogTWF4aW11bSBibyBzaXpl IGlzIHRoZSB1bnBpbm5lZCBndHQgc2l6ZSBzaW5jZSB3ZSB1c2UgdGhlIGd0dCB0bwo+ICAgICAg ICAgICAgICAgICAgKiBoYW5kbGUgdnJhbSB0byBzeXN0ZW0gcG9vbCBtaWdyYXRpb25zLgo+ICAg ICAgICAgICAgICAgICAgKi8KPiBAQCAtMTE2LDcgKzExNyw4IEBAIHZvaWQgYW1kZ3B1X2dlbV9m b3JjZV9yZWxlYXNlKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQo+ICAgKiBDYWxsIGZyb20g ZHJtX2dlbV9oYW5kbGVfY3JlYXRlIHdoaWNoIGFwcGVhciBpbiBib3RoIG5ldyBhbmQgb3BlbiBp b2N0bAo+ICAgKiBjYXNlLgo+ICAgKi8KPiAtaW50IGFtZGdwdV9nZW1fb2JqZWN0X29wZW4oc3Ry dWN0IGRybV9nZW1fb2JqZWN0ICpvYmosIHN0cnVjdCBkcm1fZmlsZSAqZmlsZV9wcml2KQo+ICtp bnQgYW1kZ3B1X2dlbV9vYmplY3Rfb3BlbihzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iaiwKPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdikKPiAg ewo+ICAgICAgICAgc3RydWN0IGFtZGdwdV9ibyAqcmJvID0gZ2VtX3RvX2FtZGdwdV9ibyhvYmop Owo+ICAgICAgICAgc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYgPSByYm8tPmFkZXY7Cj4gQEAg LTQwOCw5ICs0MTAsMTEgQEAgaW50IGFtZGdwdV9nZW1fd2FpdF9pZGxlX2lvY3RsKHN0cnVjdCBk cm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gICAgICAgICB9Cj4gICAgICAgICByb2JqID0g Z2VtX3RvX2FtZGdwdV9ibyhnb2JqKTsKPiAgICAgICAgIGlmICh0aW1lb3V0ID09IDApCj4gLSAg ICAgICAgICAgICAgIHJldCA9IHJlc2VydmF0aW9uX29iamVjdF90ZXN0X3NpZ25hbGVkX3JjdShy b2JqLT50Ym8ucmVzdiwgdHJ1ZSk7Cj4gKyAgICAgICAgICAgICAgIHJldCA9IHJlc2VydmF0aW9u X29iamVjdF90ZXN0X3NpZ25hbGVkX3JjdShyb2JqLT50Ym8ucmVzdiwKPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRydWUpOwo+ICAg ICAgICAgZWxzZQo+IC0gICAgICAgICAgICAgICByZXQgPSByZXNlcnZhdGlvbl9vYmplY3Rfd2Fp dF90aW1lb3V0X3JjdShyb2JqLT50Ym8ucmVzdiwgdHJ1ZSwgdHJ1ZSwgdGltZW91dCk7Cj4gKyAg ICAgICAgICAgICAgIHJldCA9IHJlc2VydmF0aW9uX29iamVjdF93YWl0X3RpbWVvdXRfcmN1KHJv YmotPnRiby5yZXN2LCB0cnVlLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB0cnVlLCB0aW1lb3V0KTsKPgo+ICAgICAgICAgLyogcmV0 ID09IDAgbWVhbnMgbm90IHNpZ25hbGVkLAo+ICAgICAgICAgICogcmV0ID4gMCBtZWFucyBzaWdu YWxlZAo+IEBAIC00ODAsNyArNDg0LDggQEAgb3V0Ogo+ICAgKiB2aXRhbCBoZXJlLCBzbyB0aGV5 IGFyZSBub3QgcmVwb3J0ZWQgYmFjayB0byB1c2Vyc3BhY2UuCj4gICAqLwo+ICBzdGF0aWMgdm9p ZCBhbWRncHVfZ2VtX3ZhX3VwZGF0ZV92bShzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPiAt ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgYW1kZ3B1X2JvX3ZhICpi b192YSwgdWludDMyX3Qgb3BlcmF0aW9uKQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHN0cnVjdCBhbWRncHVfYm9fdmEgKmJvX3ZhLAo+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHVpbnQzMl90IG9wZXJhdGlvbikKPiAgewo+ICAgICAgICAgc3RydWN0 IHR0bV92YWxpZGF0ZV9idWZmZXIgdHYsICplbnRyeTsKPiAgICAgICAgIHN0cnVjdCBhbWRncHVf Ym9fbGlzdF9lbnRyeSB2bV9wZDsKPiBAQCAtNzA0LDcgKzcwOSw4IEBAIGludCBhbWRncHVfbW9k ZV9kdW1iX2NyZWF0ZShzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdiwKPiAgICAgICAgIHVpbnQz Ml90IGhhbmRsZTsKPiAgICAgICAgIGludCByOwo+Cj4gLSAgICAgICBhcmdzLT5waXRjaCA9IGFt ZGdwdV9hbGlnbl9waXRjaChhZGV2LCBhcmdzLT53aWR0aCwgYXJncy0+YnBwLCAwKSAqICgoYXJn cy0+YnBwICsgMSkgLyA4KTsKPiArICAgICAgIGFyZ3MtPnBpdGNoID0gYW1kZ3B1X2FsaWduX3Bp dGNoKGFkZXYsIGFyZ3MtPndpZHRoLCBhcmdzLT5icHAsIDApICoKPiArICAgICAgICAgICAgICAg KChhcmdzLT5icHAgKyAxKSAvIDgpOwo+ICAgICAgICAgYXJncy0+c2l6ZSA9ICh1NjQpYXJncy0+ cGl0Y2ggKiBhcmdzLT5oZWlnaHQ7Cj4gICAgICAgICBhcmdzLT5zaXplID0gQUxJR04oYXJncy0+ c2l6ZSwgUEFHRV9TSVpFKTsKPgo+IC0tCj4gMi41LjAKPgo+IF9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gYW1kLWdmeCBtYWlsaW5nIGxpc3QKPiBhbWQt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vYW1kLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2FtZC1nZngK