Re: [PATCH 2/2] drm/amd/display: fix minor codestyle problems

[Alex Deucher <alexdeucher@gmail.com>]

Applied the series.  Thanks!

Alex

On Thu, Aug 11, 2022 at 4:44 PM Tales Aparecida
<tales.aparecida@gmail.com> wrote:
>
> Fixes five checkpatch warnings:
>
> CHECK: Please don't use multiple blank lines
> +
> +
>
> ERROR: Macros with complex values should be enclosed in parentheses
> +#define MAX_I64 \
> +       (int64_t)((1ULL << 63) - 1)
>
> WARNING: Missing a blank line after declarations
> +       struct bw_fixed res;
> +       ASSERT(value < BW_FIXED_MAX_I32 && value > BW_FIXED_MIN_I32);
>
> ERROR: that open brace { should be on the previous line
> +               do
> +               {
>
> ERROR: that open brace { should be on the previous line
> +                       if (remainder >= arg2_value)
> +                       {
>
> Signed-off-by: Tales Aparecida <tales.aparecida@gmail.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dml/calcs/bw_fixed.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/calcs/bw_fixed.c b/drivers/gpu/drm/amd/display/dc/dml/calcs/bw_fixed.c
> index 2d46bc527b21..3aa8dd0acd5e 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/calcs/bw_fixed.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/calcs/bw_fixed.c
> @@ -25,9 +25,8 @@
>  #include "dm_services.h"
>  #include "bw_fixed.h"
>
> -
>  #define MAX_I64 \
> -       (int64_t)((1ULL << 63) - 1)
> +       ((int64_t)((1ULL << 63) - 1))
>
>  #define MIN_I64 \
>         (-MAX_I64 - 1)
> @@ -49,6 +48,7 @@ static uint64_t abs_i64(int64_t arg)
>  struct bw_fixed bw_int_to_fixed_nonconst(int64_t value)
>  {
>         struct bw_fixed res;
> +
>         ASSERT(value < BW_FIXED_MAX_I32 && value > BW_FIXED_MIN_I32);
>         res.value = value << BW_FIXED_BITS_PER_FRACTIONAL_PART;
>         return res;
> @@ -78,14 +78,12 @@ struct bw_fixed bw_frc_to_fixed(int64_t numerator, int64_t denominator)
>         {
>                 uint32_t i = BW_FIXED_BITS_PER_FRACTIONAL_PART;
>
> -               do
> -               {
> +               do {
>                         remainder <<= 1;
>
>                         res_value <<= 1;
>
> -                       if (remainder >= arg2_value)
> -                       {
> +                       if (remainder >= arg2_value) {
>                                 res_value |= 1;
>                                 remainder -= arg2_value;
>                         }
> --
> 2.37.0
>