From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49D20C35280 for ; Wed, 2 Oct 2019 14:17:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C72621D7B for ; Wed, 2 Oct 2019 14:17:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R9JOAAoi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728086AbfJBORW (ORCPT ); Wed, 2 Oct 2019 10:17:22 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:55924 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727647AbfJBORW (ORCPT ); Wed, 2 Oct 2019 10:17:22 -0400 Received: by mail-wm1-f66.google.com with SMTP id a6so7379084wma.5 for ; Wed, 02 Oct 2019 07:17:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=6ZK/alQJG/DzU2yr4fmPDAWsu9lpuXfvvu9e0XLg0VM=; b=R9JOAAoirQ85aRbnoJE2ghGjMgnYZvgp/+N3TS16/mkj/h2NNpOiHgT9N4Vgb5ZFUr Qvt9YwtL7wwJGnMGjciAyBDekZP08zC/RE3WCJGsu54Kg60BFF1aRjSRZOlAexfn8HUG v9P0wmbcdn6mtEheFbcfdcbYIM7yWN3wnaXSfHIVlUyiWzoG8X+42qteH2PEW6Bod9ij YQ5czd+9r7Q5vkS6EEvyoKKuShp889JJ1P+rxHrMcZ4dTbwOQ7G+QM4EetpDK3dNgOFp bFZG6SemRrWRHzHE4w/TaSw0YYfUN+0ytvHd1Ea3x/2gSMAuj5O4UX3bjWSZ/jPdiEm6 UV3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=6ZK/alQJG/DzU2yr4fmPDAWsu9lpuXfvvu9e0XLg0VM=; b=QlN/b04O6yLvtnU4K0O5aMHFQXt9xlnkdZfki/+cVx0pDlKmfhA3K1nDJLILbjGQ1w +dPj8K1TdE70wiyghwM5qwUFZzoKVUDUfBdXoX0xxjRZ6lHeYuZDKG86F7ySkIEwNNae Cmnq9tdcHMyTq3CCLbabFwtflNr2eB0vGCzJku5bIkSwa5/GmW4hmBjp5456F45gHO30 +QrBR8ZeDCilzadAX6y0R3ZVZbQsX+HH/jLzqWTfLn3DzSHZ8HF8ihE0c51toJC+VP3R Li7RrsGNVSDQZrQUM5q/ZoQf69xgwQXHu5dA7IZcChm7OnjU87RabCvWRCukPr6nxeUa je4Q== X-Gm-Message-State: APjAAAWGv8dQHH287Ov7pdhDCXy3k67VuBQS//cbWL5nFTenhfMe4kwt 9RyaDb/GGspHDvyjXu1BC2O6Ls6frljUvWdakdY= X-Google-Smtp-Source: APXvYqyXYHJXAwnKoxIMcQTyz+KVy3BGpZtHLq8GhT6Hy6Pq77R1ldTnCYjHcoDu9jFPjmr39XnZGOn/DLiaiC8kTnQ= X-Received: by 2002:a1c:1a45:: with SMTP id a66mr3100375wma.102.1570025839778; Wed, 02 Oct 2019 07:17:19 -0700 (PDT) MIME-Version: 1.0 References: <20191002120136.1777161-1-arnd@arndb.de> <20191002120136.1777161-5-arnd@arndb.de> In-Reply-To: <20191002120136.1777161-5-arnd@arndb.de> From: Alex Deucher Date: Wed, 2 Oct 2019 10:17:07 -0400 Message-ID: Subject: Re: [PATCH 4/6] drm/amd/display: fix dcn21 Makefile for clang To: Arnd Bergmann Cc: Alex Deucher , Harry Wentland , Leo Li , =?UTF-8?Q?Christian_K=C3=B6nig?= , "David (ChunMing) Zhou" , David Airlie , Daniel Vetter , LKML , Maling list - DRI developers , clang-built-linux@googlegroups.com, amd-gfx list , Bhawanpreet Lakha Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 2, 2019 at 8:03 AM Arnd Bergmann wrote: > > Just like all the other variants, this one passes invalid > compile-time options with clang after the new code got > merged: > > clang: error: unknown argument: '-mpreferred-stack-boundary=3D4' > scripts/Makefile.build:265: recipe for target 'drivers/gpu/drm/amd/amdgpu= /../display/dc/dcn21/dcn21_resource.o' failed > > Use the same variant that we have for dcn20 to fix compilation. > > Fixes: eced51f9babb ("drm/amd/display: Add hubp block for Renoir (v2)") > Signed-off-by: Arnd Bergmann I'm getting an error with gcc with this patch: CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.o drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.c: In function =E2=80=98calculate_wm_set_for_vlevel=E2=80=99: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.c:964:22: error: SSE register return with SSE disabled wm_set->urgent_ns =3D get_wm_urgent(dml, pipes, pipe_cnt) * 1000; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ make[4]: *** [scripts/Makefile.build:273: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.o] Error 1 make[3]: *** [scripts/Makefile.build:490: drivers/gpu/drm/amd/amdgpu] Error= 2 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [scripts/Makefile.build:490: drivers/gpu/drm] Error 2 make[1]: *** [scripts/Makefile.build:490: drivers/gpu] Error 2 make: *** [Makefile:1080: drivers] Error 2 Alex > --- > drivers/gpu/drm/amd/display/dc/dcn21/Makefile | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/Makefile b/drivers/gpu/= drm/amd/display/dc/dcn21/Makefile > index 8cd9de8b1a7a..ef673bffc241 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn21/Makefile > +++ b/drivers/gpu/drm/amd/display/dc/dcn21/Makefile > @@ -3,7 +3,17 @@ > > DCN21 =3D dcn21_hubp.o dcn21_hubbub.o dcn21_resource.o > > -CFLAGS_$(AMDDALPATH)/dc/dcn21/dcn21_resource.o :=3D -mhard-float -msse -= mpreferred-stack-boundary=3D4 > +ifneq ($(call cc-option, -mpreferred-stack-boundary=3D4),) > + cc_stack_align :=3D -mpreferred-stack-boundary=3D4 > +else ifneq ($(call cc-option, -mstack-alignment=3D16),) > + cc_stack_align :=3D -mstack-alignment=3D16 > +endif > + > +CFLAGS_$(AMDDALPATH)/dc/dcn21/dcn21_resource.o :=3D -mhard-float -msse $= (cc_stack_align) > + > +ifdef CONFIG_CC_IS_CLANG > +CFLAGS_$(AMDDALPATH)/dc/dcn21/dcn21_resource.o +=3D -msse2 > +endif > > AMD_DAL_DCN21 =3D $(addprefix $(AMDDALPATH)/dc/dcn21/,$(DCN21)) > > -- > 2.20.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH 4/6] drm/amd/display: fix dcn21 Makefile for clang Date: Wed, 2 Oct 2019 10:17:07 -0400 Message-ID: References: <20191002120136.1777161-1-arnd@arndb.de> <20191002120136.1777161-5-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191002120136.1777161-5-arnd-r2nGTMty4D4@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Arnd Bergmann Cc: "David (ChunMing) Zhou" , clang-built-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Leo Li , Bhawanpreet Lakha , LKML , Maling list - DRI developers , David Airlie , amd-gfx list , Daniel Vetter , Alex Deucher , Harry Wentland , =?UTF-8?Q?Christian_K=C3=B6nig?= List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBPY3QgMiwgMjAxOSBhdCA4OjAzIEFNIEFybmQgQmVyZ21hbm4gPGFybmRAYXJuZGIu ZGU+IHdyb3RlOgo+Cj4gSnVzdCBsaWtlIGFsbCB0aGUgb3RoZXIgdmFyaWFudHMsIHRoaXMgb25l IHBhc3NlcyBpbnZhbGlkCj4gY29tcGlsZS10aW1lIG9wdGlvbnMgd2l0aCBjbGFuZyBhZnRlciB0 aGUgbmV3IGNvZGUgZ290Cj4gbWVyZ2VkOgo+Cj4gY2xhbmc6IGVycm9yOiB1bmtub3duIGFyZ3Vt ZW50OiAnLW1wcmVmZXJyZWQtc3RhY2stYm91bmRhcnk9NCcKPiBzY3JpcHRzL01ha2VmaWxlLmJ1 aWxkOjI2NTogcmVjaXBlIGZvciB0YXJnZXQgJ2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1Ly4u L2Rpc3BsYXkvZGMvZGNuMjEvZGNuMjFfcmVzb3VyY2UubycgZmFpbGVkCj4KPiBVc2UgdGhlIHNh bWUgdmFyaWFudCB0aGF0IHdlIGhhdmUgZm9yIGRjbjIwIHRvIGZpeCBjb21waWxhdGlvbi4KPgo+ IEZpeGVzOiBlY2VkNTFmOWJhYmIgKCJkcm0vYW1kL2Rpc3BsYXk6IEFkZCBodWJwIGJsb2NrIGZv ciBSZW5vaXIgKHYyKSIpCj4gU2lnbmVkLW9mZi1ieTogQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5k Yi5kZT4KCkknbSBnZXR0aW5nIGFuIGVycm9yIHdpdGggZ2NjIHdpdGggdGhpcyBwYXRjaDoKICBD QyBbTV0gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1Ly4uL2Rpc3BsYXkvZGMvZGNuMjEvZGNu MjFfcmVzb3VyY2Uubwpkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS8uLi9kaXNwbGF5L2RjL2Rj bjIxL2RjbjIxX3Jlc291cmNlLmM6IEluCmZ1bmN0aW9uIOKAmGNhbGN1bGF0ZV93bV9zZXRfZm9y X3ZsZXZlbOKAmToKZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vZGlzcGxheS9kYy9kY24y MS9kY24yMV9yZXNvdXJjZS5jOjk2NDoyMjoKZXJyb3I6IFNTRSByZWdpc3RlciByZXR1cm4gd2l0 aCBTU0UgZGlzYWJsZWQKICB3bV9zZXQtPnVyZ2VudF9ucyA9IGdldF93bV91cmdlbnQoZG1sLCBw aXBlcywgcGlwZV9jbnQpICogMTAwMDsKICAgICAgICAgICAgICAgICAgICAgIF5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+Cm1ha2VbNF06ICoqKiBbc2NyaXB0cy9NYWtlZmlsZS5i dWlsZDoyNzM6CmRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1Ly4uL2Rpc3BsYXkvZGMvZGNuMjEv ZGNuMjFfcmVzb3VyY2Uub10gRXJyb3IKMQptYWtlWzNdOiAqKiogW3NjcmlwdHMvTWFrZWZpbGUu YnVpbGQ6NDkwOiBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdV0gRXJyb3IgMgptYWtlWzNdOiAq KiogV2FpdGluZyBmb3IgdW5maW5pc2hlZCBqb2JzLi4uLgptYWtlWzJdOiAqKiogW3NjcmlwdHMv TWFrZWZpbGUuYnVpbGQ6NDkwOiBkcml2ZXJzL2dwdS9kcm1dIEVycm9yIDIKbWFrZVsxXTogKioq IFtzY3JpcHRzL01ha2VmaWxlLmJ1aWxkOjQ5MDogZHJpdmVycy9ncHVdIEVycm9yIDIKbWFrZTog KioqIFtNYWtlZmlsZToxMDgwOiBkcml2ZXJzXSBFcnJvciAyCgpBbGV4Cgo+IC0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZGNuMjEvTWFrZWZpbGUgfCAxMiArKysrKysrKysr Ky0KPiAgMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPgo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZGNuMjEvTWFrZWZp bGUgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZGNuMjEvTWFrZWZpbGUKPiBpbmRl eCA4Y2Q5ZGU4YjFhN2EuLmVmNjczYmZmYzI0MSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vYW1kL2Rpc3BsYXkvZGMvZGNuMjEvTWFrZWZpbGUKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v YW1kL2Rpc3BsYXkvZGMvZGNuMjEvTWFrZWZpbGUKPiBAQCAtMyw3ICszLDE3IEBACj4KPiAgRENO MjEgPSBkY24yMV9odWJwLm8gZGNuMjFfaHViYnViLm8gZGNuMjFfcmVzb3VyY2Uubwo+Cj4gLUNG TEFHU18kKEFNRERBTFBBVEgpL2RjL2RjbjIxL2RjbjIxX3Jlc291cmNlLm8gOj0gLW1oYXJkLWZs b2F0IC1tc3NlIC1tcHJlZmVycmVkLXN0YWNrLWJvdW5kYXJ5PTQKPiAraWZuZXEgKCQoY2FsbCBj Yy1vcHRpb24sIC1tcHJlZmVycmVkLXN0YWNrLWJvdW5kYXJ5PTQpLCkKPiArICAgICAgIGNjX3N0 YWNrX2FsaWduIDo9IC1tcHJlZmVycmVkLXN0YWNrLWJvdW5kYXJ5PTQKPiArZWxzZSBpZm5lcSAo JChjYWxsIGNjLW9wdGlvbiwgLW1zdGFjay1hbGlnbm1lbnQ9MTYpLCkKPiArICAgICAgIGNjX3N0 YWNrX2FsaWduIDo9IC1tc3RhY2stYWxpZ25tZW50PTE2Cj4gK2VuZGlmCj4gKwo+ICtDRkxBR1Nf JChBTUREQUxQQVRIKS9kYy9kY24yMS9kY24yMV9yZXNvdXJjZS5vIDo9IC1taGFyZC1mbG9hdCAt bXNzZSAkKGNjX3N0YWNrX2FsaWduKQo+ICsKPiAraWZkZWYgQ09ORklHX0NDX0lTX0NMQU5HCj4g K0NGTEFHU18kKEFNRERBTFBBVEgpL2RjL2RjbjIxL2RjbjIxX3Jlc291cmNlLm8gKz0gLW1zc2Uy Cj4gK2VuZGlmCj4KPiAgQU1EX0RBTF9EQ04yMSA9ICQoYWRkcHJlZml4ICQoQU1EREFMUEFUSCkv ZGMvZGNuMjEvLCQoRENOMjEpKQo+Cj4gLS0KPiAyLjIwLjAKPgo+IF9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+ IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2FtZC1nZng=