From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C9EBC388F7 for ; Fri, 13 Nov 2020 17:28:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55C9121D1A for ; Fri, 13 Nov 2020 17:28:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GrHaeW1p" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726657AbgKMR2y (ORCPT ); Fri, 13 Nov 2020 12:28:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726087AbgKMR2y (ORCPT ); Fri, 13 Nov 2020 12:28:54 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A792CC0613D1 for ; Fri, 13 Nov 2020 09:28:53 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id c17so10732892wrc.11 for ; Fri, 13 Nov 2020 09:28:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=C+0w2nBltIcPLOhtMLZ4S0PvakYggYrXZkCbBUTmbq0=; b=GrHaeW1ppx0bLiAObJsVnHiwxGBLMJkGdYRyPjzHR3pdOm7zuDvCsQJsahDDewdjr+ iIQsy4tiGdL2sWEGJQdzgG002YgyWqyzpIdIxRwgNzz6y47GJVlsawkrckGP+I+qXOiF 2f1y+AdYnM9scoXNsdfACnAW48roo5y4YgXQ9Oadcip29U1tcCwdfGBVqjN/YeXPWP0O ewwir+MKbyc1JHzUnbYoVyPjiZDY1TP3sYtSYgImzQCfm6HnDv+dy1HpthyRyBOJ43ZU CCFk0qeFT1hSUW2R1NhwzwwOUrg4QiV2t47PPDjMamatmBF12DxC4/YRhbMCIYv58W/0 n4Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=C+0w2nBltIcPLOhtMLZ4S0PvakYggYrXZkCbBUTmbq0=; b=RqEjm1rZDiCYJLlKfPnjCwp1P1s5GJB3jPdrgrB6Cwoh0OyUnlIxFp8j6lbnOBLF7C b/Q8VdeB9xX7Nn/QgiUu5P1e+qxpEfzqJZWSEBpEZSbLsodKGyCTGMLAY0D8LD0OVAUQ a79xi/wGr1tgEXRzcaGI6/ymEQXolkqyGMsYgivt+aj5sbIw0CSB4tzB5c/8bpf0+yqh mb9/4DfyMOFhdnjVh6obo48Wh3VO4NQw8/yEylvuV9d4IDDrt/Cqxa7zjp6gxfzr3qyy uJ1i1WS935i8VsPTZXbz9Tmf7Qab2pm8aHQH2EUayi2/Wg/R27IceTldnEsE/vD2+AKA MWTg== X-Gm-Message-State: AOAM532W1BU4Qotuqb1JshluPe9e6ld0PzfFc/83EffLK9cincVj5ffn d6dtNvlZd8KovPqcbBRsWobtJv52I/jchpDh/jY= X-Google-Smtp-Source: ABdhPJxuaa3hBBRuLvzp1t3KaqcAtdvwchrwB6YlbtVUL8bP+9zl0m9O5cz+ROgmeD2LRgIHwlg4TZND6aDOvazNpQw= X-Received: by 2002:adf:e9c9:: with SMTP id l9mr5064718wrn.124.1605288527583; Fri, 13 Nov 2020 09:28:47 -0800 (PST) MIME-Version: 1.0 References: <20201113134938.4004947-1-lee.jones@linaro.org> <20201113134938.4004947-27-lee.jones@linaro.org> In-Reply-To: <20201113134938.4004947-27-lee.jones@linaro.org> From: Alex Deucher Date: Fri, 13 Nov 2020 12:28:36 -0500 Message-ID: Subject: Re: [PATCH 26/40] drm/amd/amdgpu/amdgpu_gmc: Demote one and fix another function header To: Lee Jones Cc: David Airlie , LKML , amd-gfx list , Maling list - DRI developers , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:69: warning: Function parameter = or member 'bo' not described in 'amdgpu_gmc_pd_addr' > drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:121: warning: Function parameter= or member 'bo' not described in 'amdgpu_gmc_agp_addr' > drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:121: warning: Excess function pa= rameter 'tbo' description in 'amdgpu_gmc_agp_addr' > > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/am= d/amdgpu/amdgpu_gmc.c > index 056cb87d09ea3..fede84509dbca 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c > @@ -61,9 +61,8 @@ void amdgpu_gmc_get_pde_for_bo(struct amdgpu_bo *bo, in= t level, > amdgpu_gmc_get_vm_pde(adev, level, addr, flags); > } > > -/** > +/* > * amdgpu_gmc_pd_addr - return the address of the root directory > - * > */ > uint64_t amdgpu_gmc_pd_addr(struct amdgpu_bo *bo) > { > @@ -112,7 +111,7 @@ int amdgpu_gmc_set_pte_pde(struct amdgpu_device *adev= , void *cpu_pt_addr, > /** > * amdgpu_gmc_agp_addr - return the address in the AGP address space > * > - * @tbo: TTM BO which needs the address, must be in GTT domain > + * @bo: TTM BO which needs the address, must be in GTT domain > * > * Tries to figure out how to access the BO through the AGP aperture. Re= turns > * AMDGPU_BO_INVALID_OFFSET if that is not possible. > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A912C61DD8 for ; Fri, 13 Nov 2020 17:28:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C438520A8B for ; Fri, 13 Nov 2020 17:28:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GrHaeW1p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C438520A8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1CDF66E5D4; Fri, 13 Nov 2020 17:28:55 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFE626E5D2; Fri, 13 Nov 2020 17:28:53 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id u12so3548486wrt.0; Fri, 13 Nov 2020 09:28:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=C+0w2nBltIcPLOhtMLZ4S0PvakYggYrXZkCbBUTmbq0=; b=GrHaeW1ppx0bLiAObJsVnHiwxGBLMJkGdYRyPjzHR3pdOm7zuDvCsQJsahDDewdjr+ iIQsy4tiGdL2sWEGJQdzgG002YgyWqyzpIdIxRwgNzz6y47GJVlsawkrckGP+I+qXOiF 2f1y+AdYnM9scoXNsdfACnAW48roo5y4YgXQ9Oadcip29U1tcCwdfGBVqjN/YeXPWP0O ewwir+MKbyc1JHzUnbYoVyPjiZDY1TP3sYtSYgImzQCfm6HnDv+dy1HpthyRyBOJ43ZU CCFk0qeFT1hSUW2R1NhwzwwOUrg4QiV2t47PPDjMamatmBF12DxC4/YRhbMCIYv58W/0 n4Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=C+0w2nBltIcPLOhtMLZ4S0PvakYggYrXZkCbBUTmbq0=; b=iF9BdasLpJdxAK6HiKrbYU4C65Mp+/Ji/OQGhuPRKeuyenDIYOsktmDW+KHrMkmB9l l44iGbaH+H+JT2nv0rrzUL3CbpxWYq5/fZmrJUS60sV6Fx3DdWuuiWCRs1XUqzGVv/Sn CyYayx5iZTrKZJBxtIDg2fiYNAfAHTpFRwrbHYupdYQtwTz6yuxbiEot4ow4p7SQZ9wv TqFT+M3kP0Du/oLxBV1q0dXuynV2GEpsNGG2FVWGMlE3aAzR37UWxJH/uf2p6eZnIMGs oQUf2Ku2FspYNLWqYDAeDkMC3CE6u5JGhUzvIe8/SJOfV4AfqLXdbtOVVpQzFw5vAdyX +bkA== X-Gm-Message-State: AOAM530hv8aFwlpUqPkRveiPxj5DQzk41nFSio7Gw/3Bqjl82a+7gkGv BAqGce7dE2neKlNYjAwQI1/tNhLMG0YpMi/0zSo= X-Google-Smtp-Source: ABdhPJxuaa3hBBRuLvzp1t3KaqcAtdvwchrwB6YlbtVUL8bP+9zl0m9O5cz+ROgmeD2LRgIHwlg4TZND6aDOvazNpQw= X-Received: by 2002:adf:e9c9:: with SMTP id l9mr5064718wrn.124.1605288527583; Fri, 13 Nov 2020 09:28:47 -0800 (PST) MIME-Version: 1.0 References: <20201113134938.4004947-1-lee.jones@linaro.org> <20201113134938.4004947-27-lee.jones@linaro.org> In-Reply-To: <20201113134938.4004947-27-lee.jones@linaro.org> From: Alex Deucher Date: Fri, 13 Nov 2020 12:28:36 -0500 Message-ID: Subject: Re: [PATCH 26/40] drm/amd/amdgpu/amdgpu_gmc: Demote one and fix another function header To: Lee Jones X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , amd-gfx list , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCBOb3YgMTMsIDIwMjAgYXQgODo1MCBBTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5h cm8ub3JnPiB3cm90ZToKPgo+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3 YXJuaW5nKHMpOgo+Cj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nbWMuYzo2 OTogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1lbWJlciAnYm8nIG5vdCBkZXNjcmli ZWQgaW4gJ2FtZGdwdV9nbWNfcGRfYWRkcicKPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv YW1kZ3B1X2dtYy5jOjEyMTogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1lbWJlciAn Ym8nIG5vdCBkZXNjcmliZWQgaW4gJ2FtZGdwdV9nbWNfYWdwX2FkZHInCj4gIGRyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nbWMuYzoxMjE6IHdhcm5pbmc6IEV4Y2VzcyBmdW5jdGlv biBwYXJhbWV0ZXIgJ3RibycgZGVzY3JpcHRpb24gaW4gJ2FtZGdwdV9nbWNfYWdwX2FkZHInCj4K PiBDYzogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1Y2hlckBhbWQuY29tPgo+IENjOiAiQ2hy aXN0aWFuIEvDtm5pZyIgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KPiBDYzogRGF2aWQgQWly bGllIDxhaXJsaWVkQGxpbnV4LmllPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwu Y2g+Cj4gQ2M6IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gQ2M6IGRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKPiBTaWduZWQtb2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25l c0BsaW5hcm8ub3JnPgoKQXBwbGllZC4gIFRoYW5rcyEKCkFsZXgKCj4gLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nbWMuYyB8IDUgKystLS0KPiAgMSBmaWxlIGNoYW5n ZWQsIDIgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ21jLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfZ21jLmMKPiBpbmRleCAwNTZjYjg3ZDA5ZWEzLi5mZWRlODQ1MDlkYmNh IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nbWMuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nbWMuYwo+IEBAIC02MSw5 ICs2MSw4IEBAIHZvaWQgYW1kZ3B1X2dtY19nZXRfcGRlX2Zvcl9ibyhzdHJ1Y3QgYW1kZ3B1X2Jv ICpibywgaW50IGxldmVsLAo+ICAgICAgICAgYW1kZ3B1X2dtY19nZXRfdm1fcGRlKGFkZXYsIGxl dmVsLCBhZGRyLCBmbGFncyk7Cj4gIH0KPgo+IC0vKioKPiArLyoKPiAgICogYW1kZ3B1X2dtY19w ZF9hZGRyIC0gcmV0dXJuIHRoZSBhZGRyZXNzIG9mIHRoZSByb290IGRpcmVjdG9yeQo+IC0gKgo+ ICAgKi8KPiAgdWludDY0X3QgYW1kZ3B1X2dtY19wZF9hZGRyKHN0cnVjdCBhbWRncHVfYm8gKmJv KQo+ICB7Cj4gQEAgLTExMiw3ICsxMTEsNyBAQCBpbnQgYW1kZ3B1X2dtY19zZXRfcHRlX3BkZShz dHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwgdm9pZCAqY3B1X3B0X2FkZHIsCj4gIC8qKgo+ICAg KiBhbWRncHVfZ21jX2FncF9hZGRyIC0gcmV0dXJuIHRoZSBhZGRyZXNzIGluIHRoZSBBR1AgYWRk cmVzcyBzcGFjZQo+ICAgKgo+IC0gKiBAdGJvOiBUVE0gQk8gd2hpY2ggbmVlZHMgdGhlIGFkZHJl c3MsIG11c3QgYmUgaW4gR1RUIGRvbWFpbgo+ICsgKiBAYm86IFRUTSBCTyB3aGljaCBuZWVkcyB0 aGUgYWRkcmVzcywgbXVzdCBiZSBpbiBHVFQgZG9tYWluCj4gICAqCj4gICAqIFRyaWVzIHRvIGZp Z3VyZSBvdXQgaG93IHRvIGFjY2VzcyB0aGUgQk8gdGhyb3VnaCB0aGUgQUdQIGFwZXJ0dXJlLiBS ZXR1cm5zCj4gICAqIEFNREdQVV9CT19JTlZBTElEX09GRlNFVCBpZiB0aGF0IGlzIG5vdCBwb3Nz aWJsZS4KPiAtLQo+IDIuMjUuMQo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73FABC55ABD for ; Fri, 13 Nov 2020 17:28:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D8DC20A8B for ; Fri, 13 Nov 2020 17:28:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GrHaeW1p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D8DC20A8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C82876E5D2; Fri, 13 Nov 2020 17:28:54 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFE626E5D2; Fri, 13 Nov 2020 17:28:53 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id u12so3548486wrt.0; Fri, 13 Nov 2020 09:28:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=C+0w2nBltIcPLOhtMLZ4S0PvakYggYrXZkCbBUTmbq0=; b=GrHaeW1ppx0bLiAObJsVnHiwxGBLMJkGdYRyPjzHR3pdOm7zuDvCsQJsahDDewdjr+ iIQsy4tiGdL2sWEGJQdzgG002YgyWqyzpIdIxRwgNzz6y47GJVlsawkrckGP+I+qXOiF 2f1y+AdYnM9scoXNsdfACnAW48roo5y4YgXQ9Oadcip29U1tcCwdfGBVqjN/YeXPWP0O ewwir+MKbyc1JHzUnbYoVyPjiZDY1TP3sYtSYgImzQCfm6HnDv+dy1HpthyRyBOJ43ZU CCFk0qeFT1hSUW2R1NhwzwwOUrg4QiV2t47PPDjMamatmBF12DxC4/YRhbMCIYv58W/0 n4Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=C+0w2nBltIcPLOhtMLZ4S0PvakYggYrXZkCbBUTmbq0=; b=iF9BdasLpJdxAK6HiKrbYU4C65Mp+/Ji/OQGhuPRKeuyenDIYOsktmDW+KHrMkmB9l l44iGbaH+H+JT2nv0rrzUL3CbpxWYq5/fZmrJUS60sV6Fx3DdWuuiWCRs1XUqzGVv/Sn CyYayx5iZTrKZJBxtIDg2fiYNAfAHTpFRwrbHYupdYQtwTz6yuxbiEot4ow4p7SQZ9wv TqFT+M3kP0Du/oLxBV1q0dXuynV2GEpsNGG2FVWGMlE3aAzR37UWxJH/uf2p6eZnIMGs oQUf2Ku2FspYNLWqYDAeDkMC3CE6u5JGhUzvIe8/SJOfV4AfqLXdbtOVVpQzFw5vAdyX +bkA== X-Gm-Message-State: AOAM530hv8aFwlpUqPkRveiPxj5DQzk41nFSio7Gw/3Bqjl82a+7gkGv BAqGce7dE2neKlNYjAwQI1/tNhLMG0YpMi/0zSo= X-Google-Smtp-Source: ABdhPJxuaa3hBBRuLvzp1t3KaqcAtdvwchrwB6YlbtVUL8bP+9zl0m9O5cz+ROgmeD2LRgIHwlg4TZND6aDOvazNpQw= X-Received: by 2002:adf:e9c9:: with SMTP id l9mr5064718wrn.124.1605288527583; Fri, 13 Nov 2020 09:28:47 -0800 (PST) MIME-Version: 1.0 References: <20201113134938.4004947-1-lee.jones@linaro.org> <20201113134938.4004947-27-lee.jones@linaro.org> In-Reply-To: <20201113134938.4004947-27-lee.jones@linaro.org> From: Alex Deucher Date: Fri, 13 Nov 2020 12:28:36 -0500 Message-ID: Subject: Re: [PATCH 26/40] drm/amd/amdgpu/amdgpu_gmc: Demote one and fix another function header To: Lee Jones X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , amd-gfx list , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" T24gRnJpLCBOb3YgMTMsIDIwMjAgYXQgODo1MCBBTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5h cm8ub3JnPiB3cm90ZToKPgo+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3 YXJuaW5nKHMpOgo+Cj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nbWMuYzo2 OTogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1lbWJlciAnYm8nIG5vdCBkZXNjcmli ZWQgaW4gJ2FtZGdwdV9nbWNfcGRfYWRkcicKPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv YW1kZ3B1X2dtYy5jOjEyMTogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1lbWJlciAn Ym8nIG5vdCBkZXNjcmliZWQgaW4gJ2FtZGdwdV9nbWNfYWdwX2FkZHInCj4gIGRyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nbWMuYzoxMjE6IHdhcm5pbmc6IEV4Y2VzcyBmdW5jdGlv biBwYXJhbWV0ZXIgJ3RibycgZGVzY3JpcHRpb24gaW4gJ2FtZGdwdV9nbWNfYWdwX2FkZHInCj4K PiBDYzogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1Y2hlckBhbWQuY29tPgo+IENjOiAiQ2hy aXN0aWFuIEvDtm5pZyIgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KPiBDYzogRGF2aWQgQWly bGllIDxhaXJsaWVkQGxpbnV4LmllPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwu Y2g+Cj4gQ2M6IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gQ2M6IGRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKPiBTaWduZWQtb2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25l c0BsaW5hcm8ub3JnPgoKQXBwbGllZC4gIFRoYW5rcyEKCkFsZXgKCj4gLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nbWMuYyB8IDUgKystLS0KPiAgMSBmaWxlIGNoYW5n ZWQsIDIgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ21jLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfZ21jLmMKPiBpbmRleCAwNTZjYjg3ZDA5ZWEzLi5mZWRlODQ1MDlkYmNh IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nbWMuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nbWMuYwo+IEBAIC02MSw5 ICs2MSw4IEBAIHZvaWQgYW1kZ3B1X2dtY19nZXRfcGRlX2Zvcl9ibyhzdHJ1Y3QgYW1kZ3B1X2Jv ICpibywgaW50IGxldmVsLAo+ICAgICAgICAgYW1kZ3B1X2dtY19nZXRfdm1fcGRlKGFkZXYsIGxl dmVsLCBhZGRyLCBmbGFncyk7Cj4gIH0KPgo+IC0vKioKPiArLyoKPiAgICogYW1kZ3B1X2dtY19w ZF9hZGRyIC0gcmV0dXJuIHRoZSBhZGRyZXNzIG9mIHRoZSByb290IGRpcmVjdG9yeQo+IC0gKgo+ ICAgKi8KPiAgdWludDY0X3QgYW1kZ3B1X2dtY19wZF9hZGRyKHN0cnVjdCBhbWRncHVfYm8gKmJv KQo+ICB7Cj4gQEAgLTExMiw3ICsxMTEsNyBAQCBpbnQgYW1kZ3B1X2dtY19zZXRfcHRlX3BkZShz dHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwgdm9pZCAqY3B1X3B0X2FkZHIsCj4gIC8qKgo+ICAg KiBhbWRncHVfZ21jX2FncF9hZGRyIC0gcmV0dXJuIHRoZSBhZGRyZXNzIGluIHRoZSBBR1AgYWRk cmVzcyBzcGFjZQo+ICAgKgo+IC0gKiBAdGJvOiBUVE0gQk8gd2hpY2ggbmVlZHMgdGhlIGFkZHJl c3MsIG11c3QgYmUgaW4gR1RUIGRvbWFpbgo+ICsgKiBAYm86IFRUTSBCTyB3aGljaCBuZWVkcyB0 aGUgYWRkcmVzcywgbXVzdCBiZSBpbiBHVFQgZG9tYWluCj4gICAqCj4gICAqIFRyaWVzIHRvIGZp Z3VyZSBvdXQgaG93IHRvIGFjY2VzcyB0aGUgQk8gdGhyb3VnaCB0aGUgQUdQIGFwZXJ0dXJlLiBS ZXR1cm5zCj4gICAqIEFNREdQVV9CT19JTlZBTElEX09GRlNFVCBpZiB0aGF0IGlzIG5vdCBwb3Nz aWJsZS4KPiAtLQo+IDIuMjUuMQo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdm eAo=