From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50A91C433DF for ; Wed, 29 Jul 2020 21:55:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 251432082E for ; Wed, 29 Jul 2020 21:55:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gKqQtSnc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727781AbgG2Vzz (ORCPT ); Wed, 29 Jul 2020 17:55:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726365AbgG2Vzz (ORCPT ); Wed, 29 Jul 2020 17:55:55 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0420BC061794 for ; Wed, 29 Jul 2020 14:55:55 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id k8so4409107wma.2 for ; Wed, 29 Jul 2020 14:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=TiiQwPk5+wOcxrYMTcSS5MR4bewjoZWHQZN/jXHtdiY=; b=gKqQtSncl3aZQrpCwzujZGt/kEYgdOrn7K97OchbFtV6qAJ+AerT2QZqhONhgsO/BU z+eftmao4cxw//G57++dPfV1FINhUppAQQhsT/QrFjwtFMpp0cbQ4Zi23vy1lOABTSfj DzemwfZLHraQOvZsxJbCJkPlK9Ony3NEQ3qaXfkuESwBjY9Iq7Bs3wpIq1xs9FgYubT7 tGqLmMzUrrdj4wIkU08sVubHzFgyX5R57qpvcSNPBUk904JItj1EfOSZ1VlkIXYDUnqF bl/Ew4Jtn9PCNpDGKyrYbSdgFV+iWzNy1G+Wj3EKEpi+WNyhKLt/DjD+c7afiDOu4c2v 5GEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=TiiQwPk5+wOcxrYMTcSS5MR4bewjoZWHQZN/jXHtdiY=; b=jvTFLLBXRgIBtbiyHUX0ugfcI0w+uO4/QITDpe0ezx0MKEintO4rnrMuOtsJNKRydp SMqcY2FtrqAPf1MkadbLgt18Rn4PAk/2N4vJ1IhSrss4b8eDeptKlInfXA/H3PkC21Ke jzfiXnQXmOgRmh9L6DJFcgc5dwn5KkmMetT4DDb5S+SXTSwssUrOcI3MQXkfvGVBmGOw oAOcwqwiiOlKmPcQmImDEwm01AkOJlGmakRYuyhpGJ5s/4NrZZSXVRZDPWX89/seRuwC V4TgLwgMbimbtV0T8XicALy6wCaPb1yGJUjndCKA0MoRtBxnvvuuO5sHhgBTyRycq2pm hHAw== X-Gm-Message-State: AOAM530Julmm1HtXVVz2WchX7wBaKn0mfW/nr92uQNW7X9thOlp8VfRl DGt7A7qB8eZwZrjc/mo2DvYpOx6Tzqu0ni9cfYg= X-Google-Smtp-Source: ABdhPJy6xeXbe287qC13KOwKNKQS5Im4azlgXn6R3Xvzb5UezGM3otbEEztVP2ILmuILeliBoMojwbe/rnAUjzLzlrs= X-Received: by 2002:a1c:2:: with SMTP id 2mr10798884wma.79.1596059753614; Wed, 29 Jul 2020 14:55:53 -0700 (PDT) MIME-Version: 1.0 References: <20200728192924.441570-1-yepeilin.cs@gmail.com> <30b2a31f-77c2-56c1-ecde-875c6eea99d5@gmail.com> In-Reply-To: <30b2a31f-77c2-56c1-ecde-875c6eea99d5@gmail.com> From: Alex Deucher Date: Wed, 29 Jul 2020 17:55:42 -0400 Message-ID: Subject: Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl() To: Christian Koenig Cc: Peilin Ye , Alex Deucher , David Airlie , Daniel Vetter , Leo Liu , Arnd Bergmann , Greg Kroah-Hartman , Felix Kuehling , LKML , amd-gfx list , =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , Hans de Goede , Trek , Maling list - DRI developers , Thomas Zimmermann , Evan Quan , linux-kernel-mentees@lists.linuxfoundation.org, Nicholas Kazlauskas , Dan Carpenter , Xiaojie Yuan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied. Thanks! Alex On Wed, Jul 29, 2020 at 4:11 AM Christian K=C3=B6nig wrote: > > Am 28.07.20 um 21:29 schrieb Peilin Ye: > > Compiler leaves a 4-byte hole near the end of `dev_info`, causing > > amdgpu_info_ioctl() to copy uninitialized kernel stack memory to usersp= ace > > when `size` is greater than 356. > > > > In 2015 we tried to fix this issue by doing `=3D {};` on `dev_info`, wh= ich > > unfortunately does not initialize that 4-byte hole. Fix it by using > > memset() instead. > > > > Cc: stable@vger.kernel.org > > Fixes: c193fa91b918 ("drm/amdgpu: information leak in amdgpu_info_ioctl= ()") > > Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)") > > Suggested-by: Dan Carpenter > > Signed-off-by: Peilin Ye > > Reviewed-by: Christian K=C3=B6nig > > I can't count how many of those we have fixed over the years. > > At some point we should probably document that using "=3D {}" or "=3D { 0= }" > in the kernel is a really bad idea and should be avoided. > > Thanks, > Christian. > > > --- > > $ pahole -C "drm_amdgpu_info_device" drivers/gpu/drm/amd/amdgpu/amdgpu_= kms.o > > struct drm_amdgpu_info_device { > > __u32 device_id; /* 0 4 *= / > > __u32 chip_rev; /* 4 4 *= / > > __u32 external_rev; /* 8 4 *= / > > __u32 pci_rev; /* 12 4 *= / > > __u32 family; /* 16 4 *= / > > __u32 num_shader_engines; /* 20 4 *= / > > __u32 num_shader_arrays_per_engine; /* 24= 4 */ > > __u32 gpu_counter_freq; /* 28 4 *= / > > __u64 max_engine_clock; /* 32 8 *= / > > __u64 max_memory_clock; /* 40 8 *= / > > __u32 cu_active_number; /* 48 4 *= / > > __u32 cu_ao_mask; /* 52 4 *= / > > __u32 cu_bitmap[4][4]; /* 56 64 *= / > > /* --- cacheline 1 boundary (64 bytes) was 56 bytes ago --- */ > > __u32 enabled_rb_pipes_mask; /* 120 4 = */ > > __u32 num_rb_pipes; /* 124 4 *= / > > /* --- cacheline 2 boundary (128 bytes) --- */ > > __u32 num_hw_gfx_contexts; /* 128 4 *= / > > __u32 _pad; /* 132 4 *= / > > __u64 ids_flags; /* 136 8 *= / > > __u64 virtual_address_offset; /* 144 8= */ > > __u64 virtual_address_max; /* 152 8 *= / > > __u32 virtual_address_alignment; /* 160 = 4 */ > > __u32 pte_fragment_size; /* 164 4 *= / > > __u32 gart_page_size; /* 168 4 *= / > > __u32 ce_ram_size; /* 172 4 *= / > > __u32 vram_type; /* 176 4 *= / > > __u32 vram_bit_width; /* 180 4 *= / > > __u32 vce_harvest_config; /* 184 4 *= / > > __u32 gc_double_offchip_lds_buf; /* 188 = 4 */ > > /* --- cacheline 3 boundary (192 bytes) --- */ > > __u64 prim_buf_gpu_addr; /* 192 8 *= / > > __u64 pos_buf_gpu_addr; /* 200 8 *= / > > __u64 cntl_sb_buf_gpu_addr; /* 208 8 *= / > > __u64 param_buf_gpu_addr; /* 216 8 *= / > > __u32 prim_buf_size; /* 224 4 *= / > > __u32 pos_buf_size; /* 228 4 *= / > > __u32 cntl_sb_buf_size; /* 232 4 *= / > > __u32 param_buf_size; /* 236 4 *= / > > __u32 wave_front_size; /* 240 4 *= / > > __u32 num_shader_visible_vgprs; /* 244 = 4 */ > > __u32 num_cu_per_sh; /* 248 4 *= / > > __u32 num_tcc_blocks; /* 252 4 *= / > > /* --- cacheline 4 boundary (256 bytes) --- */ > > __u32 gs_vgt_table_depth; /* 256 4 *= / > > __u32 gs_prim_buffer_depth; /* 260 4 *= / > > __u32 max_gs_waves_per_vgt; /* 264 4 *= / > > __u32 _pad1; /* 268 4 *= / > > __u32 cu_ao_bitmap[4][4]; /* 272 64 *= / > > /* --- cacheline 5 boundary (320 bytes) was 16 bytes ago --- */ > > __u64 high_va_offset; /* 336 8 *= / > > __u64 high_va_max; /* 344 8 *= / > > __u32 pa_sc_tile_steering_override; /* 352= 4 */ > > > > /* XXX 4 bytes hole, try to pack */ > > > > __u64 tcc_disabled_mask; /* 360 8 *= / > > > > /* size: 368, cachelines: 6, members: 49 */ > > /* sum members: 364, holes: 1, sum holes: 4 */ > > /* last cacheline: 48 bytes */ > > }; > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/= amd/amdgpu/amdgpu_kms.c > > index a8c47aecd342..0047da06041f 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c > > @@ -707,9 +707,10 @@ static int amdgpu_info_ioctl(struct drm_device *de= v, void *data, struct drm_file > > return n ? -EFAULT : 0; > > } > > case AMDGPU_INFO_DEV_INFO: { > > - struct drm_amdgpu_info_device dev_info =3D {}; > > + struct drm_amdgpu_info_device dev_info; > > uint64_t vm_size; > > > > + memset(&dev_info, 0, sizeof(dev_info)); > > dev_info.device_id =3D dev->pdev->device; > > dev_info.chip_rev =3D adev->rev_id; > > dev_info.external_rev =3D adev->external_rev_id; > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F122C433E1 for ; Wed, 29 Jul 2020 21:55:58 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53B302082E for ; Wed, 29 Jul 2020 21:55:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gKqQtSnc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53B302082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 11C1287F3F; Wed, 29 Jul 2020 21:55:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EMKqFo7Rs1ov; Wed, 29 Jul 2020 21:55:57 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 73F2987EC4; Wed, 29 Jul 2020 21:55:57 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 64464C0050; Wed, 29 Jul 2020 21:55:57 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 776A0C004D for ; Wed, 29 Jul 2020 21:55:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 7343587F3F for ; Wed, 29 Jul 2020 21:55:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KPOX2ukWUJu6 for ; Wed, 29 Jul 2020 21:55:55 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by hemlock.osuosl.org (Postfix) with ESMTPS id 689A387EC4 for ; Wed, 29 Jul 2020 21:55:55 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id d190so3995270wmd.4 for ; Wed, 29 Jul 2020 14:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=TiiQwPk5+wOcxrYMTcSS5MR4bewjoZWHQZN/jXHtdiY=; b=gKqQtSncl3aZQrpCwzujZGt/kEYgdOrn7K97OchbFtV6qAJ+AerT2QZqhONhgsO/BU z+eftmao4cxw//G57++dPfV1FINhUppAQQhsT/QrFjwtFMpp0cbQ4Zi23vy1lOABTSfj DzemwfZLHraQOvZsxJbCJkPlK9Ony3NEQ3qaXfkuESwBjY9Iq7Bs3wpIq1xs9FgYubT7 tGqLmMzUrrdj4wIkU08sVubHzFgyX5R57qpvcSNPBUk904JItj1EfOSZ1VlkIXYDUnqF bl/Ew4Jtn9PCNpDGKyrYbSdgFV+iWzNy1G+Wj3EKEpi+WNyhKLt/DjD+c7afiDOu4c2v 5GEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=TiiQwPk5+wOcxrYMTcSS5MR4bewjoZWHQZN/jXHtdiY=; b=hIKlbtBYwyymeNZKAaHdovxuQr5ICH0G14dEmqpoeLs1iesGd2ehOKd/s5CWiFhthG wqQuGCD4VxP1vFGKZEUd+sJgDzU9tQ3w/urqcGnvYI3ZRDfhX3/gwi4XeovW/phioOus M4mTyZKFwMvyIU64n1NNpq+Y/7PriNcNTKAlaD0nlukcrD2kH6XoZUbmCwQ+O7+ce6LY np7X7tGv0HtTfPyaq8mFoy9Z5hcZdOVQrCH1512Q9EjUAC0HdtM/dzFnkAlzq8CrWo1Q AJc+A2toeZeC6HKbRTbU9X/cL/ayaFCr2I05CIvG8uGzTcwht+iYIKb7cE3ZADwNQT+w +KvQ== X-Gm-Message-State: AOAM532sRNp9otuYqOWlG5iosTsjXuGH4lxzGuNcrVCTg2XfMUfWKQd4 XlHLg//WGs2LRrI8wDZAaS4fj1L18Pmyln3te2c= X-Google-Smtp-Source: ABdhPJy6xeXbe287qC13KOwKNKQS5Im4azlgXn6R3Xvzb5UezGM3otbEEztVP2ILmuILeliBoMojwbe/rnAUjzLzlrs= X-Received: by 2002:a1c:2:: with SMTP id 2mr10798884wma.79.1596059753614; Wed, 29 Jul 2020 14:55:53 -0700 (PDT) MIME-Version: 1.0 References: <20200728192924.441570-1-yepeilin.cs@gmail.com> <30b2a31f-77c2-56c1-ecde-875c6eea99d5@gmail.com> In-Reply-To: <30b2a31f-77c2-56c1-ecde-875c6eea99d5@gmail.com> From: Alex Deucher Date: Wed, 29 Jul 2020 17:55:42 -0400 Message-ID: To: Christian Koenig Cc: Xiaojie Yuan , Thomas Zimmermann , Arnd Bergmann , David Airlie , Felix Kuehling , LKML , amd-gfx list , Nicholas Kazlauskas , =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , Hans de Goede , Trek , Maling list - DRI developers , Daniel Vetter , Alex Deucher , Evan Quan , Leo Liu , Peilin Ye , Dan Carpenter , linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl() X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" QXBwbGllZC4gIFRoYW5rcyEKCkFsZXgKCk9uIFdlZCwgSnVsIDI5LCAyMDIwIGF0IDQ6MTEgQU0g Q2hyaXN0aWFuIEvDtm5pZwo8Y2tvZW5pZy5sZWljaHR6dW1lcmtlbkBnbWFpbC5jb20+IHdyb3Rl Ogo+Cj4gQW0gMjguMDcuMjAgdW0gMjE6Mjkgc2NocmllYiBQZWlsaW4gWWU6Cj4gPiBDb21waWxl ciBsZWF2ZXMgYSA0LWJ5dGUgaG9sZSBuZWFyIHRoZSBlbmQgb2YgYGRldl9pbmZvYCwgY2F1c2lu Zwo+ID4gYW1kZ3B1X2luZm9faW9jdGwoKSB0byBjb3B5IHVuaW5pdGlhbGl6ZWQga2VybmVsIHN0 YWNrIG1lbW9yeSB0byB1c2Vyc3BhY2UKPiA+IHdoZW4gYHNpemVgIGlzIGdyZWF0ZXIgdGhhbiAz NTYuCj4gPgo+ID4gSW4gMjAxNSB3ZSB0cmllZCB0byBmaXggdGhpcyBpc3N1ZSBieSBkb2luZyBg PSB7fTtgIG9uIGBkZXZfaW5mb2AsIHdoaWNoCj4gPiB1bmZvcnR1bmF0ZWx5IGRvZXMgbm90IGlu aXRpYWxpemUgdGhhdCA0LWJ5dGUgaG9sZS4gRml4IGl0IGJ5IHVzaW5nCj4gPiBtZW1zZXQoKSBp bnN0ZWFkLgo+ID4KPiA+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnCj4gPiBGaXhlczogYzE5 M2ZhOTFiOTE4ICgiZHJtL2FtZGdwdTogaW5mb3JtYXRpb24gbGVhayBpbiBhbWRncHVfaW5mb19p b2N0bCgpIikKPiA+IEZpeGVzOiBkMzhjZWFmOTllZDAgKCJkcm0vYW1kZ3B1OiBhZGQgY29yZSBk cml2ZXIgKHY0KSIpCj4gPiBTdWdnZXN0ZWQtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50 ZXJAb3JhY2xlLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IFBlaWxpbiBZZSA8eWVwZWlsaW4uY3NA Z21haWwuY29tPgo+Cj4gUmV2aWV3ZWQtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5r b2VuaWdAYW1kLmNvbT4KPgo+IEkgY2FuJ3QgY291bnQgaG93IG1hbnkgb2YgdGhvc2Ugd2UgaGF2 ZSBmaXhlZCBvdmVyIHRoZSB5ZWFycy4KPgo+IEF0IHNvbWUgcG9pbnQgd2Ugc2hvdWxkIHByb2Jh Ymx5IGRvY3VtZW50IHRoYXQgdXNpbmcgIj0ge30iIG9yICI9IHsgMCB9Igo+IGluIHRoZSBrZXJu ZWwgaXMgYSByZWFsbHkgYmFkIGlkZWEgYW5kIHNob3VsZCBiZSBhdm9pZGVkLgo+Cj4gVGhhbmtz LAo+IENocmlzdGlhbi4KPgo+ID4gLS0tCj4gPiAkIHBhaG9sZSAtQyAiZHJtX2FtZGdwdV9pbmZv X2RldmljZSIgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2ttcy5vCj4gPiBzdHJ1 Y3QgZHJtX2FtZGdwdV9pbmZvX2RldmljZSB7Cj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAg ICAgICAgICBkZXZpY2VfaWQ7ICAgICAgICAgICAgLyogICAgIDAgICAgIDQgKi8KPiA+ICAgICAg IF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGNoaXBfcmV2OyAgICAgICAgICAgICAvKiAgICAg NCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgZXh0ZXJuYWxf cmV2OyAgICAgICAgIC8qICAgICA4ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAg ICAgICAgICAgICBwY2lfcmV2OyAgICAgICAgICAgICAgLyogICAgMTIgICAgIDQgKi8KPiA+ICAg ICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGZhbWlseTsgICAgICAgICAgICAgICAvKiAg ICAxNiAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgbnVtX3No YWRlcl9lbmdpbmVzOyAgIC8qICAgIDIwICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAg ICAgICAgICAgICAgICBudW1fc2hhZGVyX2FycmF5c19wZXJfZW5naW5lOyAvKiAgICAyNCAgICAg NCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgZ3B1X2NvdW50ZXJfZnJl cTsgICAgIC8qICAgIDI4ICAgICA0ICovCj4gPiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAg ICAgICBtYXhfZW5naW5lX2Nsb2NrOyAgICAgLyogICAgMzIgICAgIDggKi8KPiA+ICAgICAgIF9f dTY0ICAgICAgICAgICAgICAgICAgICAgIG1heF9tZW1vcnlfY2xvY2s7ICAgICAvKiAgICA0MCAg ICAgOCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgY3VfYWN0aXZlX251 bWJlcjsgICAgIC8qICAgIDQ4ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAg ICAgICAgICBjdV9hb19tYXNrOyAgICAgICAgICAgLyogICAgNTIgICAgIDQgKi8KPiA+ICAgICAg IF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGN1X2JpdG1hcFs0XVs0XTsgICAgICAvKiAgICA1 NiAgICA2NCAqLwo+ID4gICAgICAgLyogLS0tIGNhY2hlbGluZSAxIGJvdW5kYXJ5ICg2NCBieXRl cykgd2FzIDU2IGJ5dGVzIGFnbyAtLS0gKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAg ICAgICAgIGVuYWJsZWRfcmJfcGlwZXNfbWFzazsgLyogICAxMjAgICAgIDQgKi8KPiA+ICAgICAg IF9fdTMyICAgICAgICAgICAgICAgICAgICAgIG51bV9yYl9waXBlczsgICAgICAgICAvKiAgIDEy NCAgICAgNCAqLwo+ID4gICAgICAgLyogLS0tIGNhY2hlbGluZSAyIGJvdW5kYXJ5ICgxMjggYnl0 ZXMpIC0tLSAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgbnVtX2h3X2dm eF9jb250ZXh0czsgIC8qICAgMTI4ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAg ICAgICAgICAgICBfcGFkOyAgICAgICAgICAgICAgICAgLyogICAxMzIgICAgIDQgKi8KPiA+ICAg ICAgIF9fdTY0ICAgICAgICAgICAgICAgICAgICAgIGlkc19mbGFnczsgICAgICAgICAgICAvKiAg IDEzNiAgICAgOCAqLwo+ID4gICAgICAgX191NjQgICAgICAgICAgICAgICAgICAgICAgdmlydHVh bF9hZGRyZXNzX29mZnNldDsgLyogICAxNDQgICAgIDggKi8KPiA+ICAgICAgIF9fdTY0ICAgICAg ICAgICAgICAgICAgICAgIHZpcnR1YWxfYWRkcmVzc19tYXg7ICAvKiAgIDE1MiAgICAgOCAqLwo+ ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgdmlydHVhbF9hZGRyZXNzX2FsaWdu bWVudDsgLyogICAxNjAgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAg ICAgIHB0ZV9mcmFnbWVudF9zaXplOyAgICAvKiAgIDE2NCAgICAgNCAqLwo+ID4gICAgICAgX191 MzIgICAgICAgICAgICAgICAgICAgICAgZ2FydF9wYWdlX3NpemU7ICAgICAgIC8qICAgMTY4ICAg ICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBjZV9yYW1fc2l6ZTsg ICAgICAgICAgLyogICAxNzIgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAg ICAgICAgIHZyYW1fdHlwZTsgICAgICAgICAgICAvKiAgIDE3NiAgICAgNCAqLwo+ID4gICAgICAg X191MzIgICAgICAgICAgICAgICAgICAgICAgdnJhbV9iaXRfd2lkdGg7ICAgICAgIC8qICAgMTgw ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICB2Y2VfaGFydmVz dF9jb25maWc7ICAgLyogICAxODQgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAg ICAgICAgICAgIGdjX2RvdWJsZV9vZmZjaGlwX2xkc19idWY7IC8qICAgMTg4ICAgICA0ICovCj4g PiAgICAgICAvKiAtLS0gY2FjaGVsaW5lIDMgYm91bmRhcnkgKDE5MiBieXRlcykgLS0tICovCj4g PiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAgICAgICBwcmltX2J1Zl9ncHVfYWRkcjsgICAg LyogICAxOTIgICAgIDggKi8KPiA+ICAgICAgIF9fdTY0ICAgICAgICAgICAgICAgICAgICAgIHBv c19idWZfZ3B1X2FkZHI7ICAgICAvKiAgIDIwMCAgICAgOCAqLwo+ID4gICAgICAgX191NjQgICAg ICAgICAgICAgICAgICAgICAgY250bF9zYl9idWZfZ3B1X2FkZHI7IC8qICAgMjA4ICAgICA4ICov Cj4gPiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAgICAgICBwYXJhbV9idWZfZ3B1X2FkZHI7 ICAgLyogICAyMTYgICAgIDggKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAg IHByaW1fYnVmX3NpemU7ICAgICAgICAvKiAgIDIyNCAgICAgNCAqLwo+ID4gICAgICAgX191MzIg ICAgICAgICAgICAgICAgICAgICAgcG9zX2J1Zl9zaXplOyAgICAgICAgIC8qICAgMjI4ICAgICA0 ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBjbnRsX3NiX2J1Zl9zaXpl OyAgICAgLyogICAyMzIgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAg ICAgIHBhcmFtX2J1Zl9zaXplOyAgICAgICAvKiAgIDIzNiAgICAgNCAqLwo+ID4gICAgICAgX191 MzIgICAgICAgICAgICAgICAgICAgICAgd2F2ZV9mcm9udF9zaXplOyAgICAgIC8qICAgMjQwICAg ICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBudW1fc2hhZGVyX3Zp c2libGVfdmdwcnM7IC8qICAgMjQ0ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAg ICAgICAgICAgICBudW1fY3VfcGVyX3NoOyAgICAgICAgLyogICAyNDggICAgIDQgKi8KPiA+ICAg ICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIG51bV90Y2NfYmxvY2tzOyAgICAgICAvKiAg IDI1MiAgICAgNCAqLwo+ID4gICAgICAgLyogLS0tIGNhY2hlbGluZSA0IGJvdW5kYXJ5ICgyNTYg Ynl0ZXMpIC0tLSAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgZ3Nfdmd0 X3RhYmxlX2RlcHRoOyAgIC8qICAgMjU2ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAg ICAgICAgICAgICAgICBnc19wcmltX2J1ZmZlcl9kZXB0aDsgLyogICAyNjAgICAgIDQgKi8KPiA+ ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIG1heF9nc193YXZlc19wZXJfdmd0OyAv KiAgIDI2NCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgX3Bh ZDE7ICAgICAgICAgICAgICAgIC8qICAgMjY4ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAg ICAgICAgICAgICAgICAgICBjdV9hb19iaXRtYXBbNF1bNF07ICAgLyogICAyNzIgICAgNjQgKi8K PiA+ICAgICAgIC8qIC0tLSBjYWNoZWxpbmUgNSBib3VuZGFyeSAoMzIwIGJ5dGVzKSB3YXMgMTYg Ynl0ZXMgYWdvIC0tLSAqLwo+ID4gICAgICAgX191NjQgICAgICAgICAgICAgICAgICAgICAgaGln aF92YV9vZmZzZXQ7ICAgICAgIC8qICAgMzM2ICAgICA4ICovCj4gPiAgICAgICBfX3U2NCAgICAg ICAgICAgICAgICAgICAgICBoaWdoX3ZhX21heDsgICAgICAgICAgLyogICAzNDQgICAgIDggKi8K PiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIHBhX3NjX3RpbGVfc3RlZXJpbmdf b3ZlcnJpZGU7IC8qICAgMzUyICAgICA0ICovCj4gPgo+ID4gICAgICAgLyogWFhYIDQgYnl0ZXMg aG9sZSwgdHJ5IHRvIHBhY2sgKi8KPiA+Cj4gPiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAg ICAgICB0Y2NfZGlzYWJsZWRfbWFzazsgICAgLyogICAzNjAgICAgIDggKi8KPiA+Cj4gPiAgICAg ICAvKiBzaXplOiAzNjgsIGNhY2hlbGluZXM6IDYsIG1lbWJlcnM6IDQ5ICovCj4gPiAgICAgICAv KiBzdW0gbWVtYmVyczogMzY0LCBob2xlczogMSwgc3VtIGhvbGVzOiA0ICovCj4gPiAgICAgICAv KiBsYXN0IGNhY2hlbGluZTogNDggYnl0ZXMgKi8KPiA+IH07Cj4gPgo+ID4gICBkcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfa21zLmMgfCAzICsrLQo+ID4gICAxIGZpbGUgY2hhbmdl ZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9rbXMuYyBiL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdV9rbXMuYwo+ID4gaW5kZXggYThjNDdhZWNkMzQyLi4wMDQ3ZGEwNjA0 MWYgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfa21z LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9rbXMuYwo+ID4g QEAgLTcwNyw5ICs3MDcsMTAgQEAgc3RhdGljIGludCBhbWRncHVfaW5mb19pb2N0bChzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLCBzdHJ1Y3QgZHJtX2ZpbGUKPiA+ICAgICAgICAg ICAgICAgcmV0dXJuIG4gPyAtRUZBVUxUIDogMDsKPiA+ICAgICAgIH0KPiA+ICAgICAgIGNhc2Ug QU1ER1BVX0lORk9fREVWX0lORk86IHsKPiA+IC0gICAgICAgICAgICAgc3RydWN0IGRybV9hbWRn cHVfaW5mb19kZXZpY2UgZGV2X2luZm8gPSB7fTsKPiA+ICsgICAgICAgICAgICAgc3RydWN0IGRy bV9hbWRncHVfaW5mb19kZXZpY2UgZGV2X2luZm87Cj4gPiAgICAgICAgICAgICAgIHVpbnQ2NF90 IHZtX3NpemU7Cj4gPgo+ID4gKyAgICAgICAgICAgICBtZW1zZXQoJmRldl9pbmZvLCAwLCBzaXpl b2YoZGV2X2luZm8pKTsKPiA+ICAgICAgICAgICAgICAgZGV2X2luZm8uZGV2aWNlX2lkID0gZGV2 LT5wZGV2LT5kZXZpY2U7Cj4gPiAgICAgICAgICAgICAgIGRldl9pbmZvLmNoaXBfcmV2ID0gYWRl di0+cmV2X2lkOwo+ID4gICAgICAgICAgICAgICBkZXZfaW5mby5leHRlcm5hbF9yZXYgPSBhZGV2 LT5leHRlcm5hbF9yZXZfaWQ7Cj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+IGFtZC1nZnggbWFpbGluZyBsaXN0Cj4gYW1kLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2FtZC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KTGludXgta2VybmVsLW1lbnRlZXMgbWFpbGluZyBsaXN0CkxpbnV4LWtlcm5lbC1tZW50ZWVz QGxpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24u b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgta2VybmVsLW1lbnRlZXMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55D94C433E0 for ; Wed, 29 Jul 2020 21:55:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28D8C2082E for ; Wed, 29 Jul 2020 21:55:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gKqQtSnc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28D8C2082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 078BD6E7E6; Wed, 29 Jul 2020 21:55:56 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id 184816E7E5; Wed, 29 Jul 2020 21:55:55 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id f18so4391151wml.3; Wed, 29 Jul 2020 14:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=TiiQwPk5+wOcxrYMTcSS5MR4bewjoZWHQZN/jXHtdiY=; b=gKqQtSncl3aZQrpCwzujZGt/kEYgdOrn7K97OchbFtV6qAJ+AerT2QZqhONhgsO/BU z+eftmao4cxw//G57++dPfV1FINhUppAQQhsT/QrFjwtFMpp0cbQ4Zi23vy1lOABTSfj DzemwfZLHraQOvZsxJbCJkPlK9Ony3NEQ3qaXfkuESwBjY9Iq7Bs3wpIq1xs9FgYubT7 tGqLmMzUrrdj4wIkU08sVubHzFgyX5R57qpvcSNPBUk904JItj1EfOSZ1VlkIXYDUnqF bl/Ew4Jtn9PCNpDGKyrYbSdgFV+iWzNy1G+Wj3EKEpi+WNyhKLt/DjD+c7afiDOu4c2v 5GEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=TiiQwPk5+wOcxrYMTcSS5MR4bewjoZWHQZN/jXHtdiY=; b=f+cqnLzttCLJfOqUpWKpnnBonypgQXSiKZdqTjO+HCqQGEBAuTQ12xHVI1zi80jXp3 mN6cjGio2rj61CXOsLU5x9UdVNRmedUE7zAYrLRnbzIi1F2qXQHtBPov4d24U21fqfCh gkW4sJrTnhFUM9h1a9DZB7Z9UvEfNysS1nfJ1qpPVcaMOxZAVqZsAWvxJJLLCjOAs8GX L5SfCa+B7SmhzlknEr/s587YYfryXCDytW0IbfnuC543VMmJ7imX+hYPymPDnRkI/NAW oCzDrSiZz/O56mRblmTK4aAyl9tCsbqz+5yU/L27hMZ3T8qPHhBT3O8P2JqHjgAFoLl5 A9Ow== X-Gm-Message-State: AOAM533w5O8uxemm6/WwhcNY5JGU+MpJ8Epy8LUnmzn4Mpe8/uWN6pRy DJeXTPdtHLf9KEhpTWTTjZ52PNEUs3GKHaULeUw= X-Google-Smtp-Source: ABdhPJy6xeXbe287qC13KOwKNKQS5Im4azlgXn6R3Xvzb5UezGM3otbEEztVP2ILmuILeliBoMojwbe/rnAUjzLzlrs= X-Received: by 2002:a1c:2:: with SMTP id 2mr10798884wma.79.1596059753614; Wed, 29 Jul 2020 14:55:53 -0700 (PDT) MIME-Version: 1.0 References: <20200728192924.441570-1-yepeilin.cs@gmail.com> <30b2a31f-77c2-56c1-ecde-875c6eea99d5@gmail.com> In-Reply-To: <30b2a31f-77c2-56c1-ecde-875c6eea99d5@gmail.com> From: Alex Deucher Date: Wed, 29 Jul 2020 17:55:42 -0400 Message-ID: Subject: Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl() To: Christian Koenig X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Xiaojie Yuan , Thomas Zimmermann , Arnd Bergmann , David Airlie , Greg Kroah-Hartman , Felix Kuehling , LKML , amd-gfx list , Nicholas Kazlauskas , =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , Hans de Goede , Trek , Maling list - DRI developers , Alex Deucher , Evan Quan , Leo Liu , Peilin Ye , Dan Carpenter , linux-kernel-mentees@lists.linuxfoundation.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" QXBwbGllZC4gIFRoYW5rcyEKCkFsZXgKCk9uIFdlZCwgSnVsIDI5LCAyMDIwIGF0IDQ6MTEgQU0g Q2hyaXN0aWFuIEvDtm5pZwo8Y2tvZW5pZy5sZWljaHR6dW1lcmtlbkBnbWFpbC5jb20+IHdyb3Rl Ogo+Cj4gQW0gMjguMDcuMjAgdW0gMjE6Mjkgc2NocmllYiBQZWlsaW4gWWU6Cj4gPiBDb21waWxl ciBsZWF2ZXMgYSA0LWJ5dGUgaG9sZSBuZWFyIHRoZSBlbmQgb2YgYGRldl9pbmZvYCwgY2F1c2lu Zwo+ID4gYW1kZ3B1X2luZm9faW9jdGwoKSB0byBjb3B5IHVuaW5pdGlhbGl6ZWQga2VybmVsIHN0 YWNrIG1lbW9yeSB0byB1c2Vyc3BhY2UKPiA+IHdoZW4gYHNpemVgIGlzIGdyZWF0ZXIgdGhhbiAz NTYuCj4gPgo+ID4gSW4gMjAxNSB3ZSB0cmllZCB0byBmaXggdGhpcyBpc3N1ZSBieSBkb2luZyBg PSB7fTtgIG9uIGBkZXZfaW5mb2AsIHdoaWNoCj4gPiB1bmZvcnR1bmF0ZWx5IGRvZXMgbm90IGlu aXRpYWxpemUgdGhhdCA0LWJ5dGUgaG9sZS4gRml4IGl0IGJ5IHVzaW5nCj4gPiBtZW1zZXQoKSBp bnN0ZWFkLgo+ID4KPiA+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnCj4gPiBGaXhlczogYzE5 M2ZhOTFiOTE4ICgiZHJtL2FtZGdwdTogaW5mb3JtYXRpb24gbGVhayBpbiBhbWRncHVfaW5mb19p b2N0bCgpIikKPiA+IEZpeGVzOiBkMzhjZWFmOTllZDAgKCJkcm0vYW1kZ3B1OiBhZGQgY29yZSBk cml2ZXIgKHY0KSIpCj4gPiBTdWdnZXN0ZWQtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50 ZXJAb3JhY2xlLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IFBlaWxpbiBZZSA8eWVwZWlsaW4uY3NA Z21haWwuY29tPgo+Cj4gUmV2aWV3ZWQtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5r b2VuaWdAYW1kLmNvbT4KPgo+IEkgY2FuJ3QgY291bnQgaG93IG1hbnkgb2YgdGhvc2Ugd2UgaGF2 ZSBmaXhlZCBvdmVyIHRoZSB5ZWFycy4KPgo+IEF0IHNvbWUgcG9pbnQgd2Ugc2hvdWxkIHByb2Jh Ymx5IGRvY3VtZW50IHRoYXQgdXNpbmcgIj0ge30iIG9yICI9IHsgMCB9Igo+IGluIHRoZSBrZXJu ZWwgaXMgYSByZWFsbHkgYmFkIGlkZWEgYW5kIHNob3VsZCBiZSBhdm9pZGVkLgo+Cj4gVGhhbmtz LAo+IENocmlzdGlhbi4KPgo+ID4gLS0tCj4gPiAkIHBhaG9sZSAtQyAiZHJtX2FtZGdwdV9pbmZv X2RldmljZSIgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2ttcy5vCj4gPiBzdHJ1 Y3QgZHJtX2FtZGdwdV9pbmZvX2RldmljZSB7Cj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAg ICAgICAgICBkZXZpY2VfaWQ7ICAgICAgICAgICAgLyogICAgIDAgICAgIDQgKi8KPiA+ICAgICAg IF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGNoaXBfcmV2OyAgICAgICAgICAgICAvKiAgICAg NCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgZXh0ZXJuYWxf cmV2OyAgICAgICAgIC8qICAgICA4ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAg ICAgICAgICAgICBwY2lfcmV2OyAgICAgICAgICAgICAgLyogICAgMTIgICAgIDQgKi8KPiA+ICAg ICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGZhbWlseTsgICAgICAgICAgICAgICAvKiAg ICAxNiAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgbnVtX3No YWRlcl9lbmdpbmVzOyAgIC8qICAgIDIwICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAg ICAgICAgICAgICAgICBudW1fc2hhZGVyX2FycmF5c19wZXJfZW5naW5lOyAvKiAgICAyNCAgICAg NCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgZ3B1X2NvdW50ZXJfZnJl cTsgICAgIC8qICAgIDI4ICAgICA0ICovCj4gPiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAg ICAgICBtYXhfZW5naW5lX2Nsb2NrOyAgICAgLyogICAgMzIgICAgIDggKi8KPiA+ICAgICAgIF9f dTY0ICAgICAgICAgICAgICAgICAgICAgIG1heF9tZW1vcnlfY2xvY2s7ICAgICAvKiAgICA0MCAg ICAgOCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgY3VfYWN0aXZlX251 bWJlcjsgICAgIC8qICAgIDQ4ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAg ICAgICAgICBjdV9hb19tYXNrOyAgICAgICAgICAgLyogICAgNTIgICAgIDQgKi8KPiA+ICAgICAg IF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGN1X2JpdG1hcFs0XVs0XTsgICAgICAvKiAgICA1 NiAgICA2NCAqLwo+ID4gICAgICAgLyogLS0tIGNhY2hlbGluZSAxIGJvdW5kYXJ5ICg2NCBieXRl cykgd2FzIDU2IGJ5dGVzIGFnbyAtLS0gKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAg ICAgICAgIGVuYWJsZWRfcmJfcGlwZXNfbWFzazsgLyogICAxMjAgICAgIDQgKi8KPiA+ICAgICAg IF9fdTMyICAgICAgICAgICAgICAgICAgICAgIG51bV9yYl9waXBlczsgICAgICAgICAvKiAgIDEy NCAgICAgNCAqLwo+ID4gICAgICAgLyogLS0tIGNhY2hlbGluZSAyIGJvdW5kYXJ5ICgxMjggYnl0 ZXMpIC0tLSAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgbnVtX2h3X2dm eF9jb250ZXh0czsgIC8qICAgMTI4ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAg ICAgICAgICAgICBfcGFkOyAgICAgICAgICAgICAgICAgLyogICAxMzIgICAgIDQgKi8KPiA+ICAg ICAgIF9fdTY0ICAgICAgICAgICAgICAgICAgICAgIGlkc19mbGFnczsgICAgICAgICAgICAvKiAg IDEzNiAgICAgOCAqLwo+ID4gICAgICAgX191NjQgICAgICAgICAgICAgICAgICAgICAgdmlydHVh bF9hZGRyZXNzX29mZnNldDsgLyogICAxNDQgICAgIDggKi8KPiA+ICAgICAgIF9fdTY0ICAgICAg ICAgICAgICAgICAgICAgIHZpcnR1YWxfYWRkcmVzc19tYXg7ICAvKiAgIDE1MiAgICAgOCAqLwo+ ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgdmlydHVhbF9hZGRyZXNzX2FsaWdu bWVudDsgLyogICAxNjAgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAg ICAgIHB0ZV9mcmFnbWVudF9zaXplOyAgICAvKiAgIDE2NCAgICAgNCAqLwo+ID4gICAgICAgX191 MzIgICAgICAgICAgICAgICAgICAgICAgZ2FydF9wYWdlX3NpemU7ICAgICAgIC8qICAgMTY4ICAg ICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBjZV9yYW1fc2l6ZTsg ICAgICAgICAgLyogICAxNzIgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAg ICAgICAgIHZyYW1fdHlwZTsgICAgICAgICAgICAvKiAgIDE3NiAgICAgNCAqLwo+ID4gICAgICAg X191MzIgICAgICAgICAgICAgICAgICAgICAgdnJhbV9iaXRfd2lkdGg7ICAgICAgIC8qICAgMTgw ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICB2Y2VfaGFydmVz dF9jb25maWc7ICAgLyogICAxODQgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAg ICAgICAgICAgIGdjX2RvdWJsZV9vZmZjaGlwX2xkc19idWY7IC8qICAgMTg4ICAgICA0ICovCj4g PiAgICAgICAvKiAtLS0gY2FjaGVsaW5lIDMgYm91bmRhcnkgKDE5MiBieXRlcykgLS0tICovCj4g PiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAgICAgICBwcmltX2J1Zl9ncHVfYWRkcjsgICAg LyogICAxOTIgICAgIDggKi8KPiA+ICAgICAgIF9fdTY0ICAgICAgICAgICAgICAgICAgICAgIHBv c19idWZfZ3B1X2FkZHI7ICAgICAvKiAgIDIwMCAgICAgOCAqLwo+ID4gICAgICAgX191NjQgICAg ICAgICAgICAgICAgICAgICAgY250bF9zYl9idWZfZ3B1X2FkZHI7IC8qICAgMjA4ICAgICA4ICov Cj4gPiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAgICAgICBwYXJhbV9idWZfZ3B1X2FkZHI7 ICAgLyogICAyMTYgICAgIDggKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAg IHByaW1fYnVmX3NpemU7ICAgICAgICAvKiAgIDIyNCAgICAgNCAqLwo+ID4gICAgICAgX191MzIg ICAgICAgICAgICAgICAgICAgICAgcG9zX2J1Zl9zaXplOyAgICAgICAgIC8qICAgMjI4ICAgICA0 ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBjbnRsX3NiX2J1Zl9zaXpl OyAgICAgLyogICAyMzIgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAg ICAgIHBhcmFtX2J1Zl9zaXplOyAgICAgICAvKiAgIDIzNiAgICAgNCAqLwo+ID4gICAgICAgX191 MzIgICAgICAgICAgICAgICAgICAgICAgd2F2ZV9mcm9udF9zaXplOyAgICAgIC8qICAgMjQwICAg ICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBudW1fc2hhZGVyX3Zp c2libGVfdmdwcnM7IC8qICAgMjQ0ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAg ICAgICAgICAgICBudW1fY3VfcGVyX3NoOyAgICAgICAgLyogICAyNDggICAgIDQgKi8KPiA+ICAg ICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIG51bV90Y2NfYmxvY2tzOyAgICAgICAvKiAg IDI1MiAgICAgNCAqLwo+ID4gICAgICAgLyogLS0tIGNhY2hlbGluZSA0IGJvdW5kYXJ5ICgyNTYg Ynl0ZXMpIC0tLSAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgZ3Nfdmd0 X3RhYmxlX2RlcHRoOyAgIC8qICAgMjU2ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAg ICAgICAgICAgICAgICBnc19wcmltX2J1ZmZlcl9kZXB0aDsgLyogICAyNjAgICAgIDQgKi8KPiA+ ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIG1heF9nc193YXZlc19wZXJfdmd0OyAv KiAgIDI2NCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgX3Bh ZDE7ICAgICAgICAgICAgICAgIC8qICAgMjY4ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAg ICAgICAgICAgICAgICAgICBjdV9hb19iaXRtYXBbNF1bNF07ICAgLyogICAyNzIgICAgNjQgKi8K PiA+ICAgICAgIC8qIC0tLSBjYWNoZWxpbmUgNSBib3VuZGFyeSAoMzIwIGJ5dGVzKSB3YXMgMTYg Ynl0ZXMgYWdvIC0tLSAqLwo+ID4gICAgICAgX191NjQgICAgICAgICAgICAgICAgICAgICAgaGln aF92YV9vZmZzZXQ7ICAgICAgIC8qICAgMzM2ICAgICA4ICovCj4gPiAgICAgICBfX3U2NCAgICAg ICAgICAgICAgICAgICAgICBoaWdoX3ZhX21heDsgICAgICAgICAgLyogICAzNDQgICAgIDggKi8K PiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIHBhX3NjX3RpbGVfc3RlZXJpbmdf b3ZlcnJpZGU7IC8qICAgMzUyICAgICA0ICovCj4gPgo+ID4gICAgICAgLyogWFhYIDQgYnl0ZXMg aG9sZSwgdHJ5IHRvIHBhY2sgKi8KPiA+Cj4gPiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAg ICAgICB0Y2NfZGlzYWJsZWRfbWFzazsgICAgLyogICAzNjAgICAgIDggKi8KPiA+Cj4gPiAgICAg ICAvKiBzaXplOiAzNjgsIGNhY2hlbGluZXM6IDYsIG1lbWJlcnM6IDQ5ICovCj4gPiAgICAgICAv KiBzdW0gbWVtYmVyczogMzY0LCBob2xlczogMSwgc3VtIGhvbGVzOiA0ICovCj4gPiAgICAgICAv KiBsYXN0IGNhY2hlbGluZTogNDggYnl0ZXMgKi8KPiA+IH07Cj4gPgo+ID4gICBkcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfa21zLmMgfCAzICsrLQo+ID4gICAxIGZpbGUgY2hhbmdl ZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9rbXMuYyBiL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdV9rbXMuYwo+ID4gaW5kZXggYThjNDdhZWNkMzQyLi4wMDQ3ZGEwNjA0 MWYgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfa21z LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9rbXMuYwo+ID4g QEAgLTcwNyw5ICs3MDcsMTAgQEAgc3RhdGljIGludCBhbWRncHVfaW5mb19pb2N0bChzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLCBzdHJ1Y3QgZHJtX2ZpbGUKPiA+ICAgICAgICAg ICAgICAgcmV0dXJuIG4gPyAtRUZBVUxUIDogMDsKPiA+ICAgICAgIH0KPiA+ICAgICAgIGNhc2Ug QU1ER1BVX0lORk9fREVWX0lORk86IHsKPiA+IC0gICAgICAgICAgICAgc3RydWN0IGRybV9hbWRn cHVfaW5mb19kZXZpY2UgZGV2X2luZm8gPSB7fTsKPiA+ICsgICAgICAgICAgICAgc3RydWN0IGRy bV9hbWRncHVfaW5mb19kZXZpY2UgZGV2X2luZm87Cj4gPiAgICAgICAgICAgICAgIHVpbnQ2NF90 IHZtX3NpemU7Cj4gPgo+ID4gKyAgICAgICAgICAgICBtZW1zZXQoJmRldl9pbmZvLCAwLCBzaXpl b2YoZGV2X2luZm8pKTsKPiA+ICAgICAgICAgICAgICAgZGV2X2luZm8uZGV2aWNlX2lkID0gZGV2 LT5wZGV2LT5kZXZpY2U7Cj4gPiAgICAgICAgICAgICAgIGRldl9pbmZvLmNoaXBfcmV2ID0gYWRl di0+cmV2X2lkOwo+ID4gICAgICAgICAgICAgICBkZXZfaW5mby5leHRlcm5hbF9yZXYgPSBhZGV2 LT5leHRlcm5hbF9yZXZfaWQ7Cj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+IGFtZC1nZnggbWFpbGluZyBsaXN0Cj4gYW1kLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2FtZC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3567C433E0 for ; Wed, 29 Jul 2020 21:55:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 800202082E for ; Wed, 29 Jul 2020 21:55:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gKqQtSnc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 800202082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B9C496E7E5; Wed, 29 Jul 2020 21:55:55 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id 184816E7E5; Wed, 29 Jul 2020 21:55:55 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id f18so4391151wml.3; Wed, 29 Jul 2020 14:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=TiiQwPk5+wOcxrYMTcSS5MR4bewjoZWHQZN/jXHtdiY=; b=gKqQtSncl3aZQrpCwzujZGt/kEYgdOrn7K97OchbFtV6qAJ+AerT2QZqhONhgsO/BU z+eftmao4cxw//G57++dPfV1FINhUppAQQhsT/QrFjwtFMpp0cbQ4Zi23vy1lOABTSfj DzemwfZLHraQOvZsxJbCJkPlK9Ony3NEQ3qaXfkuESwBjY9Iq7Bs3wpIq1xs9FgYubT7 tGqLmMzUrrdj4wIkU08sVubHzFgyX5R57qpvcSNPBUk904JItj1EfOSZ1VlkIXYDUnqF bl/Ew4Jtn9PCNpDGKyrYbSdgFV+iWzNy1G+Wj3EKEpi+WNyhKLt/DjD+c7afiDOu4c2v 5GEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=TiiQwPk5+wOcxrYMTcSS5MR4bewjoZWHQZN/jXHtdiY=; b=f+cqnLzttCLJfOqUpWKpnnBonypgQXSiKZdqTjO+HCqQGEBAuTQ12xHVI1zi80jXp3 mN6cjGio2rj61CXOsLU5x9UdVNRmedUE7zAYrLRnbzIi1F2qXQHtBPov4d24U21fqfCh gkW4sJrTnhFUM9h1a9DZB7Z9UvEfNysS1nfJ1qpPVcaMOxZAVqZsAWvxJJLLCjOAs8GX L5SfCa+B7SmhzlknEr/s587YYfryXCDytW0IbfnuC543VMmJ7imX+hYPymPDnRkI/NAW oCzDrSiZz/O56mRblmTK4aAyl9tCsbqz+5yU/L27hMZ3T8qPHhBT3O8P2JqHjgAFoLl5 A9Ow== X-Gm-Message-State: AOAM533w5O8uxemm6/WwhcNY5JGU+MpJ8Epy8LUnmzn4Mpe8/uWN6pRy DJeXTPdtHLf9KEhpTWTTjZ52PNEUs3GKHaULeUw= X-Google-Smtp-Source: ABdhPJy6xeXbe287qC13KOwKNKQS5Im4azlgXn6R3Xvzb5UezGM3otbEEztVP2ILmuILeliBoMojwbe/rnAUjzLzlrs= X-Received: by 2002:a1c:2:: with SMTP id 2mr10798884wma.79.1596059753614; Wed, 29 Jul 2020 14:55:53 -0700 (PDT) MIME-Version: 1.0 References: <20200728192924.441570-1-yepeilin.cs@gmail.com> <30b2a31f-77c2-56c1-ecde-875c6eea99d5@gmail.com> In-Reply-To: <30b2a31f-77c2-56c1-ecde-875c6eea99d5@gmail.com> From: Alex Deucher Date: Wed, 29 Jul 2020 17:55:42 -0400 Message-ID: Subject: Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl() To: Christian Koenig X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Xiaojie Yuan , Thomas Zimmermann , Arnd Bergmann , David Airlie , Greg Kroah-Hartman , Felix Kuehling , LKML , amd-gfx list , Nicholas Kazlauskas , =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , Hans de Goede , Trek , Maling list - DRI developers , Daniel Vetter , Alex Deucher , Evan Quan , Leo Liu , Peilin Ye , Dan Carpenter , linux-kernel-mentees@lists.linuxfoundation.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" QXBwbGllZC4gIFRoYW5rcyEKCkFsZXgKCk9uIFdlZCwgSnVsIDI5LCAyMDIwIGF0IDQ6MTEgQU0g Q2hyaXN0aWFuIEvDtm5pZwo8Y2tvZW5pZy5sZWljaHR6dW1lcmtlbkBnbWFpbC5jb20+IHdyb3Rl Ogo+Cj4gQW0gMjguMDcuMjAgdW0gMjE6Mjkgc2NocmllYiBQZWlsaW4gWWU6Cj4gPiBDb21waWxl ciBsZWF2ZXMgYSA0LWJ5dGUgaG9sZSBuZWFyIHRoZSBlbmQgb2YgYGRldl9pbmZvYCwgY2F1c2lu Zwo+ID4gYW1kZ3B1X2luZm9faW9jdGwoKSB0byBjb3B5IHVuaW5pdGlhbGl6ZWQga2VybmVsIHN0 YWNrIG1lbW9yeSB0byB1c2Vyc3BhY2UKPiA+IHdoZW4gYHNpemVgIGlzIGdyZWF0ZXIgdGhhbiAz NTYuCj4gPgo+ID4gSW4gMjAxNSB3ZSB0cmllZCB0byBmaXggdGhpcyBpc3N1ZSBieSBkb2luZyBg PSB7fTtgIG9uIGBkZXZfaW5mb2AsIHdoaWNoCj4gPiB1bmZvcnR1bmF0ZWx5IGRvZXMgbm90IGlu aXRpYWxpemUgdGhhdCA0LWJ5dGUgaG9sZS4gRml4IGl0IGJ5IHVzaW5nCj4gPiBtZW1zZXQoKSBp bnN0ZWFkLgo+ID4KPiA+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnCj4gPiBGaXhlczogYzE5 M2ZhOTFiOTE4ICgiZHJtL2FtZGdwdTogaW5mb3JtYXRpb24gbGVhayBpbiBhbWRncHVfaW5mb19p b2N0bCgpIikKPiA+IEZpeGVzOiBkMzhjZWFmOTllZDAgKCJkcm0vYW1kZ3B1OiBhZGQgY29yZSBk cml2ZXIgKHY0KSIpCj4gPiBTdWdnZXN0ZWQtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50 ZXJAb3JhY2xlLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IFBlaWxpbiBZZSA8eWVwZWlsaW4uY3NA Z21haWwuY29tPgo+Cj4gUmV2aWV3ZWQtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5r b2VuaWdAYW1kLmNvbT4KPgo+IEkgY2FuJ3QgY291bnQgaG93IG1hbnkgb2YgdGhvc2Ugd2UgaGF2 ZSBmaXhlZCBvdmVyIHRoZSB5ZWFycy4KPgo+IEF0IHNvbWUgcG9pbnQgd2Ugc2hvdWxkIHByb2Jh Ymx5IGRvY3VtZW50IHRoYXQgdXNpbmcgIj0ge30iIG9yICI9IHsgMCB9Igo+IGluIHRoZSBrZXJu ZWwgaXMgYSByZWFsbHkgYmFkIGlkZWEgYW5kIHNob3VsZCBiZSBhdm9pZGVkLgo+Cj4gVGhhbmtz LAo+IENocmlzdGlhbi4KPgo+ID4gLS0tCj4gPiAkIHBhaG9sZSAtQyAiZHJtX2FtZGdwdV9pbmZv X2RldmljZSIgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2ttcy5vCj4gPiBzdHJ1 Y3QgZHJtX2FtZGdwdV9pbmZvX2RldmljZSB7Cj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAg ICAgICAgICBkZXZpY2VfaWQ7ICAgICAgICAgICAgLyogICAgIDAgICAgIDQgKi8KPiA+ICAgICAg IF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGNoaXBfcmV2OyAgICAgICAgICAgICAvKiAgICAg NCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgZXh0ZXJuYWxf cmV2OyAgICAgICAgIC8qICAgICA4ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAg ICAgICAgICAgICBwY2lfcmV2OyAgICAgICAgICAgICAgLyogICAgMTIgICAgIDQgKi8KPiA+ICAg ICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGZhbWlseTsgICAgICAgICAgICAgICAvKiAg ICAxNiAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgbnVtX3No YWRlcl9lbmdpbmVzOyAgIC8qICAgIDIwICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAg ICAgICAgICAgICAgICBudW1fc2hhZGVyX2FycmF5c19wZXJfZW5naW5lOyAvKiAgICAyNCAgICAg NCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgZ3B1X2NvdW50ZXJfZnJl cTsgICAgIC8qICAgIDI4ICAgICA0ICovCj4gPiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAg ICAgICBtYXhfZW5naW5lX2Nsb2NrOyAgICAgLyogICAgMzIgICAgIDggKi8KPiA+ICAgICAgIF9f dTY0ICAgICAgICAgICAgICAgICAgICAgIG1heF9tZW1vcnlfY2xvY2s7ICAgICAvKiAgICA0MCAg ICAgOCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgY3VfYWN0aXZlX251 bWJlcjsgICAgIC8qICAgIDQ4ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAg ICAgICAgICBjdV9hb19tYXNrOyAgICAgICAgICAgLyogICAgNTIgICAgIDQgKi8KPiA+ICAgICAg IF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGN1X2JpdG1hcFs0XVs0XTsgICAgICAvKiAgICA1 NiAgICA2NCAqLwo+ID4gICAgICAgLyogLS0tIGNhY2hlbGluZSAxIGJvdW5kYXJ5ICg2NCBieXRl cykgd2FzIDU2IGJ5dGVzIGFnbyAtLS0gKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAg ICAgICAgIGVuYWJsZWRfcmJfcGlwZXNfbWFzazsgLyogICAxMjAgICAgIDQgKi8KPiA+ICAgICAg IF9fdTMyICAgICAgICAgICAgICAgICAgICAgIG51bV9yYl9waXBlczsgICAgICAgICAvKiAgIDEy NCAgICAgNCAqLwo+ID4gICAgICAgLyogLS0tIGNhY2hlbGluZSAyIGJvdW5kYXJ5ICgxMjggYnl0 ZXMpIC0tLSAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgbnVtX2h3X2dm eF9jb250ZXh0czsgIC8qICAgMTI4ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAg ICAgICAgICAgICBfcGFkOyAgICAgICAgICAgICAgICAgLyogICAxMzIgICAgIDQgKi8KPiA+ICAg ICAgIF9fdTY0ICAgICAgICAgICAgICAgICAgICAgIGlkc19mbGFnczsgICAgICAgICAgICAvKiAg IDEzNiAgICAgOCAqLwo+ID4gICAgICAgX191NjQgICAgICAgICAgICAgICAgICAgICAgdmlydHVh bF9hZGRyZXNzX29mZnNldDsgLyogICAxNDQgICAgIDggKi8KPiA+ICAgICAgIF9fdTY0ICAgICAg ICAgICAgICAgICAgICAgIHZpcnR1YWxfYWRkcmVzc19tYXg7ICAvKiAgIDE1MiAgICAgOCAqLwo+ ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgdmlydHVhbF9hZGRyZXNzX2FsaWdu bWVudDsgLyogICAxNjAgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAg ICAgIHB0ZV9mcmFnbWVudF9zaXplOyAgICAvKiAgIDE2NCAgICAgNCAqLwo+ID4gICAgICAgX191 MzIgICAgICAgICAgICAgICAgICAgICAgZ2FydF9wYWdlX3NpemU7ICAgICAgIC8qICAgMTY4ICAg ICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBjZV9yYW1fc2l6ZTsg ICAgICAgICAgLyogICAxNzIgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAg ICAgICAgIHZyYW1fdHlwZTsgICAgICAgICAgICAvKiAgIDE3NiAgICAgNCAqLwo+ID4gICAgICAg X191MzIgICAgICAgICAgICAgICAgICAgICAgdnJhbV9iaXRfd2lkdGg7ICAgICAgIC8qICAgMTgw ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICB2Y2VfaGFydmVz dF9jb25maWc7ICAgLyogICAxODQgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAg ICAgICAgICAgIGdjX2RvdWJsZV9vZmZjaGlwX2xkc19idWY7IC8qICAgMTg4ICAgICA0ICovCj4g PiAgICAgICAvKiAtLS0gY2FjaGVsaW5lIDMgYm91bmRhcnkgKDE5MiBieXRlcykgLS0tICovCj4g PiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAgICAgICBwcmltX2J1Zl9ncHVfYWRkcjsgICAg LyogICAxOTIgICAgIDggKi8KPiA+ICAgICAgIF9fdTY0ICAgICAgICAgICAgICAgICAgICAgIHBv c19idWZfZ3B1X2FkZHI7ICAgICAvKiAgIDIwMCAgICAgOCAqLwo+ID4gICAgICAgX191NjQgICAg ICAgICAgICAgICAgICAgICAgY250bF9zYl9idWZfZ3B1X2FkZHI7IC8qICAgMjA4ICAgICA4ICov Cj4gPiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAgICAgICBwYXJhbV9idWZfZ3B1X2FkZHI7 ICAgLyogICAyMTYgICAgIDggKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAg IHByaW1fYnVmX3NpemU7ICAgICAgICAvKiAgIDIyNCAgICAgNCAqLwo+ID4gICAgICAgX191MzIg ICAgICAgICAgICAgICAgICAgICAgcG9zX2J1Zl9zaXplOyAgICAgICAgIC8qICAgMjI4ICAgICA0 ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBjbnRsX3NiX2J1Zl9zaXpl OyAgICAgLyogICAyMzIgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAg ICAgIHBhcmFtX2J1Zl9zaXplOyAgICAgICAvKiAgIDIzNiAgICAgNCAqLwo+ID4gICAgICAgX191 MzIgICAgICAgICAgICAgICAgICAgICAgd2F2ZV9mcm9udF9zaXplOyAgICAgIC8qICAgMjQwICAg ICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBudW1fc2hhZGVyX3Zp c2libGVfdmdwcnM7IC8qICAgMjQ0ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAg ICAgICAgICAgICBudW1fY3VfcGVyX3NoOyAgICAgICAgLyogICAyNDggICAgIDQgKi8KPiA+ICAg ICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIG51bV90Y2NfYmxvY2tzOyAgICAgICAvKiAg IDI1MiAgICAgNCAqLwo+ID4gICAgICAgLyogLS0tIGNhY2hlbGluZSA0IGJvdW5kYXJ5ICgyNTYg Ynl0ZXMpIC0tLSAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgZ3Nfdmd0 X3RhYmxlX2RlcHRoOyAgIC8qICAgMjU2ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAg ICAgICAgICAgICAgICBnc19wcmltX2J1ZmZlcl9kZXB0aDsgLyogICAyNjAgICAgIDQgKi8KPiA+ ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIG1heF9nc193YXZlc19wZXJfdmd0OyAv KiAgIDI2NCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgX3Bh ZDE7ICAgICAgICAgICAgICAgIC8qICAgMjY4ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAg ICAgICAgICAgICAgICAgICBjdV9hb19iaXRtYXBbNF1bNF07ICAgLyogICAyNzIgICAgNjQgKi8K PiA+ICAgICAgIC8qIC0tLSBjYWNoZWxpbmUgNSBib3VuZGFyeSAoMzIwIGJ5dGVzKSB3YXMgMTYg Ynl0ZXMgYWdvIC0tLSAqLwo+ID4gICAgICAgX191NjQgICAgICAgICAgICAgICAgICAgICAgaGln aF92YV9vZmZzZXQ7ICAgICAgIC8qICAgMzM2ICAgICA4ICovCj4gPiAgICAgICBfX3U2NCAgICAg ICAgICAgICAgICAgICAgICBoaWdoX3ZhX21heDsgICAgICAgICAgLyogICAzNDQgICAgIDggKi8K PiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIHBhX3NjX3RpbGVfc3RlZXJpbmdf b3ZlcnJpZGU7IC8qICAgMzUyICAgICA0ICovCj4gPgo+ID4gICAgICAgLyogWFhYIDQgYnl0ZXMg aG9sZSwgdHJ5IHRvIHBhY2sgKi8KPiA+Cj4gPiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAg ICAgICB0Y2NfZGlzYWJsZWRfbWFzazsgICAgLyogICAzNjAgICAgIDggKi8KPiA+Cj4gPiAgICAg ICAvKiBzaXplOiAzNjgsIGNhY2hlbGluZXM6IDYsIG1lbWJlcnM6IDQ5ICovCj4gPiAgICAgICAv KiBzdW0gbWVtYmVyczogMzY0LCBob2xlczogMSwgc3VtIGhvbGVzOiA0ICovCj4gPiAgICAgICAv KiBsYXN0IGNhY2hlbGluZTogNDggYnl0ZXMgKi8KPiA+IH07Cj4gPgo+ID4gICBkcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfa21zLmMgfCAzICsrLQo+ID4gICAxIGZpbGUgY2hhbmdl ZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9rbXMuYyBiL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdV9rbXMuYwo+ID4gaW5kZXggYThjNDdhZWNkMzQyLi4wMDQ3ZGEwNjA0 MWYgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfa21z LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9rbXMuYwo+ID4g QEAgLTcwNyw5ICs3MDcsMTAgQEAgc3RhdGljIGludCBhbWRncHVfaW5mb19pb2N0bChzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLCBzdHJ1Y3QgZHJtX2ZpbGUKPiA+ICAgICAgICAg ICAgICAgcmV0dXJuIG4gPyAtRUZBVUxUIDogMDsKPiA+ICAgICAgIH0KPiA+ICAgICAgIGNhc2Ug QU1ER1BVX0lORk9fREVWX0lORk86IHsKPiA+IC0gICAgICAgICAgICAgc3RydWN0IGRybV9hbWRn cHVfaW5mb19kZXZpY2UgZGV2X2luZm8gPSB7fTsKPiA+ICsgICAgICAgICAgICAgc3RydWN0IGRy bV9hbWRncHVfaW5mb19kZXZpY2UgZGV2X2luZm87Cj4gPiAgICAgICAgICAgICAgIHVpbnQ2NF90 IHZtX3NpemU7Cj4gPgo+ID4gKyAgICAgICAgICAgICBtZW1zZXQoJmRldl9pbmZvLCAwLCBzaXpl b2YoZGV2X2luZm8pKTsKPiA+ICAgICAgICAgICAgICAgZGV2X2luZm8uZGV2aWNlX2lkID0gZGV2 LT5wZGV2LT5kZXZpY2U7Cj4gPiAgICAgICAgICAgICAgIGRldl9pbmZvLmNoaXBfcmV2ID0gYWRl di0+cmV2X2lkOwo+ID4gICAgICAgICAgICAgICBkZXZfaW5mby5leHRlcm5hbF9yZXYgPSBhZGV2 LT5leHRlcm5hbF9yZXZfaWQ7Cj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+IGFtZC1nZnggbWFpbGluZyBsaXN0Cj4gYW1kLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2FtZC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==