Re: [PATCH -next] hwmon: (nzxt-smart2) Fix build with CONFIG_PM=n

From: Aleksandr Mezin <mezin.alexander@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] hwmon: (nzxt-smart2) Fix build with CONFIG_PM=n
Date: Tue, 4 Jan 2022 20:40:17 +0600	[thread overview]
Message-ID: <CADnvcf+xszorFKv72wf0AMnNwr0r7O+2-KQWSt6tqaGzNKcUpg@mail.gmail.com> (raw)
In-Reply-To: <20220104135328.604-1-yuehaibing@huawei.com>

On Tue, Jan 4, 2022 at 7:54 PM YueHaibing <yuehaibing@huawei.com> wrote:
>
> drivers/hwmon/nzxt-smart2.c:707:12: error: 'nzxt_smart2_hid_reset_resume' defined but not used [-Werror=unused-function]
>   707 | static int nzxt_smart2_hid_reset_resume(struct hid_device *hdev)
>       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Move it into #ifdef block to fix this.
>
> Fixes: 0e43f31ee52f ("hwmon: add driver for NZXT RGB&Fan Controller/Smart Device v2.")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/hwmon/nzxt-smart2.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hwmon/nzxt-smart2.c b/drivers/hwmon/nzxt-smart2.c
> index 534d39b8908e..4963d630394a 100644
> --- a/drivers/hwmon/nzxt-smart2.c
> +++ b/drivers/hwmon/nzxt-smart2.c
> @@ -704,6 +704,7 @@ static int nzxt_smart2_hid_raw_event(struct hid_device *hdev,
>         return 0;
>  }
>
> +#ifdef CONFIG_PM
>  static int nzxt_smart2_hid_reset_resume(struct hid_device *hdev)
>  {
>         struct drvdata *drvdata = hid_get_drvdata(hdev);
> @@ -720,6 +721,7 @@ static int nzxt_smart2_hid_reset_resume(struct hid_device *hdev)
>
>         return init_device(drvdata, drvdata->update_interval);
>  }
> +#endif
>
>  static int nzxt_smart2_hid_probe(struct hid_device *hdev,
>                                  const struct hid_device_id *id)
> --
> 2.17.1
>

Hi.

It's already fixed:
https://lore.kernel.org/all/20211228014813.832491-1-mezin.alexander@gmail.com/
(and already in linux-next:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/hwmon/nzxt-smart2.c?id=f103b2e5a6197586effb0b9a1b72c30b5d65b0cd
)