From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Griffin Date: Wed, 29 Jul 2015 22:04:57 +0100 Subject: [U-Boot] [PATCH v2 3/6] hi6553: Add register definition and bitfield header for 6553 pmic In-Reply-To: References: <1436371040-26620-1-git-send-email-peter.griffin@linaro.org> <1436371040-26620-4-git-send-email-peter.griffin@linaro.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On 18 July 2015 at 15:37, Simon Glass wrote: > Hi Peter, > > On 8 July 2015 at 09:57, Peter Griffin wrote: > > This pmic is used on the 96boards consumer edition HiKey board. > > > > Signed-off-by: Peter Griffin > > --- > > arch/arm/include/asm/arch-hi6220/hi6553.h | 75 > +++++++++++++++++++++++++++++++ > > 1 file changed, 75 insertions(+) > > create mode 100644 arch/arm/include/asm/arch-hi6220/hi6553.h > > Should be in drivers/power/pmic I think. Also use struct for reg > access. Should probably use the new PMIC uclass (we can convert it > later if you don't have a device tree yet). > OK I've converted it to a simple pmic driver in v3 patches. regards, Peter