From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F43CCD80BC for ; Tue, 10 Oct 2023 12:09:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231604AbjJJMJq (ORCPT ); Tue, 10 Oct 2023 08:09:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231548AbjJJMJp (ORCPT ); Tue, 10 Oct 2023 08:09:45 -0400 Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A450AC for ; Tue, 10 Oct 2023 05:09:43 -0700 (PDT) Received: by mail-qv1-xf2c.google.com with SMTP id 6a1803df08f44-668e4fd13a3so29420916d6.2 for ; Tue, 10 Oct 2023 05:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696939782; x=1697544582; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DgSEBJcUi7PZ5OXedvwInXaFNURNqtsaL0h7wFFXk5g=; b=Df3KmV6NzyoruKmJufGdyQeVIeM94xePXheDrzzm9/krPQ0jAEIvv5Ien2F0RrmPkc uKtla/0xPvuSxqAgH3p7HrD1gT5kWUMhkFfSaj2ib46V3FRNFcTfUaSMQCuPpFR8yOY3 ixA9gJeTCoBtX65NfpE1VpxFHHWM1IdKP+fgDyZFX/UGcvBbWstNlDicBgxoYFenAWBj G+VdxULEkMAl7xmCRg6IDmZ1apVCjQz4IXjBbkj+kPs1eOuakvTCAqcIKrqoHV+PT5rb dhg1fPXp3J9LipxYR2CpFtPNfBMnW3oIB2gC/ElJ0ChXIvUEDMcqENyf/3GxkwMykgQM FIfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696939782; x=1697544582; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DgSEBJcUi7PZ5OXedvwInXaFNURNqtsaL0h7wFFXk5g=; b=SwpxLQj+MUSe0GOjLXgSlud9k6M/BBwj28ot4BJijXbfbpPIEN9KQkzScrkimlW6OF L7HbweOzldjzRKdg6bgTBIEs/tB0wSaocFHsug4/BDiCR4T0ljJB1GgfhHG3tnmklckA 0Ec+MCpQyj0BdjfecKOA+Py0iF5/uUAfpTnLua/hsUuzdkrYqkmFbLXIG//KxK9GCrwQ SJZut8P11rY/bJZcGC0g0c/yJcQriLosms6KD5878sOABzq3/xYJWgsfVi+t5+5gvHF7 Blo1JPXlL/TydjEJ6eFCtrK3s30W4GrvlOeI40PeEgg5PlvOu83TcQnRJSUnRNZdXrdb Wvcw== X-Gm-Message-State: AOJu0YyDR1KdvhzdawJVZW1nGxnWK4Ym/RCEZkNY63vaLkiIRlsv1BU4 jnTief9jMEmEH1apeNUP59EC6PClaG5XXcnNL4Pv7A== X-Google-Smtp-Source: AGHT+IEkobWfRAv+hk9GeXAgYbAsdwwHInRJB4q4A/k6gLUZyJCTapOQUejfM/de0SvYVTlXeCdNVMlVoHapdH1mpY8= X-Received: by 2002:ad4:5cc7:0:b0:65d:dcc:9754 with SMTP id iu7-20020ad45cc7000000b0065d0dcc9754mr22900149qvb.30.1696939782310; Tue, 10 Oct 2023 05:09:42 -0700 (PDT) MIME-Version: 1.0 References: <20231005155618.700312-1-peter.griffin@linaro.org> <20231005155618.700312-20-peter.griffin@linaro.org> <20231006205204.GA269353-robh@kernel.org> In-Reply-To: <20231006205204.GA269353-robh@kernel.org> From: Peter Griffin Date: Tue, 10 Oct 2023 13:09:31 +0100 Message-ID: Subject: Re: [PATCH 19/21] google/gs101: Add dt overlay for oriole board To: Rob Herring Cc: krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, cw00.choi@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Rob, Thanks for your review! On Fri, 6 Oct 2023 at 21:52, Rob Herring wrote: > > On Thu, Oct 05, 2023 at 04:56:16PM +0100, Peter Griffin wrote: > > The LK bootloader on Pixel6 searches for a dt overlay in the > > dtbo partition with a board_id and board_rev that matches > > what is baked into the device. If this overlay is not present > > then the phone will bootloop in fastboot and you can't boot > > the upstream kernel. > > > > This commit adds a dtbo for the production oriole variant. > > The other pre-production board overlays are not included > > at this time. > > > > Adding the dtbo here allows for a better experience when > > building/booting the upstream kernel on Pixel devices > > as all the DT required to boot the device will be created > > as part of the kernel build process. Rather than having to > > fetch the dtbo from some other repo. > > > > Signed-off-by: Peter Griffin > > --- > > arch/arm64/boot/dts/google/Makefile | 1 + > > arch/arm64/boot/dts/google/gs101-oriole.dtso | 21 ++++++++++++++++++++ > > 2 files changed, 22 insertions(+) > > create mode 100644 arch/arm64/boot/dts/google/gs101-oriole.dtso > > > > diff --git a/arch/arm64/boot/dts/google/Makefile b/arch/arm64/boot/dts/google/Makefile > > index 6d2026a767d4..3f1761f8daa9 100644 > > --- a/arch/arm64/boot/dts/google/Makefile > > +++ b/arch/arm64/boot/dts/google/Makefile > > @@ -2,5 +2,6 @@ > > > > dtb-$(CONFIG_ARCH_GOOGLE_TENSOR) += \ > > gs101-oriole.dtb \ > > + gs101-oriole.dtbo > > Overlays in the kernel must be able to be applied to a base DT in the > kernel. Add a rule to apply this (hint: a '-dtbs' variable does this > similar to -objs variables). Ok will do, thanks for the hint > > > diff --git a/arch/arm64/boot/dts/google/gs101-oriole.dtso b/arch/arm64/boot/dts/google/gs101-oriole.dtso > > new file mode 100644 > > index 000000000000..50832fd94204 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/google/gs101-oriole.dtso > > @@ -0,0 +1,21 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > +/* > > + * Oriole DVT Device Tree > > Doesn't DVT mean pre-production? Yes, DVT stands for Design Verification Testing. I can remove that DVT suffix for v2. I suppose that means there were no changes between DVT and production as this is the overlay used by the production devices. regards, Peter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91744CD80BA for ; Tue, 10 Oct 2023 12:10:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CL9Wfe/c0xR6Vkv+3Bq4PLtWEoSXNTnFdbOj8ZmagXU=; b=XCYrnSbaeP/oFm dTOszLSqJNUrK1YGMEVsxMcwLoBIomKdKG6dovwZsqerFbsJyWwI+CgzkhpZLwfQu5/PWu/3VkUEE HgqZE2XZa0QmNREsTWAb2+HHlXFqo+mc9wqiK59xmLx2gV8PrdE6ouxMGwMtxsrQqoll8U8f3tmPh bvPp63PvUC4WsgHM5H68uzdK3ZYNHAfijqBsSnk4n6OeQdEge+VmD89+rYr/sXvXJ3VJCigtHbpuz 9OFUqiTu7GMw6ufdl/yuStFQdyRaLBqTrgoP0rFceO73oPuf04zpXwVMGvXU5twlJhwjSxCuLvw9x yRBwDsBGH1SeLgMUtElA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqBYc-00DIcC-22; Tue, 10 Oct 2023 12:09:50 +0000 Received: from mail-qk1-x731.google.com ([2607:f8b0:4864:20::731]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqBYY-00DIaM-2e for linux-arm-kernel@lists.infradead.org; Tue, 10 Oct 2023 12:09:48 +0000 Received: by mail-qk1-x731.google.com with SMTP id af79cd13be357-7741c5bac51so324737485a.1 for ; Tue, 10 Oct 2023 05:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696939782; x=1697544582; darn=lists.infradead.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DgSEBJcUi7PZ5OXedvwInXaFNURNqtsaL0h7wFFXk5g=; b=e5zdBKYXw04RbWr59a+c6rcsRWEo417eVGxesT096hZvpBmK3v/4oqE/JPlvIPRgOJ RY2h/J1h52SlhcLMCE4P/aCiI04YmvrTL/kPCQOqi4vDZJtlOrtUdwlmnW+lQR83cCjQ fNQFxHD/feEDomTTYfSrgQ3WGKZEXm81t6rHD8SBZNKH062zdpIpM/mE6RwPmq4Jx+DR PJ/0tugYqp/sir1veDhtIJYqTT2eWISr4ebeKCcyC4YXC5jJnY9sTTj7VUxLvxYGY7rW nQupAEc2pZ9LdrPz14c2gzfhlH+GhVMd/1Crl203/QARtDJFmy14Ssbxv+OX5jFa9WEp pbUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696939782; x=1697544582; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DgSEBJcUi7PZ5OXedvwInXaFNURNqtsaL0h7wFFXk5g=; b=gCzTbDBEEn7kmVgAB1gl6/KkY3+R137U4xCQRWgjoKdBLsiQMivXI3A5X+pigAVe1D 0Vm12Ro3DurCDUQlMtHumOimM7xaFAXBqb+B73UzDAW7DmS6v9qkD9LzmfpmsM8cWWma 0U5+/WtuDteS7iP0K+2UYEjmhF8446xbssefzuLU6sPSHOTvxw4wXlP8Mgjb0XgKAxRj ZWJEbPgBOewfn10PF9e8dCwsavgBWGzzbGoWYm4CooHXBc44xjuQAw7QZziySwXQdole d9+drR0WZZYYmFXG3inDrNWOjpW0mc5wEWnx7+RAbh6zYSSF7VXGbU+X+R3aYFP/gme8 XfsQ== X-Gm-Message-State: AOJu0Yx6bZWsduwDrPZ1sxrILBiJ5wWZ+0IUK3MfobfMxuhJWsEbdCyb HH0Xtmu08k80IchYoT46ILNs/XDGEW7Ost8acK5pNA== X-Google-Smtp-Source: AGHT+IEkobWfRAv+hk9GeXAgYbAsdwwHInRJB4q4A/k6gLUZyJCTapOQUejfM/de0SvYVTlXeCdNVMlVoHapdH1mpY8= X-Received: by 2002:ad4:5cc7:0:b0:65d:dcc:9754 with SMTP id iu7-20020ad45cc7000000b0065d0dcc9754mr22900149qvb.30.1696939782310; Tue, 10 Oct 2023 05:09:42 -0700 (PDT) MIME-Version: 1.0 References: <20231005155618.700312-1-peter.griffin@linaro.org> <20231005155618.700312-20-peter.griffin@linaro.org> <20231006205204.GA269353-robh@kernel.org> In-Reply-To: <20231006205204.GA269353-robh@kernel.org> From: Peter Griffin Date: Tue, 10 Oct 2023 13:09:31 +0100 Message-ID: Subject: Re: [PATCH 19/21] google/gs101: Add dt overlay for oriole board To: Rob Herring Cc: krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, cw00.choi@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231010_050946_857357_613729DA X-CRM114-Status: GOOD ( 33.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, Thanks for your review! On Fri, 6 Oct 2023 at 21:52, Rob Herring wrote: > > On Thu, Oct 05, 2023 at 04:56:16PM +0100, Peter Griffin wrote: > > The LK bootloader on Pixel6 searches for a dt overlay in the > > dtbo partition with a board_id and board_rev that matches > > what is baked into the device. If this overlay is not present > > then the phone will bootloop in fastboot and you can't boot > > the upstream kernel. > > > > This commit adds a dtbo for the production oriole variant. > > The other pre-production board overlays are not included > > at this time. > > > > Adding the dtbo here allows for a better experience when > > building/booting the upstream kernel on Pixel devices > > as all the DT required to boot the device will be created > > as part of the kernel build process. Rather than having to > > fetch the dtbo from some other repo. > > > > Signed-off-by: Peter Griffin > > --- > > arch/arm64/boot/dts/google/Makefile | 1 + > > arch/arm64/boot/dts/google/gs101-oriole.dtso | 21 ++++++++++++++++++++ > > 2 files changed, 22 insertions(+) > > create mode 100644 arch/arm64/boot/dts/google/gs101-oriole.dtso > > > > diff --git a/arch/arm64/boot/dts/google/Makefile b/arch/arm64/boot/dts/google/Makefile > > index 6d2026a767d4..3f1761f8daa9 100644 > > --- a/arch/arm64/boot/dts/google/Makefile > > +++ b/arch/arm64/boot/dts/google/Makefile > > @@ -2,5 +2,6 @@ > > > > dtb-$(CONFIG_ARCH_GOOGLE_TENSOR) += \ > > gs101-oriole.dtb \ > > + gs101-oriole.dtbo > > Overlays in the kernel must be able to be applied to a base DT in the > kernel. Add a rule to apply this (hint: a '-dtbs' variable does this > similar to -objs variables). Ok will do, thanks for the hint > > > diff --git a/arch/arm64/boot/dts/google/gs101-oriole.dtso b/arch/arm64/boot/dts/google/gs101-oriole.dtso > > new file mode 100644 > > index 000000000000..50832fd94204 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/google/gs101-oriole.dtso > > @@ -0,0 +1,21 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > +/* > > + * Oriole DVT Device Tree > > Doesn't DVT mean pre-production? Yes, DVT stands for Design Verification Testing. I can remove that DVT suffix for v2. I suppose that means there were no changes between DVT and production as this is the overlay used by the production devices. regards, Peter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel