From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81A18E81DE9 for ; Fri, 6 Oct 2023 12:41:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232218AbjJFMlj (ORCPT ); Fri, 6 Oct 2023 08:41:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232174AbjJFMli (ORCPT ); Fri, 6 Oct 2023 08:41:38 -0400 Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1393CF for ; Fri, 6 Oct 2023 05:41:36 -0700 (PDT) Received: by mail-qv1-xf2d.google.com with SMTP id 6a1803df08f44-66b024d26e2so754916d6.0 for ; Fri, 06 Oct 2023 05:41:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696596096; x=1697200896; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BG+pU1EHGnCj6tU73G8/u9FDfygPxqAGCLjoLFitfDU=; b=Z1rRQi3HAYdYZVC8Q+Sas5E8KKLeQGX/uOmN+LPLYMEYs74uHg1DGZtvZhBe8KUoSr QaqlfMvz9kUDc4U8l9rAphNzOjhKhrWl+zWf9k9uF9c5mIcs9ewubzYRQ+zrIgFCF7WU ACxTXPBn1rTbcpZhUmmifUOkd/+jBHOliABGrdroul9X0E7+WlNRwZ2eO2aZWBlcYRaz 5ub+9SspRgb8VHgqJP1K/axAzZ3fSeg3LH6N7Bv5qkbPT2wPvoIWDJ1jIXQlUbnCgoEi Fk+zDaX1nZ1foCDZT+DALPIhWC5M2Ns026yE7nLYcaPEAw9M3hYVVZeulq5vZzNMLHr1 wFSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696596096; x=1697200896; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BG+pU1EHGnCj6tU73G8/u9FDfygPxqAGCLjoLFitfDU=; b=MaMLCscqLOVhXLFxGIFBUNwpTIaCVgIQcH4/ko+Viau0eJF/sP0jRZSParanBNOd9w +x1g5H+XTpJONOUf0TjIad+50iWxlrcugbJAwQySmhuAqQhx4fVuQCb7Eixzaa54tEMR ksf6Te3l7/hjAzgAGCW3p7Hu5Gyo+rhv63B3R3sWnfdDSRdvZGGYCzzIY/HF6HtqDitf mddapFeF0pxsqpBksFHYYexxIR/MYGNj9vBsZUB4FChPQQ9BOUJ4+BoeQIIHuwFdnbzX dOw4St6fSzQirD5eWasoCQkU16meyS+sjnD5Is36FTYcnll9RjPtVSShz+308PyMnqHl NhIA== X-Gm-Message-State: AOJu0YxqEVt4Ezqrsvy+/yLrjZiYL7tCKLxEPywVRO64neR8TMy662go b5NYkUEl5zb6UtBbGC8UcBbESrDMVawgKJz054VS2g== X-Google-Smtp-Source: AGHT+IEc9cXq8etKpdI34yJncEC8RLd8eZzic0vY4V2CYU6+7KPMm/ULeW87OBJQQb7Lh+PasTJleL0tLgLVqUOGwPQ= X-Received: by 2002:a05:6214:400e:b0:64f:4d4a:70c with SMTP id kd14-20020a056214400e00b0064f4d4a070cmr6030330qvb.27.1696596095802; Fri, 06 Oct 2023 05:41:35 -0700 (PDT) MIME-Version: 1.0 References: <20231005155618.700312-1-peter.griffin@linaro.org> <20231005155618.700312-5-peter.griffin@linaro.org> In-Reply-To: From: Peter Griffin Date: Fri, 6 Oct 2023 13:41:24 +0100 Message-ID: Subject: Re: [PATCH 04/21] dt-bindings: soc: google: exynos-sysreg: add dedicated SYSREG compatibles to GS101 To: Krzysztof Kozlowski Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, cw00.choi@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Krzysztof, Many thanks for reviewing the series :) On Thu, 5 Oct 2023 at 17:07, Krzysztof Kozlowski wrote: > > On 05/10/2023 17:56, Peter Griffin wrote: > > GS101 has three different SYSREG controllers, add dedicated > > compatibles for them to the documentation. > > > > Signed-off-by: Peter Griffin > > --- > > .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > > index 163e912e9cad..02f580d6489b 100644 > > --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > > +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > > @@ -50,6 +50,13 @@ properties: > > - samsung,exynosautov9-peric1-sysreg > > - const: samsung,exynosautov9-sysreg > > - const: syscon > > + - items: > > + - enum: > > + - google,gs101-peric0-sysreg > > + - google,gs101-peric1-sysreg > > + - google,gs101-apm-sysreg > > + - const: google,gs101-sysreg > > Please drop this one compatible. Exynos has it only for backwards > compatibility. Just double checking, you mean I should drop this one compatible? + - const: google,gs101-sysreg > > Also, please put entire list ("items") before such entry for > samsung,exynos5433-sysreg, so everything is more-or-less ordered > alphabetically, by the fallback compatible. Will do! regards, Peter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97850E81DF0 for ; Fri, 6 Oct 2023 12:42:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gWRb/+HbQ5mPDpjE/cqTmpv6mTsxuUUGaaIF7hgF3BI=; b=d6ZKsx304YXXrS dlzUOcuFJiDN6zYw0KC1CO31IZ5r+gezJXjxt9HEaR7HNom1QLYmU2uL/Qb2ugtaDqKnni7tYj2te uCKULwBJXrMp7g6Kqlkc2tCQvJUnqZ/leU6jIv5duQm3bVTwDkV6VdBwIUmUeXU5a7+cF/hsCs5lx CW5VmF+f3dG56WaVYMltSUa6WpmexJ4bpq0XG0YPD9H/yp56gTRlFbI14Et5cmxSXmfgroTRHGzzX 6PjwFlNI/FtB7ZfZ1V1GzYNcypg5fghy5cgRcsOCap7OokBsuzHqz3boZvpTujgMxrjNg221HEkli x6xovMKk/2LZrAKiHcnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qok9F-005nvK-0D; Fri, 06 Oct 2023 12:41:41 +0000 Received: from mail-qv1-xf32.google.com ([2607:f8b0:4864:20::f32]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qok9C-005ntK-0A for linux-arm-kernel@lists.infradead.org; Fri, 06 Oct 2023 12:41:39 +0000 Received: by mail-qv1-xf32.google.com with SMTP id 6a1803df08f44-65b0216b067so25850456d6.1 for ; Fri, 06 Oct 2023 05:41:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696596096; x=1697200896; darn=lists.infradead.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BG+pU1EHGnCj6tU73G8/u9FDfygPxqAGCLjoLFitfDU=; b=w5u8TwKoHM740aaTQ5dV2TRfPyS5NC0YMvdkkCQ5/pnthntJa3HccH7ySm1guD4PP7 VFeBi+yaz9jIJtFf50FOYQptSJgMJ9LqjiGjNSIukJo28ChonpwmrRaRd5qCbKE6cxTi 2rViHAjuYq3N1rit31/gdyQrumOu/zExsbxUbaldm4zJptsbB83LgwXGl97uPOiPjbzP KYmWGQK2upXjq1z7goawVmp2inTygjxtsHzFzwrQrKfsYsO/f7Ad1wCXjBMC9BijMM3p jDh3u8261ZvyqZJA2JycN2sZjQjPI25RKiSMR0I++aIPb6sVKnQJwRjiar/MQMrSti9g F1iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696596096; x=1697200896; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BG+pU1EHGnCj6tU73G8/u9FDfygPxqAGCLjoLFitfDU=; b=ejDo/qZm/JddgmeKDB98NYrd/RWXFDKNmnvjLl1+M+up4p9KDXP/UDB2smM8KYSJvz 2mCjBY6HZWhWdHV6BplzVtdgYIZJ1zJznXYe09PTwkdNgV6WzhM+Y6GKoaG+avIhin+o kv3k6snCM2elElR0Dl9kiWCLoExB8UZtPwgbQaDgQPLoBAmF2DTMb9kjRdZTqrPowQzJ snDxZWa5qAJA0r/BeKKX0Dv2egGN+vt/e8+VTUhmYE2H+6vxI/cCpp228waakfU/afVM UOCyLsbnbmOd1FG0AG7iphL1h95JDiIeHO6GrWpL1MqNdIWaedLbAlgr1J6G8jvpr0q+ 37rQ== X-Gm-Message-State: AOJu0Yy5DT1vfdOoR6WE/CN+Dr01Tl9vf/FBagRsPJWMYQAQeGLIO1vS PevjCmqvxW+QQNAJkaEz7MRdpHCn5MHf8oBeoxSNIg== X-Google-Smtp-Source: AGHT+IEc9cXq8etKpdI34yJncEC8RLd8eZzic0vY4V2CYU6+7KPMm/ULeW87OBJQQb7Lh+PasTJleL0tLgLVqUOGwPQ= X-Received: by 2002:a05:6214:400e:b0:64f:4d4a:70c with SMTP id kd14-20020a056214400e00b0064f4d4a070cmr6030330qvb.27.1696596095802; Fri, 06 Oct 2023 05:41:35 -0700 (PDT) MIME-Version: 1.0 References: <20231005155618.700312-1-peter.griffin@linaro.org> <20231005155618.700312-5-peter.griffin@linaro.org> In-Reply-To: From: Peter Griffin Date: Fri, 6 Oct 2023 13:41:24 +0100 Message-ID: Subject: Re: [PATCH 04/21] dt-bindings: soc: google: exynos-sysreg: add dedicated SYSREG compatibles to GS101 To: Krzysztof Kozlowski Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, cw00.choi@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231006_054138_111628_35377B09 X-CRM114-Status: GOOD ( 16.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, Many thanks for reviewing the series :) On Thu, 5 Oct 2023 at 17:07, Krzysztof Kozlowski wrote: > > On 05/10/2023 17:56, Peter Griffin wrote: > > GS101 has three different SYSREG controllers, add dedicated > > compatibles for them to the documentation. > > > > Signed-off-by: Peter Griffin > > --- > > .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > > index 163e912e9cad..02f580d6489b 100644 > > --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > > +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > > @@ -50,6 +50,13 @@ properties: > > - samsung,exynosautov9-peric1-sysreg > > - const: samsung,exynosautov9-sysreg > > - const: syscon > > + - items: > > + - enum: > > + - google,gs101-peric0-sysreg > > + - google,gs101-peric1-sysreg > > + - google,gs101-apm-sysreg > > + - const: google,gs101-sysreg > > Please drop this one compatible. Exynos has it only for backwards > compatibility. Just double checking, you mean I should drop this one compatible? + - const: google,gs101-sysreg > > Also, please put entire list ("items") before such entry for > samsung,exynos5433-sysreg, so everything is more-or-less ordered > alphabetically, by the fallback compatible. Will do! regards, Peter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel