From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SzUAPLx1" Received: from mail-ua1-x936.google.com (mail-ua1-x936.google.com [IPv6:2607:f8b0:4864:20::936]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B0BA18B for ; Tue, 5 Dec 2023 14:29:46 -0800 (PST) Received: by mail-ua1-x936.google.com with SMTP id a1e0cc1a2514c-7c5a2b5e77bso970787241.1 for ; Tue, 05 Dec 2023 14:29:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701815385; x=1702420185; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=NrXqJVDzW4Zm/gOjUfh5BbRIxo1FamErN2RJgIBt+Rg=; b=SzUAPLx1mlnqn4xCO0z6RhzFtL9DkM1/MY4zDBwCSG6jXaCRcGwRJjvZo0YsDPu5m4 miQcdaeuy0lFWtFQ3QDmuGVjSNjGLUjKxRAVDq1dN2KPGT2UM+6lvh/VjEA32PAE85x2 xvO5/TeR/vKMn4zeWv7dhnyEum0V8i7jeos7zkwvD7RRvrbCiYaA1pv85Hc4H+q/4sml XwmwgqdPkHONOWrQALsZkMyllVhU6XtqY35fClg9yq/re+QxBC94e7zAuutZ+07eFd9P 7lNcoqlriEImhZByQ40DKs6d9QcaI7VlIgr0K5ckFDW/5EcTFheYrVnhP/t9r2st1FeH pJAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701815385; x=1702420185; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NrXqJVDzW4Zm/gOjUfh5BbRIxo1FamErN2RJgIBt+Rg=; b=MnPYittLk2b31q01AEMI4c2w3N5ux064pENG8zvUdEdxlmFh6J1peEmLTxM2pDOJ3v 3TAeN9vGeLOYLKJtgHo41YhfSP/UHXMQt4Pp5c65rxFr/GH1cyTbeOnP9+M2NqXUhmqU tKIAKjH0t8EUhL68P6zOMeo4yUOv/TJvsj1O/u8YwMnFUyoFz3/AURpUM8FL4Qydunoo 5uzxLwosWm8g7OkTVzJy/4dQj0tM8p5L9F7RAiqKWMZPdjqEHSCgOlOYxY2+3a9GfO65 KemElPc9WEI9dYFR6UxY7cvHQTCnNh43CvUrFI+tRjLJvbLnqMtCfdL+h1p2G6r2YRZU mnLw== X-Gm-Message-State: AOJu0Yxq0K6ICmjj4DA4wD+Q7n/bjTCn+Qm/fQMsIAc2p+69Sb4eiOjn QAfs0Cyu8RN9QYK+lvSbHGqcnHx7L99Rv8YlczfCUw== X-Google-Smtp-Source: AGHT+IFF2TpItFKowjCZ8ASJ/0BWEWuvpsfiA6UqGLSiCQ0pnJ8/SuZznn+CD6peVXZleVKejXfbOHGauFLhVvJuCuQ= X-Received: by 2002:a67:af0b:0:b0:464:7b6d:2efc with SMTP id v11-20020a67af0b000000b004647b6d2efcmr4247312vsl.34.1701815385307; Tue, 05 Dec 2023 14:29:45 -0800 (PST) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231201160925.3136868-1-peter.griffin@linaro.org> <20231201160925.3136868-18-peter.griffin@linaro.org> In-Reply-To: From: Peter Griffin Date: Tue, 5 Dec 2023 22:29:34 +0000 Message-ID: Subject: Re: [PATCH v5 17/20] tty: serial: samsung: Add gs101 compatible and common fifoszdt_serial_drv_data To: William McVicker Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, cw00.choi@samsung.com, alim.akhtar@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, saravanak@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Hi Will, On Sat, 2 Dec 2023 at 00:01, William McVicker wrote: > > On 12/01/2023, Peter Griffin wrote: > > Add serial driver data for Google Tensor gs101 SoC and a common > > fifoszdt_serial_drv_data that can be used by platforms that specify the > > samsung,uart-fifosize DT property. > > > > A corresponding dt-bindings patch updates the yaml to ensure > > samsung,uart-fifosize is a required property. > > > > Acked-by: Greg Kroah-Hartman > > Reviewed-by: Sam Protsenko > > Reviewed-by: Arnd Bergmann > > Signed-off-by: Peter Griffin > > Tested-by: Will McVicker > > --- > > I verified boot to a busybox console with kernel logs printed to the serial > port. Thanks for testing :) I've added your Tested-by tags to the various patches apart from the pinctrl ones that have been refactored a bit. Thanks, Peter. > > Regards, > Will > > > --- > > drivers/tty/serial/samsung_tty.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > > index 1b0c2b467a30..f8d98f1006de 100644 > > --- a/drivers/tty/serial/samsung_tty.c > > +++ b/drivers/tty/serial/samsung_tty.c > > @@ -2490,14 +2490,25 @@ static const struct s3c24xx_serial_drv_data exynos850_serial_drv_data = { > > .fifosize = { 256, 64, 64, 64 }, > > }; > > > > +/* > > + * Common drv_data struct for platforms that specify uart,fifosize in > > + * device tree. > > + */ > > +static const struct s3c24xx_serial_drv_data exynos_fifoszdt_serial_drv_data = { > > + EXYNOS_COMMON_SERIAL_DRV_DATA(), > > + .fifosize = { 0 }, > > +}; > > + > > #define EXYNOS4210_SERIAL_DRV_DATA (&exynos4210_serial_drv_data) > > #define EXYNOS5433_SERIAL_DRV_DATA (&exynos5433_serial_drv_data) > > #define EXYNOS850_SERIAL_DRV_DATA (&exynos850_serial_drv_data) > > +#define EXYNOS_FIFOSZDT_DRV_DATA (&exynos_fifoszdt_serial_drv_data) > > > > #else > > #define EXYNOS4210_SERIAL_DRV_DATA NULL > > #define EXYNOS5433_SERIAL_DRV_DATA NULL > > #define EXYNOS850_SERIAL_DRV_DATA NULL > > +#define EXYNOS_FIFOSZDT_DRV_DATA NULL > > #endif > > > > #ifdef CONFIG_ARCH_APPLE > > @@ -2581,6 +2592,9 @@ static const struct platform_device_id s3c24xx_serial_driver_ids[] = { > > }, { > > .name = "artpec8-uart", > > .driver_data = (kernel_ulong_t)ARTPEC8_SERIAL_DRV_DATA, > > + }, { > > + .name = "gs101-uart", > > + .driver_data = (kernel_ulong_t)EXYNOS_FIFOSZDT_DRV_DATA, > > }, > > { }, > > }; > > @@ -2602,6 +2616,8 @@ static const struct of_device_id s3c24xx_uart_dt_match[] = { > > .data = EXYNOS850_SERIAL_DRV_DATA }, > > { .compatible = "axis,artpec8-uart", > > .data = ARTPEC8_SERIAL_DRV_DATA }, > > + { .compatible = "google,gs101-uart", > > + .data = EXYNOS_FIFOSZDT_DRV_DATA }, > > {}, > > }; > > MODULE_DEVICE_TABLE(of, s3c24xx_uart_dt_match); > > -- > > 2.43.0.rc2.451.g8631bc7472-goog > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DF63C4167B for ; Tue, 5 Dec 2023 22:30:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S+zrfGPG3Po6R2pAZIWZuzgCsUpmJU91F3KJGvHMHKY=; b=IoL0U0z3IdvCAx A7Z/O5kVfCtfqOsKK3l1TsIp2I1ljHrmPp9zJlowFlvAUg1y2vo/J0RjeT/OyIdWTi5xjRSDMzJtU exS8a2ULnThWYbi9tvk8T/52Oz1L0GHVWZ0b/UEGZ1OTDOYJdOVnIbQ4D7/xn9Ce425IU2mM4sIaK v/XmBzPEnxfnUFBBETM5gRlwggnv9KhHguyC8/Xo3hV6uAZRgi/FHE7uQUoc3JW3oRqbsk8TunSjn 6wVbfQIbChxQJcbqCs8eSSJfI4kM8NBe0tkfPuoKG+soKtBj6/axt/syXretQwMJoAYQnwBHjGHj9 nO7TLM8Zvox7Cu2kiXbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAdvL-008VzU-0A; Tue, 05 Dec 2023 22:29:51 +0000 Received: from mail-ua1-x936.google.com ([2607:f8b0:4864:20::936]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAdvI-008Vyp-1s for linux-arm-kernel@lists.infradead.org; Tue, 05 Dec 2023 22:29:49 +0000 Received: by mail-ua1-x936.google.com with SMTP id a1e0cc1a2514c-7c5d16a4bc6so651600241.3 for ; Tue, 05 Dec 2023 14:29:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701815385; x=1702420185; darn=lists.infradead.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=NrXqJVDzW4Zm/gOjUfh5BbRIxo1FamErN2RJgIBt+Rg=; b=MFrjTBGYfwt8o1Sptr/PzuDaX4QXL0zAPoCZZ5bTnIDO6cC8QzwuvjsFFxqyxYjy3G gGo8qaa4rys4Vx/v4HM0uuc6zz/d4Ygl9LKab2n+bLXdvdptIddS9gKIng8Uqd2C31UC X7ru12MX9JGGQlp5ctauZWhLMIjLETYH0ZPImrRP6RZG3iDiGDI82EM+tPJgjnWRljTe btX0n5eClrEpKjQIP6d2lhCxy3c2lRhKkRx+BD6cdg7kMrkHd8ufPJPpZT4mdPHao3NC crf+OuQvrRjLSNrxPuVdndfxSQdtaRrHXg0K+iqY2H1KggItR9T3LNoIC4PHs1yU9vp3 a4mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701815385; x=1702420185; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NrXqJVDzW4Zm/gOjUfh5BbRIxo1FamErN2RJgIBt+Rg=; b=Xb+rKz/kdt+gOcWZAyP9xBe+f46rXDjIPBfG3uiT55Ds+EwydZA+8xvhzbaMK3U8tC CauPgJT4dsIQqvEXifGSHW/iurxm55MDLFPPiYm7pg6QyD6SKkx/m7watF+FeqX8tWMy L67JRF8922Gzjhc6+mhfb6lzj9z00KHb+PzItbXaKeF8am7WlDdL66iQwAd1zvg46/Pt DsW2Z+LtjhJq2g+/Msu+y7HAKOSHXjILP4YUbjd4ZKXCSxdluFANynJ6iKOYITdTFpcN 02HRPqKP8Lpn8ZUDsYOvLwFfHXjibkJB+EPuvQpPNCi8Zvk424M2oo04a9LyfUVu6IwJ L/iw== X-Gm-Message-State: AOJu0YwgF04hSSRnZkW9KbuQ1e3owidTpHkYZd4J+7rD2SwtGV/+CJM0 l0J3IcudvdhZCoDZkOavuB86XUz1tN+mXvzO5FFnrA== X-Google-Smtp-Source: AGHT+IFF2TpItFKowjCZ8ASJ/0BWEWuvpsfiA6UqGLSiCQ0pnJ8/SuZznn+CD6peVXZleVKejXfbOHGauFLhVvJuCuQ= X-Received: by 2002:a67:af0b:0:b0:464:7b6d:2efc with SMTP id v11-20020a67af0b000000b004647b6d2efcmr4247312vsl.34.1701815385307; Tue, 05 Dec 2023 14:29:45 -0800 (PST) MIME-Version: 1.0 References: <20231201160925.3136868-1-peter.griffin@linaro.org> <20231201160925.3136868-18-peter.griffin@linaro.org> In-Reply-To: From: Peter Griffin Date: Tue, 5 Dec 2023 22:29:34 +0000 Message-ID: Subject: Re: [PATCH v5 17/20] tty: serial: samsung: Add gs101 compatible and common fifoszdt_serial_drv_data To: William McVicker Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, cw00.choi@samsung.com, alim.akhtar@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, saravanak@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231205_142948_620355_153D2CD6 X-CRM114-Status: GOOD ( 23.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Will, On Sat, 2 Dec 2023 at 00:01, William McVicker wrote: > > On 12/01/2023, Peter Griffin wrote: > > Add serial driver data for Google Tensor gs101 SoC and a common > > fifoszdt_serial_drv_data that can be used by platforms that specify the > > samsung,uart-fifosize DT property. > > > > A corresponding dt-bindings patch updates the yaml to ensure > > samsung,uart-fifosize is a required property. > > > > Acked-by: Greg Kroah-Hartman > > Reviewed-by: Sam Protsenko > > Reviewed-by: Arnd Bergmann > > Signed-off-by: Peter Griffin > > Tested-by: Will McVicker > > --- > > I verified boot to a busybox console with kernel logs printed to the serial > port. Thanks for testing :) I've added your Tested-by tags to the various patches apart from the pinctrl ones that have been refactored a bit. Thanks, Peter. > > Regards, > Will > > > --- > > drivers/tty/serial/samsung_tty.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > > index 1b0c2b467a30..f8d98f1006de 100644 > > --- a/drivers/tty/serial/samsung_tty.c > > +++ b/drivers/tty/serial/samsung_tty.c > > @@ -2490,14 +2490,25 @@ static const struct s3c24xx_serial_drv_data exynos850_serial_drv_data = { > > .fifosize = { 256, 64, 64, 64 }, > > }; > > > > +/* > > + * Common drv_data struct for platforms that specify uart,fifosize in > > + * device tree. > > + */ > > +static const struct s3c24xx_serial_drv_data exynos_fifoszdt_serial_drv_data = { > > + EXYNOS_COMMON_SERIAL_DRV_DATA(), > > + .fifosize = { 0 }, > > +}; > > + > > #define EXYNOS4210_SERIAL_DRV_DATA (&exynos4210_serial_drv_data) > > #define EXYNOS5433_SERIAL_DRV_DATA (&exynos5433_serial_drv_data) > > #define EXYNOS850_SERIAL_DRV_DATA (&exynos850_serial_drv_data) > > +#define EXYNOS_FIFOSZDT_DRV_DATA (&exynos_fifoszdt_serial_drv_data) > > > > #else > > #define EXYNOS4210_SERIAL_DRV_DATA NULL > > #define EXYNOS5433_SERIAL_DRV_DATA NULL > > #define EXYNOS850_SERIAL_DRV_DATA NULL > > +#define EXYNOS_FIFOSZDT_DRV_DATA NULL > > #endif > > > > #ifdef CONFIG_ARCH_APPLE > > @@ -2581,6 +2592,9 @@ static const struct platform_device_id s3c24xx_serial_driver_ids[] = { > > }, { > > .name = "artpec8-uart", > > .driver_data = (kernel_ulong_t)ARTPEC8_SERIAL_DRV_DATA, > > + }, { > > + .name = "gs101-uart", > > + .driver_data = (kernel_ulong_t)EXYNOS_FIFOSZDT_DRV_DATA, > > }, > > { }, > > }; > > @@ -2602,6 +2616,8 @@ static const struct of_device_id s3c24xx_uart_dt_match[] = { > > .data = EXYNOS850_SERIAL_DRV_DATA }, > > { .compatible = "axis,artpec8-uart", > > .data = ARTPEC8_SERIAL_DRV_DATA }, > > + { .compatible = "google,gs101-uart", > > + .data = EXYNOS_FIFOSZDT_DRV_DATA }, > > {}, > > }; > > MODULE_DEVICE_TABLE(of, s3c24xx_uart_dt_match); > > -- > > 2.43.0.rc2.451.g8631bc7472-goog > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel