From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Griffin Subject: Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured. Date: Mon, 23 Oct 2017 18:34:25 +0100 Message-ID: References: <1502806465-17772-1-git-send-email-peter.griffin@linaro.org> <20170828085108.zp4pjkmt6gbewwgm@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1603642566==" Return-path: Received: from mail-io0-x22e.google.com (mail-io0-x22e.google.com [IPv6:2607:f8b0:4001:c06::22e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 20A6C6E3C1 for ; Mon, 23 Oct 2017 17:34:26 +0000 (UTC) Received: by mail-io0-x22e.google.com with SMTP id m81so20937358ioi.13 for ; Mon, 23 Oct 2017 10:34:26 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Xinliang Liu Cc: seanpaul@google.com, Guodong Xu , Feng Chen , Linux Kernel Mailing List , dri-devel , "Liuxinliang (Matthew Liu)" , XinWei Kong , stable@vger.kernel.org, Rongrong Zou , Andrey Konovalov , LAKML List-Id: dri-devel@lists.freedesktop.org --===============1603642566== Content-Type: multipart/alternative; boundary="001a1141909ee5c62d055c3a3bb9" --001a1141909ee5c62d055c3a3bb9 Content-Type: text/plain; charset="UTF-8" Hi Xinliang, On 28 August 2017 at 10:27, Xinliang Liu wrote: > Hi Daniel, > > On 28 August 2017 at 16:51, Daniel Vetter wrote: > > On Mon, Aug 28, 2017 at 04:44:30PM +0800, Xinliang Liu wrote: > >> Hi, > >> > >> On 15 August 2017 at 22:14, Peter Griffin > wrote: > >> > >> > This patch fixes the following soft lockup: > >> > BUG: soft lockup - CPU#0 stuck for 23s! [weston:307] > >> > > >> > On weston idle-timeout the IP is powered down and reset > >> > asserted. On weston resume we get a massive vblank > >> > IRQ storm due to the LDI registers having lost some state. > >> > > >> > This state loss is caused by ade_crtc_atomic_begin() not > >> > calling ade_ldi_set_mode(). With this patch applied > >> > resuming from Weston idle-timeout works well. > >> > > >> > Signed-off-by: Peter Griffin > >> > Tested-by: John Stultz > >> > > >> > >> Thanks Peter, > >> This patch looks good to me. > >> Reviewed-by: Xinliang Liu > >> > >> @Sean, could you please help to apply to drm-misc if others has no more > >> comments, thanks. > > > > hisilicon isn't maintained in drm-misc, and you're the maintainer. This > is > > not how it works. So either > > a) pick up the patch and send out a pull request to Dave Airlie > > b) move hisilicon over to drm-misc and become a drm-misc maintainer > > yourself. This needs a MAINTAINERS update to point the git tree at > > drm-misc. > > > > drm-misc maintainers don't maintain everyone else's driver as a service, > > that simply doesn't scale. > > Sorry for my misunderstanding and thanks for pointing out that how > drm-misc works. > So I will pick up the patch and send a pull request. > Did you send the pull request? I still can't see this patch in the latest kernel RC. Peter. --001a1141909ee5c62d055c3a3bb9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Xinliang,

On 28 August 2017 at 10:27, Xinliang Liu <= xinliang.liu@l= inaro.org> wrote:
Hi Danie= l,

On 28 August 2017 at 16:51, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Mon, Aug 28, 2017 at 04:44:30PM +0800, Xinliang Liu wrote:
>> Hi,
>>
>> On 15 August 2017 at 22:14, Peter Griffin <peter.griffin@linaro.org> wrote:
>>
>> > This patch fixes the following soft lockup:
>> >=C2=A0 =C2=A0BUG: soft lockup - CPU#0 stuck for 23s! [weston:3= 07]
>> >
>> > On weston idle-timeout the IP is powered down and reset
>> > asserted. On weston resume we get a massive vblank
>> > IRQ storm due to the LDI registers having lost some state. >> >
>> > This state loss is caused by ade_crtc_atomic_begin() not
>> > calling ade_ldi_set_mode(). With this patch applied
>> > resuming from Weston idle-timeout works well.
>> >
>> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
>> > Tested-by: John Stultz <john.stultz@linaro.org>
>> >
>>
>> Thanks Peter,
>> This patch looks good to me.
>> Reviewed-by: Xinliang Liu <xinliang.liu@linaro.org>
>>
>> @Sean, could you please help to apply to drm-misc if others has no= more
>> comments, thanks.
>
> hisilicon isn't maintained in drm-misc, and you're the maintai= ner. This is
> not how it works. So either
> a) pick up the patch and send out a pull request to Dave Airlie
> b) move hisilicon over to drm-misc and become a drm-misc maintainer > yourself. This needs a MAINTAINERS update to point the git tree at
> drm-misc.
>
> drm-misc maintainers don't maintain everyone else's driver as = a service,
> that simply doesn't scale.

Sorry for my misunderstanding and thanks for pointing out that = how
drm-misc works.
So I will pick up the patch and send a pull request.
<= br>
Did you send the pull request?

I sti= ll can't see this patch in the latest kernel RC.

Peter.
--001a1141909ee5c62d055c3a3bb9-- --===============1603642566== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1603642566==--