From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QxdzWdj2" Received: from mail-oo1-xc35.google.com (mail-oo1-xc35.google.com [IPv6:2607:f8b0:4864:20::c35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DBD2D9 for ; Sun, 3 Dec 2023 13:21:26 -0800 (PST) Received: by mail-oo1-xc35.google.com with SMTP id 006d021491bc7-58d98188dc0so2414145eaf.3 for ; Sun, 03 Dec 2023 13:21:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701638485; x=1702243285; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MBALP8YV0QZwaMwdd2KBWcj9Tq1p2Z16LRDLKvabBto=; b=QxdzWdj2Adq+1FMGv2/fas25Mr2HqQdqka2/V56PA84tqjM8ns0LpH+We5MkNCIiFD GEgtEtz4SdcDeBKq3EmCbft5zlmDS3ofH+iihci1Zzwlh3dCJ7RB4y2Vfk1iM+uiwra9 M6kIqZDgf3su24XfuYvAnEJ4BbCkWLoar/6US4luXNY+3Ke0vZYB5gqxbzqZi+pWr5L1 XVRaBYBiSro1MOUN/a04trw5OwjpXmp7GeZAXsXxaw9UqWciP7m9ZTgqb0CUwV29TrTO Ni9nxijSfPpwhoC0z2wLerj8X7ZFAptUZNWRAF2gqCerfC/GMb1kn39PVdUDMNH1HR9I f6Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701638485; x=1702243285; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MBALP8YV0QZwaMwdd2KBWcj9Tq1p2Z16LRDLKvabBto=; b=fo29yW7/vcGS1otoETAFCFUOf/JhC6UwkkmF8r9+mXR8RrpNQ2Ddos3YXWAbYOF/Pd Pzd5zsEMRundlPupH62Kw1eeCLiPT7WVtno0aAUntsVF7jSybgXoI8r83DA0tfFlyL2M vKRrzx3NOiSnz5MjSOs+HRBlNizFC+NxKdsLs0uTcXRgLH23xZfhZozLzO/bb+0ekTs8 1F/SPLEmHaiKajrnmsG+8JM6Lb812GhFX9zkq7GK0/j4Uf9RHUMnL+vTDrP0sXbGCLVE 4Epq6/KwCjPbKBgJ13E6GMeHnDINe49V5nEbLasFXt2nWyg5EtLw+ohUhDhcuWC1xT+I KpYg== X-Gm-Message-State: AOJu0Yyudv2FsUQCNb40TgITBTDKmOkyskT9QsxMi1uK9jbVATwx747z l2jdEdKVOfcFbQ6FRThkvrcHoUR4ykcBzTq3QUIBJQ== X-Google-Smtp-Source: AGHT+IGtekMHkp852JA6RkiudAH5D96Q93RiRqk9YOj5heuqbhP+mmIk3wEQ0uwM4Ob7BzATccUT7+4SnMfM9Ymm5do= X-Received: by 2002:a05:6358:1206:b0:170:8f0:c6c2 with SMTP id h6-20020a056358120600b0017008f0c6c2mr3905258rwi.21.1701638485268; Sun, 03 Dec 2023 13:21:25 -0800 (PST) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231201160925.3136868-1-peter.griffin@linaro.org> <20231201160925.3136868-8-peter.griffin@linaro.org> In-Reply-To: From: Peter Griffin Date: Sun, 3 Dec 2023 21:21:14 +0000 Message-ID: Subject: Re: [PATCH v5 07/20] dt-bindings: pinctrl: samsung: add gs101-wakeup-eint compatible To: Krzysztof Kozlowski Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, cw00.choi@samsung.com, alim.akhtar@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Hi Krzysztof, Thanks for the review. On Sun, 3 Dec 2023 at 15:11, Krzysztof Kozlowski wrote: > > On 01/12/2023 17:09, Peter Griffin wrote: > > gs101 is similar to newer Exynos SoCs like Exynos850 and ExynosAutov9 > > where more than one pin controller can do external wake-up interrupt. > > So add a dedicated compatible for it. > > > > Signed-off-by: Peter Griffin > > --- > > .../bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > > index 2bafa867aea2..de2209f8ba00 100644 > > --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > > +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > > @@ -44,6 +44,7 @@ properties: > > - const: samsung,exynos7-wakeup-eint > > - items: > > - enum: > > + - google,gs101-wakeup-eint > > - samsung,exynosautov9-wakeup-eint > > - samsung,exynosautov920-wakeup-eint > > - const: samsung,exynos850-wakeup-eint > > @@ -111,6 +112,7 @@ allOf: > > compatible: > > contains: > > enum: > > + - google,gs101-wakeup-eint > > Drop, not needed. Will fix Peter. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9E6BC4167B for ; Sun, 3 Dec 2023 21:22:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Pcqgh2MTpu4ehtW5TmpnB0wFY14bcos96Wi17Of8sJE=; b=b2r3skFrPU6ECe MzWC4/wTWfhVGgVWxBOjOB/g5RWGtg24ZOdeUP+Rs9kTDZz7XOBJuKwN5A5J6wP2DrhUiY0XonQ+5 sqFHH+F6YE44nbOnuxfwjnFbLYasJJA0F7vCogI9+kn+/9aSAYt2+ooJEK0185IO2BuRVwXbONvfn /Zrfbwxy2Rt6GiFlZ/o5d+SVRUa0ddEBIdfb9psfBqJyvov+xMwIeNgYEbrONsJlFFGNYeBNdbWMe SvrRaHjdIt6bddwtW24cR8S3caONL/CO6ccktEy+JUjh94kmjEHBYMp4TO7uulyeeuPnqEdui7Kwr CqSJKK0wCa1eLujk+1ZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r9tu8-002bPF-2l; Sun, 03 Dec 2023 21:21:32 +0000 Received: from mail-oo1-xc2b.google.com ([2607:f8b0:4864:20::c2b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r9tu5-002bOm-1L for linux-arm-kernel@lists.infradead.org; Sun, 03 Dec 2023 21:21:30 +0000 Received: by mail-oo1-xc2b.google.com with SMTP id 006d021491bc7-58d7d58ab7fso2414260eaf.2 for ; Sun, 03 Dec 2023 13:21:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701638485; x=1702243285; darn=lists.infradead.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MBALP8YV0QZwaMwdd2KBWcj9Tq1p2Z16LRDLKvabBto=; b=KpL+B6QDZlOmdvKhRUzF38NzRjKc2fCq/t35ni5ulUQVTDZpCsHrv87J7h8OZvnMDJ b/LlTm4YHg5O4eGU3nRhDe86y8h37JTX+tMK+IVxHyH+rG+n8RZMvWMIxli+/kg2N0vQ pIFXBS1HOK5QbbwqGtbslV6jrEZV9j7Tcvls1gpFIVVtQjaFTeHWEZZdEIR81XLhJso8 3PyREAQxOOeZpJ9fubaC7m5pXMEX/XSBFyxTBlyVlkCTlmVnHZvGr9zH+LCe77khJ8kF uPxVBPORyRs6kd72e2BuqUNLIg9xl41+y9mjy9+l5XgcinKlHEfKHws6QgwyzScgNxPC /zUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701638485; x=1702243285; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MBALP8YV0QZwaMwdd2KBWcj9Tq1p2Z16LRDLKvabBto=; b=edqx8VyVGqOQzSlnUOqSvy/miT5OF9LS89vCwrUkVCHHbWock2TWLhlbFisAtcWeG9 K+UGa6BLvJF7+nN8ZSFPXE1pqxqka6DXfQnoemj41gTmj1TKSQ73e+RVR18rIrzGijva 9e4pey4+VW4E2yjnwTcT5dOyWGb/sD0SwZgnF2sIDrWWvCPhRyBGhWlbRr5GkHQt/RcH 77dcfRdEx6fg55i6ACAXUsubXTrbmvJh1f22ddV+qEdh4RflezkNgiRD838ZJZtCodV3 JiN9EAlh1PKn4JyH2oWUbsw/9Zlxvho81/4bdcNlG2skUCkZ/JuuD/fazjQvqY8RXiNA g5hA== X-Gm-Message-State: AOJu0YzDLf/ejVLGhoO5k9IKrjG486rtDiBfNdcU//7lZeZWERh2EQpa pEPhH/UaQiP/HeftHEofgJKPQkuc2tV7aHpPLX2Alg== X-Google-Smtp-Source: AGHT+IGtekMHkp852JA6RkiudAH5D96Q93RiRqk9YOj5heuqbhP+mmIk3wEQ0uwM4Ob7BzATccUT7+4SnMfM9Ymm5do= X-Received: by 2002:a05:6358:1206:b0:170:8f0:c6c2 with SMTP id h6-20020a056358120600b0017008f0c6c2mr3905258rwi.21.1701638485268; Sun, 03 Dec 2023 13:21:25 -0800 (PST) MIME-Version: 1.0 References: <20231201160925.3136868-1-peter.griffin@linaro.org> <20231201160925.3136868-8-peter.griffin@linaro.org> In-Reply-To: From: Peter Griffin Date: Sun, 3 Dec 2023 21:21:14 +0000 Message-ID: Subject: Re: [PATCH v5 07/20] dt-bindings: pinctrl: samsung: add gs101-wakeup-eint compatible To: Krzysztof Kozlowski Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, cw00.choi@samsung.com, alim.akhtar@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231203_132129_493699_3D49FF62 X-CRM114-Status: GOOD ( 14.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, Thanks for the review. On Sun, 3 Dec 2023 at 15:11, Krzysztof Kozlowski wrote: > > On 01/12/2023 17:09, Peter Griffin wrote: > > gs101 is similar to newer Exynos SoCs like Exynos850 and ExynosAutov9 > > where more than one pin controller can do external wake-up interrupt. > > So add a dedicated compatible for it. > > > > Signed-off-by: Peter Griffin > > --- > > .../bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > > index 2bafa867aea2..de2209f8ba00 100644 > > --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > > +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > > @@ -44,6 +44,7 @@ properties: > > - const: samsung,exynos7-wakeup-eint > > - items: > > - enum: > > + - google,gs101-wakeup-eint > > - samsung,exynosautov9-wakeup-eint > > - samsung,exynosautov920-wakeup-eint > > - const: samsung,exynos850-wakeup-eint > > @@ -111,6 +112,7 @@ allOf: > > compatible: > > contains: > > enum: > > + - google,gs101-wakeup-eint > > Drop, not needed. Will fix Peter. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel