From mboxrd@z Thu Jan 1 00:00:00 1970 From: divya ojha Subject: Re: [PATCH v2 2/4] pinctrl: qpnp: Qualcomm PMIC pin controller driver Date: Mon, 21 Jul 2014 21:32:24 +0530 Message-ID: References: <1405610748-7583-1-git-send-email-iivanov@mm-sol.com> <1405610748-7583-3-git-send-email-iivanov@mm-sol.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1405610748-7583-3-git-send-email-iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Ivan T. Ivanov" Cc: Linus Walleij , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Grant Likely , Bjorn Andersson , Mark Brown , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org Hi, On Thu, Jul 17, 2014 at 8:55 PM, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > This is the pinctrl, pinmux, pinconf and gpiolib driver for the > Qualcomm GPIO and MPP sub-function blocks found in the PMIC chips. > > Signed-off-by: Ivan T. Ivanov > --- > drivers/pinctrl/Kconfig | 12 + > drivers/pinctrl/Makefile | 1 + > drivers/pinctrl/pinctrl-qpnp.c | 1565 +++++++++++++++++++++++++ > include/dt-bindings/pinctrl/qcom,pm8xxx-mpp.h | 34 + .. + struct device *dev = qctrl->dev; > + struct pinctrl_pin_desc *desc, *descs; > + struct qpnp_padinfo *pad, *pads; > + int idx, ret, cnt, gps, ais, aos, css; > + const char **names, *format; > + unsigned int addr; > + > + pads = devm_kcalloc(dev, qchip->npads, sizeof(*pads), GFP_KERNEL); when do we free these structures..? > + if (!pads) > + return -ENOMEM; > + > + descs = devm_kcalloc(dev, qchip->npads, sizeof(*descs), GFP_KERNEL); ditto.. > + if (!descs) > + return -ENOMEM; > + .. > + cnt = qctrl->groups[idx].npins; > + if (!cnt) > + continue; > + > + names = devm_kcalloc(dev, cnt, sizeof(names), GFP_KERNEL); ditto.. > + if (!names) > + return -ENOMEM; > +#define PM8XXX_MPP_AIN_ABUS4 7 > + > +#endif > -- > 1.8.3.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Regards Divya -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933038AbaGUQCa (ORCPT ); Mon, 21 Jul 2014 12:02:30 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:57558 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932766AbaGUQC2 (ORCPT ); Mon, 21 Jul 2014 12:02:28 -0400 MIME-Version: 1.0 In-Reply-To: <1405610748-7583-3-git-send-email-iivanov@mm-sol.com> References: <1405610748-7583-1-git-send-email-iivanov@mm-sol.com> <1405610748-7583-3-git-send-email-iivanov@mm-sol.com> Date: Mon, 21 Jul 2014 21:32:24 +0530 Message-ID: Subject: Re: [PATCH v2 2/4] pinctrl: qpnp: Qualcomm PMIC pin controller driver From: divya ojha To: "Ivan T. Ivanov" Cc: Linus Walleij , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Grant Likely , Bjorn Andersson , Mark Brown , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Jul 17, 2014 at 8:55 PM, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > This is the pinctrl, pinmux, pinconf and gpiolib driver for the > Qualcomm GPIO and MPP sub-function blocks found in the PMIC chips. > > Signed-off-by: Ivan T. Ivanov > --- > drivers/pinctrl/Kconfig | 12 + > drivers/pinctrl/Makefile | 1 + > drivers/pinctrl/pinctrl-qpnp.c | 1565 +++++++++++++++++++++++++ > include/dt-bindings/pinctrl/qcom,pm8xxx-mpp.h | 34 + .. + struct device *dev = qctrl->dev; > + struct pinctrl_pin_desc *desc, *descs; > + struct qpnp_padinfo *pad, *pads; > + int idx, ret, cnt, gps, ais, aos, css; > + const char **names, *format; > + unsigned int addr; > + > + pads = devm_kcalloc(dev, qchip->npads, sizeof(*pads), GFP_KERNEL); when do we free these structures..? > + if (!pads) > + return -ENOMEM; > + > + descs = devm_kcalloc(dev, qchip->npads, sizeof(*descs), GFP_KERNEL); ditto.. > + if (!descs) > + return -ENOMEM; > + .. > + cnt = qctrl->groups[idx].npins; > + if (!cnt) > + continue; > + > + names = devm_kcalloc(dev, cnt, sizeof(names), GFP_KERNEL); ditto.. > + if (!names) > + return -ENOMEM; > +#define PM8XXX_MPP_AIN_ABUS4 7 > + > +#endif > -- > 1.8.3.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Regards Divya