From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory Fong Subject: Re: [PATCH 004/182] gpio: generic: factor into gpio_chip struct Date: Sun, 13 Dec 2015 18:35:15 -0800 Message-ID: References: <1449666760-29876-1-git-send-email-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-ig0-f178.google.com ([209.85.213.178]:37827 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751708AbbLNCfp (ORCPT ); Sun, 13 Dec 2015 21:35:45 -0500 In-Reply-To: <1449666760-29876-1-git-send-email-linus.walleij@linaro.org> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij Cc: linux-gpio@vger.kernel.org, Johan Hovold , Alexandre Courbot , Michael Welling , Markus Pargmann , Anton Vorontsov , arm@kernel.org, Lee Jones , Alexander Shiyan , Shawn Guo , Sascha Hauer , Tony Lindgren , Kukjin Kim , Krzysztof Kozlowski , Alexandre Courbot , Brian Norris , Florian Fainelli , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Nicolas Pitre , Olof Johansson , Vladimir Zapolskiy , Rabin Vincent On Wed, Dec 9, 2015 at 5:12 AM, Linus Walleij wrote: > The separate struct bgpio_chip has been a pain to handle, both > by being confusingly similar in name to struct gpio_chip and > for being contained inside a struct so that struct gpio_chip > is contained in a struct contained in a struct, making several > steps of dereferencing necessary. > > Make things simpler: include the fields directly into > , #ifdef:ed for CONFIG_GENERIC_GPIO, and > get rid of the altogether. Prefix > some of the member variables with bgpio_* and add proper > kerneldoc while we're at it. > > Modify all users to handle the change and use a struct > gpio_chip directly. And while we're at it: replace all > container_of() dereferencing by gpiochip_get_data() and > registering the gpio_chip with gpiochip_add_data(). > > Cc: arm@kernel.org > Cc: Lee Jones > Cc: Alexander Shiyan > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Tony Lindgren > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Alexandre Courbot > Cc: Gregory Fong > Cc: Brian Norris > Cc: Florian Fainelli > Cc: Liviu Dudau > Cc: Sudeep Holla > Cc: Lorenzo Pieralisi > Cc: Nicolas Pitre > Cc: Olof Johansson > Cc: Vladimir Zapolskiy > Cc: Rabin Vincent > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-omap@vger.kernel.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: bcm-kernel-feedback-list@broadcom.com > Signed-off-by: Linus Walleij > --- > ARM SoC folks and Lee: it would be great if you could > ACK the few lines hitting arch/arm/* and drivers/mfd/* in this > so I can take it through the GPIO tree. > --- [...] > drivers/gpio/gpio-brcmstb.c | 80 ++++----- For brcmstb: Acked-by: Gregory Fong From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.0xf0@gmail.com (Gregory Fong) Date: Sun, 13 Dec 2015 18:35:15 -0800 Subject: [PATCH 004/182] gpio: generic: factor into gpio_chip struct In-Reply-To: <1449666760-29876-1-git-send-email-linus.walleij@linaro.org> References: <1449666760-29876-1-git-send-email-linus.walleij@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Dec 9, 2015 at 5:12 AM, Linus Walleij wrote: > The separate struct bgpio_chip has been a pain to handle, both > by being confusingly similar in name to struct gpio_chip and > for being contained inside a struct so that struct gpio_chip > is contained in a struct contained in a struct, making several > steps of dereferencing necessary. > > Make things simpler: include the fields directly into > , #ifdef:ed for CONFIG_GENERIC_GPIO, and > get rid of the altogether. Prefix > some of the member variables with bgpio_* and add proper > kerneldoc while we're at it. > > Modify all users to handle the change and use a struct > gpio_chip directly. And while we're at it: replace all > container_of() dereferencing by gpiochip_get_data() and > registering the gpio_chip with gpiochip_add_data(). > > Cc: arm at kernel.org > Cc: Lee Jones > Cc: Alexander Shiyan > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Tony Lindgren > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Alexandre Courbot > Cc: Gregory Fong > Cc: Brian Norris > Cc: Florian Fainelli > Cc: Liviu Dudau > Cc: Sudeep Holla > Cc: Lorenzo Pieralisi > Cc: Nicolas Pitre > Cc: Olof Johansson > Cc: Vladimir Zapolskiy > Cc: Rabin Vincent > Cc: linux-arm-kernel at lists.infradead.org > Cc: linux-omap at vger.kernel.org > Cc: linux-samsung-soc at vger.kernel.org > Cc: bcm-kernel-feedback-list at broadcom.com > Signed-off-by: Linus Walleij > --- > ARM SoC folks and Lee: it would be great if you could > ACK the few lines hitting arch/arm/* and drivers/mfd/* in this > so I can take it through the GPIO tree. > --- [...] > drivers/gpio/gpio-brcmstb.c | 80 ++++----- For brcmstb: Acked-by: Gregory Fong