All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leonardo Bras <leobras.c@gmail.com>
To: helen@koikeco.de
Cc: lkcamp@lists.libreplanetbr.org, Borislav Petkov <bp@alien8.de>,
	David.Laight@aculab.com, Andy Lutomirski <luto@kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <michal.lkml@markovi.net>,
	linux-kbuild@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/5] Creates macro to avoid variable shadowing
Date: Tue, 23 Oct 2018 22:48:34 -0300	[thread overview]
Message-ID: <CADvQ+rE0THV2ZYwGi2jxU3sNSQhPxurfTSqpf022s5OP7ftiGw@mail.gmail.com> (raw)
In-Reply-To: <fe54aafc-1dbc-d4a1-96b5-37455595956e@koikeco.de>

Hello Helen,
On Tue, Oct 23, 2018 at 6:35 PM Helen Koike <helen@koikeco.de> wrote:
> Like this you are not changing the logic in this file, you are just
> renaming the variable which is more then enough to solve the -Wshadow
> warning.
> I don't it is worthy changing the logic.

You are right, that was what the patch was supposed to do. For some
crazy reason I must have submitted the wrong commit as a patch.

I will fix it and send you all a v3 ASAP.

Sorry for the inconvenience.
Thanks!

Leonardo Brás

  reply	other threads:[~2018-10-24  2:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23  1:10 [PATCH v2 3/5] Creates macro to avoid variable shadowing Leonardo Brás
2018-10-23 21:14 ` Helen Koike
2018-10-23 21:35 ` Helen Koike
2018-10-24  1:48   ` Leonardo Bras [this message]
2018-10-28 16:37 ` Masahiro Yamada
2018-10-30  0:32   ` Leonardo Bras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADvQ+rE0THV2ZYwGi2jxU3sNSQhPxurfTSqpf022s5OP7ftiGw@mail.gmail.com \
    --to=leobras.c@gmail.com \
    --cc=David.Laight@aculab.com \
    --cc=bp@alien8.de \
    --cc=helen@koikeco.de \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkcamp@lists.libreplanetbr.org \
    --cc=luto@kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=mingo@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.