diff for duplicates of <CADvQ+rGQenkoE0xCRTwjA5BuKZbZ2Upkyx=+qWFUGnUcit-aCQ@mail.gmail.com>
diff --git a/a/1.txt b/N1/1.txt
index f92975f..c1b182e 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -1,13 +1,13 @@
On Fri, Sep 28, 2018 at 4:15 AM James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
>
-> On Thu, 2018-09-27 at 23:08 -0300, Leonardo Br=C3=A1s wrote:
+> On Thu, 2018-09-27 at 23:08 -0300, Leonardo Brás wrote:
> > Avoids building driver if 'make drivers/parisc/' is called and
> > CONFIG_PARISC is disabled.
>
> Is that really a problem? The drivers/Makefile has this:
>
-> obj-$(CONFIG_PARISC) +=3D parisc/
+> obj-$(CONFIG_PARISC) += parisc/
> And you just overrode that by forcing the build. It's not even clear
> we should refuse the build in that case; how would we know you don't
> have a legitimate reason for the override?
@@ -17,7 +17,7 @@ Sorry I did not explained my reasons earlier. I sent everybody involved an
e-mail explaining the full reason of this change.
(For reference it's here: https://lkml.org/lkml/2018/10/3/707)
-> Signed-off-by: Leonardo Br=C3=A1s <leobras.c@gmail.com>
+> Signed-off-by: Leonardo Brás <leobras.c@gmail.com>
> > ---
> > drivers/parisc/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
@@ -26,13 +26,13 @@ e-mail explaining the full reason of this change.
> > index 3cd5e6cb8478..80049d763aa0 100644
> > --- a/drivers/parisc/Makefile
> > +++ b/drivers/parisc/Makefile
-> > @@ -24,5 +24,5 @@ obj-$(CONFIG_EISA) +=3D eisa.o
+> > @@ -24,5 +24,5 @@ obj-$(CONFIG_EISA) += eisa.o
> > eisa_enumerator.o eisa_eeprom.o
-> > obj-$(CONFIG_SUPERIO) +=3D superio.o
-> > obj-$(CONFIG_CHASSIS_LCD_LED) +=3D led.o
-> > obj-$(CONFIG_PDC_STABLE) +=3D pdc_stable.o
-> > -obj-y +=3D power.o
-> > +obj-$(CONFIG_PARISC) +=3D power.o
+> > obj-$(CONFIG_SUPERIO) += superio.o
+> > obj-$(CONFIG_CHASSIS_LCD_LED) += led.o
+> > obj-$(CONFIG_PDC_STABLE) += pdc_stable.o
+> > -obj-y += power.o
+> > +obj-$(CONFIG_PARISC) += power.o
>
> If we conclude the use case is legitimate, that's not enough: the two
> inner symbols are PARISC only but CONFIG_EISA isn't.
diff --git a/a/content_digest b/N1/content_digest
index d21ace9..81c79e9 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -45,13 +45,13 @@
"On Fri, Sep 28, 2018 at 4:15 AM James Bottomley\n",
"<James.Bottomley\@hansenpartnership.com> wrote:\n",
">\n",
- "> On Thu, 2018-09-27 at 23:08 -0300, Leonardo Br=C3=A1s wrote:\n",
+ "> On Thu, 2018-09-27 at 23:08 -0300, Leonardo Br\303\241s wrote:\n",
"> > Avoids building driver if 'make drivers/parisc/' is called and\n",
"> > CONFIG_PARISC is disabled.\n",
">\n",
"> Is that really a problem? The drivers/Makefile has this:\n",
">\n",
- "> obj-\$(CONFIG_PARISC) +=3D parisc/\n",
+ "> obj-\$(CONFIG_PARISC) += parisc/\n",
"> And you just overrode that by forcing the build. It's not even clear\n",
"> we should refuse the build in that case; how would we know you don't\n",
"> have a legitimate reason for the override?\n",
@@ -61,7 +61,7 @@
"e-mail explaining the full reason of this change.\n",
"(For reference it's here: https://lkml.org/lkml/2018/10/3/707)\n",
"\n",
- "> Signed-off-by: Leonardo Br=C3=A1s <leobras.c\@gmail.com>\n",
+ "> Signed-off-by: Leonardo Br\303\241s <leobras.c\@gmail.com>\n",
"> > ---\n",
"> > drivers/parisc/Makefile | 2 +-\n",
"> > 1 file changed, 1 insertion(+), 1 deletion(-)\n",
@@ -70,13 +70,13 @@
"> > index 3cd5e6cb8478..80049d763aa0 100644\n",
"> > --- a/drivers/parisc/Makefile\n",
"> > +++ b/drivers/parisc/Makefile\n",
- "> > \@\@ -24,5 +24,5 \@\@ obj-\$(CONFIG_EISA) +=3D eisa.o\n",
+ "> > \@\@ -24,5 +24,5 \@\@ obj-\$(CONFIG_EISA) += eisa.o\n",
"> > eisa_enumerator.o eisa_eeprom.o\n",
- "> > obj-\$(CONFIG_SUPERIO) +=3D superio.o\n",
- "> > obj-\$(CONFIG_CHASSIS_LCD_LED) +=3D led.o\n",
- "> > obj-\$(CONFIG_PDC_STABLE) +=3D pdc_stable.o\n",
- "> > -obj-y +=3D power.o\n",
- "> > +obj-\$(CONFIG_PARISC) +=3D power.o\n",
+ "> > obj-\$(CONFIG_SUPERIO) += superio.o\n",
+ "> > obj-\$(CONFIG_CHASSIS_LCD_LED) += led.o\n",
+ "> > obj-\$(CONFIG_PDC_STABLE) += pdc_stable.o\n",
+ "> > -obj-y += power.o\n",
+ "> > +obj-\$(CONFIG_PARISC) += power.o\n",
">\n",
"> If we conclude the use case is legitimate, that's not enough: the two\n",
"> inner symbols are PARISC only but CONFIG_EISA isn't.\n",
@@ -93,4 +93,4 @@
"Leonardo Bras"
]
-805a92257554ac5076ad86300c7c67bb3d16ea02c2302795e23ac5b427d38edb
+509fdc68d1b9c509e742fc27608289ad46bffa989188b3c9a6a523420ad9e407
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.